socialization 1.2.3 → 2.0.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 6bb2c1347bb2975c9a229366e60e2f1552f95e28b2c4ac27ab7e48edd963caaf
-  data.tar.gz: a2a9d47da210368463afa8c56cc943548f4765f350c762ede7f84c9e942e2c01
+  metadata.gz: 50ba5e062fb98e4b8b881e29701db48b7dad1fbfd01c97dd920362a4ff003160
+  data.tar.gz: 95b61065f67ae9bea59bf50a5f899b7c3ab4626e93ff3e1a18f25681b59a12b9
 SHA512:
-  metadata.gz: b903ff8c62263cf0f4f9f4a748b77c508f0d81065584a867a7c21aea2990d38873d9eb08321ceb782e733d979f985a07c0be708a8a2beac33372da4d2ce4bad0
-  data.tar.gz: a7ac541cbf6de510aa841a622086d869406050a21dc41580c7e5ab74a0127eb18e01c6e55ba47f004ecfcc703850bb7f723ff9292fa72a9b969b5f7124e25c28
+  metadata.gz: 0d9e0dc1c4c399bed13bd0bf86703768c9fa420b1d9f33fad85e49c2db9609031506e3fb1b4091ca87886ff6cbbbd52ee14ebfb883a03f12bf78b194560a121d
+  data.tar.gz: 359c3b7154cca91d946f7072891c675ffde0929a3995ce04b51231e1df532a0fd8f0bb879730556d04d2d72ef17242f54a18043133b324e8c0a4abbda0e2fbf9

data/.github/workflows/specs.yml

@@ -0,0 +1,35 @@
+# This workflow uses actions that are not certified by GitHub.
+# They are provided by a third-party and are governed by
+# separate terms of service, privacy policy, and support
+# documentation.
+# This workflow will download a prebuilt Ruby version, install dependencies and run tests with Rake
+# For more information see: https://github.com/marketplace/actions/setup-ruby-jruby-and-truffleruby
+
+name: Ruby
+
+on:
+  push:
+    branches: "*"
+  pull_request:
+    branches: "*"
+
+jobs:
+  rspec:
+    runs-on: ubuntu-latest
+    strategy:
+      matrix:
+        ruby-version: ['2.7', '3.0', '3.1']
+
+    steps:
+    - uses: actions/checkout@v2
+    - name: Set up Ruby
+    # To automatically get bug fixes and new Ruby versions for ruby/setup-ruby,
+    # change this to (see https://github.com/ruby/setup-ruby#versioning):
+      uses: ruby/setup-ruby@v1
+      with:
+        ruby-version: ${{ matrix.ruby-version }}
+        bundler-cache: true # runs 'bundle install' and caches installed gems automatically
+    - name: Install dependencies
+      run: bundle exec appraisal install
+    - name: Run tests
+      run: bundle exec appraisal rspec

data/.gitignore

@@ -11,3 +11,4 @@ doc
 .yardoc
 .rbenv-version
 gemfiles
+.byebug_history

data/.ruby-version

@@ -1 +1 @@
-2.6.2
+2.7.2

data/Appraisals

@@ -1,27 +1,7 @@
-appraise "activerecord30" do
-  gem "activerecord", "~> 3.0.10"
+appraise "activerecord614" do
+  gem "activerecord", "~> 6.1.4"
 end
 
-appraise "activerecord31" do
-  gem "activerecord", "~> 3.1.1"
-end
-
-appraise "activerecord32" do
-  gem "activerecord", "~> 3.2.1"
-end
-
-appraise "activerecord40" do
-  gem "activerecord", "~> 4.0.13"
-end
-
-appraise "activerecord41" do
-  gem "activerecord", "~> 4.1.12"
-end
-
-appraise "activerecord42" do
-  gem "activerecord", "~> 4.2.3"
-end
-
-appraise "activerecord523" do
-  gem "activerecord", "~> 5.2.3"
+appraise "activerecord702" do
+  gem "activerecord", "~> 7.0.2"
 end

data/CHANGELOG.md

@@ -1,8 +1,13 @@
 # Changelog
 
+## 2.0.0 (February 18, 2022)
+
+* Dropped support for old Rails versions. Updated CI.
+* BREAKING CHANGE (maybe): calling `followers`, `followables`, `likers`, `likeables`, `mentioners`, `mentionables` now returns `ActiveRecord::Relation` instead of an `Array`
+
 ## 1.2.3 (April 17, 2019)
 
-* Rename "victim" methods to "subject" internally. Thanks to @jdugarte for the suggestion.
+* Rename `victim` methods to `subject` internally. Thanks to @jdugarte for the suggestion.
 
 ## 1.2.2 (April 17, 2019)
 

data/README.md

@@ -8,12 +8,10 @@ The Like feature works just like a Facebook Like. For example, John likes Pulp F
 
 The Mention feature was written with Facebook mentions in mind. For example, John mentions Jane in a comment. Typically, Jane would be highlighted in the comment user interface and possibly notified that John mentioned her. This Facebook feature is occasionally called Tagging, although tagging is generally something [entirely different](http://en.wikipedia.org/wiki/Tag_(metadata).
 
-[![Build Status](https://secure.travis-ci.org/cmer/socialization.png?branch=master)](http://travis-ci.org/cmer/socialization)
+![Specs](https://github.com/cmer/socialization/actions/workflows/specs.yml/badge.svg)
 
 ## Installation
 
-### Rails 3/4
-
 Add the gem to the gemfile:
 `gem "socialization"`
 
@@ -25,9 +23,9 @@ Or if you want to use Redis as your data store:
 
 This will generate three migration files (when using ActiveRecord) and three models named Follow, Like and Mention. You may delete any of the Follow, Like or Mention models and migrations if you don't need that functionality in your application.
 
-### Rails 2.3.x Support
+### Legacy Rails Support
 
-This gem requires Rails 3 or better. Sorry!
+This gem requires Rails 6 or better. Sorry!
 
 ## Usage
 
@@ -264,22 +262,6 @@ You can find the compiled YARD documentation at http://rubydoc.info/github/cmer/
 
 ***
 
-## Changelog
-
-Here it is: https://github.com/cmer/socialization/blob/master/CHANGELOG.md
-
-## Demo App
-
-For your convenience, I have added a demo app in demo/demo_app. It does not have a web UI, but you can play with Socialization in the Rails console. It should also help you figure out hown to use Socialization in the Real World.
-
-To use the demo app:
-
-    $ cd demo/demo_app
-    $ bundle
-    $ rake db:migrate
-    $ rake db:seed
-    $ rails console
-
 
 ## Note on Patches/Pull Requests
 
@@ -295,4 +277,4 @@ To use the demo app:
 
 ## Copyright
 
-Copyright (c) 2012-2015 Carl Mercier --  Released under the MIT license.
+Copyright (c) 2012-2022 Carl Mercier --  Released under the MIT license.

data/lib/socialization/stores/active_record/follow.rb

@@ -68,12 +68,7 @@ module Socialization
 
         # Returns all the followers of a certain type that are following followable
         def followers(followable, klass, opts = {})
-          rel = followers_relation(followable, klass, opts)
-          if rel.is_a?(ActiveRecord::Relation)
-            rel.to_a
-          else
-            rel
-          end
+          followers_relation(followable, klass, opts)
         end
 
         # Returns an ActiveRecord::Relation of all the followables of a certain type that are followed by follower
@@ -94,12 +89,7 @@ module Socialization
 
         # Returns all the followables of a certain type that are followed by follower
         def followables(follower, klass, opts = {})
-          rel = followables_relation(follower, klass, opts)
-          if rel.is_a?(ActiveRecord::Relation)
-            rel.to_a
-          else
-            rel
-          end
+          followables_relation(follower, klass, opts)
         end
 
         # Remove all the followers for followable

data/lib/socialization/stores/active_record/like.rb

@@ -68,12 +68,7 @@ module Socialization
 
         # Returns all the likers of a certain type that are liking  likeable
         def likers(likeable, klass, opts = {})
-          rel = likers_relation(likeable, klass, opts)
-          if rel.is_a?(ActiveRecord::Relation)
-            rel.to_a
-          else
-            rel
-          end
+          likers_relation(likeable, klass, opts)
         end
 
         # Returns an ActiveRecord::Relation of all the likeables of a certain type that are liked by liker
@@ -94,12 +89,7 @@ module Socialization
 
         # Returns all the likeables of a certain type that are liked by liker
         def likeables(liker, klass, opts = {})
-          rel = likeables_relation(liker, klass, opts)
-          if rel.is_a?(ActiveRecord::Relation)
-            rel.to_a
-          else
-            rel
-          end
+          likeables_relation(liker, klass, opts)
         end
 
         # Remove all the likers for likeable

data/lib/socialization/stores/active_record/mention.rb

@@ -68,12 +68,7 @@ module Socialization
 
         # Returns all the mentioners of a certain type that are mentioning mentionable
         def mentioners(mentionable, klass, opts = {})
-          rel = mentioners_relation(mentionable, klass, opts)
-          if rel.is_a?(ActiveRecord::Relation)
-            rel.to_a
-          else
-            rel
-          end
+          mentioners_relation(mentionable, klass, opts)
         end
 
         # Returns an ActiveRecord::Relation of all the mentionables of a certain type that are mentioned by mentioner
@@ -94,12 +89,7 @@ module Socialization
 
         # Returns all the mentionables of a certain type that are mentioned by mentioner
         def mentionables(mentioner, klass, opts = {})
-          rel = mentionables_relation(mentioner, klass, opts)
-          if rel.is_a?(ActiveRecord::Relation)
-            rel.to_a
-          else
-            rel
-          end
+          mentionables_relation(mentioner, klass, opts)
         end
 
         # Remove all the mentioners for mentionable

data/lib/socialization/stores/redis/base.rb

@@ -11,7 +11,7 @@ module Socialization
               result
             end
           else
-            actors_relation(subject, klass, options).to_a
+            actors_relation(subject, klass, options)
           end
         end
 
@@ -33,7 +33,7 @@ module Socialization
               result
             end
           else
-            subjects_relation(actor, klass, options).to_a
+            subjects_relation(actor, klass, options)
           end
         end
         alias victims subjects

data/lib/socialization/version.rb

@@ -1,3 +1,3 @@
 module Socialization
-  VERSION = "1.2.3"
+  VERSION = "2.0.0"
 end

data/socialization.gemspec

@@ -28,4 +28,5 @@ Gem::Specification.new do |s|
   s.add_development_dependency "mock_redis"
   s.add_development_dependency "guard"
   s.add_development_dependency "guard-rspec"
+  s.add_development_dependency "byebug"
 end

data/spec/actors/liker_spec.rb

@@ -47,15 +47,14 @@ describe Socialization::Liker do
     end
 
     it "unlikes when likeing" do
-      expect(@liker).to receive(:likes?).with(@likeable).once.and_return(true)
-      expect(@liker).to receive(:unlike!).with(@likeable).once
+      @liker.like!(@likeable)
       @liker.toggle_like!(@likeable)
+      expect(@liker.likes?(@likeable)).to be false
     end
 
     it "likes when not likeing" do
-      expect(@liker).to receive(:likes?).with(@likeable).once.and_return(false)
-      expect(@liker).to receive(:like!).with(@likeable).once
       @liker.toggle_like!(@likeable)
+      expect(@liker.likes?(@likeable)).to be true
     end
   end
 

data/spec/actors/mentioner_spec.rb

@@ -47,15 +47,14 @@ describe Socialization::Mentioner do
     end
 
     it "unmentions when mentioning" do
-      expect(@mentioner).to receive(:mentions?).with(@mentionable).once.and_return(true)
-      expect(@mentioner).to receive(:unmention!).with(@mentionable).once
+      @mentioner.mention!(@mentionable)
       @mentioner.toggle_mention!(@mentionable)
+      expect(@mentioner.mentions?(@mentionable)).to eq false
     end
 
     it "mentions when not mentioning" do
-      expect(@mentioner).to receive(:mentions?).with(@mentionable).once.and_return(false)
-      expect(@mentioner).to receive(:mention!).with(@mentionable).once
       @mentioner.toggle_mention!(@mentionable)
+      expect(@mentioner.mentions?(@mentionable)).to eq true
     end
   end
 

data/spec/spec_helper.rb

@@ -15,6 +15,7 @@ require "socialization"
 require 'spec_support/data_stores'
 require 'spec_support/matchers'
 require 'logger'
+require 'byebug' rescue nil
 
 ActiveSupport::Inflector.inflections do |inflect|
   inflect.irregular 'cache', 'caches'

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: socialization
 version: !ruby/object:Gem::Version
-  version: 1.2.3
+  version: 2.0.0
 platform: ruby
 authors:
 - Carl Mercier
-autorequire: 
+autorequire:
 bindir: bin
 cert_chain: []
-date: 2019-04-17 00:00:00.000000000 Z
+date: 2022-02-18 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activerecord
@@ -150,6 +150,20 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
+- !ruby/object:Gem::Dependency
+  name: byebug
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 description: Socialization allows any model to Follow and/or Like any other model.
   This is accomplished through a double polymorphic relationship on the Follow and
   Like models. But you don't need to know that since all the complexity is hidden
@@ -159,9 +173,9 @@ executables: []
 extensions: []
 extra_rdoc_files: []
 files:
+- ".github/workflows/specs.yml"
 - ".gitignore"
 - ".ruby-version"
-- ".travis.yml"
 - Appraisals
 - CHANGELOG.md
 - Gemfile
@@ -169,74 +183,6 @@ files:
 - LICENSE
 - README.md
 - Rakefile
-- demo/.gitignore
-- demo/Gemfile
-- demo/README.rdoc
-- demo/Rakefile
-- demo/app/assets/images/rails.png
-- demo/app/assets/javascripts/application.js
-- demo/app/assets/stylesheets/application.css
-- demo/app/controllers/application_controller.rb
-- demo/app/helpers/application_helper.rb
-- demo/app/mailers/.gitkeep
-- demo/app/models/.gitkeep
-- demo/app/models/celebrity.rb
-- demo/app/models/comment.rb
-- demo/app/models/follow.rb
-- demo/app/models/like.rb
-- demo/app/models/mention.rb
-- demo/app/models/movie.rb
-- demo/app/models/user.rb
-- demo/app/views/layouts/application.html.erb
-- demo/config.ru
-- demo/config/application.rb
-- demo/config/boot.rb
-- demo/config/database.yml
-- demo/config/environment.rb
-- demo/config/environments/development.rb
-- demo/config/environments/production.rb
-- demo/config/environments/test.rb
-- demo/config/initializers/backtrace_silencers.rb
-- demo/config/initializers/inflections.rb
-- demo/config/initializers/mime_types.rb
-- demo/config/initializers/secret_token.rb
-- demo/config/initializers/session_store.rb
-- demo/config/initializers/wrap_parameters.rb
-- demo/config/locales/en.yml
-- demo/config/routes.rb
-- demo/db/migrate/20120115051222_create_users.rb
-- demo/db/migrate/20120115051234_create_movies.rb
-- demo/db/migrate/20120115051255_create_celebrities.rb
-- demo/db/migrate/20120115054646_create_follows.rb
-- demo/db/migrate/20120115054647_create_likes.rb
-- demo/db/migrate/20120221200644_create_mentions.rb
-- demo/db/migrate/20120221202703_create_comments.rb
-- demo/db/schema.rb
-- demo/db/seeds.rb
-- demo/lib/assets/.gitkeep
-- demo/lib/tasks/.gitkeep
-- demo/public/404.html
-- demo/public/422.html
-- demo/public/500.html
-- demo/public/favicon.ico
-- demo/public/index.html
-- demo/public/robots.txt
-- demo/script/rails
-- demo/test/fixtures/.gitkeep
-- demo/test/fixtures/celebrities.yml
-- demo/test/fixtures/movies.yml
-- demo/test/fixtures/users.yml
-- demo/test/functional/.gitkeep
-- demo/test/integration/.gitkeep
-- demo/test/performance/browsing_test.rb
-- demo/test/test_helper.rb
-- demo/test/unit/.gitkeep
-- demo/test/unit/celebrity_test.rb
-- demo/test/unit/movie_test.rb
-- demo/test/unit/user_test.rb
-- demo/vendor/assets/javascripts/.gitkeep
-- demo/vendor/assets/stylesheets/.gitkeep
-- demo/vendor/plugins/.gitkeep
 - init.rb
 - lib/generators/socialization/socialization_generator.rb
 - lib/generators/socialization/templates/active_record/migration_follows.rb
@@ -299,7 +245,7 @@ homepage: https://github.com/cmer/socialization
 licenses:
 - MIT
 metadata: {}
-post_install_message: 
+post_install_message:
 rdoc_options: []
 require_paths:
 - lib
@@ -314,8 +260,8 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.0.3
-signing_key: 
+rubygems_version: 3.1.4
+signing_key:
 specification_version: 4
 summary: Easily socialize your app with Likes and Follows
 test_files:

data/.travis.yml

@@ -1,6 +0,0 @@
-language: ruby
-rvm:
-  - 2.5.0
-  - 2.6.2
-
-script: bundle exec rake spec

data/demo/.gitignore

@@ -1,15 +0,0 @@
-# See http://help.github.com/ignore-files/ for more about ignoring files.
-#
-# If you find yourself ignoring temporary files generated by your text editor
-# or operating system, you probably want to add a global ignore instead:
-#   git config --global core.excludesfile ~/.gitignore_global
-
-# Ignore bundler config
-/.bundle
-
-# Ignore the default SQLite database.
-/db/*.sqlite3
-
-# Ignore all logfiles and tempfiles.
-/log/*.log
-/tmp

data/demo/Gemfile

@@ -1,35 +0,0 @@
-source 'https://rubygems.org'
-
-gem 'rails', '~> 4.1.11'
-gem 'socialization', :path => '../'
-# Bundle edge Rails instead:
-# gem 'rails', :git => 'git://github.com/rails/rails.git'
-
-gem 'sqlite3'
-
-
-# Gems used only for assets and not required
-# in production environments by default.
-group :assets do
-  gem 'sass-rails'
-  gem 'coffee-rails'
-
-  gem 'uglifier'
-end
-
-gem 'jquery-rails'
-
-# To use ActiveModel has_secure_password
-# gem 'bcrypt-ruby', '~> 3.0.0'
-
-# To use Jbuilder templates for JSON
-# gem 'jbuilder'
-
-# Use unicorn as the web server
-# gem 'unicorn'
-
-# Deploy with Capistrano
-# gem 'capistrano'
-
-# To use debugger
-# gem 'ruby-debug19', :require => 'ruby-debug'