socialization 1.1.0 → 1.2.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 39b3c656c408687fa0ee59c6290a726c06cc99d9
-  data.tar.gz: 04842d1fba2aefd0d43a4196493cfd466de10f6a
+  metadata.gz: a760308b08f93a8929499b6ba5b1c3d9ddf66b19
+  data.tar.gz: e5c2ec3cd08861113267525060542682da32eaa7
 SHA512:
-  metadata.gz: a0d79112e37012c0efe43a47f75a03b6b5a727b79c22ab70bbdb89d0d37bc55ca55e932f7c3552043eb33080d1fa0e5fb5f0c7fb74393966524dd7b172804ffd
-  data.tar.gz: d63f0418b794e48c4bed540fa096cfe886ba85f3db61fe7eb5eceadd03536a2ef422e722fa2f62774dc56049df99da97febad6c4529541d7eafd5ed7bd49b54f
+  metadata.gz: f935cb82ad88a7db6c2a09d6d3232e8be9ff276a2b70b2a38cfe5a12941081f265eb0920a78ece38c34deae21632f84e27dd94fe8d4223aaf8b654952c816e5f
+  data.tar.gz: 4207ebfefb3b53e477a23ff830071708623fd3a540eb26994eee18514ec432890c590bc9cbf02e8dc9289efc334c9d6c63c9c9546ecc23ccb4901c96d3c852c9

data/.ruby-version

@@ -0,0 +1 @@
+2.2.2

data/.travis.yml

@@ -3,5 +3,6 @@ rvm:
   - 1.9.3
   - 2.0.0
   - 2.1.0
+  - 2.2.2
 
-script: bundle exec rake test
+script: bundle exec rake spec

data/Appraisals

@@ -8,4 +8,16 @@ end
 
 appraise "activerecord32" do
   gem "activerecord", "~> 3.2.1"
-end
+end
+
+appraise "activerecord40" do
+  gem "activerecord", "~> 4.0.13"
+end
+
+appraise "activerecord41" do
+  gem "activerecord", "~> 4.1.12"
+end
+
+appraise "activerecord42" do
+  gem "activerecord", "~> 4.2.3"
+end

data/CHANGELOG.md

@@ -1,5 +1,11 @@
 # Changelog
 
+## 1.2 (August 8, 2015)
+
+* Support for ActiveRecord counter caches (thanks @samnang)
+* Moved entire test suite to RSpec
+
+
 ## 1.0.1 (January 8, 2014)
 
 * Supports Rails 4 (thanks @thomas88)
@@ -10,6 +16,7 @@
 
 * Same as 0.5.0.beta4. Been using it in a very high traffic production environment for over a year and it works.
 
+
 ## 0.5.0.beta (June 6, 2012)
 
 * **IMPORTANT:** This release includes many changes, some breaking. Make sure to test your code carefully after upgrading.
@@ -24,11 +31,13 @@
 * Added: support for single table inheritance. Thanks to [@balvig](https://github.com/balvig).
 * Changed: raises Socialization::ArgumentError instead of ::ArgumentError
 
+
 ## v0.4.0 (February 25, 2012)
 
 * **BREAKING CHANGE:** Renamed `mentionner` to `mentioner`. This is proper English.
 * Added: `followees`, `likees` and `mentionees` methods to `Follower`, `Liker` and `Mentioner`. Thanks to [@ihara2525](https://github.com/ihara2525).
 
+
 ## v0.3.0 (February 22, 2012)
 
 * **BREAKING CHANGE:** `likers`, `followers` now return a scope instead of an array. They also require to have the class of the desired scope as an argument. For example: `Movie.find(1).followers(User)`.
@@ -41,15 +50,18 @@
 * Improved tests.
 * Changed: Can no longer like or follow yourself.
 
+
 ## 0.2.1 (January 15, 2012)
 
 * Bug fixes
 
+
 ## 0.2.0 (January 15, 2012)
 
 * Bug fixes
 * Made Ruby 1.8.7 compatible
 
+
 ## 0.1.0 (January 14, 2012)
 
 * Initial release

data/Guardfile

@@ -0,0 +1,12 @@
+guard :rspec, cmd: "bundle exec rspec" do
+  require "guard/rspec/dsl"
+  dsl = Guard::RSpec::Dsl.new(self)
+
+  rspec = dsl.rspec
+  watch(rspec.spec_helper) { rspec.spec_dir }
+  watch(rspec.spec_support) { rspec.spec_dir }
+  watch(%r{^spec/.+_spec\.rb$})
+
+  ruby = dsl.ruby
+  dsl.watch_spec_files_for(ruby.lib_files)
+end

data/LICENSE

@@ -1,4 +1,4 @@
-Copyright (c) 2012 Carl Mercier
+Copyright (c) 2015 Carl Mercier
 
 Permission is hereby granted, free of charge, to any person obtaining
 a copy of this software and associated documentation files (the
@@ -17,4 +17,4 @@ MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
 NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE
 LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION
 OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION
-WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
+WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.

data/README.md

@@ -119,6 +119,13 @@ What items are you following (given that an Item model is followed)?
 
     user.followees(Item)
 
+Number of followees (Requires followees_count column in db)
+
+    def change
+      add_column :#{Table_name}, :followees_count, :integer, :default => 0
+    end
+
+    user.followees_count
 
 ***
 
@@ -133,6 +140,13 @@ All followers
 
     celebrity.followers(User)
 
+Number of followers (Requires followers_count column in db)
+
+    def change
+      add_column :#{Table_name}, :followers_count, :integer, :default => 0
+    end
+
+    celebrity.followers_count
 
 ***
 
@@ -155,6 +169,14 @@ Likes?
 
     user.likes?(movie)
 
+Number of likees (Requires likees_count column in db)
+
+    def change
+      add_column :#{Table_name}, :likees_count, :integer, :default => 0
+    end
+
+    user.likees_count
+
 ***
 
 
@@ -168,6 +190,14 @@ All likers
 
     movie.likers(User)
 
+Number of likers (Requires likers_count column in db)
+
+    def change
+      add_column :#{Table_name}, :likers_count, :integer, :default => 0
+    end
+
+    movie.likers_count
+
 ***
 
 
@@ -195,6 +225,14 @@ All mentionees
 
     comment.mentionees(User)
 
+Number of mentionees (Requires mentionees column in db)
+
+    def change
+      add_column :#{Table_name}, : mentionees, :integer, :default => 0
+    end
+
+    user. mentionees_count
+
 ***
 
 
@@ -208,6 +246,13 @@ All mentioners
 
     user.mentioners(Comment)
 
+Number of mentioners (Requires mentioners_count column in db)
+
+    def change
+      add_column :#{Table_name}, :mentioners_count, :integer, :default => 0
+    end
+
+    movie.mentioners_count
 
 ***
 
@@ -250,4 +295,4 @@ To use the demo app:
 
 ## Copyright
 
-Copyright (c) 2012-2014 Carl Mercier --  Released under the MIT license.
+Copyright (c) 2012-2015 Carl Mercier --  Released under the MIT license.

data/Rakefile

@@ -1,16 +1,14 @@
 require 'rake'
-require 'rake/testtask'
 require 'bundler/gem_tasks'
 require 'appraisal'
 
-desc 'Default: run unit tests against all supported versions of ActiveRecord'
-task :default => ["appraisal:install"] do |t|
-  exec("rake appraisal test")
-end
+begin
+  require 'rspec/core/rake_task'
+  RSpec::Core::RakeTask.new(:spec)
 
-desc 'Test the socialization plugin.'
-Rake::TestTask.new(:test) do |t|
-  t.libs << 'lib'
-  t.pattern = 'test/**/*_test.rb'
-  t.verbose = true
+  desc 'Default: run unit tests against all supported versions of ActiveRecord'
+  task :default => ["appraisal:install"] do |t|
+    exec("rake appraisal spec")
+  end
+rescue LoadError
 end

data/lib/socialization/stores/active_record/follow.rb

@@ -25,6 +25,8 @@ module Socialization
               follow.follower = follower
               follow.followable = followable
             end
+            update_counter(follower, followees_count: +1)
+            update_counter(followable, followers_count: +1)
             call_after_create_hooks(follower, followable)
             true
           else
@@ -35,6 +37,8 @@ module Socialization
         def unfollow!(follower, followable)
           if follows?(follower, followable)
             follow_for(follower, followable).destroy_all
+            update_counter(follower, followees_count: -1)
+            update_counter(followable, followers_count: -1)
             call_after_destroy_hooks(follower, followable)
             true
           else

data/lib/socialization/stores/active_record/like.rb

@@ -25,6 +25,8 @@ module Socialization
               like.liker = liker
               like.likeable = likeable
             end
+            update_counter(liker, likees_count: +1)
+            update_counter(likeable, likers_count: +1)
             call_after_create_hooks(liker, likeable)
             true
           else
@@ -35,6 +37,8 @@ module Socialization
         def unlike!(liker, likeable)
           if likes?(liker, likeable)
             like_for(liker, likeable).destroy_all
+            update_counter(liker, likees_count: -1)
+            update_counter(likeable, likers_count: -1)
             call_after_destroy_hooks(liker, likeable)
             true
           else

data/lib/socialization/stores/active_record/mention.rb

@@ -25,6 +25,8 @@ module Socialization
               mention.mentioner = mentioner
               mention.mentionable = mentionable
             end
+            update_counter(mentioner, mentionees_count: +1)
+            update_counter(mentionable, mentioners_count: +1)
             call_after_create_hooks(mentioner, mentionable)
             true
           else
@@ -35,6 +37,8 @@ module Socialization
         def unmention!(mentioner, mentionable)
           if mentions?(mentioner, mentionable)
             mention_for(mentioner, mentionable).destroy_all
+            update_counter(mentioner, mentionees_count: -1)
+            update_counter(mentionable, mentioners_count: -1)
             call_after_destroy_hooks(mentioner, mentionable)
             true
           else

data/lib/socialization/stores/active_record/mixins/base.rb

@@ -2,6 +2,10 @@ module Socialization
   module ActiveRecordStores
     module Mixins
       module Base
+        def update_counter(model, counter)
+          column_name, _ = counter.first
+          model.class.update_counters model.id, counter if model.respond_to?(column_name)
+        end
       end
     end
   end

data/lib/socialization/stores/mixins/follow.rb

@@ -36,4 +36,4 @@ module Socialization
       end
     end
   end
-end
+end

data/lib/socialization/version.rb

@@ -1,3 +1,3 @@
 module Socialization
-  VERSION = "1.1.0"
+  VERSION = "1.2.0"
 end

data/socialization.gemspec

@@ -22,9 +22,11 @@ Gem::Specification.new do |s|
 
   s.add_development_dependency "appraisal"
   s.add_development_dependency "logger"
-  s.add_development_dependency "mocha"
-  s.add_development_dependency "shoulda"
+  s.add_development_dependency "rspec", "~> 3.3.0"
+  s.add_development_dependency "rspec-mocks"
   s.add_development_dependency "sqlite3"
   s.add_development_dependency "yard"
   s.add_development_dependency "mock_redis"
-end
+  s.add_development_dependency "guard"
+  s.add_development_dependency "guard-rspec"
+end

data/spec/actors/follower_spec.rb

@@ -0,0 +1,113 @@
+require 'spec_helper'
+
+describe Socialization::Follower do
+  before(:all) do
+    use_ar_store
+    @follower = ImAFollower.new
+    @followable = ImAFollowable.create
+  end
+
+  describe "#is_follower?" do
+    it "returns true" do
+      expect(@follower.is_follower?).to be true
+    end
+  end
+
+  describe "#follower?" do
+    it "returns true" do
+      expect(@follower.follower?).to be true
+    end
+  end
+
+  describe "#follow!" do
+    it "does not accept non-followables" do
+      expect { @follower.follow!(:foo) }.to raise_error(Socialization::ArgumentError)
+    end
+
+    it "calls $Follow.follow!" do
+      expect($Follow).to receive(:follow!).with(@follower, @followable).once
+      @follower.follow!(@followable)
+    end
+  end
+
+  describe "#unfollow!" do
+    it "does not accept non-followables" do
+      expect { @follower.unfollow!(:foo) }.to raise_error(Socialization::ArgumentError)
+    end
+
+    it "calls $Follow.follow!" do
+      expect($Follow).to receive(:unfollow!).with(@follower, @followable).once
+      @follower.unfollow!(@followable)
+    end
+  end
+
+  describe "#toggle_follow!" do
+    it "does not accept non-followables" do
+      expect { @follower.unfollow!(:foo) }.to raise_error(Socialization::ArgumentError)
+    end
+
+    it "unfollows when following" do
+      expect(@follower).to receive(:follows?).with(@followable).once.and_return(true)
+      expect(@follower).to receive(:unfollow!).with(@followable).once
+      @follower.toggle_follow!(@followable)
+    end
+
+    it "follows when not following" do
+      expect(@follower).to receive(:follows?).with(@followable).once.and_return(false)
+      expect(@follower).to receive(:follow!).with(@followable).once
+      @follower.toggle_follow!(@followable)
+    end
+  end
+
+  describe "#follows?" do
+    it "does not accept non-followables" do
+      expect { @follower.unfollow!(:foo) }.to raise_error(Socialization::ArgumentError)
+    end
+
+    it "calls $Follow.follows?" do
+      expect($Follow).to receive(:follows?).with(@follower, @followable).once
+      @follower.follows?(@followable)
+    end
+  end
+
+  describe "#followables" do
+    it "calls $Follow.followables" do
+      expect($Follow).to receive(:followables).with(@follower, @followable.class, { :foo => :bar })
+      @follower.followables(@followable.class, { :foo => :bar })
+    end
+  end
+
+  describe "#followees" do
+    it "calls $Follow.followables" do
+      expect($Follow).to receive(:followables).with(@follower, @followable.class, { :foo => :bar })
+      @follower.followees(@followable.class, { :foo => :bar })
+    end
+  end
+
+  describe "#followables_relation" do
+    it "calls $Follow.followables_relation" do
+      expect($Follow).to receive(:followables_relation).with(@follower, @followable.class, { :foo => :bar })
+      @follower.followables_relation(@followable.class, { :foo => :bar })
+    end
+  end
+
+  describe "#followees_relation" do
+    it "calls $Follow.followables_relation" do
+      expect($Follow).to receive(:followables_relation).with(@follower, @followable.class, { :foo => :bar })
+      @follower.followees_relation(@followable.class, { :foo => :bar })
+    end
+  end
+
+  describe "deleting a follower" do
+    before(:all) do
+      @follower = ImAFollower.create
+      @follower.follow!(@followable)
+    end
+
+    it "removes follow relationships" do
+      expect(Socialization.follow_model).to receive(:remove_followables).with(@follower)
+      @follower.destroy
+    end
+  end
+
+end

data/spec/actors/liker_spec.rb

@@ -0,0 +1,105 @@
+require 'spec_helper'
+
+describe Socialization::Liker do
+  before(:all) do
+    use_ar_store
+    @liker = ImALiker.new
+    @likeable = ImALikeable.create
+  end
+
+  describe "#is_liker?" do
+    it "returns true" do
+      expect(@liker.is_liker?).to be true
+    end
+  end
+
+  describe "#liker?" do
+    it "returns true" do
+      expect(@liker.liker?).to be true
+    end
+  end
+
+  describe "#like!" do
+    it "does not accept non-likeables" do
+      expect { @liker.like!(:foo) }.to raise_error(Socialization::ArgumentError)
+    end
+
+    it "calls $Like.like!" do
+      expect($Like).to receive(:like!).with(@liker, @likeable).once
+      @liker.like!(@likeable)
+    end
+  end
+
+  describe "#unlike!" do
+    it "does not accept non-likeables" do
+      expect { @liker.unlike!(:foo) }.to raise_error(Socialization::ArgumentError)
+    end
+
+    it "calls $Like.like!" do
+      expect($Like).to receive(:unlike!).with(@liker, @likeable).once
+      @liker.unlike!(@likeable)
+    end
+  end
+
+  describe "#toggle_like!" do
+    it "does not accept non-likeables" do
+      expect { @liker.unlike!(:foo) }.to raise_error(Socialization::ArgumentError)
+    end
+
+    it "unlikes when likeing" do
+      expect(@liker).to receive(:likes?).with(@likeable).once.and_return(true)
+      expect(@liker).to receive(:unlike!).with(@likeable).once
+      @liker.toggle_like!(@likeable)
+    end
+
+    it "likes when not likeing" do
+      expect(@liker).to receive(:likes?).with(@likeable).once.and_return(false)
+      expect(@liker).to receive(:like!).with(@likeable).once
+      @liker.toggle_like!(@likeable)
+    end
+  end
+
+  describe "#likes?" do
+    it "does not accept non-likeables" do
+      expect { @liker.unlike!(:foo) }.to raise_error(Socialization::ArgumentError)
+    end
+
+    it "calls $Like.likes?" do
+      expect($Like).to receive(:likes?).with(@liker, @likeable).once
+      @liker.likes?(@likeable)
+    end
+  end
+
+  describe "#likeables" do
+    it "calls $Like.likeables" do
+      expect($Like).to receive(:likeables).with(@liker, @likeable.class, { :foo => :bar })
+      @liker.likeables(@likeable.class, { :foo => :bar })
+    end
+  end
+
+  describe "#likees" do
+    it "calls $Like.likeables" do
+      expect($Like).to receive(:likeables).with(@liker, @likeable.class, { :foo => :bar })
+      @liker.likees(@likeable.class, { :foo => :bar })
+    end
+  end
+
+  describe "#likeables_relation" do
+    it "calls $Follow.likeables_relation" do
+      expect($Like).to receive(:likeables_relation).with(@liker, @likeable.class, { :foo => :bar })
+      @liker.likeables_relation(@likeable.class, { :foo => :bar })
+    end
+  end
+
+  describe "#likees_relation" do
+    it "calls $Follow.likeables_relation" do
+      expect($Like).to receive(:likeables_relation).with(@liker, @likeable.class, { :foo => :bar })
+      @liker.likees_relation(@likeable.class, { :foo => :bar })
+    end
+  end
+
+  it "removes like relationships" do
+    expect(Socialization.like_model).to receive(:remove_likeables).with(@liker)
+    @liker.destroy
+  end
+end