socialcastr 0.2.16 → 0.2.17

data/lib/socialcastr/base.rb

@@ -89,6 +89,7 @@ module Socialcastr
         @data[method_name(method.to_s.sub(/=$/,''))] = args.first
       else
         obj = @data[method_name(method)] 
+        return nil unless obj
         unless new?
           self.class.set_prefix_options(obj, to_prefix_options)
         end

data/lib/socialcastr/sax/active_resource.rb

@@ -36,9 +36,9 @@ module Socialcastr
       end
 
       def start_element name, attrs = []
-        return nil_element! if name.contains_dot? # [FIXME] we can't evaluate strings inside elements like <html.title>
+        return nil_element! if unsupported?(name)
         type = parse_attrs_and_get_type(attrs)
-        return if nil_element?
+        return nil_element! if type.nil?
         push_element(type)
       end
 
@@ -53,7 +53,8 @@ module Socialcastr
         (value, type) = pop_element
         case type
         when HASH
-          element = element_class(name).from_hash(value || {})
+          return nil unless value
+          element = element_class(name).from_hash(value)
         when INTEGER
           element = value.to_i
         when BOOLEAN
@@ -73,12 +74,12 @@ module Socialcastr
 
       private
 
+      def unsupported?(name)
+        name.contains_dot?
+      end
+
       def element_class(name)
-        if RUBY_VERSION < '1.9' 
-          Socialcastr.const_get(Socialcastr.to_class_name(name))
-        else 
-          Socialcastr.const_get(Socialcastr.to_class_name(name), false)
-        end
+        Socialcastr.get_element_class(Socialcastr.to_class_name(name))
       end
 
       def container_type
@@ -103,7 +104,7 @@ module Socialcastr
 
       def parse_attrs_and_get_type(attribute_array=[])
         attributes = attribute_array.to_attribute_hash
-        return nil_element! if attributes["nil"]
+        return nil if attributes["nil"]
         attributes["type"] ? attributes["type"] : HASH
       end
 

data/lib/socialcastr/version.rb

@@ -1,3 +1,3 @@
 module Socialcastr
-  VERSION = "0.2.16"
+  VERSION = "0.2.17"
 end

data/lib/socialcastr.rb

@@ -70,7 +70,20 @@ module Socialcastr
       method.to_s.gsub(/^[a-z]|-[a-z]/i) { |a| a.sub("-", '').upcase }
     end
 
+    def get_element_class(class_name)
+      define_element_class(class_name) unless Socialcastr.const_defined?(class_name)
+      if RUBY_VERSION < '1.9'
+        Socialcastr.const_get(class_name)
+      else 
+        Socialcastr.const_get(class_name, false)
+      end
+    end
+
     def const_missing(class_name)
+      define_element_class(class_name)
+    end
+
+    def define_element_class(class_name)
       Socialcastr.const_set(class_name, Class.new(Socialcastr::Base))
     end
   end

data/spec/sax/active_resource_spec.rb

@@ -8,15 +8,15 @@ describe Socialcastr::SAX::ActiveResource do
     end
 
     context "an empty document with a root 'message' element" do
-      it "should return a Message object" do
+      it "should return a nil object" do
         xml = "<message></message>"
         @parser.parse(xml)
-        @active_resource.data.class.should == Socialcastr::Message
+        @active_resource.data.should be_nil
       end
     end
     context "a document with a nil element" do
       it "should make the nil element accessible" do
-        xml = "<message><rating nil=\"true\"></rating></message>"
+        xml = "<message><id>1</id><rating nil=\"true\"></rating></message>"
         @parser.parse(xml)
         @active_resource.data.rating.should be_nil
       end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: socialcastr
 version: !ruby/object:Gem::Version
-  version: 0.2.16
+  version: 0.2.17
   prerelease: 
 platform: ruby
 authors:
@@ -9,12 +9,12 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2011-08-08 00:00:00.000000000 +01:00
+date: 2011-10-03 00:00:00.000000000 +01:00
 default_executable: 
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rake
-  requirement: &2152947880 !ruby/object:Gem::Requirement
+  requirement: &2152777920 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ~>
@@ -22,10 +22,10 @@ dependencies:
         version: '0.8'
   type: :development
   prerelease: false
-  version_requirements: *2152947880
+  version_requirements: *2152777920
 - !ruby/object:Gem::Dependency
   name: rspec
-  requirement: &2153031760 !ruby/object:Gem::Requirement
+  requirement: &2152915220 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ~>
@@ -33,10 +33,10 @@ dependencies:
         version: '2.5'
   type: :development
   prerelease: false
-  version_requirements: *2153031760
+  version_requirements: *2152915220
 - !ruby/object:Gem::Dependency
   name: yard
-  requirement: &2153137260 !ruby/object:Gem::Requirement
+  requirement: &2152982900 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -44,10 +44,10 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *2153137260
+  version_requirements: *2152982900
 - !ruby/object:Gem::Dependency
   name: artifice
-  requirement: &2160224120 !ruby/object:Gem::Requirement
+  requirement: &2152992820 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -55,10 +55,10 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *2160224120
+  version_requirements: *2152992820
 - !ruby/object:Gem::Dependency
   name: nokogiri
-  requirement: &2160560720 !ruby/object:Gem::Requirement
+  requirement: &2152996040 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -66,7 +66,7 @@ dependencies:
         version: 1.4.4
   type: :runtime
   prerelease: false
-  version_requirements: *2160560720
+  version_requirements: *2152996040
 description: A Ruby wrapper for the Socialcast REST API
 email:
 - bru@codewitch.org