socialcast-git-extensions 4.1.0 → 4.1.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 15c1ec40dbe8a2b80701e60dcad382fc1d151a70
-  data.tar.gz: e3ddfaa87901257a06a9aeb846c406e1e7cd9ea6
+  metadata.gz: b636e86e81a35a85a4709b288c1a5a0d157c19a8
+  data.tar.gz: 388e65e84fe941af1e7ccbdbda072bcc5de64ccf
 SHA512:
-  metadata.gz: e2bddfe8501060bcc653d6f2492b5565020424189690f79f9fb72e99bd3379de2b548d179e8dece8cea81a758aa71f91ae710a57756dd4cbe89dabd6dab7e8da
-  data.tar.gz: 3685ff147e5ec0ac69d172d1450e028321de02bf72df3a0b3441af4285676ed42af86a7f624cdfff4367057e9db79c19f4e80696d1eff75091ca167dee2a30cb
+  metadata.gz: 56ab6b7a039596d9dd557cc1363af42484a63b513ca52dda4336e910b2123f850c221d2c6f71855cc0a3f6a4e84e2a766055b6567eea0a0d5e205e956b2f16b9
+  data.tar.gz: fa9fb632400f12020746ab92134771bfb08135714f4ab9e3de70a1bbe623197da89306dc14644e513ac5ba6143596ecbe30195b59146ac0bde42a0000be234e2

data/lib/socialcast-git-extensions/github.rb

@@ -121,7 +121,12 @@ module Socialcast
       end
 
       def github_api_request(method, path, payload = nil)
-        url = path.include?('http') ? path : "https://api.github.com/#{path}"
+        url = if path.start_with?('http://') || path.start_with?('https://')
+          path
+        else
+          "https://api.github.com/#{path}"
+        end
+
         JSON.parse RestClient::Request.new(:url => url, :method => method, :payload => payload, :headers => { :accept => :json, :content_type => :json, 'Authorization' => "token #{authorization_token}", :user_agent => 'socialcast-git-extensions' }).execute
       rescue RestClient::Exception => e
         process_error e

data/lib/socialcast-git-extensions/version.rb

@@ -1,5 +1,5 @@
 module Socialcast
   module Gitx
-    VERSION = "4.1.0"
+    VERSION = "4.1.1"
   end
 end

data/spec/github_spec.rb

@@ -33,7 +33,7 @@ describe Socialcast::Gitx::Github do
         :body => body
       }
     end
-    let(:dummy_pr_created_response) { { :dummy => :response } }
+    let(:dummy_pr_created_response) { { 'dummy' => 'response' } }
     let(:body) { 'This is my pull request.' }
     before do
       allow(test_instance).to receive(:base_branch).and_return(base_branch)
@@ -44,9 +44,14 @@ describe Socialcast::Gitx::Github do
 
   describe '#pull_requests_for_branch' do
     subject { test_instance.send(:pull_requests_for_branch, repo, branch) }
-    let(:dummy_pr_list_response) { [{ :dummy => :response }] }
+    let(:branch) { 'my-http-and-https-branch' }
+    let(:dummy_pr_list_response) { [{ 'dummy' => 'response' }] }
     before do
-      expect(test_instance).to receive(:github_api_request).with('GET', 'repos/ownername/projectname/pulls?head=ownername:my-branch').and_return(dummy_pr_list_response)
+      allow(test_instance).to receive(:authorization_token).and_return('abc123')
+      expect_any_instance_of(RestClient::Request).to receive(:execute) do |instance|
+        expect(instance.url).to eq 'https://api.github.com/repos/ownername/projectname/pulls?head=ownername:my-http-and-https-branch'
+        '[{ "dummy": "response" }]'
+      end
     end
     it { is_expected.to eq dummy_pr_list_response }
   end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: socialcast-git-extensions
 version: !ruby/object:Gem::Version
-  version: 4.1.0
+  version: 4.1.1
 platform: ruby
 authors:
 - Socialcast
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-09-22 00:00:00.000000000 Z
+date: 2016-11-09 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rugged