socialcast-git-extensions 3.1.22 → 3.1.23

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: c4a79a9c968ed581fd256ad82d55798f1abfb0e3
-  data.tar.gz: 448fb0e78e52aaea27197109f0fddb7722bcf797
+  metadata.gz: b980b68e25c9e7d9a362521e696a6a2ac9765d28
+  data.tar.gz: 31ef169e62e027d408fc18206dda74261b197dcf
 SHA512:
-  metadata.gz: c018c5a08b1d655b81db2a031a6d86b1e09e8d25c11fc5eb64eea099acb1565c83cabc99d60548b4fbc4629817b48e1d8c238be8dffaff7f7bdcc69c277061ef
-  data.tar.gz: c1f3fcf4b193de15b9062d8799f55abf7d7fb5d1afb79d141fce6cdff6438ad49cffbf2a4dec16da930d40f1a679bf80a26c442c8ede567104e0dc1e71f331ad
+  metadata.gz: 1a5e2859d6a3aa9c5203dd737aca06309eda03e1dcdb6598fb7e0beebbae16628647f98e302ee15f9218b79d1f15277283f2702de01fb477d3397dcf3e9f6477
+  data.tar.gz: be9c48c3d885f8142cf826ba8fe3299c888f6d50f593047dad0ca041c152b62f38b6f2002def99a830603a60d2181ebd326d817144f248b2ab52552feb1aa9ff

data/lib/socialcast-git-extensions/cli.rb

@@ -64,7 +64,7 @@ module Socialcast
         url = create_pull_request branch, repo, description, assignee
         say "Pull request created: #{url}"
 
-        review_message = ["#reviewrequest for #{branch} #scgitx", "/cc @SocialcastDevelopers", review_mention, description, changelog_summary(branch)].compact.join("\n\n")
+        review_message = ["#reviewrequest for #{branch} #scgitx", "/cc @#{developer_group}", review_mention, description, changelog_summary(branch)].compact.join("\n\n")
         post review_message, :url => url, :message_type => 'review_request'
       end
 
@@ -108,7 +108,7 @@ module Socialcast
         if socialcast_reviewer
           review_message << "/cc @#{socialcast_reviewer} for #backport track"
         end
-        review_message << "/cc @SocialcastDevelopers"
+        review_message << "/cc @#{developer_group}"
         post review_message.join("\n\n"), :url => pull_request_url, :message_type => 'review_request'
       ensure
         ENV['BASE_BRANCH'] = original_base_branch
@@ -207,7 +207,7 @@ module Socialcast
 
         message_parts = []
         message_parts << "#worklog resetting #{bad_branch} branch to #{good_branch} #scgitx"
-        message_parts << "/cc @SocialcastDevelopers"
+        message_parts << "/cc @#{developer_group}"
         if removed_branches.any?
           message_parts << ""
           message_parts << "the following branches were affected:"
@@ -237,6 +237,10 @@ module Socialcast
 
       private
 
+      def developer_group
+        config['developer_group'] || 'SocialcastDevelopers'
+      end
+
       # post a message in socialcast
       # skip sharing message if CLI quiet option is present
       def post(message, params = {})

data/lib/socialcast-git-extensions/version.rb

@@ -1,5 +1,5 @@
 module Socialcast
   module Gitx
-    VERSION = "3.1.22"
+    VERSION = "3.1.23"
   end
 end

data/spec/cli_spec.rb

@@ -973,6 +973,18 @@ describe Socialcast::Gitx::CLI do
           ])
         end
       end
+      context 'and a developer group is specified' do
+        let(:message_body) { "#reviewrequest for FOO #scgitx\n\n/cc @#{another_group}\n\ntesting\n\n1 file changed" }
+        let(:another_group) { 'AnotherDeveloperGroup' }
+        before do
+          allow_any_instance_of(Socialcast::Gitx::CLI).to receive(:changelog_summary).and_return('1 file changed')
+          allow_any_instance_of(Socialcast::Gitx::CLI).to receive(:config).and_return({'developer_group' => another_group})
+          # The Review Buddy should be @mentioned in the message
+          stub_message message_body, :url => 'http://github.com/repo/project/pulls/1', :message_type => 'review_request'
+          Socialcast::Gitx::CLI.start ['reviewrequest', '--description', 'testing', '-s']
+        end
+        it 'should create github pull request with a different group mentioned' do end # see expectations
+      end
       context 'and additional reviewers are not specified' do
         let(:message_body) { "#reviewrequest for FOO #scgitx\n\n/cc @SocialcastDevelopers\n\ntesting\n\n1 file changed" }
         before do

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: socialcast-git-extensions
 version: !ruby/object:Gem::Version
-  version: 3.1.22
+  version: 3.1.23
 platform: ruby
 authors:
 - Ryan Sonnek
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-09-17 00:00:00.000000000 Z
+date: 2014-09-30 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: grit