social_stream-base 0.21.2 → 0.22.0

data/app/models/activity.rb

@@ -182,12 +182,14 @@ class Activity < ActiveRecord::Base
 
   # The first activity object of this activity
   def direct_activity_object
-    activity_objects.first
+    @direct_activity_object ||=
+      activity_objects.first
   end
 
   # The first object of this activity
   def direct_object
-    direct_activity_object.try(:object)
+    @direct_object ||=
+      direct_activity_object.try(:object)
   end
 
   # The title for this activity in the stream

data/app/models/activity_action.rb

@@ -5,8 +5,6 @@ class ActivityAction < ActiveRecord::Base
   belongs_to :actor
   belongs_to :activity_object
 
-  before_save :change_follower_count
-
   scope :sent_by, lambda{ |actor|
     where(:actor_id => Actor.normalize_id(actor))
   }
@@ -27,8 +25,11 @@ class ActivityAction < ActiveRecord::Base
     authored_or_owned.sent_by(subject)
   }
 
+
   before_create :follow_by_author_and_owner
 
+  after_save :change_follower_count
+
   private
 
   # Updates the follower_count counter in the {ActivityObject}

data/app/models/activity_object.rb

@@ -92,6 +92,21 @@ class ActivityObject < ActiveRecord::Base
       merge(ActivityObjectAudience.where(:relation_id => Relation.ids_shared_with(subject)))
   }
 
+  # Obtain the {ActivityAction} between this {ActivityObject}
+  # and the {Actor} identified by actor_id
+  def received_action_by(actor_id)
+    received_actions.
+      find{ |a| a.actor_id == actor_id }
+  end
+
+  # Obtain received_action_by(actor_id) or create it if it does
+  # not exist
+  def received_action_by!(actor_id)
+    received_action_by(actor_id) ||
+      received_actions.build(:actor_id  => actor_id)
+  end
+
+  # Get the first {ActivityAction} that has activated the role flag
   def received_role_action(role)
     received_actions.
       find{ |a| a.__send__ "#{ role }?" }
@@ -106,16 +121,9 @@ class ActivityObject < ActiveRecord::Base
 
       def #{ role }_id=(actor_id)                    # def author_id=(actor_id)
         action =                                     #   action =
-          received_actions.                          #     received_actions.
-            find{ |a| a.actor_id == actor_id }       #       select{ |a| a.actor_id == actor_id }
+          received_action_by!(actor_id)              #     received_action_by!(actor_id)
                                                      #
-        if action                                    #   if action 
-          action.#{ role } = true                    #     action.author = true
-        else                                         #   else
-          received_actions.                          #     received_actions.
-            build :actor_id  => actor_id,            #       build :actor_id => actor_id,
-                  :#{ role } => true                 #             :author   => true
-        end                                          #   end
+        action.#{ role } = true                      #     action.author = true
                                                      #
         actor_id                                     #  actor_id
       end                                            # end
@@ -133,7 +141,6 @@ class ActivityObject < ActiveRecord::Base
       def #{ role }_subject # def author_subject
         #{ role }.subject   #   author.subject
       end                   # end
-
     EOC
 
     class_eval code, __FILE__, __LINE__ - code.lines.count - 2

data/app/models/actor.rb

@@ -5,7 +5,7 @@
 # type of a {Tie} is a {Relation}. Each actor can define and customize their relations own
 # {Relation Relations}.
 #
-# Every {Actor} has an Avatar, a {Profile} with personal o group information, contact data, etc.
+# Every {Actor} has an Avatar, a {Profile} with personal or group information, contact data, etc.
 #
 # {Actor Actors} perform {ActivityAction actions} (like, suscribe, etc.) on
 # {ActivityObject activity objects} ({Post posts}, {Comment commments}, pictures, events..)
@@ -81,6 +81,19 @@ class Actor < ActiveRecord::Base
            :source  => :activity_object,
            :conditions => { 'activity_actions.follow' => true }
 
+  has_many :authored_activities,
+           :class_name  => "Activity",
+           :foreign_key => :author_id,
+           :dependent   => :destroy
+  has_many :user_authored_activities,
+           :class_name  => "Activity",
+           :foreign_key => :user_author_id,
+           :dependent   => :destroy
+  has_many :owned_activities,
+           :class_name  => "Activity",
+           :foreign_key => :owner_id,
+           :dependent   => :destroy
+
   scope :alphabetic, order('actors.name')
 
   scope :letter, lambda { |param|

data/app/models/comment.rb

@@ -4,6 +4,9 @@ class Comment < ActiveRecord::Base
   alias_attribute :text, :description
   validates_presence_of :text
 
+  after_create :increment_comment_count
+  before_destroy :decrement_comment_count
+
   define_index do
     activity_object_index
   end
@@ -15,4 +18,25 @@ class Comment < ActiveRecord::Base
   def title
     description.truncate(30, :separator =>' ')
   end
+
+  private
+
+  # after_create callback 
+  # 
+  # Increment comment counter in parent's activity_object with a comment
+  def increment_comment_count 
+    return if self.post_activity.parent.blank?
+ 
+    self.post_activity.parent.direct_activity_object.increment!(:comment_count) 
+  end 
+ 
+  # before_destroy callback 
+  # 
+  # Decrement comment counter in parent's activity_object when comment is destroyed 
+  def decrement_comment_count 
+    return if self.post_activity.blank? || self.post_activity.parent.blank?
+ 
+    self.post_activity.parent.direct_activity_object.decrement!(:comment_count) 
+  end 
+
 end

data/app/views/activities/_comments.html.erb

@@ -1,3 +1,5 @@
 <div class="activity_comments" id="comments_<%= dom_id(activity) %>">
-  <%= render activity.comments %>
+  <% if activity.direct_activity_object.blank? || activity.direct_activity_object.comment_count > 0 %>
+    <%= render activity.comments %>
+  <% end %>
 </div>

data/db/migrate/20120621135650_add_comment_count_to_activity_object.rb

@@ -0,0 +1,24 @@
+class AddCommentCountToActivityObject < ActiveRecord::Migration
+  def up
+    add_column :activity_objects, :comment_count, :integer, :default => 0
+
+    ActivityObject.record_timestamps = false
+    ActivityObject.reset_column_information
+
+    ActivityObject.all.each do |ao|
+      parent_activity = ao.activities.first
+
+      # Actors have not parent activities
+      next if parent_activity.blank?
+
+      ao.update_attribute(:comment_count, Activity.includes(:activity_objects).where('activity_objects.object_type' => "Comment").where(:ancestry => [parent_activity.id]).size)
+    end
+
+    ActivityObject.record_timestamps = true
+    ActivityObject.reset_column_information
+  end
+
+  def down
+    remove_column :activity_objects, :comment_count
+  end
+end

data/db/migrate/20120627115244_fix_activity_object_follower_count.rb

@@ -0,0 +1,17 @@
+# Reset follower_count for all the ActivityObjects that are not Actors
+# See: https://github.com/ging/social_stream/issues/274
+class FixActivityObjectFollowerCount < ActiveRecord::Migration
+  def up
+    ActivityObject.record_timestamps = false
+
+    ActivityObject.where("object_type != ?", "Actor").all.each do |ao|
+      ao.update_attribute :follower_count, ao.received_actions.where(:follow => true).count
+    end
+
+    ActivityObject.record_timestamps = true
+    ActivityObject.reset_column_information
+  end
+
+  def down
+  end
+end

data/lib/social_stream/base/version.rb

@@ -1,5 +1,5 @@
 module SocialStream
   module Base
-    VERSION = "0.21.2".freeze
+    VERSION = "0.22.0".freeze
   end
 end

data/social_stream-base.gemspec

@@ -34,7 +34,7 @@ Gem::Specification.new do |s|
   # jQuery
   s.add_runtime_dependency('jquery-rails', '>= 1.0.9')
   # Authorization
-  s.add_runtime_dependency('cancan', '~> 1.6.4')
+  s.add_runtime_dependency('cancan', '1.6.7')
   # Pagination
   s.add_runtime_dependency('kaminari', '~> 0.13.0')
   # OAuth client

data/spec/integration/activity.rb

@@ -0,0 +1,15 @@
+require 'spec_helper'
+
+describe Activity do
+  before(:all) do
+    @activity = Factory(:activity)
+  end
+
+  it "should be destroyed along with its author" do
+    author = @activity.author
+
+    author.destroy
+
+    Activity.find_by_id(@activity.id).should be_nil
+  end
+end

data/spec/models/activity_action_spec.rb

@@ -31,6 +31,10 @@ describe ActivityAction do
       it "should not be duplicated" do
         @post.received_actions.count.should == 2
       end
+
+      it "should initialize follower count" do
+        @post.reload.follower_count.should == 2
+      end
     end
 
     describe "where posting to self" do
@@ -41,6 +45,10 @@ describe ActivityAction do
       it "should not be duplicated" do
         @post.received_actions.count.should == 1
       end
+
+      it "should initialize follower count" do
+        @post.reload.follower_count.should == 1
+      end
     end
 
     describe "where building the post" do

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: social_stream-base
 version: !ruby/object:Gem::Version
-  version: 0.21.2
+  version: 0.22.0
   prerelease: 
 platform: ruby
 authors:
@@ -10,7 +10,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2012-06-11 00:00:00.000000000 Z
+date: 2012-06-28 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: deep_merge
@@ -161,17 +161,17 @@ dependencies:
   requirement: !ruby/object:Gem::Requirement
     none: false
     requirements:
-    - - ~>
+    - - '='
       - !ruby/object:Gem::Version
-        version: 1.6.4
+        version: 1.6.7
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     none: false
     requirements:
-    - - ~>
+    - - '='
       - !ruby/object:Gem::Version
-        version: 1.6.4
+        version: 1.6.7
 - !ruby/object:Gem::Dependency
   name: kaminari
   requirement: !ruby/object:Gem::Requirement
@@ -1059,6 +1059,8 @@ files:
 - db/migrate/20120411132550_add_visit_count_to_activity_object.rb
 - db/migrate/20120411151413_relation_public_permissions.rb
 - db/migrate/20120526171311_remove_activity_channels.rb
+- db/migrate/20120621135650_add_comment_count_to_activity_object.rb
+- db/migrate/20120627115244_fix_activity_object_follower_count.rb
 - lib/acts_as_taggable_on/acts_as_taggable_on/dirty.rb
 - lib/acts_as_taggable_on/social_stream.rb
 - lib/generators/social_stream/base/install_generator.rb
@@ -1195,6 +1197,7 @@ files:
 - spec/factories/relation_custom.rb
 - spec/factories/tie.rb
 - spec/factories/user.rb
+- spec/integration/activity.rb
 - spec/integration/navigation_spec.rb
 - spec/integration/resque_access_spec.rb
 - spec/models/activity_action_spec.rb