social_count 0.0.6 → 0.0.7

checksums.yaml

@@ -1,15 +1,15 @@
 ---
 !binary "U0hBMQ==":
   metadata.gz: !binary |-
-    ZDg1MDdkOTUxZTlhZjM1ZTZiODM1MmI0Y2EzM2ZkZmU1NGMwZWY5NQ==
+    MTQyOGI2ZWRmMDMzZjM1MzE1MjA0YWJiNmViMzQ4NjBkMTMwNGQyZg==
   data.tar.gz: !binary |-
-    ZjE4YzY1NGFiMjUwODRhYWFiNmFlOTU1NmMxMDZmNDkyOWNiZDAyMA==
+    NjRiYjFmNTM5OWZlYWRmZGI4ZWRhOGJiZTk3ZDExOTU2ZTk2ZTYwOQ==
 SHA512:
   metadata.gz: !binary |-
-    Y2Y5MDc1MzVlYzQ2MmEyY2FhZTU0MjQxZjhmNDRlNThkMDBiYTY5ZjJhNGU4
-    MmE5OGFmNDA0YjQ4OGU3NmZmNjEyNjBkOTg1MDM4NmMxNzJkMGZlNzY3OWFk
-    MjUyMDJlZDZjOGJhOWU2NTE3ZjYyNGY2OTE1ZGFhMzI1YjJiMzk=
+    MTM3YjU5ZTM4MDc2NzY5M2NhNjQzMWQxMTU2ZGQ4MWI2ZTU5OWQzN2IxMTFi
+    YzY0NTI1OWIyNGIwZTRlNTFkZDMxZmUwOTRjYjEzOTFkMDU0ZTllYWVmYTQ0
+    MmJhNGUwMjJjMWM2ZGIzYzIxZGJmNTc1MDZkMDhjNzllMGIwYTQ=
   data.tar.gz: !binary |-
-    NzA3OGJjZDUzMzRmMjk4NjhmZTUxOWFkZWY5NTUwNTMxYWM5M2UyNDQ3NTdm
-    YTczNjI3N2JhODBmNzBmMjJjYWEwZDVlMzY1NDhiMDNkZjUwNTA2YWRkYTJj
-    Njc4Y2EzYjY0YzZiYTczYTM0Nzc5Yzc4OWUwMmM0ODVjZGIwMTA=
+    NmRlYTIyNzUwYjcwYTNlYmNkY2EyNGRhYTM4NjdkNzU3OTkzM2ViNjcyOWRh
+    ZDYzMDA0MGZjNGVmMmRkNmJkMjk4MGRjZGJlOGM4OTJlNjcyNDE0YWYyYzEw
+    ZWQ2ODZmOTNlYjQ3NWExNThmNmUyYzIxYjVmNzhmOGEwYjUwNDU=

data/lib/social_count/twitter_user.rb

@@ -9,7 +9,8 @@ module SocialCount
 
     def valid?
       return @valid unless @valid.nil?
-      @valid = self.class.get_http_response("#{USER_DOMAIN}/#{name}").is_a?(Net::HTTPOK)
+      url ="#{USER_DOMAIN}/#{name}"
+      @valid = self.class.get_http_response(url).is_a?(Net::HTTPOK)
     end
 
     def follower_count
@@ -22,7 +23,10 @@ module SocialCount
 
     private
       def follower_count_url
-        @follower_count_url ||= "#{API_DOMAIN}/1.1/users/show.json?screen_name=#{URI.escape(name)}"
+        @follower_count_url ||= "#{API_DOMAIN}/1.1/users/show.json?screen_name=#{URI.escape(name_without_at)}"
+      end
+      def name_without_at
+        @name_without_at ||= '@' == name[0] ? name[1..-1] : name
       end
 
     class << self

data/lib/social_count/version.rb

@@ -1,3 +1,3 @@
 module SocialCount
-  VERSION = "0.0.6"
+  VERSION = "0.0.7"
 end

data/social_count.gemspec

@@ -19,7 +19,7 @@ Gem::Specification.new do |spec|
   spec.require_paths = ["lib"]
 
   spec.add_dependency "activesupport"
-  spec.add_dependency "fb_graph"
+  spec.add_dependency "fb_graph", '~> 2.7.11'
   spec.add_dependency "twitter_oauth", '~> 0.4.94'
 
   spec.add_development_dependency "bundler", "~> 1.3"

data/spec/social_count/facebook_user_spec.rb

@@ -55,7 +55,7 @@ describe SocialCount::FacebookUser do
       user.username.should eq(username)
       user.first_name.should eq('Mark')
       user.last_name.should eq('Zuckerberg')
-      user.link.should eq("http://www.facebook.com/#{username}")
+      user.link.should eq("https://www.facebook.com/#{username}")
       user.gender.should eq('male')
     end
     it "should get the user's id" do

data/spec/social_count/twitter_user_spec.rb

@@ -16,9 +16,6 @@ describe SocialCount::TwitterUser do
   before(:all) do
     SocialCount.credentials = TestCredentials::INSTANCE
   end
-  def username
-    @username ||= 'tsa'
-  end
 
   describe "name" do
     it "cannot be an empty string" do
@@ -29,20 +26,6 @@ describe SocialCount::TwitterUser do
     end
   end
 
-  describe "existent user" do
-    before(:each) do
-      @twitter = SocialCount::TwitterUser.new(username)
-    end
-
-    it "should be valid" do
-      @twitter.valid?.should be_true
-    end
-
-    it "should get the follow count" do
-      @twitter.follower_count.should eq(12872)
-    end
-  end
-
   describe "non-existent user" do
     def non_existent_user
       SocialCount::TwitterUser.new('no_such_agency')
@@ -61,19 +44,35 @@ describe SocialCount::TwitterUser do
     end
   end
 
-  describe "expired credentials" do
-    before(:all) do
-      @old_credentials = SocialCount.credentials
-      SocialCount::TwitterUser.reset_credentials
-      SocialCount.credentials = TestCredentials::EXPIRED_CREDENTIALS
-      @twitter = SocialCount::TwitterUser.new(username)
-    end
-    it "should raise an exception" do
-      expect{@twitter.follower_count}.to raise_error(SocialCount::TwitterApiError, "Code(s): 32\nSee code explanations at https://dev.twitter.com/docs/error-codes-responses")
+  ['@tsa', 'tsa'].each do |username|
+    describe "existent user" do
+      before(:each) do
+        @twitter = SocialCount::TwitterUser.new(username)
+      end
+
+      it "should be valid" do
+        @twitter.valid?.should be_true
+      end
+
+      it "should get the follow count" do
+        @twitter.follower_count.should eq(12872)
+      end
     end
-    after(:all) do
-      SocialCount.credentials = @old_credentials
-      SocialCount::TwitterUser.reset_credentials
+
+    describe "expired credentials" do
+      before(:all) do
+        @old_credentials = SocialCount.credentials
+        SocialCount::TwitterUser.reset_credentials
+        SocialCount.credentials = TestCredentials::EXPIRED_CREDENTIALS
+        @twitter = SocialCount::TwitterUser.new(username)
+      end
+      it "should raise an exception" do
+        expect{@twitter.follower_count}.to raise_error(SocialCount::TwitterApiError, "Code(s): 32\nSee code explanations at https://dev.twitter.com/docs/error-codes-responses")
+      end
+      after(:all) do
+        SocialCount.credentials = @old_credentials
+        SocialCount::TwitterUser.reset_credentials
+      end
     end
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: social_count
 version: !ruby/object:Gem::Version
-  version: 0.0.6
+  version: 0.0.7
 platform: ruby
 authors:
 - Isaac Betesh
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-11-01 00:00:00.000000000 Z
+date: 2014-04-09 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
@@ -28,16 +28,16 @@ dependencies:
   name: fb_graph
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ! '>='
+    - - ~>
       - !ruby/object:Gem::Version
-        version: '0'
+        version: 2.7.11
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ! '>='
+    - - ~>
       - !ruby/object:Gem::Version
-        version: '0'
+        version: 2.7.11
 - !ruby/object:Gem::Dependency
   name: twitter_oauth
   requirement: !ruby/object:Gem::Requirement