social_count 0.0.4 → 0.0.6

checksums.yaml

@@ -1,15 +1,15 @@
 ---
 !binary "U0hBMQ==":
   metadata.gz: !binary |-
-    MjA5NjhjYTc4ZWY5NmEzZmY5NTNiOGUwMWExMWJhM2FiMGFlYWNkYw==
+    ZDg1MDdkOTUxZTlhZjM1ZTZiODM1MmI0Y2EzM2ZkZmU1NGMwZWY5NQ==
   data.tar.gz: !binary |-
-    Nzc0NzdjZGI4ZWRkNjNiZDNiZjM0MGY0YzNjZDEwMDNjMjEyMmU0Mg==
+    ZjE4YzY1NGFiMjUwODRhYWFiNmFlOTU1NmMxMDZmNDkyOWNiZDAyMA==
 SHA512:
   metadata.gz: !binary |-
-    ZTQ0MDAzYTAyNzliNjI0NTM2NGRjMzM2OWFiN2Y1NTgwYWMxMGI1MjEyMDMy
-    NDJkMzU0M2NjZGY1NzIxYjU3YzRmOGU5ODg0Y2ZjNzBjYjAxNjQwMWFlMmJi
-    OTIxMjEwOTYxMDE5YjRhZTA1MmUwOGI3NTQxM2M0NWYzYzEzNTE=
+    Y2Y5MDc1MzVlYzQ2MmEyY2FhZTU0MjQxZjhmNDRlNThkMDBiYTY5ZjJhNGU4
+    MmE5OGFmNDA0YjQ4OGU3NmZmNjEyNjBkOTg1MDM4NmMxNzJkMGZlNzY3OWFk
+    MjUyMDJlZDZjOGJhOWU2NTE3ZjYyNGY2OTE1ZGFhMzI1YjJiMzk=
   data.tar.gz: !binary |-
-    YzliODBmZDkxYmU1ZjYxYjdjNWFlZDI2MzgxODkyZDMxNmNkZWZhOTk5YWNj
-    NWMyMTViYWVhNTJlZjkyMDQ3ZmZmODA5ZmNhMWZhNjY1MTdmNWI5MzQxOGU2
-    ZTUwMGZkNzlkZWNjMDk4NDQxNGYxYWRlZjU5ZDg5ZTNiNTUyMmM=
+    NzA3OGJjZDUzMzRmMjk4NjhmZTUxOWFkZWY5NTUwNTMxYWM5M2UyNDQ3NTdm
+    YTczNjI3N2JhODBmNzBmMjJjYWEwZDVlMzY1NDhiMDNkZjUwNTA2YWRkYTJj
+    Njc4Y2EzYjY0YzZiYTczYTM0Nzc5Yzc4OWUwMmM0ODVjZGIwMTA=

data/lib/social_count/error.rb

@@ -11,4 +11,15 @@ module SocialCount
       "Code(s): #{code}\nSee code explanations at https://dev.twitter.com/docs/error-codes-responses"
     end
   end
+  class FacebookApiError < Error
+    attr_reader :code
+    def initialize(msg, code)
+      @code = code
+      @msg = msg
+      super(msg)
+    end
+    def to_s
+      "Code: #{code}\n#{@msg}\nSee code explanations at https://developers.facebook.com/docs/reference/api/errors/"
+    end
+  end
 end

data/lib/social_count/facebook_user.rb

@@ -28,7 +28,12 @@ module SocialCount
         return unless valid?
         url = "#{DOMAIN}/fql?q=#{query(column)}"
         response = self.class.get_http_response(url)
-        JSON.parse(response.body)["data"][0]["#{column}_count"]
+        response = JSON.parse(response.body)
+        data = response['data']
+        raise SocialCount::FacebookApiError.new("The social_count gem could not parse the response from the Facebook Graph API: #{response}", 0) unless data.is_a?(Array)
+        return nil if data.empty?
+        raise SocialCount::FacebookApiError.new("The social_count gem could not parse the response from the Facebook Graph API: #{response}", 0) unless data[0].is_a?(Hash)
+        data[0]["#{column}_count"]
       end
       def query(column)
         "SELECT #{column}_count FROM user WHERE uid=#{id}"
@@ -36,7 +41,13 @@ module SocialCount
 
     class << self
       def access_token
-        @access_token ||= get_http_response(access_url).body.split("access_token=")[1]
+        return @access_token unless @access_token.nil?
+        response = get_http_response(access_url)
+        unless response.is_a?(Net::HTTPOK)
+          response = JSON.parse(response.body)
+          raise SocialCount::FacebookApiError.new("Facebook API returned the following error: #{response["error"]["message"]}", response["error"]["code"])
+        end
+        @access_token = response.body.split("access_token=")[1]
       end
       private
         def access_url

data/lib/social_count/version.rb

@@ -1,3 +1,3 @@
 module SocialCount
-  VERSION = "0.0.4"
+  VERSION = "0.0.6"
 end

data/spec/social_count/facebook_user_spec.rb

@@ -1,5 +1,17 @@
 require 'spec_helper'
 
+module SocialCount
+  class FacebookUser
+    class << self
+      def reset_credentials
+        @access_token = nil
+        @access_url = nil
+        @credentials = nil
+      end
+    end
+  end
+end
+
 describe SocialCount::FacebookUser do
   before(:all) do
     SocialCount.credentials = TestCredentials::INSTANCE
@@ -23,10 +35,10 @@ describe SocialCount::FacebookUser do
 
   describe "name" do
     it "cannot be an empty string" do
-      expect{SocialCount::TwitterUser.new('')}.to raise_error(SocialCount::Error, "SocialCount::TwitterUser#name cannot be blank")
+      expect{SocialCount::FacebookUser.new('')}.to raise_error(SocialCount::Error, "SocialCount::FacebookUser#name cannot be blank")
     end
     it "cannot be nil" do
-      expect{SocialCount::TwitterUser.new(nil)}.to raise_error(SocialCount::Error, "SocialCount::TwitterUser#name cannot be blank")
+      expect{SocialCount::FacebookUser.new(nil)}.to raise_error(SocialCount::Error, "SocialCount::FacebookUser#name cannot be blank")
     end
   end
 
@@ -52,7 +64,7 @@ describe SocialCount::FacebookUser do
     it "should get the user's follower count" do
       count = @facebook.follower_count
       count.should be_a(Fixnum)
-      count.should eq(19528198)
+      count.should eq(20394278)
     end
     it "should handle friend_count gracefully" do
       @facebook.friend_count.should be_nil
@@ -66,7 +78,7 @@ describe SocialCount::FacebookUser do
     it "should get the user's friend count" do
       count = @facebook.friend_count
       count.should be_a(Fixnum)
-      count.should eq(568)
+      count.should eq(586)
     end
     it "should handle friend_count gracefully" do
       @facebook.follower_count.should be_nil
@@ -96,4 +108,20 @@ describe SocialCount::FacebookUser do
       non_existent_user.follower_count.should be_nil
     end
   end
+
+  describe "expired credentials" do
+    before(:all) do
+      @old_credentials = SocialCount.credentials
+      SocialCount::FacebookUser.reset_credentials
+      SocialCount.credentials = TestCredentials::EXPIRED_CREDENTIALS
+      @facebook = SocialCount::FacebookUser.new(username)
+    end
+    it "should raise an exception when generating the access token" do
+      expect{@facebook.follower_count}.to raise_error(SocialCount::FacebookApiError, "Code: 1\nFacebook API returned the following error: Error validating client secret.\nSee code explanations at https://developers.facebook.com/docs/reference/api/errors/")
+    end
+    after(:all) do
+      SocialCount.credentials = @old_credentials
+      SocialCount::FacebookUser.reset_credentials
+    end
+  end
 end

data/spec/social_count/twitter_user_spec.rb

@@ -39,7 +39,7 @@ describe SocialCount::TwitterUser do
     end
 
     it "should get the follow count" do
-      @twitter.follower_count.should eq(12171)
+      @twitter.follower_count.should eq(12872)
     end
   end
 
@@ -69,7 +69,7 @@ describe SocialCount::TwitterUser do
       @twitter = SocialCount::TwitterUser.new(username)
     end
     it "should raise an exception" do
-      expect{@twitter.follower_count}.to raise_error(SocialCount::TwitterApiError, "Code(s): 89\nSee code explanations at https://dev.twitter.com/docs/error-codes-responses")
+      expect{@twitter.follower_count}.to raise_error(SocialCount::TwitterApiError, "Code(s): 32\nSee code explanations at https://dev.twitter.com/docs/error-codes-responses")
     end
     after(:all) do
       SocialCount.credentials = @old_credentials

data/spec/support/credentials.rb.example

@@ -14,6 +14,6 @@ class TestCredentials
     'ANYTHING_RANDOM_STRING_HERE',
     'ANOTHER_RANDOM_STRING_HERE',
     'MY_FACEBOOK_APP_ID', # Same as above
-    'MY_FACEBOOK_APP_SECRET', # Same as above
+    'ANOTHER_STRING_WHATEVER_YOU_WANT'
   )
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: social_count
 version: !ruby/object:Gem::Version
-  version: 0.0.4
+  version: 0.0.6
 platform: ruby
 authors:
 - Isaac Betesh
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-10-04 00:00:00.000000000 Z
+date: 2013-11-01 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport