social_count 0.0.3 → 0.0.4

checksums.yaml

@@ -1,15 +1,15 @@
 ---
 !binary "U0hBMQ==":
   metadata.gz: !binary |-
-    NWQ5ZjM0MWZmYmU1YWIyZTNiMGI4YTBkNzhkZGQ3OGY1NTM2YTYxNQ==
+    MjA5NjhjYTc4ZWY5NmEzZmY5NTNiOGUwMWExMWJhM2FiMGFlYWNkYw==
   data.tar.gz: !binary |-
-    MzY0ZTRiYjIyOGNlY2JiZmE2M2M5MDk3MDhmYjFlYzFkZDFhNjMxOA==
+    Nzc0NzdjZGI4ZWRkNjNiZDNiZjM0MGY0YzNjZDEwMDNjMjEyMmU0Mg==
 SHA512:
   metadata.gz: !binary |-
-    ZjRmMDYxYWFmZmEzZmU5YWQ1YzhkYzE4MTU2NmFjZGE0MTNiYzBkMzg2Zjk4
-    MTRjZDdkY2FmNWE3NTZlMzFkZjc2MzQwYmRlMGYzNjYyZjg1MzdmNWYwMGRl
-    OGRkOWFiNTYyNDU1MGZlNGI2MDAwOGY1NjJlYjI5OGI0ODU5MzY=
+    ZTQ0MDAzYTAyNzliNjI0NTM2NGRjMzM2OWFiN2Y1NTgwYWMxMGI1MjEyMDMy
+    NDJkMzU0M2NjZGY1NzIxYjU3YzRmOGU5ODg0Y2ZjNzBjYjAxNjQwMWFlMmJi
+    OTIxMjEwOTYxMDE5YjRhZTA1MmUwOGI3NTQxM2M0NWYzYzEzNTE=
   data.tar.gz: !binary |-
-    NmVmYTA2NWU4ZjZkMmVmYzNkN2Y4YzViYTIzNmE2NTY5ZmMyNzQwZTJkOTQy
-    ZjY4OWU0YmVhZDcwNmNkZTYzNWFlZjFkMzJhZjk4NzNjNWEzZDQyYzdjMjc1
-    YzBkYTA3MjlmOWY1OThhMDFlYWNmNGVlOTYxMTg0OWU5YjdhN2U=
+    YzliODBmZDkxYmU1ZjYxYjdjNWFlZDI2MzgxODkyZDMxNmNkZWZhOTk5YWNj
+    NWMyMTViYWVhNTJlZjkyMDQ3ZmZmODA5ZmNhMWZhNjY1MTdmNWI5MzQxOGU2
+    ZTUwMGZkNzlkZWNjMDk4NDQxNGYxYWRlZjU5ZDg5ZTNiNTUyMmM=

data/lib/social_count/error.rb

@@ -1,4 +1,14 @@
 module SocialCount
   class Error < StandardError
   end
+  class TwitterApiError < Error
+    attr_reader :code
+    def initialize(msg, code)
+      @code = code.is_a?(Array) ? code.join(", ") : code
+      super(msg)
+    end
+    def to_s
+      "Code(s): #{code}\nSee code explanations at https://dev.twitter.com/docs/error-codes-responses"
+    end
+  end
 end

data/lib/social_count/twitter_user.rb

@@ -13,9 +13,13 @@ module SocialCount
     end
 
     def follower_count
+      return unless valid?
       response = self.class.access_token.request(:get, follower_count_url)
-      JSON.parse(response.body)["followers_count"]
+      response = JSON.parse(response.body)
+      raise SocialCount::TwitterApiError.new("Twitter API returned the following errors: #{response["errors"]}", response["errors"].collect{|e| e["code"]}) if response["errors"]
+      response["followers_count"]
     end
+
     private
       def follower_count_url
         @follower_count_url ||= "#{API_DOMAIN}/1.1/users/show.json?screen_name=#{URI.escape(name)}"

data/lib/social_count/version.rb

@@ -1,3 +1,3 @@
 module SocialCount
-  VERSION = "0.0.3"
+  VERSION = "0.0.4"
 end

data/spec/social_count/twitter_user_spec.rb

@@ -1,5 +1,17 @@
 require 'spec_helper'
 
+module SocialCount
+  class TwitterUser
+    class << self
+      def reset_credentials
+        @token_hash = nil
+        @access_token = nil
+        @credentials = nil
+      end
+    end
+  end
+end
+
 describe SocialCount::TwitterUser do
   before(:all) do
     SocialCount.credentials = TestCredentials::INSTANCE
@@ -48,4 +60,20 @@ describe SocialCount::TwitterUser do
       non_existent_user.follower_count.should be_nil
     end
   end
+
+  describe "expired credentials" do
+    before(:all) do
+      @old_credentials = SocialCount.credentials
+      SocialCount::TwitterUser.reset_credentials
+      SocialCount.credentials = TestCredentials::EXPIRED_CREDENTIALS
+      @twitter = SocialCount::TwitterUser.new(username)
+    end
+    it "should raise an exception" do
+      expect{@twitter.follower_count}.to raise_error(SocialCount::TwitterApiError, "Code(s): 89\nSee code explanations at https://dev.twitter.com/docs/error-codes-responses")
+    end
+    after(:all) do
+      SocialCount.credentials = @old_credentials
+      SocialCount::TwitterUser.reset_credentials
+    end
+  end
 end

data/spec/support/credentials.rb.example

@@ -8,4 +8,12 @@ class TestCredentials
     'MY_FACEBOOK_APP_ID',
     'MY_FACEBOOK_APP_SECRET'
   )
+  EXPIRED_CREDENTIALS = TestCredentials.new(
+    'MY_TWITTER_CONSUMER_KEY', # Same as above
+    'MY_TWITTER_CONSUMER_SECRET', # Same as above
+    'ANYTHING_RANDOM_STRING_HERE',
+    'ANOTHER_RANDOM_STRING_HERE',
+    'MY_FACEBOOK_APP_ID', # Same as above
+    'MY_FACEBOOK_APP_SECRET', # Same as above
+  )
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: social_count
 version: !ruby/object:Gem::Version
-  version: 0.0.3
+  version: 0.0.4
 platform: ruby
 authors:
 - Isaac Betesh
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-10-03 00:00:00.000000000 Z
+date: 2013-10-04 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport