social_count 0.0.2 → 0.0.3

checksums.yaml

@@ -0,0 +1,15 @@
+---
+!binary "U0hBMQ==":
+  metadata.gz: !binary |-
+    NWQ5ZjM0MWZmYmU1YWIyZTNiMGI4YTBkNzhkZGQ3OGY1NTM2YTYxNQ==
+  data.tar.gz: !binary |-
+    MzY0ZTRiYjIyOGNlY2JiZmE2M2M5MDk3MDhmYjFlYzFkZDFhNjMxOA==
+SHA512:
+  metadata.gz: !binary |-
+    ZjRmMDYxYWFmZmEzZmU5YWQ1YzhkYzE4MTU2NmFjZGE0MTNiYzBkMzg2Zjk4
+    MTRjZDdkY2FmNWE3NTZlMzFkZjc2MzQwYmRlMGYzNjYyZjg1MzdmNWYwMGRl
+    OGRkOWFiNTYyNDU1MGZlNGI2MDAwOGY1NjJlYjI5OGI0ODU5MzY=
+  data.tar.gz: !binary |-
+    NmVmYTA2NWU4ZjZkMmVmYzNkN2Y4YzViYTIzNmE2NTY5ZmMyNzQwZTJkOTQy
+    ZjY4OWU0YmVhZDcwNmNkZTYzNWFlZjFkMzJhZjk4NzNjNWEzZDQyYzdjMjc1
+    YzBkYTA3MjlmOWY1OThhMDFlYWNmNGVlOTYxMTg0OWU5YjdhN2U=

data/.rspec

@@ -0,0 +1 @@
+--color

data/lib/social_count/api_base.rb

@@ -1,9 +1,12 @@
 require 'net/http'
+require 'active_support/core_ext/object/blank'
+require 'social_count/error'
 
 module SocialCount
   class ApiBase
     attr_reader :name
     def initialize(name)
+      raise SocialCount::Error, "#{self.class}#name cannot be blank" if name.blank?
       @name = name
     end
     class << self

data/lib/social_count/error.rb

@@ -0,0 +1,4 @@
+module SocialCount
+  class Error < StandardError
+  end
+end

data/lib/social_count/facebook_user.rb

@@ -21,7 +21,7 @@ module SocialCount
     end
     def follower_count
       count = run_query(:subscriber)
-      count.zero? ? nil : count
+      count.to_i.zero? ? nil : count
     end
     private
       def run_query(column)

data/lib/social_count/version.rb

@@ -1,3 +1,3 @@
 module SocialCount
-  VERSION = "0.0.2"
+  VERSION = "0.0.3"
 end

data/lib/social_count.rb

@@ -1,12 +1,13 @@
+require 'active_support/core_ext/object/blank'
 require "social_count/version"
+require "social_count/error"
 require "social_count/facebook_user"
 require "social_count/twitter_user"
 
 module SocialCount
   REQUIRED_CREDENTIALS = [:twitter_consumer_key, :twitter_consumer_secret, :twitter_oauth_token, :twitter_oauth_token_secret, :fb_app_id, :fb_app_secret]
-  class Error < StandardError; end
   class Credentials
-    attr_reader *REQUIRED_CREDENTIALS
+    attr_accessor *REQUIRED_CREDENTIALS
   end
   class << self
     def credentials
@@ -20,7 +21,10 @@ module SocialCount
     end
     private
       def validate_credentials(_credentials)
-        REQUIRED_CREDENTIALS.each { |attr| raise SocialCount::Error, "SocialCount.credentials must respond to #{attr}" unless _credentials.respond_to?(attr.to_s) }
+        REQUIRED_CREDENTIALS.each do |attr|
+          raise SocialCount::Error, "SocialCount.credentials must respond to #{attr}" unless _credentials.respond_to?(attr.to_s)
+          raise SocialCount::Error, "SocialCount.credentials.#{attr} cannot be blank" if _credentials.__send__(attr.to_s).blank?
+        end
       end
   end
 end

data/social_count.gemspec

@@ -18,6 +18,7 @@ Gem::Specification.new do |spec|
   spec.test_files    = spec.files.grep(%r{^(test|spec|features)/})
   spec.require_paths = ["lib"]
 
+  spec.add_dependency "activesupport"
   spec.add_dependency "fb_graph"
   spec.add_dependency "twitter_oauth", '~> 0.4.94'
 

data/spec/social_count/credentials_spec.rb

@@ -13,16 +13,39 @@ def credentials_without(attr)
   SocialCount::REQUIRED_CREDENTIALS.dup.tap { |a| a.delete(attr) }
 end
 
+def class_that_doesnt_respond_to(credential)
+  Class.new do
+    attributes = credentials_without(credential)
+    attributes.each do |a|
+      define_method(a) { '123' }
+    end
+  end
+end
+
+def class_that_responds_with_x_to(credential, x)
+  Class.new(class_that_doesnt_respond_to(credential)) do
+    define_method(credential) { x }
+  end
+end
+
 describe SocialCount::Credentials do
   SocialCount::REQUIRED_CREDENTIALS.each do |credential|
     it "should require credentials to have a #{credential}" do
-      credentials = Class.new do attr_reader *credentials_without(credential); end
+      credentials = class_that_doesnt_respond_to(credential)
       expect{SocialCount.credentials = credentials.new}.to raise_error(SocialCount::Error, "SocialCount.credentials must respond to #{credential}")
     end
+    it "should not allow #{credential} to be nil" do
+      credentials = class_that_responds_with_x_to(credential, nil)
+      expect{SocialCount.credentials = credentials.new}.to raise_error(SocialCount::Error, "SocialCount.credentials.#{credential} cannot be blank")
+    end
+    it "should not allow #{credential} to be an empty string" do
+      credentials = class_that_responds_with_x_to(credential, '')
+      expect{SocialCount.credentials = credentials.new}.to raise_error(SocialCount::Error, "SocialCount.credentials.#{credential} cannot be blank")
+    end
   end
 
   it "shouldn't change state when an exception is raised" do
-    credentials = Class.new do attr_reader *credentials_without(:twitter_consumer_secret); end
+    credentials = class_that_doesnt_respond_to(:twitter_consumer_secret)
     SocialCount.reset_credentials
     expect{SocialCount.credentials = credentials.new}.to raise_error(SocialCount::Error, "SocialCount.credentials must respond to twitter_consumer_secret")
     expect(SocialCount.instance_variable_get("@credentials")).to be_nil
@@ -34,6 +57,13 @@ describe SocialCount::Credentials do
   end
 
   it "can be a SocialCount::Credentials instance" do
-    expect{SocialCount.credentials = SocialCount::Credentials.new}.to_not raise_error
+    s = SocialCount::Credentials.new
+    s.twitter_consumer_key = "1"
+    s.twitter_consumer_secret = "1"
+    s.twitter_oauth_token = "1"
+    s.twitter_oauth_token_secret = "1"
+    s.fb_app_id = "1"
+    s.fb_app_secret = "1"
+    expect{SocialCount.credentials = s}.to_not raise_error
   end
 end

data/spec/social_count/facebook_user_spec.rb

@@ -11,6 +11,7 @@ describe SocialCount::FacebookUser do
   def access_token_did_not_match_specified_format
     @access_token_did_not_match_specified_format ||= "Facebook Access Token #{@access_token} did not match specified format"
   end
+
   describe "class methods" do
     it "should receive an access token" do
       @access_token = SocialCount::FacebookUser.access_token.split("|")
@@ -19,6 +20,17 @@ describe SocialCount::FacebookUser do
       @access_token[1].should match(/[_A-Za-z0-9]{27}/), access_token_did_not_match_specified_format
     end
   end
+
+  describe "name" do
+    it "cannot be an empty string" do
+      expect{SocialCount::TwitterUser.new('')}.to raise_error(SocialCount::Error, "SocialCount::TwitterUser#name cannot be blank")
+    end
+    it "cannot be nil" do
+      expect{SocialCount::TwitterUser.new(nil)}.to raise_error(SocialCount::Error, "SocialCount::TwitterUser#name cannot be blank")
+    end
+  end
+
+
   describe "user that supports following" do
     before(:all) do
       @facebook = SocialCount::FacebookUser.new(username)
@@ -46,6 +58,7 @@ describe SocialCount::FacebookUser do
       @facebook.friend_count.should be_nil
     end
   end
+
   describe "user that supports friending" do
     before(:all) do
       @facebook = SocialCount::FacebookUser.new('jose.valim')
@@ -59,6 +72,7 @@ describe SocialCount::FacebookUser do
       @facebook.follower_count.should be_nil
     end
   end
+
   describe "non-existent user" do
     def non_existent_user
       SocialCount::FacebookUser.new("george_orwell")
@@ -78,5 +92,8 @@ describe SocialCount::FacebookUser do
     it "should have nil friend_count" do
       non_existent_user.friend_count.should be_nil
     end
+    it "should have nil follower_count" do
+      non_existent_user.follower_count.should be_nil
+    end
   end
 end

data/spec/social_count/twitter_user_spec.rb

@@ -8,6 +8,15 @@ describe SocialCount::TwitterUser do
     @username ||= 'tsa'
   end
 
+  describe "name" do
+    it "cannot be an empty string" do
+      expect{SocialCount::TwitterUser.new('')}.to raise_error(SocialCount::Error, "SocialCount::TwitterUser#name cannot be blank")
+    end
+    it "cannot be nil" do
+      expect{SocialCount::TwitterUser.new(nil)}.to raise_error(SocialCount::Error, "SocialCount::TwitterUser#name cannot be blank")
+    end
+  end
+
   describe "existent user" do
     before(:each) do
       @twitter = SocialCount::TwitterUser.new(username)

data/spec/support/test_credentials.rb

@@ -6,7 +6,6 @@ class TestCredentials
   credentials_file = File.expand_path("#{__FILE__}/../credentials.rb")
   unless File.exists?(credentials_file)
     puts "Please configure your Facebook and Twitter application credentials by copying #{credentials_file}.example to #{credentials_file} and configuring the required values there appropriately."
-    puts "Then comment out the 'exit' line in #{File.expand_path(__FILE__)} before running rspec."
     exit
   end
 end

metadata

@@ -1,20 +1,32 @@
 --- !ruby/object:Gem::Specification
 name: social_count
 version: !ruby/object:Gem::Version
-  version: 0.0.2
-  prerelease: 
+  version: 0.0.3
 platform: ruby
 authors:
 - Isaac Betesh
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-10-02 00:00:00.000000000 Z
+date: 2013-10-03 00:00:00.000000000 Z
 dependencies:
+- !ruby/object:Gem::Dependency
+  name: activesupport
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: fb_graph
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
     - - ! '>='
       - !ruby/object:Gem::Version
@@ -22,7 +34,6 @@ dependencies:
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
     - - ! '>='
       - !ruby/object:Gem::Version
@@ -30,7 +41,6 @@ dependencies:
 - !ruby/object:Gem::Dependency
   name: twitter_oauth
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
@@ -38,7 +48,6 @@ dependencies:
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
@@ -46,7 +55,6 @@ dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
@@ -54,7 +62,6 @@ dependencies:
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
@@ -62,7 +69,6 @@ dependencies:
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
     - - ! '>='
       - !ruby/object:Gem::Version
@@ -70,7 +76,6 @@ dependencies:
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
     - - ! '>='
       - !ruby/object:Gem::Version
@@ -78,7 +83,6 @@ dependencies:
 - !ruby/object:Gem::Dependency
   name: rspec
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
     - - ! '>='
       - !ruby/object:Gem::Version
@@ -86,7 +90,6 @@ dependencies:
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
     - - ! '>='
       - !ruby/object:Gem::Version
@@ -100,12 +103,14 @@ extensions: []
 extra_rdoc_files: []
 files:
 - .gitignore
+- .rspec
 - Gemfile
 - LICENSE.txt
 - README.md
 - Rakefile
 - lib/social_count.rb
 - lib/social_count/api_base.rb
+- lib/social_count/error.rb
 - lib/social_count/facebook_user.rb
 - lib/social_count/twitter_user.rb
 - lib/social_count/version.rb
@@ -119,33 +124,26 @@ files:
 homepage: https://github.com/betesh/social_count
 licenses:
 - MIT
+metadata: {}
 post_install_message: 
 rdoc_options: []
 require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
-  none: false
   requirements:
   - - ! '>='
     - !ruby/object:Gem::Version
       version: '0'
-      segments:
-      - 0
-      hash: 1024359385876280514
 required_rubygems_version: !ruby/object:Gem::Requirement
-  none: false
   requirements:
   - - ! '>='
     - !ruby/object:Gem::Version
       version: '0'
-      segments:
-      - 0
-      hash: 1024359385876280514
 requirements: []
 rubyforge_project: 
-rubygems_version: 1.8.25
+rubygems_version: 2.1.5
 signing_key: 
-specification_version: 3
+specification_version: 4
 summary: ! '# SocialCount  This gem is an incredibly ligh-weight wrapper for finding
   how many facebook friends and twitter followers someone has.  ## Installation  gem
   ''social_count'' # In your Gemfile  $ gem install social_count # Install locally  ##