soaspec 0.2.29 → 0.2.30

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 85321b628bfe9f5c96477fbbb8b630439332838b4552ce295c00486c94922461
-  data.tar.gz: 9de5454ec0b65ee3442e6f3772d0f61d09463f1ba78751edfb9e9394331aaafb
+  metadata.gz: 13abdb0b785d580ec2af2397004bde32370cffa289fbafc7d754a51e2a2e7bee
+  data.tar.gz: 6825e3c29b77b9072e26b068b407f30e3ffcf2e97983fa1d78d47d2e79aedd2e
 SHA512:
-  metadata.gz: 4a6b6e8b16a9c432ea9b8b23e90ec64e9174d96504c2c49089d0a732ddefe6d9d6b67b258dc143887314cf767ff3bd822b4c7a12baebc38824f72947823d9152
-  data.tar.gz: d8cda71cffe34d1df8bae7fa0c701e6360009a70458e62eed88821cafd79ca25c47f6090f27821e4f1fc9c843741601e37ee3fa0e8c86ddcf73cc39680fe13ae
+  metadata.gz: '05649c438f5f8f9d43c870d9e0abc2dcf88fb8762c53374487e0dc7fdb33f4f422d8f6ef514ed536d8276b4705646a7fa471fbc9be4bc3875800c3b40a79c851'
+  data.tar.gz: ce3c53b92dadd7949b18455d835220961a4813954442ba5e46d789ae8f499dc114861f3a3f2d8e720cfda6b641d8c20995722978f36aa20a5c080963ce301958

data/ChangeLog

@@ -1,3 +1,9 @@
+Version 0.2.30
+* Enhancement
+  * New method `retry_on_exceptions` on `exchange_handler` where one can specify
+    exceptions to retry on for all exchanges using that Handler
+  * 'exception' method on handler that stores exception of last exchange
+
 Version 0.2.29
 * Enhancement
   * SpecLogger - change:

data/Gemfile

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 source 'https://rubygems.org'
 
 git_source(:gitlab) { |_repo_name| 'https://gitlab.com/samuel-garratt/soaspec' }

data/Rakefile

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'bundler/gem_tasks'
 require 'rspec/core/rake_task'
 require 'rake/clean'
@@ -12,7 +14,7 @@ RSpec::Core::RakeTask.new(spec: %i[clean clobber start_test_server]) do |t|
   t.pattern = "spec/**/#{ENV['folder']}*/#{ENV['test']}*_spec.rb"
 end
 
-task :parallel => [:clean, :clobber, :start_test_server] do
+task parallel: %i[clean clobber start_test_server] do
   puts `parallel_rspec spec`
 end
 

data/exe/soaspec

@@ -1,4 +1,5 @@
 #!/usr/bin/env ruby
+# frozen_string_literal: true
 
 require 'thor'
 $LOAD_PATH.unshift File.join(File.dirname(__FILE__), '..', 'lib')

data/exe/xml_to_yaml_file

@@ -1,4 +1,5 @@
 #!/usr/bin/env ruby
+# frozen_string_literal: true
 
 require 'xmlsimple'
 require 'yaml'

data/lib/soaspec/core_ext/hash.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 # Override Hash class with convenience methods
 class Hash
   # Transform each key in Hash to a symbol. Privately used by non-self method

data/lib/soaspec/cucumber/generic_steps.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'active_support/core_ext/string/inflections'
 
 # @return [Exchange] Return current or last exchange used in Cucumber

data/lib/soaspec/demo.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 # Load this file for demoing Soaspec (e.g in IRB). Has common settings applicable for demoing
 
 require_relative '../soaspec'

data/lib/soaspec/errors.rb

@@ -1,9 +1,10 @@
+# frozen_string_literal: true
 
 module Soaspec
   # Standard Error related to Soaspec
-  class Error < StandardError ; end
+  class Error < StandardError; end
   # Error related to a response
-  class ResponseError < StandardError ; end
+  class ResponseError < StandardError; end
 end
 
 # Raised to represent when there's no element at an Xpath

data/lib/soaspec/exchange/exchange.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require_relative '../../soaspec'
 require_relative 'exchange_properties'
 require_relative 'exchange_extractor'
@@ -19,9 +21,11 @@ class Exchange
 
   # Instance of ExchangeHandler for which this exchange is made
   attr_accessor :exchange_handler
-  # How many times to retry for a success
+  # @return [Integer] How many times to retry for a success
   attr_accessor :retry_count
-  # Name used for displaying class
+  # @return [Integer] Times request was retried before being returned
+  attr_accessor :times_retried
+  # @@return [String] Name used for displaying class
   attr_accessor :test_name
   # Expect Factory to fail upon trying to create
   attr_writer :fail_factory
@@ -35,11 +39,18 @@ class Exchange
     self
   end
 
+  # This is set on an individual Exchange marking it as one that should be retried
   # @return [Bool] Whether to keep making request until success code reached
   def retry_for_success?
     @retry_for_success
   end
 
+  # Defined as general rule from ExchangeHandler
+  # @return [Boolean] Whether exception is an exception that must be retried
+  def invalid_exception?
+    !exchange_handler.retry_on_exceptions.find { |e| e == exchange_handler.exception.class }.nil?
+  end
+
   # Override this in subclass to tie that subclass to an ExchangeHandler
   # @return [Soaspec::ExchangeHandler] Soaspec::ExchangeHandler used by this exchange
   def default_handler_used; end
@@ -57,8 +68,8 @@ class Exchange
     @fail_factory = nil
     @override_parameters = override_parameters
     @retry_for_success = false
-    self.retry_count = 3
-    @exchange_handler.elements.each { |element| methods_for_element(element) }
+    self.retry_count = exchange_handler.retry_exception_limit
+    exchange_handler.elements.each { |element| methods_for_element(element) }
   end
 
   # @return [Hash] Hash representing what will be sent
@@ -74,10 +85,11 @@ class Exchange
     request_params = @override_parameters
     (0..retry_count).each do |count|
       response = exchange_handler.make_request(request_params)
-      return response unless retry_for_success?
+      return response if !retry_for_success? && !invalid_exception?
       return response if (200..299).cover? exchange_handler.status_code_for(response)
 
-      sleep 0.5 # Time before retrying
+      sleep exchange_handler.retry_pause_time # Time before retrying
+      self.times_retried = count
       break response if count == retry_count
     end
   end

data/lib/soaspec/exchange/exchange_extractor.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Soaspec
   # Methods for extracting aspects of the traffic for a request / response
   # in an exchange from the ExchangeHandler that it's tied to
@@ -32,7 +34,7 @@ module Soaspec
       exchange_handler.value_from_path(response, path.to_s)
     end
 
-    alias_method :value_from_path, :[]
+    alias value_from_path []
 
     # Using same path syntax as []. Returns true of false depending on whether an element is found
     # @return [Boolean] Whether an element exists at the path

data/lib/soaspec/exchange/exchange_properties.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Soaspec
   # Convenience methods to set Exchange specific properties
   # Will be used when creating a subclass of Exchange

data/lib/soaspec/exchange/exchange_repeater.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Soaspec
   # Ways of repeating an exchange to reach a desired outcome
   module ExchangeRepeater

data/lib/soaspec/exchange/request_builder.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Soaspec
   # Methods to help build a Request
   module RequestBuilder

data/lib/soaspec/exchange/variable_storer.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Soaspec
   # Enables Exchange to store and retrieve variables so that one
   # exchange can make assertions based on a previous one

data/lib/soaspec/exchange_handlers/exchange_handler.rb

@@ -1,10 +1,17 @@
+# frozen_string_literal: true
+
 require_relative 'handler_accessors'
+require_relative 'exchange_handler_defaults'
 
 module Soaspec
   # Inherit this for a class describing how to implement a particular exchange.
-  # Has basic methods common for methods defining RSpec tests in YAML
+  # Has methods common to Soaspec framework for working with Exchange/Handler pair
   class ExchangeHandler
     extend Soaspec::HandlerAccessors
+    include ExchangeHandlerDefaults
+
+    # @return [Exception] Exception if raised
+    attr_accessor :exception
 
     # Use an instance of this ExchangeHandler in any further Exchange's
     # This is a convenience method as it creates an ExchangeHandler behind the scenes
@@ -64,32 +71,6 @@ module Soaspec
       @template_name = name
     end
 
-    # Will be used in 'success_scenarios' shared examples.
-    # Set though 'mandatory_elements' method
-    # @return [Array] Array of symbols specifying element names
-    def expected_mandatory_elements
-      []
-    end
-
-    # Change this through 'mandatory_xpath_values' method to specify xpath results that must be present in the response
-    # Will be used in 'success_scenarios' shared examples
-    # @return [Hash] Hash of 'xpath' => 'expected value' pairs
-    def expected_mandatory_xpath_values
-      {}
-    end
-
-    # Change this through 'mandatory_json_values' method to specify json results that must be present in the response
-    # Will be used in 'success_scenarios' shared examples
-    # @return [Hash] Hash of 'json/path' => 'expected value' pairs
-    def expected_mandatory_json_values
-      {}
-    end
-
-    # @return [Boolean] Whether all xpaths will be done with XML that is converted to lower case
-    def convert_to_lower?
-      false
-    end
-
     # Stores a value in a method that can be accessed by the provided name
     # @param [Symbol] name Name of method to use to access this value within handler
     # @param [String] value Value to store
@@ -113,18 +94,5 @@ module Soaspec
       __send__("#{key}=", hash[key])
       hash.delete key
     end
-
-    # @return [Boolean] Whether to remove namespaces in xpath assertion automatically
-    def strip_namespaces?
-      false
-    end
-
-    # Request of API call. Either intended request or actual request
-    # @param [Object] response Response from calling exchange
-    def request(response)
-      return "Request not yet sent Request option is #{@request_option}" unless response
-
-      'Specific API handler should implement this'
-    end
   end
 end

data/lib/soaspec/exchange_handlers/exchange_handler_defaults.rb

@@ -0,0 +1,61 @@
+# frozen_string_literal: true
+
+# Default values set for methods on ExchangeHandler
+module ExchangeHandlerDefaults
+  # Will be used in 'success_scenarios' shared examples.
+  # Set though 'mandatory_elements' method
+  # @return [Array] Array of symbols specifying element names
+  def expected_mandatory_elements
+    []
+  end
+
+  # Change this through 'mandatory_xpath_values' method to specify xpath results that must be present in the response
+  # Will be used in 'success_scenarios' shared examples
+  # @return [Hash] Hash of 'xpath' => 'expected value' pairs
+  def expected_mandatory_xpath_values
+    {}
+  end
+
+  # Change this through 'mandatory_json_values' method to specify json results that must be present in the response
+  # Will be used in 'success_scenarios' shared examples
+  # @return [Hash] Hash of 'json/path' => 'expected value' pairs
+  def expected_mandatory_json_values
+    {}
+  end
+
+  # @return [Boolean] Whether all xpaths will be done with XML that is converted to lower case
+  def convert_to_lower?
+    false
+  end
+
+  # @return [Boolean] Whether to remove namespaces in xpath assertion automatically
+  def strip_namespaces?
+    false
+  end
+
+  # Request of API call. Either intended request or actual request
+  # @param [Object] response Response from calling exchange
+  def request(response)
+    return "Request not yet sent Request option is #{@request_option}" unless response
+
+    'Specific API handler should implement this'
+  end
+
+  # Set through 'retry_on_exceptions' method
+  # @return [Array] List of exceptions to retry for
+  def retry_on_exceptions
+    []
+  end
+
+  # Set this through 'retry_on_exceptions' on ExchangeHandler
+  # @return [Integer] Time to wait before retrying each request. Default of 1
+  def retry_pause_time
+    1
+  end
+
+  # Set this through 'retry_on_exceptions' on ExchangeHandler
+  # @return [Integer] Times to retry before raising exception. Default of 3
+  def retry_exception_limit
+    3
+  end
+end

data/lib/soaspec/exchange_handlers/handler_accessors.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Soaspec
   # Describes methods test handlers use to easily set attributes
   # Some are included in 'success scenarios' and to configure the request sent

data/lib/soaspec/exchange_handlers/request/rest_request.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Soaspec
   # Models a request made to a REST API
   class RestRequest
@@ -38,7 +40,7 @@ module Soaspec
     # @param [String, Symbol] value Message to send to object retrieving a value
     # @return [Object] Result of retrieving value
     def [](value)
-      self.send(value)
+      send(value)
     end
 
     # @return [String] Show inspection of all parameters

data/lib/soaspec/exchange_handlers/request/soap_request.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Soaspec
   # Models a request made to a SOAP API
   class SoapRequest
@@ -28,7 +30,7 @@ module Soaspec
     # @param [String, Symbol] value Message to send to object retrieving a value
     # @return [Object] Result of retrieving value
     def [](value)
-      self.send(value)
+      send(value)
     end
 
     # @return [String] Show inspection of all parameters

data/lib/soaspec/exchange_handlers/response_extractor.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Soaspec
   # Enables extracting a response according to type / path
   module ResponseExtractor

data/lib/soaspec/exchange_handlers/rest_exchanger_factory.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Soaspec
   # Convenience methods for once off usage of a REST request
   module RestExchangeFactory

data/lib/soaspec/exchange_handlers/rest_handler.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require_relative 'exchange_handler'
 require_relative 'rest_parameters'
 require_relative 'rest_parameters_defaults'
@@ -75,7 +77,7 @@ module Soaspec
     # Override this with 'after_response' within class definition to perform an action
     # after response is retrieved
     # @param [RestClient::Response] _response Response to interpret to perform after block
-    def after_response(_response, _self) ; end
+    def after_response(_response, _self); end
 
     # Used in together with Exchange request that passes such override parameters
     # @param [Hash] override_parameters Params to characterize REST request
@@ -93,9 +95,9 @@ module Soaspec
       test_values = interpret_parameters override_parameters
       # In order for ERB to be calculated at correct time, the first time request is made, the resource should be created
       @resource ||= RestClient::Resource.new(ERB.new(base_url_value).result(binding), @merged_options)
-
       @resource_used = test_values[:suburl] ? @resource[test_values[:suburl]] : @resource
 
+      self.exception = nil # Remove any previously stored exception
       begin
         response = case test_values[:method]
                    when :post, :patch, :put
@@ -104,7 +106,10 @@ module Soaspec
                    else # :get, :delete
                      @resource_used.send(test_values[:method].to_s, test_values[:params])
                    end
-      rescue RestClient::ExceptionWithResponse => e
+      rescue RestClient::Exception => e
+        self.exception = e
+        raise e unless e.respond_to? :response
+
         response = e.response
       end
       Soaspec::SpecLogger.info("response: \n  headers: #{response&.headers}\n  body: #{response}\n")

data/lib/soaspec/exchange_handlers/rest_methods.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Soaspec
   # Contains commonly used REST methods. Include this module in the spec where you want to use it
   #

data/lib/soaspec/exchange_handlers/rest_parameters.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Soaspec
   # Methods to define parameters specific to REST handler
   module RestParameters
@@ -79,6 +81,17 @@ module Soaspec
       define_method('after_response') { |response, _self| yield response, self }
     end
 
+    # @param [Array] exception_list List of exceptions to retry response on. Default is
+    #   any REST exception
+    # @param [Integer] pause Time to wait before retrying
+    # @param [Integer] count Times to retry
+    def retry_on_exceptions(exception_list = [RestClient::RestHandler], pause: 1,
+                            count: 3)
+      define_method('retry_on_exceptions') { exception_list }
+      define_method('retry_pause_time') { pause }
+      define_method('retry_exception_limit') { count }
+    end
+
     private
 
     # Load credentials hash from a YAML using Soaspec.credentials_folder if set, adding '.yml' if not set

data/lib/soaspec/exchange_handlers/rest_parameters_defaults.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Soaspec
   # Defaults for Soaspec RestParameters methods
   module RestParametersDefaults
@@ -19,7 +21,7 @@ module Soaspec
     #     base_url "#{parent_url}/child_path"
     #   end
     #
-    #   Child.new.base_url_value #=> 'parent/child_path'
+    #   Child.new.base_url_value # => 'parent/child_path'
     # @return [String] Base url that can be accessed by a subclass.
     def parent_url
       raise 'This needs to be set through base_url method'

data/lib/soaspec/exchange_handlers/soap_handler.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require_relative 'exchange_handler'
 require_relative '../core_ext/hash'
 require_relative '../errors'
@@ -107,8 +109,8 @@ module Soaspec
       # Call the SOAP operation with the request XML provided
       request = request_parameters(request_parameters)
       begin
-        client.call request.operation, request.body #request_body_params(request_parameters)
-      rescue Savon::HTTPError => soap_error
+        client.call request.operation, request.body # request_body_params(request_parameters)
+      rescue Savon::HTTPError => e
         soap_error
       end
     end

data/lib/soaspec/exe_helpers.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'fileutils'
 module Soaspec
   # Help with tasks common to soaspec executables

data/lib/soaspec/generate_server.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'sinatra'
 
 module Soaspec

data/lib/soaspec/indifferent_hash.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'hashie'
 
 # Hash that allows accessing hash with either string or Hash

data/lib/soaspec/interpreter.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 # Help interpret the general type of a particular object
 class Interpreter
   class << self
@@ -52,16 +54,16 @@ class Interpreter
     # @return [Boolean] Whether valid XML
     def xml?
       Nokogiri::XML(@response) { |config| config.options = Nokogiri::XML::ParseOptions::STRICT }
-    rescue Nokogiri::XML::SyntaxError => xml_error
-      self.xml_errors = xml_error
+    rescue Nokogiri::XML::SyntaxError => e
+      self.xml_errors = e
       false
     end
 
     # @return [Boolean] Whether valid JSON
     def json?
       JSON.parse(@response)
-    rescue JSON::ParserError=> json_error
-      self.json_errors = json_error
+    rescue JSON::ParserError => e
+      self.json_errors = e
       false
     end
   end

data/lib/soaspec/matchers.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require_relative 'core_ext/hash'
 require_relative 'errors'
 
@@ -85,8 +87,8 @@ RSpec::Matchers.define :be_successful do
     exchange.exchange_handler.expected_mandatory_elements.each do |mandatory_element_path|
       begin
         exchange[mandatory_element_path]
-      rescue NoElementAtPath => error
-        failure_list << error.message
+      rescue NoElementAtPath => e
+        failure_list << e.message
       end
     end
     exchange.exchange_handler.expected_mandatory_xpath_values.each do |path, value|
@@ -102,6 +104,7 @@ RSpec::Matchers.define :be_successful do
     exchange = exchange_from actual
     failure_list = collect_errors exchange
     raise failure_list.to_s unless failure_list.empty?
+
     true
   end
 
@@ -109,6 +112,7 @@ RSpec::Matchers.define :be_successful do
     exchange = exchange_from actual
     failure_list = collect_errors exchange
     raise "Expected failure. Status code is #{exchange.status_code}" if failure_list.empty?
+
     true
   end
 end

data/lib/soaspec/o_auth2.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'erb'
 
 module Soaspec
@@ -98,12 +100,12 @@ module Soaspec
     def response
       Soaspec::SpecLogger.info "using oauth_params: #{params}" if debug_oauth?
       response = RestClient.post(params[:token_url], payload, cache_control: 'no_cache', verify_ssl: false)
-    rescue RestClient::Exception => error
-      Soaspec::SpecLogger.info(["oauth_error: #{error.message}", "oauth_response: #{error.response}"])
+    rescue RestClient::Exception => e
+      Soaspec::SpecLogger.info(["oauth_error: #{e.message}", "oauth_response: #{e.response}"])
       self.retry_count += 1
       sleep 0.1 # Wait if a bit before retying obtaining access token
       retry if retry_count < self.class.retry_limit
-      raise error
+      raise e
     else
       Soaspec::SpecLogger.info(["response: \n  headers: #{response&.headers}\n  body: #{response}\n"]) if debug_oauth?
       JSON.parse(response)

data/lib/soaspec/soaspec_shared_examples.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'rspec'
 
 RSpec.shared_examples_for 'success scenario' do

data/lib/soaspec/spec_logger.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'logger'
 require 'fileutils'
 require 'colorize'

data/lib/soaspec/template_reader.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'erb'
 
 module Soaspec

data/lib/soaspec/test_server/get_bank.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'erb'
 
 module Soaspec

data/lib/soaspec/test_server/id_manager.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Soaspec
   module TestServer
     # Handles returning ids dependent on a number of factors

data/lib/soaspec/test_server/invoices.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Soaspec
   module TestServer
     # Used to simulate requests requiring oauth authentication

data/lib/soaspec/test_server/puppy_service.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Soaspec
   module TestServer
     # Simulates ordering a new puppy. Used for testing REST storing, retrieving and updating data

data/lib/soaspec/test_server/test_attribute.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Soaspec
   module TestServer
     # Helps tests attribute methods

data/lib/soaspec/test_server/test_namespace.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Soaspec
   module TestServer
     # Helps tests attribute methods

data/lib/soaspec/version.rb

@@ -1,4 +1,6 @@
+# frozen_string_literal: true
+
 module Soaspec
   # @return [String] Version of the gem
-  VERSION = '0.2.29'.freeze
+  VERSION = '0.2.30'
 end

data/lib/soaspec/virtual_server.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'soaspec'
 require 'sinatra'
 require 'sinatra/basic_auth'

data/lib/soaspec/wait.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Soaspec
   class TimeOutError < StandardError; end
   # Class to enable waiting for an expected condition to return true
@@ -27,7 +29,7 @@ module Soaspec
         begin
           result = yield
           return result if result
-        rescue *ignored => last_error
+        rescue *ignored => e
           # swallowed
         end
         sleep interval

data/lib/soaspec/wsdl_generator.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Soaspec
   # Produce test content from a WSDL
   module WsdlGenerator
@@ -26,12 +28,10 @@ module Soaspec
         @use_camel_case = false
         puts 'Message params: ' + op_details.to_s
         # From namespace identifier, find namespace, and for that find schemaLocation xsd and use that to build request
-        if op_details[:parameters]
-          op_details[:parameters].each do |element, details|
-            @use_camel_case = true unless /[[:upper:]]/.match(element.to_s[0]).nil?
-            @content += "  #{element.to_s.snakecase}: #{fill_in_field_from_type(details[:type])} # #{details[:type]} \n"
-            # TODO: If details is a Hash need to loop again
-          end
+        op_details[:parameters]&.each do |element, details|
+          @use_camel_case = true unless /[[:upper:]]/.match(element.to_s[0]).nil?
+          @content += "  #{element.to_s.snakecase}: #{fill_in_field_from_type(details[:type])} # #{details[:type]} \n"
+          # TODO: If details is a Hash need to loop again
         end
         wsdl_to_yaml_for root_elements_for(op_details)
         params = []

data/lib/soaspec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'rest-client' # REST
 require 'erb' # Embedded ruby
 require 'yaml' # Reading yaml

data/soaspec.gemspec

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 lib = File.expand_path('lib', __dir__)
 $LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
 require 'soaspec/version'

data/test_wsdl.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'wasabi'
 require 'savon'
 

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: soaspec
 version: !ruby/object:Gem::Version
-  version: 0.2.29
+  version: 0.2.30
 platform: ruby
 authors:
 - SamuelGarrattIQA
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2019-07-31 00:00:00.000000000 Z
+date: 2019-08-15 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -481,6 +481,7 @@ files:
 - lib/soaspec/exchange/request_builder.rb
 - lib/soaspec/exchange/variable_storer.rb
 - lib/soaspec/exchange_handlers/exchange_handler.rb
+- lib/soaspec/exchange_handlers/exchange_handler_defaults.rb
 - lib/soaspec/exchange_handlers/handler_accessors.rb
 - lib/soaspec/exchange_handlers/request/rest_request.rb
 - lib/soaspec/exchange_handlers/request/soap_request.rb