soapy_cake 1.2.0 → 1.3.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 0107652f9476d98d7948231f30c2483dcc060807
-  data.tar.gz: 26a0fc8182bb68f1178fd9a821786272132fe2ce
+  metadata.gz: 30ab4d58dc592b76ef9f222cd5af99dd196779e2
+  data.tar.gz: 150b73a83a589c38b0f993a976604940c510d09e
 SHA512:
-  metadata.gz: aec19e1e56835808f384f4dae6e8f14dd8a1570687d19e5d5b330dd6b7293e3b2b7f0cc59d6297101ce04c20d4cdbc05842223e13367b0f8d4c570e8411ed32b
-  data.tar.gz: eebba180198ac7a1074a9c5568da4cfdd357f689461c769f3a77bdadad4633a70f944540aa68e3344d5b9757b8528122af74685f0e09aa83514349fb40559fea
+  metadata.gz: 8fe7cdc3926b6eaaeb41a6ee1a3b13f542c96c814b28408aae5013bb2cb96c138e48b4dc11242c057cd8d9feb2dee47ee6813bc092485e97c31e0720636f6913
+  data.tar.gz: 44da349ae941c4ce26efd61abd5669c0d2abbecc8c4d73013e9b57a4cdac44242c344b83239163f0b3d8933af1e4f848bf150c03b5ada3a35832bf26e03de166

data/lib/soapy_cake/admin.rb

@@ -91,5 +91,9 @@ module SoapyCake
     def affiliate_signup(opts = {})
       run Request.new(:admin, :signup, :affiliate, opts)
     end
+
+    def verticals(*)
+      run Request.new(:admin, :get, :verticals, {})
+    end
   end
 end

data/lib/soapy_cake/admin_addedit.rb

@@ -33,7 +33,9 @@ module SoapyCake
     def update_caps(opts = {})
       require_params(opts, %i(cap_type_id cap_interval_id cap_amount send_alert_only))
 
-      opts[:cap_amount] = -1 if opts[:cap_interval_id] == Const::CAP_INTERVAL_DISABLED
+      translate_values!(opts, %i(cap_type_id cap_interval_id))
+
+      opts[:cap_amount] = -1 if opts[:cap_interval_id] == const_lookup(:cap_interval_id, :disabled)
 
       run Request.new(:admin, :addedit, :caps, opts)
     end
@@ -46,11 +48,26 @@ module SoapyCake
         add_edit_option: 'add'
       )
 
+      opts[:status_id] = const_lookup(:offer_status_id, opts[:status_id]) if opts.key?(:status_id)
+      translate_values!(opts, %i(price_format_id))
+
       run Request.new(:admin, :addedit, :offer_tiers, opts)
     end
 
     private
 
+    def translate_values!(opts, params)
+      params.each do |type|
+        opts[type] = const_lookup(type, opts[type]) if opts.key?(type)
+      end
+    end
+
+    def const_lookup(type, key)
+      Const::CONSTS[type].fetch(key) do
+        fail ArgumentError, "#{key} is not a valid value for #{type}"
+      end
+    end
+
     def addedit_offer(opts)
       require_params(opts, %i(
         advertiser_id vertical_id postback_url_ms_delay offer_contract_hidden
@@ -61,6 +78,8 @@ module SoapyCake
         opts[k] = 'off' if v == false
       end
 
+      translate_values!(opts, %i(currency_id offer_status_id offer_type_id price_format_id))
+
       opts.reverse_merge!(
         offer_name: '',
         third_party_name: '',
@@ -81,8 +100,8 @@ module SoapyCake
         postback_url: '',
         fire_global_pixel: 'no_change',
         fire_pixel_on_nonpaid_conversions: 'no_change',
-        conversion_cap_behavior: Const::CONVERSION_BEHAVIOR_SYSTEM,
-        conversion_behavior_on_redirect: Const::CONVERSION_BEHAVIOR_SYSTEM,
+        conversion_cap_behavior: const_lookup(:conversion_behaviour_id, :system),
+        conversion_behavior_on_redirect: const_lookup(:conversion_behaviour_id, :system),
         expiration_date: Date.today + (365 * 100),
         expiration_date_modification_type: 'do_not_change',
         offer_contract_name: '',
@@ -109,6 +128,8 @@ module SoapyCake
         received_percentage offer_link thankyou_link offer_contract_hidden
         offer_contract_is_default use_fallback_targeting))
 
+      translate_values!(opts, %i(price_format_id))
+
       run Request.new(:admin, :addedit, :offer_contract, opts)
     end
   end

data/lib/soapy_cake/const.rb

@@ -1,39 +1,49 @@
 module SoapyCake
   module Const
-    OFFER_STATUS_PUBLIC = 1
-    OFFER_STATUS_PRIVATE = 2
-    OFFER_STATUS_APPLY_TO_RUN = 3
-    OFFER_STATUS_INACTIVE = 4
-
-    OFFER_TYPE_HOSTED = 1
-    OFFER_TYPE_HOST_N_POST = 2
-    OFFER_TYPE_3RD_PARTY = 3
-
-    CURRENCY_USD = 1
-    CURRENCY_EUR = 2
-    CURRENCY_GBD = 3
-    CURRENCY_AUD = 4
-    CURRENCY_CAD = 5
-
-    PRICE_FORMAT_CPA = 1
-    PRICE_FORMAT_CPC = 2
-    PRICE_FORMAT_CPM = 3
-    PRICE_FORMAT_FIXED = 4
-    PRICE_FORMAT_REVSHARE = 5
-
-    CONVERSION_BEHAVIOR_SYSTEM = 0
-    CONVERSION_BEHAVIOR_ADV_AFF = 1
-    CONVERSION_BEHAVIOR_ADV_NO_AFF = 2
-    CONVERSION_BEHAVIOR_IGNORE = 3
-    CONVERSION_BEHAVIOR_NO_ADV_AFF = 4
-    CONVERSION_BEHAVIOR_NO_ADV_NO_AFF = 5
-
-    CAP_TYPE_CLICK = 1
-    CAP_TYPE_CONVERSION = 2
-
-    CAP_INTERVAL_DISABLED = 0
-    CAP_INTERVAL_DAILY = 1
-    CAP_INTERVAL_WEEKLY = 2
-    CAP_INTERVAL_MONTHLY = 3
+    CONSTS = {
+      offer_status_id: {
+        public: 1,
+        private: 2,
+        apply_to_run: 3,
+        inactive: 4,
+      },
+      offer_type_id: {
+        hosted: 1,
+        host_n_post: 2,
+        third_party: 3,
+      },
+      currency_id: {
+        usd: 1,
+        eur: 2,
+        gbd: 3,
+        aud: 4,
+        cad: 5,
+      },
+      price_format_id: {
+        cpa: 1,
+        cpc: 2,
+        cpm: 3,
+        fixed: 4,
+        revshare: 5,
+      },
+      conversion_behaviour_id: {
+        system: 0,
+        adv_off: 1,
+        adv_no_aff: 2,
+        ignore: 3,
+        no_adv_aff: 4,
+        no_adv_no_aff: 5,
+      },
+      cap_type_id: {
+        click: 1,
+        conversion: 2,
+      },
+      cap_interval_id: {
+        disabled: 0,
+        daily: 1,
+        weekly: 2,
+        monthly: 3,
+      }
+    }
   end
 end

data/lib/soapy_cake/version.rb

@@ -1,3 +1,3 @@
 module SoapyCake
-  VERSION = '1.2.0'
+  VERSION = '1.3.0'
 end

data/spec/lib/soapy_cake/addedit_integration_spec.rb

@@ -13,9 +13,9 @@ RSpec.describe 'ADDEDIT integration test' do
     it 'creates an offer', :vcr do
       result = subject.add_offer(
         hidden: false,
-        offer_status_id: SoapyCake::Const::OFFER_STATUS_PUBLIC,
-        offer_type_id: SoapyCake::Const::OFFER_TYPE_3RD_PARTY,
-        currency_id: SoapyCake::Const::CURRENCY_EUR,
+        offer_status_id: :public,
+        offer_type_id: :third_party,
+        currency_id: :eur,
         ssl: false,
         click_cookie_days: 30,
         impression_cookie_days: 30,
@@ -37,7 +37,7 @@ RSpec.describe 'ADDEDIT integration test' do
         vertical_id: vertical_id,
         postback_url_ms_delay: 60,
         offer_contract_hidden: false,
-        price_format_id: SoapyCake::Const::PRICE_FORMAT_CPA,
+        price_format_id: :cpa,
         received: 2.0,
         received_percentage: false,
         payout: 1.5,
@@ -65,7 +65,7 @@ RSpec.describe 'ADDEDIT integration test' do
         vertical_id: vertical_id,
         postback_url_ms_delay: 50,
         offer_contract_hidden: false,
-        price_format_id: SoapyCake::Const::PRICE_FORMAT_CPA,
+        price_format_id: :cpa,
         received: 2.0,
         received_percentage: false,
         payout: 1.5,
@@ -95,7 +95,7 @@ RSpec.describe 'ADDEDIT integration test' do
       result = subject.add_offer_contract(
         offer_id: offer_id,
         offer_contract_name: 'Test Contract',
-        price_format_id: SoapyCake::Const::PRICE_FORMAT_CPA,
+        price_format_id: :cpa,
         received: 3.2,
         received_percentage: false,
         payout: 2.5,
@@ -114,7 +114,7 @@ RSpec.describe 'ADDEDIT integration test' do
         offer_id: offer_id,
         offer_contract_id: offer_contract_id,
         offer_contract_name: 'Test Contract',
-        price_format_id: SoapyCake::Const::PRICE_FORMAT_CPA,
+        price_format_id: :cpa,
         received: 3.2,
         received_percentage: false,
         payout: 2.5,
@@ -147,8 +147,8 @@ RSpec.describe 'ADDEDIT integration test' do
     it 'updates a cap for an offer contract', :vcr do
       result = subject.update_caps(
         offer_contract_id: offer_contract_id,
-        cap_type_id: SoapyCake::Const::CAP_TYPE_CONVERSION,
-        cap_interval_id: SoapyCake::Const::CAP_INTERVAL_DAILY,
+        cap_type_id: :conversion,
+        cap_interval_id: :daily,
         cap_amount: 42,
         send_alert_only: false
       )
@@ -159,8 +159,8 @@ RSpec.describe 'ADDEDIT integration test' do
     it 'removes a cap for an offer contract', :vcr do
       result = subject.update_caps(
         offer_contract_id: offer_contract_id,
-        cap_type_id: SoapyCake::Const::CAP_TYPE_CONVERSION,
-        cap_interval_id: SoapyCake::Const::CAP_INTERVAL_DISABLED,
+        cap_type_id: :conversion,
+        cap_interval_id: :disabled,
         cap_amount: 42,
         send_alert_only: false
       )
@@ -175,8 +175,8 @@ RSpec.describe 'ADDEDIT integration test' do
         offer_id: offer_id,
         offer_contract_id: offer_contract_id,
         tier_id: tier_id,
-        price_format_id: SoapyCake::Const::PRICE_FORMAT_CPA,
-        status_id: SoapyCake::Const::OFFER_STATUS_PUBLIC
+        price_format_id: :cpa,
+        status_id: :public
       )
 
       expect(result[:message]).to eq('Offer Tier Added')

data/spec/lib/soapy_cake/admin_spec.rb

@@ -125,6 +125,12 @@ RSpec.describe SoapyCake::Admin do
   describe 'get service' do
     let(:service) { :get }
 
+    describe '#verticals' do
+      let(:method) { :verticals }
+      let(:cake_opts) { {} }
+      it_behaves_like 'a cake admin method'
+    end
+
     describe '#currencies' do
       let(:method) { :currencies }
       let(:cake_opts) { {} }

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: soapy_cake
 version: !ruby/object:Gem::Version
-  version: 1.2.0
+  version: 1.3.0
 platform: ruby
 authors:
 - ad2games GmbH
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-02-18 00:00:00.000000000 Z
+date: 2015-02-24 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport