soapy_cake 1.25.2 → 1.26.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 1321d74f53687f87ede80c9d57c96cd0071243f3
-  data.tar.gz: 2a959b7fe70c1bbac22d7e798cd7c1eb76bc20ee
+  metadata.gz: f0200aa227f1f26c12610300c9848a22b831433a
+  data.tar.gz: 515fda58cc88b35ef23ecfbd83f3bb7dc250bce1
 SHA512:
-  metadata.gz: e7217c43f14f3b57ac1b104dfd64924e0f45a120147814ab2dfb4f8bf05efc2dca2d0ce709dd3eff418c3588b3d0049ac58458119bdde00a4a1f62b9d1e6b314
-  data.tar.gz: 64d9af5457a4fd531a01c26f7f02311ef73abbb2027fd5cc9dcf3d8204fd01d844cfeb5e27166af65974f6fda62bf993fe5eb7ae888f6d8dff7abd91c0ee2d49
+  metadata.gz: 57058b8a99b05a26c4ee21c0c21b818a957281d0125c56925d764caa07d2f6baeb2e7ec6b217ba27efeeed0cef641d04e19bf17e864fe6b5574b968a26fe00b3
+  data.tar.gz: 22554ab098bcbe0f909539b1ecf2bf72b4745e4fc7d8b10428cb490d526c7dc60cbb8a24b37f8e80c58292d70435e7a3f7a2339f3f6fd53aa1cfc627ed55dd2f

data/lib/soapy_cake/admin_addedit.rb

@@ -70,6 +70,11 @@ module SoapyCake
       offer_contract_is_default use_fallback_targeting
     ).freeze
 
+    REQUIRED_NEW_CAMPAIGN_PARAMS = %i(
+      affiliate_id offer_id account_status_id payout
+      redirect_404 clear_session_on_conversion paid_upsells
+    ).freeze
+
     CAMPAIGN_UPDATE_DEFAULT_OPTIONS = {
       account_status_id: :no_change,
       auto_disposition_delay_hours: 0,
@@ -187,7 +192,7 @@ module SoapyCake
     end
 
     def add_campaign(opts)
-      require_params(opts, %i(affiliate_id offer_id account_status_id payout))
+      require_params(opts, REQUIRED_NEW_CAMPAIGN_PARAMS)
       addedit_campaign(opts.merge(campaign_id: 0, expiration_date: future_expiration_date))
     end
 
@@ -258,6 +263,7 @@ module SoapyCake
     end
 
     def addedit_campaign(opts)
+      opts = translate_booleans(opts)
       opts = translate_values(opts, %i(account_status_id))
       opts = opts.reverse_merge(display_link_type_id: 1)
       run Request.new(:admin, :addedit, :campaign, opts)

data/lib/soapy_cake/version.rb

@@ -1,4 +1,4 @@
 # frozen_string_literal: true
 module SoapyCake
-  VERSION = '1.25.2'
+  VERSION = '1.26.0'
 end

data/spec/fixtures/vcr_cassettes/SoapyCake_AdminAddedit/campaigns/adds_a_campaign.yml

@@ -18,6 +18,9 @@ http_interactions:
               <cake:media_type_id>1</cake:media_type_id>
               <cake:account_status_id>1</cake:account_status_id>
               <cake:payout>1.23</cake:payout>
+              <cake:redirect_404>off</cake:redirect_404>
+              <cake:clear_session_on_conversion>off</cake:clear_session_on_conversion>
+              <cake:paid_upsells>off</cake:paid_upsells>
               <cake:campaign_id>0</cake:campaign_id>
               <cake:expiration_date>2045-02-09T01:00:00</cake:expiration_date>
             </cake:Campaign>
@@ -26,6 +29,12 @@ http_interactions:
     headers:
       Content-Type:
       - application/soap+xml;charset=UTF-8
+      Accept-Encoding:
+      - gzip;q=1.0,deflate;q=0.6,identity;q=0.3
+      Accept:
+      - "*/*"
+      User-Agent:
+      - Ruby
   response:
     status:
       code: 200
@@ -42,7 +51,7 @@ http_interactions:
       X-Powered-By:
       - ASP.NET
       Date:
-      - Wed, 04 May 2016 09:44:12 GMT
+      - Thu, 15 Sep 2016 14:26:47 GMT
       Content-Length:
       - '629'
     body:
@@ -50,7 +59,7 @@ http_interactions:
       string: <?xml version="1.0" encoding="utf-8"?><soap:Envelope xmlns:soap="http://www.w3.org/2003/05/soap-envelope"
         xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xmlns:xsd="http://www.w3.org/2001/XMLSchema"><soap:Body><CampaignResponse
         xmlns="http://cakemarketing.com/api/3/"><CampaignResult><success>true</success><message>Campaign
-        Created</message><success_info><campaign_id>22081</campaign_id><affiliate_id>1</affiliate_id><offer_id>8910</offer_id><offer_contract_id>1455</offer_contract_id><media_type_id>1</media_type_id><original>false</original></success_info></CampaignResult></CampaignResponse></soap:Body></soap:Envelope>
+        Created</message><success_info><campaign_id>23305</campaign_id><affiliate_id>1</affiliate_id><offer_id>8910</offer_id><offer_contract_id>1455</offer_contract_id><media_type_id>1</media_type_id><original>false</original></success_info></CampaignResult></CampaignResponse></soap:Body></soap:Envelope>
     http_version: 
   recorded_at: Tue, 17 Feb 2015 12:00:00 GMT
-recorded_with: VCR 3.0.1
+recorded_with: VCR 3.0.3

data/spec/integration/soapy_cake/admin_addedit_spec.rb

@@ -291,7 +291,10 @@ RSpec.describe SoapyCake::AdminAddedit do
         offer_id: offer_id,
         media_type_id: 1,
         account_status_id: :active,
-        payout: '1.23'
+        payout: '1.23',
+        redirect_404: false,
+        clear_session_on_conversion: false,
+        paid_upsells: false
       )
 
       expect(result[:message]).to eq('Campaign Created')

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: soapy_cake
 version: !ruby/object:Gem::Version
-  version: 1.25.2
+  version: 1.26.0
 platform: ruby
 authors:
 - ad2games GmbH
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-08-22 00:00:00.000000000 Z
+date: 2016-09-16 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
@@ -257,7 +257,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.5.1
+rubygems_version: 2.6.6
 signing_key: 
 specification_version: 4
 summary: Simple client for the CAKE API