soapy_cake 1.19.0 → 1.20.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 1b885bb4fe2f48d057406017f66cb421de417619
-  data.tar.gz: c1d0e66a52f0b4acff03760ddcf9f94ef0da7f37
+  metadata.gz: b83f34c1746ec07e1eb0eb47ddbb50c9fea4796c
+  data.tar.gz: f0dd1db1eaa1ba6550669564ea3a0c6984021a8c
 SHA512:
-  metadata.gz: 39f8963dd4d26fc38edec8478ce6b5e17af70d3c62a724fc4eb6814625f0fb5ed386e0e3f30793b64dafc18db6cf42bc4cdf6a7b8767f894f2345ea42cbbf65e
-  data.tar.gz: 8f2f6de99f031f2b5869ec82cbf02426996ea1047b1f17e6aa309579dba615a894bb3d0e2504e3d8e517cd9fae72559e9ab35b95ccb6f80d9c2ba580a4de9910
+  metadata.gz: ce98500805287cef4ed338947ca7f556e707c6143941ba02a9a9b2ce71d1ddd340347d742a69cccb277d4ce2bcf03c6e1c80d7572fe36b82185376710cc6e555
+  data.tar.gz: 082ec9d5cd54283ca0857bad5cf246bd43faf03bf27ac4314e8ebf3267b79ae593333668d1b06a9b2cccb2bc6bc6e60c4ed1f729dd512ef2c92585a7a4847365

data/lib/soapy_cake.rb

@@ -2,6 +2,7 @@ require 'logger'
 require 'nokogiri'
 require 'saxerator'
 require 'httparty'
+require 'retryable'
 require 'active_support/core_ext/hash/reverse_merge'
 require 'active_support/core_ext/hash/transform_values'
 require 'active_support/time'

data/lib/soapy_cake/client.rb

@@ -25,8 +25,10 @@ module SoapyCake
       request.api_key = api_key
       request.time_converter = time_converter
 
-      response = Response.new(response_body(request), request.short_response?, time_converter)
-      xml_response? ? response.to_xml : response.to_enum
+      Retryable.retryable(tries: 5, on: RateLimitError, sleep: -> (n) { 3**n }) do
+        response = Response.new(response_body(request), request.short_response?, time_converter)
+        xml_response? ? response.to_xml : response.to_enum
+      end
     end
 
     private

data/lib/soapy_cake/error.rb

@@ -1,4 +1,5 @@
 module SoapyCake
   class Error < RuntimeError; end
   class RequestFailed < Error; end
+  class RateLimitError < RequestFailed; end
 end

data/lib/soapy_cake/response.rb

@@ -67,6 +67,7 @@ module SoapyCake
 
     def error_check_success!
       return if sax.for_tag(:success).first == 'true'.freeze
+      fail RateLimitError if error_message == 'Restricted'.freeze
       fail RequestFailed, error_message
     end
 
@@ -82,7 +83,7 @@ module SoapyCake
     end
 
     def error_message
-      sax.for_tag(:message).first || sax.for_tag(:Text).first || 'Unknown error'
+      @error_message ||= sax.for_tag(:message).first || sax.for_tag(:Text).first || 'Unknown error'
     end
   end
 end

data/lib/soapy_cake/version.rb

@@ -1,3 +1,3 @@
 module SoapyCake
-  VERSION = '1.19.0'.freeze
+  VERSION = '1.20.0'.freeze
 end

data/soapy_cake.gemspec

@@ -22,6 +22,7 @@ Gem::Specification.new do |spec|
   spec.add_dependency 'saxerator'
   spec.add_dependency 'nokogiri'
   spec.add_dependency 'httparty'
+  spec.add_dependency 'retryable'
 
   spec.add_development_dependency 'bundler'
   spec.add_development_dependency 'rake'

data/spec/fixtures/vcr_cassettes/SoapyCake_Admin/XML_responses/fails_on_error.yml

@@ -42,7 +42,7 @@ http_interactions:
       encoding: UTF-8
       string: <?xml version="1.0" encoding="utf-8"?><soap:Envelope xmlns:soap="http://www.w3.org/2003/05/soap-envelope"
         xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xmlns:xsd="http://www.w3.org/2001/XMLSchema"><soap:Body><AffiliatesResponse
-        xmlns="http://cakemarketing.com/api/5/"><AffiliatesResult><success>false</success><message>Restricted</message><row_count>0</row_count></AffiliatesResult></AffiliatesResponse></soap:Body></soap:Envelope>
-    http_version: 
+        xmlns="http://cakemarketing.com/api/5/"><AffiliatesResult><success>false</success><message>Something Broken</message><row_count>0</row_count></AffiliatesResult></AffiliatesResponse></soap:Body></soap:Envelope>
+    http_version:
   recorded_at: Mon, 15 Jun 2015 12:00:00 GMT
 recorded_with: VCR 2.9.3

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: soapy_cake
 version: !ruby/object:Gem::Version
-  version: 1.19.0
+  version: 1.20.0
 platform: ruby
 authors:
 - ad2games GmbH
@@ -66,6 +66,20 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
+- !ruby/object:Gem::Dependency
+  name: retryable
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: bundler
   requirement: !ruby/object:Gem::Requirement