soapy_cake 1.14.0 → 1.14.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: d99924dd593a9f0d8fd215d02a44177a7919cb13
-  data.tar.gz: da5d81a7738efdd7cfc4f1dd8372c1f4c7faa5d0
+  metadata.gz: 975d77a9bebc36a642eb905204a727ac4b461c18
+  data.tar.gz: 515c4a92916f800774388ab2169d354f5052d2c6
 SHA512:
-  metadata.gz: a03fac64800f777a61b8c59969b16d133f252be0f8857b88c419496fc629a1fd639f260c0a87dcab706651e7dfaea7a7ab0c03a6b58e689e2c4fcb84b9095f5e
-  data.tar.gz: 470188fc1c53c5f2c798f32edc8a438ee7aae6f585798f1a585f72b248125a113f5be268d8b6de852cb33af91ff53c95aa910969d5a27251471ad5b6fc03c12b
+  metadata.gz: 9209729dd365c22b06a09d96de5751a609a3b970b189fe9533f84721cc468886eb133ff9ca0dcba4d4df5cab50fb2139af16baa4eaaf5025659db77d46f75094
+  data.tar.gz: dfd5f4b2ff618af93fcd79d94ec9eb890186b52a9f41e042400a6f7911fadbb1809f3496b906e1022c08f25d499156008967cf4e04ebb8870ce977ef5a0e4a5c

data/.ruby-version

@@ -1 +1 @@
-2.2.2
+2.2.3

data/lib/soapy_cake/admin.rb

@@ -1,4 +1,5 @@
 module SoapyCake
+  # rubocop:disable Metrics/ClassLength
   class Admin < Client
     include Helper
 
@@ -105,8 +106,15 @@ module SoapyCake
       run Request.new(:admin, :addedit, :campaign, opts)
     end
 
-    def add_blacklist(opts = {})
-      run Request.new(:admin, :addedit, :blacklist, opts)
+    def add_blacklist(opts)
+      require_params(opts, %i(blacklist_date))
+
+      run Request.new(
+        :admin,
+        :addedit,
+        :blacklist,
+        opts.merge(blacklist_date: (opts[:blacklist_date] + 1.day).to_s)
+      )
     end
 
     def affiliate_signup(opts = {})

data/lib/soapy_cake/admin_addedit.rb

@@ -47,7 +47,7 @@ module SoapyCake
       payout_modification_type: 'change',
       received_modification_type: 'change',
       tags_modification_type: 'do_not_change'
-    }
+    }.freeze
 
     REQUIRED_NEW_OFFER_PARAMS = %i(
       hidden offer_status_id offer_type_id currency_id ssl click_cookie_days
@@ -56,18 +56,18 @@ module SoapyCake
       enable_transaction_id_deduplication postbacks_only fire_global_pixel
       fire_pixel_on_nonpaid_conversions offer_link thankyou_link from_lines
       subject_lines
-    )
+    ).freeze
 
     REQUIRED_OFFER_PARAMS = %i(
       advertiser_id vertical_id postback_url_ms_delay offer_contract_hidden
       price_format_id received received_percentage payout tags
-    )
+    ).freeze
 
     REQUIRED_OFFER_CONTRACT_PARAMS = %i(
       offer_id offer_contract_id offer_contract_name price_format_id payout received
       received_percentage offer_link thankyou_link offer_contract_hidden
       offer_contract_is_default use_fallback_targeting
-    )
+    ).freeze
 
     def add_offer(opts)
       require_params(opts, REQUIRED_NEW_OFFER_PARAMS)

data/lib/soapy_cake/admin_batched.rb

@@ -2,7 +2,7 @@ module SoapyCake
   class AdminBatched
     ALLOWED_METHODS = %i(
       advertisers affiliates campaigns offers creatives clicks conversions events
-    )
+    ).freeze
 
     def initialize(opts = {})
       @opts = opts

data/lib/soapy_cake/const.rb

@@ -1,17 +1,30 @@
 module SoapyCake
   module Const
+    # The ID mapping in the API docs is wrong, these values are taken from the UI.
+    CONVERSION_BEHAVIOUR_ID = {
+      system: 0,
+      adv_off: 1,
+      adv_no_aff: 2,
+      no_adv_aff: 3,
+      no_adv_no_aff: 4,
+      ignore: 5
+    }.freeze
+
+    OFFER_STATUS_ID = {
+      public: 1,
+      private: 2,
+      apply_to_run: 3,
+      inactive: 4
+    }.freeze
+
     CONSTS = {
       account_status_id: {
         active: 1,
         inactive: 2,
         pending: 3
       },
-      offer_status_id: {
-        public: 1,
-        private: 2,
-        apply_to_run: 3,
-        inactive: 4
-      },
+      offer_status_id: OFFER_STATUS_ID,
+      status_id: OFFER_STATUS_ID,
       offer_type_id: {
         hosted: 1,
         host_n_post: 2,
@@ -36,15 +49,9 @@ module SoapyCake
         fixed: 4,
         revshare: 5
       },
-      # The ID mapping in the API docs is wrong, these values are taken from the UI.
-      conversion_behavior_id: {
-        system: 0,
-        adv_off: 1,
-        adv_no_aff: 2,
-        no_adv_aff: 3,
-        no_adv_no_aff: 4,
-        ignore: 5
-      },
+      conversion_behavior_id: CONVERSION_BEHAVIOUR_ID,
+      conversion_cap_behavior: CONVERSION_BEHAVIOUR_ID,
+      conversion_behavior_on_redirect: CONVERSION_BEHAVIOUR_ID,
       cap_type_id: {
         click: 1,
         conversion: 2
@@ -67,12 +74,6 @@ module SoapyCake
         inactive: 2,
         hidden: 3
       }
-    }
-
-    CONSTS.merge!(
-      conversion_cap_behavior: CONSTS[:conversion_behavior_id],
-      conversion_behavior_on_redirect: CONSTS[:conversion_behavior_id],
-      status_id: CONSTS[:offer_status_id]
-    )
+    }.freeze
   end
 end

data/lib/soapy_cake/response_value.rb

@@ -4,7 +4,7 @@ module SoapyCake
     attr_reader :key
 
     # Known string ids that should not be parsed as integers
-    STRING_IDS = %w(tax_id transaction_id)
+    STRING_IDS = %w(tax_id transaction_id).freeze
 
     def initialize(key, value, opts = {})
       @key = key.to_s

data/lib/soapy_cake/version.rb

@@ -1,3 +1,3 @@
 module SoapyCake
-  VERSION = '1.14.0'
+  VERSION = '1.14.1'.freeze
 end

data/spec/integration/soapy_cake/admin_track_spec.rb

@@ -6,6 +6,7 @@ RSpec.describe SoapyCake::AdminTrack do
     let(:cake_method) { :decrypt_affiliate_link }
     let(:method) { :decrypt_affiliate_link }
     let(:cake_opts) { { a: 1 } }
+    let(:opts) { nil }
 
     it_behaves_like 'a cake admin method'
   end

data/spec/lib/soapy_cake/admin_spec.rb

@@ -1,5 +1,5 @@
 RSpec.describe SoapyCake::Admin do
-  let(:opts) { { a: 1 } }
+  let(:opts) { nil }
   let(:cake_opts) { opts }
   let(:cake_method) { method }
 
@@ -88,7 +88,7 @@ RSpec.describe SoapyCake::Admin do
 
     describe '#conversions' do
       let(:method) { :conversions }
-      let(:cake_opts) { opts.merge(conversion_type: 'conversions') }
+      let(:cake_opts) {  { conversion_type: 'conversions' } }
       it_behaves_like 'a cake admin method'
     end
 
@@ -100,7 +100,7 @@ RSpec.describe SoapyCake::Admin do
     describe '#events' do
       let(:method) { :events }
       let(:cake_method) { :conversions }
-      let(:cake_opts) { opts.merge(conversion_type: 'events') }
+      let(:cake_opts) { { conversion_type: 'events' } }
       it_behaves_like 'a cake admin method'
     end
 
@@ -176,6 +176,10 @@ RSpec.describe SoapyCake::Admin do
     describe '#add_blacklist' do
       let(:method) { :add_blacklist }
       let(:cake_method) { :blacklist }
+      let(:date) { Date.new(2015, 9, 3) }
+      let(:request) { double('request') }
+      let(:opts) { { blacklist_date: date } }
+      let(:cake_opts) { { blacklist_date: (date + 1.day).to_s } }
       it_behaves_like 'a cake admin method'
     end
   end

data/spec/lib/soapy_cake/admin_track_spec.rb

@@ -6,6 +6,7 @@ RSpec.describe SoapyCake::AdminTrack do
     let(:cake_method) { :decrypt_affiliate_link }
     let(:method) { :decrypt_affiliate_link }
     let(:cake_opts) { { a: 1 } }
+    let(:opts) { nil }
 
     it_behaves_like 'a cake admin method'
   end

data/spec/support/admin_method_example.rb

@@ -6,6 +6,6 @@ RSpec.shared_examples_for 'a cake admin method' do
       .with(:admin, service, cake_method, cake_opts || {}).and_return(request)
     expect(subject).to receive(:run).with(request)
 
-    subject.public_send(method, *[cake_opts].compact)
+    subject.public_send(method, *[opts || cake_opts].compact)
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: soapy_cake
 version: !ruby/object:Gem::Version
-  version: 1.14.0
+  version: 1.14.1
 platform: ruby
 authors:
 - ad2games GmbH
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-09-01 00:00:00.000000000 Z
+date: 2015-09-15 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport