soapy_bing 1.0.0 → 1.0.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 65a3fd44b151237e0803cddd7d9bf6988e2469e546b4415f0d296e263e01b81b
-  data.tar.gz: a96527f1a48c50549cba94dcdbe06a4f0f91c510a93b0abd8e1869747dc2a8fe
+  metadata.gz: 410ca0200523029aee0ca775e0c1cd2e986d8f06e8052125f0f29a2a1ab6bbca
+  data.tar.gz: e60d34bd896baff2a38484d7e92aac4d3eeb28d899e3d951e6fb31cd73455f9c
 SHA512:
-  metadata.gz: 7a604992207260d32a2fe6cfe0c445473b61588f7f03fd096c5e02c54cc6876be0a3278accb911d7cb7be5727555139dc801aa922b5c816b3422514e21da61fb
-  data.tar.gz: a1f16463696c50f2926e92ff98e3838695d38c0f1bc6224a312f95b327a294566ea3c6e48acd822c7191d7e0be1489f50ca2ee4917f620737795c4f83a129319
+  metadata.gz: 6e8de7b6c64bc206576b1715819ac7e9dd32a244197d1cc1b4e0ac33004ae559fd93b5f382a984d2e311c2c66fcdffe8f56dbdf7d10352e1f8a8d9c8a4b54fab
+  data.tar.gz: c4c91a28b008659e3a571359e745297975c6d743c482cd1f6b62f5814aec4b998cb3b6777bfacb7ce0303cdd0e691d87ab20e88c49cb692e541e7cea017d129a

data/CHANGELOG.md

@@ -4,6 +4,10 @@ All notable changes to this project will be documented in this file.
 The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
 and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
+## [1.0.1] - 2019-03-13
+### Changed
+- Pass along the server's error message to `TokenRefreshError`
+
 ## [1.0.0] - 2019-01-28
 ### Added
 - This CHANGELOG

data/lib/soapy_bing/oauth_credentials.rb

@@ -27,7 +27,9 @@ module SoapyBing
     def request_access_token
       resp = HTTParty.post(token_url, body: access_token_params)
 
-      raise TokenRefreshError unless resp.code == 200
+      if resp.code != 200
+        raise TokenRefreshError, "#{resp['error_description']} (#{resp['error']})"
+      end
 
       resp['access_token']
     end

data/lib/soapy_bing/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module SoapyBing
-  VERSION = '1.0.0'
+  VERSION = '1.0.1'
 end

data/spec/soapy_bing/oauth_credentials_spec.rb

@@ -83,28 +83,37 @@ RSpec.describe SoapyBing::OauthCredentials do
 
   describe '#access_token' do
     let(:credentials) { { client_id: 'foo', client_secret: 'bar', refresh_token: 'baz' } }
-    let(:response) { double(:response) } # rubocop:disable RSpec/VerifiedDoubles
+    let(:response) do
+      HTTParty::Response.new(
+        OpenStruct.new(options: {}),
+        OpenStruct.new(code: status_code),
+        -> { response_body }
+      )
+    end
 
     before do
-      allow(response).to receive(:code).once.and_return(status_code)
       allow(HTTParty).to receive(:post).once.and_return(response)
     end
 
     context 'when there is good response' do
       let(:status_code) { 200 }
+      let(:response_body) { { 'access_token' => 'my-token' } }
 
       it 'memoizes http request response' do
-        expect(response).to receive(:[]).once.with('access_token').and_return('my-token')
         2.times { expect(oauth_credentials.access_token).to eq 'my-token' }
       end
     end
 
     context 'when there is bad response' do
       let(:status_code) { 401 }
+      let(:response_body) do
+        { 'error' => 'my-error', 'error_description' => 'This is my error.' }
+      end
 
       it 'throws exception in case of bad status code' do
         expect { oauth_credentials.access_token }.to raise_error(
-          SoapyBing::OauthCredentials::TokenRefreshError
+          SoapyBing::OauthCredentials::TokenRefreshError,
+          'This is my error. (my-error)'
         )
       end
     end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: soapy_bing
 version: !ruby/object:Gem::Version
-  version: 1.0.0
+  version: 1.0.1
 platform: ruby
 authors:
 - ad2games GmbH
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2019-01-28 00:00:00.000000000 Z
+date: 2019-03-13 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
@@ -299,8 +299,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubyforge_project: 
-rubygems_version: 2.7.6
+rubygems_version: 3.0.2
 signing_key: 
 specification_version: 4
 summary: Simple client for the Bing Ads APIs