so_paid 0.0.9 → 0.0.10

data/lib/so_paid/cybersource.rb

@@ -78,14 +78,24 @@ module SoPaid
     end
 
 
-    def self.verify_transaction_signature(message)
-      if message[:req_merchant_defined_data100].present? and message[:req_merchant_defined_data100] == "test"
+    def self.verify_transaction_signature(params)
+      if params[:req_merchant_defined_data100].present? and params[:req_merchant_defined_data100] == "test"
         secret_key = get_secret_key_for(:test)
       else
         secret_key = get_secret_key_for(:live)
       end
+      pub_digest = sign_params(params[:signed_field_names], params, secret_key)
+      pub_digest.eql?(params[:signature].strip)
+    end
 
-      verify_signature(message[:signed_field_names], message[:signature], secret_key)
+    def self.sign_params(field_list, params, secret_key)
+      field_list = field_list.split(",") if field_list.is_a? String
+      data = []
+      field_list.each do |key|
+        data << key.to_s + "=" + params[key].to_s
+      end
+      data = data.join(",")
+      encode_hop(data, secret_key)
     end
 
     def self.get_secret_key_for(targ_env)
@@ -136,17 +146,7 @@ module SoPaid
 
 
     def set_signature
-      @pv_order_params[:signature] = sign_params
-    end
-
-
-    def sign_params
-      data = []
-      @merged_pv_opts[:signed_field_names].each do |key|
-        data << key.to_s + "=" + @pv_order_params[key].to_s
-      end
-      data = data.join(",")
-      self.class.encode_hop(data, @merged_pv_opts[:secret_key])
+      @pv_order_params[:signature] = self.class.sign_params(@merged_pv_opts[:signed_field_names], @pv_order_params, @merged_pv_opts[:secret_key])
     end
 
 

data/lib/so_paid/hop.rb

@@ -40,15 +40,6 @@ module SoPaid
       Base64.encode64(mac.digest).gsub "\n", ''
     end
 
-    def self.verify_signature(data, signature, secret_key)
-       pub_digest = encode_hop(data, secret_key)
-       pub_digest.eql?(signature)
-    end
-    
-    def self.verify_transaction_signature(message)
-      raise "verify_transaction_signature needs to be defined in child class"
-    end
-
 
     def initialize(order, pv_options={}, config_options={})
       @pv_order_params = {}.with_indifferent_access

data/lib/so_paid/version.rb

@@ -1,3 +1,3 @@
 module SoPaid
-  VERSION = "0.0.9"
+  VERSION = "0.0.10"
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: so_paid
 version: !ruby/object:Gem::Version
-  version: 0.0.9
+  version: 0.0.10
   prerelease: 
 platform: ruby
 authors: