snmpjr 0.1.5-java → 0.1.7-java

checksums.yaml

@@ -1,15 +1,15 @@
 ---
 !binary "U0hBMQ==":
   metadata.gz: !binary |-
-    ZDMzMmM5ZDlhMTIyMTMyODUxMjUxNTE5ZDk2YzA1YWJkMGRmMzFjZg==
+    NGVjMjA0ZTY4YTdmN2Q3YWZkYzJlNTAzM2NjN2RjZDhjYmVjYWEwNw==
   data.tar.gz: !binary |-
-    NDYzMGI3YzRiMzQxYWQxMThkOWM2ZjhhYzIzNDU1ZDFiYmUyNTFiMA==
+    ZTI3OTIwODllMTgzMDhmNzk5NmFmYTFjZjIyOWJiMGNlYWQ3NmMyZA==
 SHA512:
   metadata.gz: !binary |-
-    ZWQ2ZGVlM2I5ZWQyN2Y4ZDg1YjNiZWI0MGMzZjM1YmNkNjU3MTY5NWY0ZjU4
-    N2M4NjM1Njg0MWFlZmZjODA2MTA0MDI0NTE2NWVhMzdlYzZmZTVjMDVhZTUz
-    ODcxZDM2M2RmMTMxM2QxNGJjYjNmNjU4YmEwN2Q1NjgzMzYxZWI=
+    ZmIzZDU5ZTE3MWUyMWQzZThlYWQwZmJjNDExZmMwYmE2ZGM1MjI1YjQ2YzJm
+    NjllOTUwNDI3MTYxZDYzM2YxZjQzMzU5MjA4ZTU2YzUxOWFhMzk4YWMyYWVi
+    YTllZjJlMjg1ZDZkMTIxM2JmNzJkZjNjNzcyZmEyOTRhMjM5MDA=
   data.tar.gz: !binary |-
-    Njg0ZTlkYzExYjZkOWMzNjNhMTFhNmM0ODFmNGZjZWM5MWEzYmRmMGJjMDlj
-    ZGZjNzM1NDhkNGRkMTZmN2ZhNGE3MjRmYzY4NjcwNGRiYzFlNjZmNzA1NmZl
-    ZDNlOGRiMDMyMWQzZWQzNjRjYTU1NzU3MDlhMDQ5NThhZGMzZGM=
+    MTZiYTc5NzBhZjFhODE5YjdkN2U4ZWFkMWU3ZTljZmViYzEwYWRhNjA2OTdj
+    YjFmMDBiYTZjYjAzOWI2NDM1ZmQzNmMyNzRmNTQ3NGFlNTUzNzRmZGU3ZDk2
+    MmU5ZDAwZDhiZTRkN2JjMWZmNjVlNzIxMzI4M2MxNDhjN2EzZjE=

data/.rspec

@@ -1,3 +1,2 @@
 --color
---warnings
 --require spec_helper

data/.rubocop.yml

@@ -0,0 +1,3 @@
+AllCops:
+  Exclude:
+    - 'vendor/**/*'

data/.travis.yml

@@ -1,7 +1,16 @@
 language: ruby
+branches:
+  only:
+    - master
+    - /^[0-9]+\.[0-9]+\.[0-9]+/
+env:
+  global:
+    - CODECLIMATE_REPO_TOKEN=151e29085225a0d503821bd67ad8d5dadddb7352fe0d585512c325990c85492b
 rvm:
 - jruby-1.7.0
 - jruby-1.7.16
+script:
+- bundle exec rake
 deploy:
   provider: rubygems
   api_key:

data/Gemfile

@@ -2,6 +2,9 @@ source 'https://rubygems.org'
 
 group :test do
   gem 'rake_rack'
+  gem 'coveralls', require: false
+  gem 'codeclimate-test-reporter', require: false
+  gem 'rubocop'
   gem 'pry'
   gem 'rspec'
   gem 'rake'

data/README.md

@@ -1,6 +1,8 @@
-# Snmpjr
+Snmpjr
+======
+
+[![Gem Version](https://badge.fury.io/rb/snmpjr.svg)](http://badge.fury.io/rb/snmpjr) [![Build Status](https://travis-ci.org/zenonas/snmpjr.svg?branch=master)](https://travis-ci.org/zenonas/snmpjr) [![Coverage Status](https://img.shields.io/coveralls/zenonas/snmpjr.svg)](https://coveralls.io/r/zenonas/snmpjr?branch=master) [![Code Climate](https://codeclimate.com/github/zenonas/snmpjr/badges/gpa.svg)](https://codeclimate.com/github/zenonas/snmpjr) [![Dependency Status](https://gemnasium.com/zenonas/snmpjr.svg)](https://gemnasium.com/zenonas/snmpjr) [![Inline docs](http://inch-ci.org/github/zenonas/snmpjr.svg?branch=master)](http://inch-ci.org/github/zenonas/snmpjr)
 
-[![Build Status](https://travis-ci.org/zenonas/snmpjr.svg?branch=master)](https://travis-ci.org/zenonas/snmpjr)
 Snmpjr aims to provide a clean and simple interface to use SNMP in your ruby code. It will wrap the popular SNMP4J library in Java.
 
 Please note the gem is still in early develpment. Do not use as of yet!
@@ -34,7 +36,7 @@ Or install it yourself as:
 
 ```ruby
 # Initialize Snmpjr with host, port and a community
-snmp = Snmpjr.new(:host => '127.0.0.1', :port => 161, :community => 'public')
+snmp = Snmpjr.new(host: '127.0.0.1', port: 161, community: 'public')
 
 # Call get on any single Oid
 snmp.get '1.3.6.1.2.1.1.1.0'

data/Rakefile

@@ -1,13 +1,16 @@
 require 'rake/clean'
 require 'rake_rack'
+require 'rubocop/rake_task'
 
-@external_dependencies = %w[jruby java]
+@external_dependencies = %w( jruby java )
 
-task :default => [
+RuboCop::RakeTask.new
+
+task default: [
   :clean,
   :"rake_rack:check_external_dependencies",
   :"rake_rack:code_quality:all",
   :"rake_rack:rspec",
   :"rake_rack:coverage:check_specs",
-  :"rake_rack:ok",
+  :"rake_rack:ok"
 ]

data/history.rdoc

@@ -1,3 +1,11 @@
+== 0.1.7 (16 October 2014)
+
+* Fix travis.yml not building tag properly
+
+== 0.1.6 (16 October 2014)
+
+* Allow retries to be specified in the initializer
+
 == 0.1.5 (14 October 2014)
 
 * Allow timeout to be specified in the initializer

data/lib/snmpjr/session.rb

@@ -36,9 +36,9 @@ class Snmpjr
 
     def construct_response variable_binding
       if variable_binding.is_exception
-        Snmpjr::Response.new(:error => variable_binding.variable.to_s)
+        Snmpjr::Response.new(error: variable_binding.variable.to_s)
       else
-        Snmpjr::Response.new(:value => variable_binding.variable.to_s)
+        Snmpjr::Response.new(value: variable_binding.variable.to_s)
       end
     end
 

data/lib/snmpjr/target.rb

@@ -8,8 +8,10 @@ class Snmpjr
       target.community = Snmpjr::Wrappers::SMI::OctetString.new(options.fetch(:community))
       target.address = Snmpjr::Wrappers::SMI::GenericAddress.parse("udp:#{options.fetch(:host)}/#{options.fetch(:port)}")
       target.version = 1
+      target.retries = options.fetch(:retries)
       target.timeout = options.fetch(:timeout)
       target
     end
+
   end
 end

data/lib/snmpjr/version.rb

@@ -1,3 +1,3 @@
 class Snmpjr
-  VERSION = "0.1.5"
+  VERSION = "0.1.7"
 end

data/lib/snmpjr.rb

@@ -6,15 +6,21 @@ class Snmpjr
 
   def initialize options = {}
     @host = options.fetch(:host)
-    @port = options.fetch(:port) || 161
+    @port = options.fetch(:port) { 161 }
     @community = options.fetch(:community)
-    @timeout = options[:timeout] || 5000
-    @max_oids_per_request = options[:max_oids_per_request] || 30
+    @timeout = options.fetch(:timeout) { 5000 }
+    @max_oids_per_request = options.fetch(:max_oids_per_request) { 30 }
+    @retries = options.fetch(:retries) { 0 }
   end
 
   def get oids
-    target = Snmpjr::Target.new.create(:host => @host, :port => @port, :community => @community, :timeout => @timeout)
-    getter = Snmpjr::Getter.new(:target => target, :max_oids_per_request => @max_oids_per_request)
+    target = Snmpjr::Target.new.create(host: @host,
+                                       port: @port,
+                                       community: @community,
+                                       timeout: @timeout,
+                                       retries: @retries
+                                      )
+    getter = Snmpjr::Getter.new(target: target, max_oids_per_request: @max_oids_per_request)
 
     case oids.class.to_s
     when 'String'

data/snmpjr.gemspec

@@ -4,20 +4,19 @@ $LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
 require 'snmpjr/version'
 
 Gem::Specification.new do |spec|
-  spec.name          = "snmpjr"
+  spec.name          = 'snmpjr'
   spec.version       = Snmpjr::VERSION
-  spec.authors       = ["Zen Kyprianou"]
-  spec.email         = ["zen@kyprianou.eu"]
-  spec.summary       = %q{Simple SNMP interface for JRuby}
-  spec.description   = %q{Snmpjr aims to provide a clean and simple interface to use SNMP in your ruby code. It will wrap the popular SNMP4J library in Java.
-}
-  spec.homepage      = "https://github.com/zenonas/snmpjr"
-  spec.license       = "MIT"
+  spec.authors       = ['Zen Kyprianou']
+  spec.email         = ['zen@kyprianou.eu']
+  spec.summary       = 'Simple SNMP interface for JRuby'
+  spec.description   = 'Snmpjr aims to provide a clean and simple interface to use SNMP in your ruby code. It will wrap the popular SNMP4J library in Java.'
+  spec.homepage      = 'https://github.com/zenonas/snmpjr'
+  spec.license       = 'MIT'
 
   spec.files         = `git ls-files -z`.split("\x0")
   spec.executables   = spec.files.grep(%r{^bin/}) { |f| File.basename(f) }
   spec.test_files    = spec.files.grep(%r{^(test|spec|features)/})
-  spec.require_paths = ["lib"]
+  spec.require_paths = ['lib']
 
-  spec.platform      = "java"
+  spec.platform      = 'java'
 end

data/spec/integration/snmpjr_spec.rb

@@ -6,33 +6,33 @@ describe "snmpjr" do
 
   describe 'GET' do
     context 'when the host is reachable' do
-      subject { Snmpjr.new(:host => 'demo.snmplabs.com', :port => 161, :community => 'public') }
+      subject { Snmpjr.new(host: 'demo.snmplabs.com', port: 161, community: 'public') }
 
-      it "can perform a simple synchronous get request on an snmp agent" do
-        expect(subject.get '1.3.6.1.2.1.1.1.0').to eq Snmpjr::Response.new(:value => 'SunOS zeus.snmplabs.com 4.1.3_U1 1 sun4m')
+      it 'can perform a simple synchronous get request on an snmp agent' do
+        expect(subject.get '1.3.6.1.2.1.1.1.0').to eq Snmpjr::Response.new(value: 'SunOS zeus.snmplabs.com 4.1.3_U1 1 sun4m')
       end
 
-      let(:expected) { [Snmpjr::Response.new(:value => 'SunOS zeus.snmplabs.com 4.1.3_U1 1 sun4m'),
-                        Snmpjr::Response.new(:value => 'zeus.snmplabs.com')] }
-      it "can perform a series of gets if passed an array of oids" do
+      let(:expected) { [Snmpjr::Response.new(value: 'SunOS zeus.snmplabs.com 4.1.3_U1 1 sun4m'),
+                        Snmpjr::Response.new(value: 'zeus.snmplabs.com')] }
+      it 'can perform a series of gets if passed an array of oids' do
         expect(subject.get ['1.3.6.1.2.1.1.1.0', '1.3.6.1.2.1.1.5.0']).to eq expected
       end
 
       context "when an invalid oid is requested" do
 
-        let(:expected) { [Snmpjr::Response.new(:error => 'noSuchInstance'),
-                          Snmpjr::Response.new(:value => 'zeus.snmplabs.com')] }
+        let(:expected) { [Snmpjr::Response.new(error: 'noSuchInstance'),
+                          Snmpjr::Response.new(value: 'zeus.snmplabs.com')] }
 
-        it "returns an error" do
+        it 'returns an error' do
           expect(subject.get ['1.3.6.1.2.1.1.5', '1.3.6.1.2.1.1.5.0']).to eq expected
         end
       end
     end
 
     context 'when the host is unreachable' do
-      subject { Snmpjr.new(:host => 'example.com', :port => 161, :community => 'public', :timeout => 50) }
+      subject { Snmpjr.new(host: 'example.com', port: 161, community: 'public', timeout: 50) }
 
-      it "the request times out after 5 seconds" do
+      it 'the request times out after 5 seconds' do
         expect{
           subject.get '1.3.6.1.2.1.1.1.0'
         }.to raise_error(Snmpjr::TargetTimeoutError)

data/spec/snmpjr/getter_spec.rb

@@ -6,7 +6,7 @@ describe Snmpjr::Getter do
   let(:pdu) { double Snmpjr::Pdu }
   let(:created_pdu_single) { double :created_pdu_single }
 
-  subject { described_class.new(:target => target, :max_oids_per_request => 1) }
+  subject { described_class.new(target: target, max_oids_per_request: 1) }
 
   before do
     allow(Snmpjr::Pdu).to receive(:new).and_return pdu
@@ -17,7 +17,7 @@ describe Snmpjr::Getter do
     allow(session).to receive(:close)
   end
 
-  describe "#get_multiple" do
+  describe '#get_multiple' do
     let(:created_pdu_multiple_1) { double :created_pdu_multiple_1 }
     let(:created_pdu_multiple_2) { double :created_pdu_multiple_2 }
 
@@ -45,7 +45,7 @@ describe Snmpjr::Getter do
     end
   end
 
-  describe "#get" do
+  describe '#get' do
     it 'starts an snmp session' do
       subject.get '1.2.3.4.5.6'
       expect(session).to have_received(:start)

data/spec/snmpjr/pdu_spec.rb

@@ -1,7 +1,7 @@
 require production_code
 
 describe Snmpjr::Pdu do
-  describe "#create" do
+  describe '#create' do
 
     let(:pdu) { double Snmpjr::Wrappers::PDU }
     let(:oid_1) { double Snmpjr::Wrappers::SMI::OID }
@@ -18,12 +18,12 @@ describe Snmpjr::Pdu do
       allow(pdu).to receive(:type=)
       allow(pdu).to receive(:add)
     end
-    it "creates a GET Pdu" do
+    it 'creates a GET Pdu' do
       expect(pdu).to receive(:type=).with(Snmpjr::Pdu::Constants::GET)
       subject.create ['1.2.3.4']
     end
 
-    it "adds an SMI variable binding containing an oid to the pdu" do
+    it 'adds an SMI variable binding containing an oid to the pdu' do
       expect(pdu).to receive(:add).with variable_binding_1
       expect(pdu).to receive(:add).with variable_binding_2
       subject.create ['1.2.3.4', '5.6.7.8']

data/spec/snmpjr/response_spec.rb

@@ -5,24 +5,24 @@ describe Snmpjr::Response do
   describe '.new' do
     context 'when initialized with a value' do
       it 'assigns that value' do
-        response = described_class.new(:value => 'Some value')
+        response = described_class.new(value: 'Some value')
         expect(response.to_s).to eq 'Some value'
       end
 
       it 'sets the error to an empty string' do
-        response = described_class.new(:value => 'Some value')
+        response = described_class.new(value: 'Some value')
         expect(response.error).to eq ''
       end
     end
 
     context 'when initialized with an error' do
       it 'assigns that error' do
-        response = described_class.new(:error => 'Some error')
+        response = described_class.new(error: 'Some error')
         expect(response.error).to eq 'Some error'
       end
 
       it 'sets the value to an empty string' do
-        response = described_class.new(:error => 'Some error')
+        response = described_class.new(error: 'Some error')
         expect(response.to_s).to eq ''
       end
     end
@@ -30,28 +30,28 @@ describe Snmpjr::Response do
 
   describe '#error?' do
     it 'returns true if there is an error' do
-      response = described_class.new(:error => 'Some error')
+      response = described_class.new(error: 'Some error')
       expect(response.error?).to be_truthy
     end
 
     it 'returns false if there isnt an error' do
-      response = described_class.new(:value => 'Some value')
+      response = described_class.new(value: 'Some value')
       expect(response.error?).to be_falsey
     end
   end
 
   describe '#==' do
     context 'when the objects are equal' do
-      let(:other) { Snmpjr::Response.new(:value => 'some value') }
+      let(:other) { Snmpjr::Response.new(value: 'some value') }
       it 'returns true' do
-        expect(described_class.new(:value => 'some value')).to eq other
+        expect(described_class.new(value: 'some value')).to eq other
       end
     end
 
     context 'when the objects are not equal' do
-      let(:other) { Snmpjr::Response.new(:error => 'some value') }
+      let(:other) { Snmpjr::Response.new(error: 'some value') }
       it 'returns true' do
-        expect(described_class.new(:error => 'some error')).to_not eq other
+        expect(described_class.new(error: 'some error')).to_not eq other
       end
     end
   end

data/spec/snmpjr/session_spec.rb

@@ -13,21 +13,21 @@ describe Snmpjr::Session do
     allow(snmp_session).to receive(:close)
   end
 
-  describe "#start" do
+  describe '#start' do
 
-    it "opens a new SNMP4J session with Udp transport mapping" do
+    it 'opens a new SNMP4J session with Udp transport mapping' do
       subject.start
       expect(Snmpjr::Wrappers::Snmp).to have_received(:new).with(transport_mapping)
     end
 
-    it "calls the listen method on the Snmp session" do
+    it 'calls the listen method on the Snmp session' do
       subject.start
       expect(snmp_session).to have_received(:listen)
     end
 
   end
 
-  describe "#send" do
+  describe '#send' do
     let(:vb1) { double :vb1 }
     let(:vb2) { double :vb2 }
     let(:results) { [vb1, vb2] }
@@ -44,7 +44,7 @@ describe Snmpjr::Session do
       allow(response).to receive_message_chain('response.variable_bindings').and_return(results)
     end
 
-    it "sends the pdu to the target" do
+    it 'sends the pdu to the target' do
       expect(snmp_session).to receive(:send).with(pdu, target)
       subject.send(pdu, target)
     end
@@ -74,8 +74,8 @@ describe Snmpjr::Session do
     end
   end
 
-  describe "#close" do
-    it "closes the snmp session" do
+  describe '#close' do
+    it 'closes the snmp session' do
       subject.close
       expect(snmp_session).to have_received(:close)
     end

data/spec/snmpjr/target_spec.rb

@@ -2,15 +2,15 @@ require production_code
 
 describe Snmpjr::Target do
 
-  describe "#create" do
-    let(:options) { { :host => '127.0.0.1', :port => 161, :community => 'some_community', :timeout => 50 } }
+  describe '#create' do
+    let(:options) { { host: '127.0.0.1', port: 161, community: 'some_community', timeout: 50, retries: 2 } }
 
-    it "creates an octet string for the community string" do
+    it 'creates an octet string for the community string' do
       expect(Snmpjr::Wrappers::SMI::OctetString).to receive(:new).with(options[:community])
       subject.create(options)
     end
 
-    it "creates an smi address based on the ip and port name" do
+    it 'creates an smi address based on the ip and port name' do
       expect(Snmpjr::Wrappers::SMI::GenericAddress).to receive(:parse).with("udp:127.0.0.1/161")
       subject.create(options)
     end
@@ -23,15 +23,17 @@ describe Snmpjr::Target do
       allow(community_target).to receive(:timeout=)
       allow(community_target).to receive(:community=)
       allow(community_target).to receive(:address=)
+      allow(community_target).to receive(:retries=)
     end
 
-    it "sets the snmp version to v2c and the timeout to 50ms" do
+    it 'sets the snmp version to v2c and the timeout to 50ms' do
       expect(community_target).to receive(:version=).with(1)
       expect(community_target).to receive(:timeout=).with(50)
+      expect(community_target).to receive(:retries=).with(2)
       subject.create(options)
     end
 
-    it "returns the SNMP4J community target" do
+    it 'returns the SNMP4J community target' do
       expect(subject.create(options).class).to eq community_target.class
     end
   end

data/spec/snmpjr_spec.rb

@@ -11,12 +11,12 @@ describe Snmpjr do
       before do
         allow(Snmpjr::Target).to receive(:new).and_return target
         allow(target).to receive(:create).with(agent_details).and_return community_target
-        allow(Snmpjr::Getter).to receive(:new).with(:target => community_target, :max_oids_per_request => 20).and_return getter
+        allow(Snmpjr::Getter).to receive(:new).with(target: community_target, max_oids_per_request: 20).and_return getter
       end
 
-      let(:agent_details) { { :host => '127.0.0.1', :port => 161, :community => 'some_community', :timeout => 50 } }
+      let(:agent_details) { { host: '127.0.0.1', port: 161, community: 'some_community', timeout: 50, retries: 50 } }
 
-      subject { described_class.new(agent_details.merge({:max_oids_per_request => 20})) }
+      subject { described_class.new(agent_details.merge({max_oids_per_request: 20})) }
 
       context 'when passed a single oid' do
         it 'performs a synchronous get' do

data/spec/spec_helper.rb

@@ -1,10 +1,27 @@
 require 'simplecov'
+require 'coveralls'
+require 'codeclimate-test-reporter'
 require 'pry'
 
+CodeClimate::TestReporter.configure do |config|
+  config.logger.level = Logger::WARN
+end
+
+formatters = [
+  SimpleCov::Formatter::HTMLFormatter,
+  Coveralls::SimpleCov::Formatter
+]
+
+if ENV['CODECLIMATE_REPO_TOKEN']
+  formatters << CodeClimate::TestReporter::Formatter
+end
+
+SimpleCov.formatter = SimpleCov::Formatter::MultiFormatter[*formatters]
 SimpleCov.coverage_dir 'log/coverage/rspec'
-SimpleCov.add_filter "spec"
-SimpleCov.add_filter "vendor"
-SimpleCov.start
+SimpleCov.start do
+  add_filter 'vendor'
+  add_filter 'spec'
+end
 
 def production_code
   spec = caller[0][/spec.+\.rb/]

metadata

@@ -1,19 +1,17 @@
 --- !ruby/object:Gem::Specification
 name: snmpjr
 version: !ruby/object:Gem::Version
-  version: 0.1.5
+  version: 0.1.7
 platform: java
 authors:
 - Zen Kyprianou
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-10-14 00:00:00.000000000 Z
+date: 2014-10-16 00:00:00.000000000 Z
 dependencies: []
-description: ! 'Snmpjr aims to provide a clean and simple interface to use SNMP in
-  your ruby code. It will wrap the popular SNMP4J library in Java.
-
-'
+description: Snmpjr aims to provide a clean and simple interface to use SNMP in your
+  ruby code. It will wrap the popular SNMP4J library in Java.
 email:
 - zen@kyprianou.eu
 executables: []
@@ -22,6 +20,7 @@ extra_rdoc_files: []
 files:
 - .gitignore
 - .rspec
+- .rubocop.yml
 - .rvmrc
 - .travis.yml
 - Gemfile