snfoil-policy 1.0.1 → 1.1.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: a6dab1a607349ecc86d023e26ad1d9ba97e96e57318cd129bafef7589b125e1e
-  data.tar.gz: 66fabe2a19f859d6cd50b707987ee34f51e0e85a19abe8fb2e16e880a570f16b
+  metadata.gz: b3899818db44a4cf74b5e3d1e46c5006cb1464fc1e9328df96611416f8018206
+  data.tar.gz: 41a79abc893070478fb79beef63d297c2220daf506a253f15e0a68fb7cf17af5
 SHA512:
-  metadata.gz: 2f4dca9af08516db9b3abfd4075eb568adf576c27da6d2e1a372b93e33a72d9fd0753d07a4700d65f8ef5dc683c1d894e1f48127a46dbcb88ed92e62465f50dd
-  data.tar.gz: 64e48295ab0086b1291ea394e44d93a5859c22a1f9e0c1652621cce81f788734897fd8b254c4c5afbaaaf3dad69003737b8387a01a1c663971aba4fbf87be04b
+  metadata.gz: f5df37cb8eab29844d872b900633322997e5cc38ddf1b08f6bb7b03e63870c7016107525729308f5baf941df8800d18eb2b8b43ab786222621cb552596f88ebc
+  data.tar.gz: 5fa5dab455a1e975851d316c00b08fd95079abd3abac3bc2bd246fffa0f40a788afa508b132cf4407612a81b30304a5afa95170d7d8899c14dceaa68b3ea0490

data/CODE_GOALS.md

@@ -0,0 +1,2 @@
+# Goals
+

data/Gemfile

@@ -4,3 +4,14 @@ source 'https://rubygems.org'
 
 # Specify your gem's dependencies in snfoil-policy.gemspec
 gemspec
+
+group :development, :test do
+  gem 'bundle-audit', '~> 0.1.0'
+  gem 'fasterer', '~> 0.10.0'
+  gem 'pry-byebug', '~> 3.9', platform: :mri
+  gem 'rake', '~> 13.0'
+  gem 'rspec', '~> 3.10'
+  gem 'rubocop', '1.33'
+  gem 'rubocop-performance', '1.14.3'
+  gem 'rubocop-rspec', '2.12.1'
+end

data/lib/snfoil/policy/version.rb

@@ -2,6 +2,6 @@
 
 module SnFoil
   module Policy
-    VERSION = '1.0.1'
+    VERSION = '1.1.0'
   end
 end

data/lib/snfoil/policy.rb

@@ -35,11 +35,6 @@ module SnFoil
       def permission(authorization_type, entity_class = nil, with: nil, &block)
         @snfoil_permissions ||= {}
         @snfoil_permissions[authorization_type] ||= {}
-        if @snfoil_permissions[authorization_type][entity_class]
-          raise SnFoil::Policy::Error,
-                "permission #{entity_class} #{authorization_type} already defined for #{name}"
-        end
-
         @snfoil_permissions[authorization_type][entity_class] = build_permission_exec(with, block)
         define_permission_method(authorization_type)
       end
@@ -47,16 +42,20 @@ module SnFoil
       def inherited(subclass)
         super
 
-        instance_variables.grep(/@snfoil_.+/).each do |i|
-          subclass.instance_variable_set(i, instance_variable_get(i).dup)
+        permissions = instance_variable_get(:@snfoil_permissions) || {}
+        inherited_permissions = {}
+        permissions.each_key do |action|
+          inherited_permissions[action] = permissions[action].dup
         end
+
+        subclass.instance_variable_set(:@snfoil_permissions, inherited_permissions)
       end
     end
 
     attr_reader :record, :entity
     attr_accessor :options
 
-    def initialize(entity, record, options = {})
+    def initialize(entity, record, **options)
       @record = record
       @entity = entity
       @options = options
@@ -70,7 +69,7 @@ module SnFoil
     class Scope
       attr_reader :scope, :entity
 
-      def initialize(scope, entity = nil)
+      def initialize(entity, scope)
         @entity = entity
         @scope = scope
       end

data/snfoil-policy.gemspec

@@ -29,13 +29,4 @@ Gem::Specification.new do |spec|
   spec.require_paths = ['lib']
 
   spec.add_dependency 'activesupport', '>= 5.2.6'
-
-  spec.add_development_dependency 'bundle-audit', '~> 0.1.0'
-  spec.add_development_dependency 'fasterer', '~> 0.10.0'
-  spec.add_development_dependency 'pry-byebug', '~> 3.9'
-  spec.add_development_dependency 'rake', '~> 13.0'
-  spec.add_development_dependency 'rspec', '~> 3.10'
-  spec.add_development_dependency 'rubocop', '1.33'
-  spec.add_development_dependency 'rubocop-performance', '1.14.3'
-  spec.add_development_dependency 'rubocop-rspec', '2.12.1'
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: snfoil-policy
 version: !ruby/object:Gem::Version
-  version: 1.0.1
+  version: 1.1.0
 platform: ruby
 authors:
 - Matthew Howes
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2022-08-08 00:00:00.000000000 Z
+date: 2022-10-05 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
@@ -25,118 +25,6 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: 5.2.6
-- !ruby/object:Gem::Dependency
-  name: bundle-audit
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: 0.1.0
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: 0.1.0
-- !ruby/object:Gem::Dependency
-  name: fasterer
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: 0.10.0
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: 0.10.0
-- !ruby/object:Gem::Dependency
-  name: pry-byebug
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '3.9'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '3.9'
-- !ruby/object:Gem::Dependency
-  name: rake
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '13.0'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '13.0'
-- !ruby/object:Gem::Dependency
-  name: rspec
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '3.10'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '3.10'
-- !ruby/object:Gem::Dependency
-  name: rubocop
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - '='
-      - !ruby/object:Gem::Version
-        version: '1.33'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - '='
-      - !ruby/object:Gem::Version
-        version: '1.33'
-- !ruby/object:Gem::Dependency
-  name: rubocop-performance
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - '='
-      - !ruby/object:Gem::Version
-        version: 1.14.3
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - '='
-      - !ruby/object:Gem::Version
-        version: 1.14.3
-- !ruby/object:Gem::Dependency
-  name: rubocop-rspec
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - '='
-      - !ruby/object:Gem::Version
-        version: 2.12.1
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - '='
-      - !ruby/object:Gem::Version
-        version: 2.12.1
 description: A set of helper functions to build permission files inspired by Pundit.
 email:
 - howeszy@gmail.com
@@ -146,6 +34,7 @@ extensions: []
 extra_rdoc_files: []
 files:
 - CHANGELOG.md
+- CODE_GOALS.md
 - CODE_OF_CONDUCT.md
 - Gemfile
 - LICENSE.txt
@@ -176,7 +65,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.1.6
+rubygems_version: 3.3.7
 signing_key: 
 specification_version: 4
 summary: Pundit Style Permissions Builder