sneaky-save 0.1.0 → 0.1.2

checksums.yaml

@@ -1,7 +1,15 @@
 ---
-SHA1:
-  metadata.gz: 9819547cbb741ef5983b1583f0dba3ea21d5e683
-  data.tar.gz: 14647c2c9aba00d24aacf85167b5982fefb43b06
+!binary "U0hBMQ==":
+  metadata.gz: !binary |-
+    ZjU4Y2NiYjczZmQwNTMxMTk1Y2IzMzRmZTk2MzIwOTFlN2RlNDc3MA==
+  data.tar.gz: !binary |-
+    OWZkMzVhZjE2NjdjY2Q5ZGJiMWZiMDFhYjhmOTI0NmRjNTMwNzBkNA==
 SHA512:
-  metadata.gz: 64abcfe769be6e0e5011c11c45664247f33ed6e7b25e6b5d292e64569b1496b2f58281de78d9035af1b31a76e76ae41dd7d91794c3557bfd513802b9e7fe6e93
-  data.tar.gz: 174ab52ca4496909d2aa2f3fa2cc303836f6282fab665f79c2477bf2212fd21928ee399efcdc66815b509e42d71186b57d99f02d847277926af35c3ea2464eaa
+  metadata.gz: !binary |-
+    ZGY1MzIzN2QyZDlhZDk2ODI0ZWQxMTc2N2MyN2VmMGRkODUzZDAyNGJjY2Fj
+    ZWQ3MzcyMmI1ZDI4ZWNiZDk4ZWViYTM3MjFhZjA2NmQ2MzQ0OTViZjFlNDlk
+    NTU3MDUxMTAwOWEwZTAxYTEzNTgwNTQ1NzZlZjRkOTc2NjFkODg=
+  data.tar.gz: !binary |-
+    Mzg5ZTFjZGNkMTVmM2E4OWYzNTNmMzkyZjMyZjliZWVlMGI0MGY3YzBmN2E1
+    ZGI3ZWJiMmE0MzJkZDUwNTkwYmIyZjU5MzFhMjk1YTJjNDg5M2I3YzFmZjlh
+    YjNlYmViMDRlZTQxZTc4NmM1MGQwNWVmNzIzMTMwZTViNDY5MzM=

data/.travis.yml

@@ -1,9 +1,20 @@
+script: bundle exec rake -t
 language: ruby
 rvm:
-  - "1.9.3"
-  - "2.0.0"
-  - "2.1.2"
+  - "2.2.2"
+  - "2.3.1"
+matrix:
+  include:
+    - rvm: 1.9.3
+      gemfile: gemfiles/rails_3_2
+    - rvm: 2.0.0
+      gemfile: gemfiles/rails_3_2
+    - rvm: 2.1.2
+      gemfile: gemfiles/rails_3_2
+    - rvm: 2.2.0
+      gemfile: gemfiles/rails_3_2
 gemfile:
   - Gemfile
+  - gemfiles/rails_3_2
   - gemfiles/rails_4
-  - gemfiles/rails_3.2
+  - gemfiles/rails_5

data/gemfiles/rails_5

@@ -0,0 +1,7 @@
+source 'http://rubygems.org'
+
+gem 'activerecord', '~> 5.0.0'
+gem 'rake'
+gem 'rspec'
+gem 'sqlite3'
+

data/lib/sneaky-save.rb

@@ -4,8 +4,8 @@
 #++
 module SneakySave
 
-  # Saves record without running callbacks/validations.
-  # Returns true if any record is changed.
+  # Saves the record without running callbacks/validations.
+  # Returns true if the record is changed.
   # @note - Does not reload updated record by default.
   #       - Does not save associated collections.
   #       - Saves only belongs_to relations.
@@ -19,71 +19,84 @@ module SneakySave
     end
   end
 
-  # Saves the record raising an exception if it fails.
+  # Saves record without running callbacks/validations.
+  # @see ActiveRecord::Base#sneaky_save
   # @return [true] if save was successful.
-  # @raise [ActiveRecord::StatementInvalid] if save failed.
+  # @raise [ActiveRecord::StatementInvalid] if saving failed.
   def sneaky_save!
     sneaky_create_or_update
   end
 
   protected
 
-    def sneaky_create_or_update
-      new_record? ? sneaky_create : sneaky_update
-    end
+  def sneaky_create_or_update
+    new_record? ? sneaky_create : sneaky_update
+  end
 
-    # Makes INSERT query in database without running any callbacks
-    # @return [false, true]
-    def sneaky_create
-      if self.id.nil? && sneaky_connection.prefetch_primary_key?(self.class.table_name)
-        self.id = sneaky_connection.next_sequence_value(self.class.sequence_name)
-      end
+  # Performs INSERT query without running any callbacks
+  # @return [false, true]
+  def sneaky_create
+    prefetch_pk_allowed = sneaky_connection.prefetch_primary_key?(self.class.table_name)
 
-      attributes_values = skeaky_attributes_values
+    if id.nil? && prefetch_pk_allowed
+      self.id = sneaky_connection.next_sequence_value(self.class.sequence_name)
+    end
 
-      # Remove the id field for databases like Postgres which will raise an error on id being NULL
-      if self.id.nil? && !sneaky_connection.prefetch_primary_key?(self.class.table_name)
-        attributes_values.reject! { |key,_| key.name == 'id' }
-      end
+    attributes_values = sneaky_attributes_values
 
-      new_id = if attributes_values.empty?
-        self.class.unscoped.insert sneaky_connection.empty_insert_statement_value
-      else
-        self.class.unscoped.insert attributes_values
-      end
+    # Remove the id field for databases like Postgres
+    # which fail with id passed as NULL
+    if id.nil? && !prefetch_pk_allowed
+      attributes_values.reject! { |key, _| key.name == 'id' }
+    end
 
-      @new_record = false
-      !!(self.id ||= new_id)
+    if attributes_values.empty?
+      new_id = self.class.unscoped.insert(sneaky_connection.empty_insert_statement_value)
+    else
+      new_id = self.class.unscoped.insert(attributes_values)
     end
 
-    # Makes update query without running callbacks
-    # @return [false, true]
-    def sneaky_update
+    @new_record = false
+    !!(self.id ||= new_id)
+  end
 
-      # Handle no changes.
-      return true if changes.empty?
+  # Performs update query without running callbacks
+  # @return [false, true]
+  def sneaky_update
+    return true if changes.empty?
 
-      # Here we have changes --> save them.
-      pk = self.class.primary_key
-      original_id = changed_attributes.has_key?(pk) ? changes[pk].first : send(pk)
-      !self.class.where(pk => original_id).update_all(attributes).zero?
+    pk = self.class.primary_key
+    original_id = changed_attributes.key?(pk) ? changes[pk].first : send(pk)
+
+    !self.class.where(pk => original_id).
+      update_all(sneaky_update_fields).zero?
+  end
+
+  def sneaky_attributes_values
+    if sneaky_new_rails?
+      send :arel_attributes_with_values_for_create, attribute_names
+    else
+      send :arel_attributes_values
     end
+  end
 
-    def skeaky_attributes_values
-      if ActiveRecord::VERSION::STRING.split('.').first.to_i > 3
-        send :arel_attributes_with_values_for_create, attribute_names
-      else
-        send :arel_attributes_values
-      end
+  def sneaky_update_fields
+    changes.keys.each_with_object({}) do |field, result|
+      result[field] = read_attribute(field)
     end
+  end
 
-    def sneaky_connection
-      if ActiveRecord::VERSION::STRING.split('.').first.to_i > 3
-        self.class.connection
-      else
-        connection
-      end
+  def sneaky_connection
+    if sneaky_new_rails?
+      self.class.connection
+    else
+      connection
     end
+  end
+
+  def sneaky_new_rails?
+    ActiveRecord::VERSION::STRING.to_i > 3
+  end
 end
 
 ActiveRecord::Base.send :include, SneakySave

data/sneaky-save.gemspec

@@ -2,11 +2,11 @@
 
 Gem::Specification.new do |s|
   s.name = %q{sneaky-save}
-  s.version = '0.1.0'
+  s.version = '0.1.2'
 
-  s.date = %q{2013-12-09}
+  s.date = %q{2016-08-06}
   s.authors = ["Sergei Zinin (einzige)"]
-  s.email = %q{zinin@xakep.ru}
+  s.email = %q{szinin@gmail.com}
   s.homepage = %q{http://github.com/einzige/sneaky-save}
 
   s.licenses = ["MIT"]

data/spec/lib/sneaky_save_spec.rb

@@ -1,88 +1,110 @@
-require 'spec_helper'
+require "spec_helper"
 
 describe SneakySave, use_connection: true do
-  context 'new record' do
-    subject { Fake.new(name: 'test') }
+  context "new record" do
+    subject { Fake.new(name: "test") }
 
-    describe '#sneaky_save' do
-      it 'returns true if everything is good' do
+    describe "#sneaky_save" do
+      it "returns true if everything is good" do
         expect(subject.sneaky_save).to eq(true)
       end
 
-      it 'inserts the new record' do
+      it "inserts the new record" do
         allow(subject).to receive(:sneaky_create).once.and_return(true)
         expect(subject.sneaky_save).to eq(true)
       end
 
-      it 'stores attributes in database' do
-        subject.name = 'test'
+      it "stores attributes in database" do
+        subject.name = "test"
         expect(subject.sneaky_save).to eq(true)
         subject.reload
-        expect(subject.name).to eq('test')
+        expect(subject.name).to eq("test")
       end
 
-      it 'does not call any callback' do
-        Fake.any_instance.should_not_receive :before_save_callback
+      it "does not call any callback" do
+        expect_any_instance_of(Fake).not_to receive(:before_save_callback)
         subject.sneaky_save
       end
 
-      it 'does not call validations' do
+      it "does not call validations" do
         expect_any_instance_of(Fake).to_not receive(:valid?)
         subject.sneaky_save
       end
     end
 
-    describe '#sneaky_save!' do
-      it 'raises an exception when insert fails' do
+    describe "#sneaky_save!" do
+      it "raises an exception when insert fails" do
         subject.name = nil
         expect { subject.sneaky_save! }.to raise_error(ActiveRecord::StatementInvalid)
       end
+
+      context "associations" do
+        let(:belonger) { Belonger.create! }
+
+        it "stores associations" do
+          subject.belonger = belonger
+          subject.sneaky_save!
+          subject.reload
+          expect(subject.belonger_id).to eq(belonger.id)
+        end
+      end
     end
   end
 
-  context 'existing record' do
-    subject { Fake.create! :name => 'test' }
+  context "existing record" do
+    subject { Fake.create!(name: "test") }
 
-    describe '#sneaky_save' do
-      context 'record is not changed' do
-        it 'does nothing' do
-          Fake.should_not_receive(:update_all)
+    describe "#sneaky_save" do
+      context "record is not changed" do
+        it "does nothing" do
+          expect(Fake).not_to receive(:update_all)
           expect(subject.sneaky_save).to eq(true)
         end
       end
 
-      context 'record is changed' do
-        it 'updates attributes' do
-          subject.should_receive(:sneaky_update).once.and_return true
-          subject.name = 'new name'
+      context "record is changed" do
+        it "updates attributes" do
+          expect(subject).to receive(:sneaky_update).once.and_return true
+          subject.name = "new name"
           expect(subject.sneaky_save).to eq(true)
         end
 
-        it 'stores attributes in database' do
-          subject.name = 'new name'
+        it "stores attributes in database" do
+          subject.name = "new name"
           expect(subject.sneaky_save).to eq(true)
           subject.reload
-          expect(subject.name).to eq('new name')
+          expect(subject.name).to eq("new name")
           expect(subject.sneaky_save).to eq(true)
         end
 
-        it 'does not call any callback' do
-          subject.should_not_receive :before_save_callback
+        it "does not call any callback" do
+          expect(subject).not_to receive(:before_save_callback)
           subject.sneaky_save
         end
 
-        it 'does not call validations' do
-          subject.should_not_receive :valid?
+        it "does not call validations" do
+          expect(subject).not_to receive(:valid?)
           subject.sneaky_save
         end
       end
     end
 
-    describe '#sneaky_save!' do
-      it 'raises an exception when update fails' do
+    describe "#sneaky_save!" do
+      it "raises an exception when update fails" do
         subject.name = nil
         expect { subject.sneaky_save! }.to raise_error(ActiveRecord::StatementInvalid)
       end
+
+      context "associations" do
+        let(:belonger) { Belonger.create! }
+
+        it "stores associations" do
+          subject.belonger = belonger
+          subject.sneaky_save!
+          subject.reload
+          expect(subject.belonger_id).to eq(belonger.id)
+        end
+      end
     end
   end
 end

data/spec/spec_helper.rb

@@ -1,23 +1,33 @@
-require 'active_record'
-require 'sqlite3'
-require 'sneaky-save'
+require "active_record"
+require "sqlite3"
+require "sneaky-save"
 
-shared_context 'use connection', use_connection: true do
-  ActiveRecord::Base.establish_connection(adapter: 'sqlite3', database: ':memory:')
+shared_context "use connection", use_connection: true do
+  ActiveRecord::Base.establish_connection(adapter: "sqlite3", database: ":memory:")
 
   ActiveRecord::Schema.define do
-    create_table 'fakes' do |table|
+    create_table "fakes" do |table|
       table.column :name, :string, null: false
+      table.column :belonger_id, :integer
+    end
+
+    create_table "belongers" do |table|
     end
   end
 
+  class Belonger < ActiveRecord::Base
+    has_many :fakes
+  end
+
   class Fake < ActiveRecord::Base
     validates :name, presence: true
 
     before_save :before_save_callback
 
+    belongs_to :belonger
+
     def before_save_callback
-      'BEFORE SAVE CALLED'
+      "BEFORE SAVE CALLED"
     end
   end
 end

metadata

@@ -1,59 +1,60 @@
 --- !ruby/object:Gem::Specification
 name: sneaky-save
 version: !ruby/object:Gem::Version
-  version: 0.1.0
+  version: 0.1.2
 platform: ruby
 authors:
 - Sergei Zinin (einzige)
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-12-09 00:00:00.000000000 Z
+date: 2016-08-06 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activerecord
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - ! '>='
       - !ruby/object:Gem::Version
         version: 3.2.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - ! '>='
       - !ruby/object:Gem::Version
         version: 3.2.0
 - !ruby/object:Gem::Dependency
   name: rspec
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - ! '>='
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - ! '>='
       - !ruby/object:Gem::Version
         version: '0'
 description: ActiveRecord extension. Allows to save record without calling callbacks
   and validations.
-email: zinin@xakep.ru
+email: szinin@gmail.com
 executables: []
 extensions: []
 extra_rdoc_files:
 - README.md
 files:
-- ".gitignore"
-- ".travis.yml"
+- .gitignore
+- .travis.yml
 - Gemfile
 - README.md
 - Rakefile
 - VERSION
-- gemfiles/rails_3.2
+- gemfiles/rails_3_2
 - gemfiles/rails_4
+- gemfiles/rails_5
 - lib/sneaky-save.rb
 - sneaky-save.gemspec
 - spec/lib/sneaky_save_spec.rb
@@ -68,17 +69,17 @@ require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
-  - - ">="
+  - - ! '>='
     - !ruby/object:Gem::Version
       version: '0'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
-  - - ">="
+  - - ! '>='
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.2.2
+rubygems_version: 2.1.5
 signing_key: 
 specification_version: 4
 summary: Allows to save record without calling callbacks and validations.