snapbot 0.4.0 → 0.4.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: fd8932c76924b2ce01335b13174915694258dcd419d5c7da3fe5daa45a7e66c7
-  data.tar.gz: 9aa4282ef7e47c1789b742f28a977c8ea387d526ed0a8b4d524b6e205120d4f1
+  metadata.gz: 3ccc2f9565d40b7b3dd10ffd1f92054e7b718eb28613cdc9336531f35a916204
+  data.tar.gz: 661b49c7b72f6a55736a88fcdafc74e249d6d59c8fcbd115b0fcf6c89442ee51
 SHA512:
-  metadata.gz: 5c3e26e2eedb55db8876619da0c63fb79754b8c584d3ed1cf6599fbc37d8f8174af90f706bf6c5ee34e88e60a4482ab57b438613c04e426992a0f8ab80b13499
-  data.tar.gz: 3153f489921edecb2ca66bb7781911d0ff13e3ce563749773e649cb5a8c1c6229cc67f89cfbdcb96e17e9270cfcdc65ea2a4af7aa10e2cec8f29f6977e397357
+  metadata.gz: d19d016d55b593f14106933bb66926d5d9b18b1b986deabfd644ab7f5c27dddb33cfe1ed6ef50952aea72d833eda570937ae6dac1be41d7519c06f403cba64d2
+  data.tar.gz: 22416a76acec3531aa6487de788068c919e69023d9569237daa7990f3db088fe853a3c0a2594632b0edab29a9ea6013921a5379c24878bc6fd8f3d3e89cf04c1

data/lib/snapbot/diagram/renderer.rb

@@ -1,7 +1,5 @@
 # frozen_string_literal: true
 
-require "open3"
-
 module Snapbot
   module Diagram
     # Render some DOT via Graphviz dot command line

data/lib/snapbot/reflector.rb

@@ -44,6 +44,8 @@ module Snapbot
 
     def add_relationships(instance, set)
       reflect_associations(instance).each do |association|
+        next unless valid_association?(association) # Skip POROs
+
         records = Array(instance.send(association.name)).compact
         records.each do |record|
           set.add(Relationship.new(instance_name(instance), instance_name(record)))
@@ -65,6 +67,18 @@ module Snapbot
 
     private
 
+    # rubocop:disable Style/RescueModifier
+    def valid_association?(association)
+      # AR7.x raises an ArgumentError when the class is a PORO. AR6.x would fall over
+      # later with NoMethodError on `relation_delegate_class`. Either way, we're not
+      # valid if the association.klass is not descended from our `base_activerecord_class`
+      return true if (association.klass rescue ArgumentError) < base_activerecord_class
+
+      warn "#{association.active_record} -> :#{association.name} is not a valid association. " \
+           "Make sure it inherits from #{base_activerecord_class}"
+    end
+    # rubocop:enable Style/RescueModifier
+
     def instance_name(instance)
       "#{instance.model_name}##{instance.id}"
     end

data/lib/snapbot/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Snapbot
-  VERSION = "0.4.0"
+  VERSION = "0.4.1"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: snapbot
 version: !ruby/object:Gem::Version
-  version: 0.4.0
+  version: 0.4.1
 platform: ruby
 authors:
 - Russell Garner
 autorequire:
 bindir: exe
 cert_chain: []
-date: 2022-08-10 00:00:00.000000000 Z
+date: 2022-08-11 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: binding_of_caller