smstraderb 0.0.1 → 0.1.0

data/CHANGES.md

@@ -1,5 +1,8 @@
 smstraderb - ChangeLog
 ======================
+# 0.1.0
+* Ensure escaping of the phone number and the message.
+* The rack server app now provides the call params for inspection.
 
 # 0.0.1
 * Initial release.

data/lib/smstraderb.rb

@@ -27,7 +27,7 @@ class SMSTradeRB
   end
 
   def send(options)
-    @to = options[:to]
+    @to = escape(check_phone_number(options[:to]))
     @message = escape(options[:message])
 
     uri = URI.parse(SMSTradeRB::HTTP_GATEWAY)

data/lib/smstraderb/constants.rb

@@ -1,5 +1,5 @@
 class SMSTradeRB
-  VERSION = '0.0.1'
+  VERSION = '0.1.0'
 
   HTTP_GATEWAY = 'http://gateway.smstrade.de/'
   HTTPS_GATEWAY = 'https://gateway.smstrade.de/'

data/lib/smstraderb/server.rb

@@ -5,6 +5,8 @@ require 'smstraderb/constants'
 
 class SMSTradeRB
   class Server
+    attr_reader :params
+
     def initialize(options = {})
       @options = options
     end
@@ -14,40 +16,40 @@ class SMSTradeRB
     end
 
     def call(env)
-      params = Rack::Request.new(env).params
+      @params = Rack::Request.new(env).params
 
       # The route param is mandatory.
-      unless params['route']
+      unless @params['route']
         return respond_with('40')
       end
 
       # There are only a few valid route values.
-      unless SMSTradeRB::ROUTES.include?(params['route'].to_sym)
+      unless SMSTradeRB::ROUTES.include?(@params['route'].to_sym)
         return respond_with('40')
       end
 
       # The to params is mandatory.
-      unless params['to']
+      unless @params['to']
         return respond_with('10')
       end
 
       # The to params needs to be in a valid format.
-      unless params['to'] =~ /^\+?\d+/
+      unless @params['to'] =~ /^\+?\d+/
         return respond_with('10')
       end
 
       # The key param is mandatory.
-      unless params['key']
+      unless @params['key']
         return respond_with('50')
       end
 
       # The message params is mandatory.
-      unless params['message']
+      unless @params['message']
         return respond_with('30')
       end
 
       # Check if the messagetype is valid.
-      if params['messagetype'] and !SMSTradeRB::MESSAGE_TYPES.include?(params['messagetype'].to_sym)
+      if @params['messagetype'] and !SMSTradeRB::MESSAGE_TYPES.include?(@params['messagetype'].to_sym)
         return respond_with('31')
       end
 
@@ -55,15 +57,15 @@ class SMSTradeRB
       ret = [@options[:code] || 100]
 
       # Some optional parameters which modify the return value.
-      if params['message_id'] == '1'
+      if @params['message_id'] == '1'
         ret[1] = '123456789'
       end
 
-      if params['cost'] == '1'
+      if @params['cost'] == '1'
         ret[2] = '0.055'
       end
 
-      if params['count'] == '1'
+      if @params['count'] == '1'
         ret[3] = '1'
       end
 

data/spec/smstraderb/server_spec.rb

@@ -114,4 +114,16 @@ describe SMSTradeRB::Server do
       end
     end
   end
+
+  describe "call inspection" do
+    it "provides access to the received params" do
+      @rack_app = SMSTradeRB::Server.new
+      def app
+        @rack_app
+      end
+      get '/', @params
+
+      @rack_app.params['message'].should == @params[:message]
+    end
+  end
 end

data/spec/smstraderb_spec.rb

@@ -110,11 +110,31 @@ describe SMSTradeRB do
   end
 
   describe "#send" do
+    it "will encode and sanitize the phone number correctly" do
+      app = SMSTradeRB::Server.new(:code => 999)
+      Artifice.activate_with(app) do
+        sms = SMSTradeRB.new(:route => :basic, :key => 'mykey', :debug => false)
+        sms.send(:to => '+12 34-567', :message => 'my message')
+      end
+
+      app.params['to'].should == '+1234567'
+    end
+
+    it "will encode the message correctly" do
+      app = SMSTradeRB::Server.new(:code => 999)
+      Artifice.activate_with(app) do
+        sms = SMSTradeRB.new(:route => :basic, :key => 'mykey', :debug => false)
+        sms.send(:to => '+12 34-567', :message => 'my message $foo+bar')
+      end
+
+      app.params['to'].should == '+1234567'
+    end
+
     context "success" do
       it "returns a response object" do
         Artifice.activate_with(SMSTradeRB::Server.new(:code => 999)) do
           sms = SMSTradeRB.new(:route => :basic, :key => 'mykey', :debug => false)
-          sms.send(:to => '1234', :message => 'my message').code.should be(999)
+          sms.send(:to => '+1234', :message => 'my message').code.should be(999)
         end
       end
     end

metadata

@@ -1,13 +1,13 @@
 --- !ruby/object:Gem::Specification 
 name: smstraderb
 version: !ruby/object:Gem::Version 
-  hash: 29
+  hash: 27
   prerelease: false
   segments: 
   - 0
-  - 0
   - 1
-  version: 0.0.1
+  - 0
+  version: 0.1.0
 platform: ruby
 authors: 
 - Bernd Ahlers
@@ -15,7 +15,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2010-10-22 00:00:00 +02:00
+date: 2010-10-23 00:00:00 +02:00
 default_executable: 
 dependencies: 
 - !ruby/object:Gem::Dependency