sms_validation 0.0.1 → 0.0.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: d771ba3b06bfaf38dd03b4422c54ca14904d0d0f
-  data.tar.gz: f81fa7011d95d86d6b2ea2a60d91a871b4461cea
+  metadata.gz: b680d0a60c8b323c44c6008c814afc782f6763a7
+  data.tar.gz: 6c78e5f0cff56d2fe3f3b5849adcf7c5601cb726
 SHA512:
-  metadata.gz: 55ef04ab2258fe6af54ace53155e4fc207617e4092a14995152cc72b8303beae6d6c920443917a7c383dd87991e743b8100ed948362060b2c5c273ae548a342b
-  data.tar.gz: 8fcd241178d77fbcc4af945307ff897a11f33313e4100e3f81137d71c9bc1a9ba59695d472965618edf91a546d0c2b1e6e3aa26e28e8ac0fa8391394560c3786
+  metadata.gz: 0028894c60c16c7bb17e031db6114645f404f8db2418f864293b5156a4ce4afd82421ec8f40511452567fa2d0cd143df35b2fe83a963594212cf5139a539a64a
+  data.tar.gz: 901fd4a43d146b3c993b517e367b74331db37d7134c1f747692ecce9a49c49af86bb34495968380c3b726365cb08529124513e7cd5a9ea9cf0e8e789d38e9782

data/lib/sms_validation/sms.rb

@@ -9,6 +9,8 @@ module SmsValidation
     MAX_LENGTH = 160
     MAX_SECTION_LENGTH = MAX_LENGTH - "(MSG XXX/XXX): ".size
     MESSAGE_WHEN_SPLIT_MESSAGE = "This message was split because it is too long to fit into a single SMS.  Instead of #message, use #messages or change SmsValidation.configuration.on_message_too_long to something other than :split"
+    LEGAL_CHARACTERS = "~\`!\"#\$\%&'\(\)*+,-.\/:;<=>?@_£¤¥§¿i¡ÄÅÃÆÇÉÑÖØÜßâáäåãæçèéìíñòöøóùüú\n\r\t ©"
+    ILLEGAL_CHARACTERS = /([^a-zA-Z0-9#{LEGAL_CHARACTERS}\\])/
 
     attr_reader :phone, :messages
 
@@ -18,6 +20,8 @@ module SmsValidation
       raise InvalidPhoneNumberError, "Phone number cannot begin with a \"#{phone[0]}\"" if ['0','1'].include?(phone[0].to_s)
       raise InvalidMessageError, "Message cannot be blank" if message.empty?
       SmsValidation.configuration.logger.warn { "WARNING: Some characters may be lost because the message must be broken into at least 1000 sections" } if message.size > (999 * MAX_SECTION_LENGTH)
+      illegal_characters = message.scan(ILLEGAL_CHARACTERS).to_a
+      raise InvalidMessageError, "Message cannot contain the following special characters: #{illegal_characters.uniq.join(', ')}" unless illegal_characters.size.zero?
       @messages = (message.size > MAX_LENGTH) ? SmsValidation::Sms.__send__(SmsValidation.configuration.on_message_too_long, message) : [message.dup]
       @phone = "1#{phone}"
     end

data/lib/sms_validation/version.rb

@@ -1,3 +1,3 @@
 module SmsValidation
-  VERSION = "0.0.1"
+  VERSION = "0.0.2"
 end

data/spec/sms_spec.rb

@@ -82,6 +82,38 @@ describe SmsValidation::Sms do
       end
     end
 
+    describe "when it contains only legal characters" do
+      described_class::LEGAL_CHARACTERS.each_char do |i|
+        describe "when message contains legal character '#{i}'" do
+          let(:message) { "#{super()}#{i}#{super()}" }
+
+          it { expect(subject.message).to eq(message) }
+        end
+      end
+
+      describe "when message contains legal character '\'" do
+        let(:message) { "#{super()}\A#{super()}" }
+
+        it { expect(subject.message).to eq(message) }
+      end
+    end
+
+    describe "when it contains illegal characters" do
+      ["\u2018", "\u2019", "\u201c", "\u201d"].each do |i|
+        describe "when message contains illegal character '#{i}'" do
+          let(:message) { "#{super()}#{i}#{super()}" }
+
+          it { expect{subject}.to raise_error(SmsValidation::Sms::InvalidMessageError, "Message cannot contain the following special characters: #{i}") }
+        end
+      end
+
+      describe "when message contains multiple illegal characters" do
+        let(:message) { "#{super()}\u2018\u2019\u8888#{super()}" }
+
+        it { expect{subject}.to raise_error(SmsValidation::Sms::InvalidMessageError, "Message cannot contain the following special characters: \u2018, \u2019, \u8888") }
+      end
+    end
+
     describe "when longer than 160 characters" do
       describe "when on_message_too_long = :truncate" do
         let(:on_message_too_long) { :truncate }

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: sms_validation
 version: !ruby/object:Gem::Version
-  version: 0.0.1
+  version: 0.0.2
 platform: ruby
 authors:
 - Isaac Betesh
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-03-11 00:00:00.000000000 Z
+date: 2015-03-27 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -94,7 +94,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.4.3
+rubygems_version: 2.2.2
 signing_key: 
 specification_version: 4
 summary: '# SmsValidation  This gem does not send SMS messages.  It just makes sure