sms_gateway 0.0.2 → 0.1.0

data/README.rdoc

@@ -31,7 +31,7 @@ To deliver SMS asynchronously this gem makes use of resque, a
 popular queing system basd on the key-value data store redis. You need
 to have a working resque and redis setup if you want to use
 the aynchronous feature. For more information on resque visit
-https://github.com/defunkt/resque.
+https://github.com/defunkt/resque .
 
 
 = Usage
@@ -64,10 +64,11 @@ resque documentation):
 
 So far the gem is pretty limited. Ideas for following version are:
 
-* unit tests
-* other sms gateway providers
+* more and better unit tests
+* more sms gateway apis
 * decoupling of resque
 
+
 = License
 
 GPLv3. Copyright 2011 Kai Rubarth.  

data/Rakefile

@@ -1,2 +1,24 @@
 require 'bundler'
+require 'rake/testtask'
+require 'rake/rdoctask'
+
 Bundler::GemHelper.install_tasks
+
+desc 'Run unit tests'
+Rake::TestTask.new(:test) do |test|
+  test.libs << 'lib' << 'test'
+  test.pattern = 'test/**/*_test.rb'
+  test.verbose = true
+end
+
+desc 'Generate Documentation'
+Rake::RDocTask.new(:rdoc) do |rdoc|
+  rdoc.rdoc_dir = 'rdoc'
+  rdoc.title = 'SmsGateway'
+  rdoc.options << '--line-numbers' << '--inline_source'
+  rdoc.rdoc_files.include('README.rdoc')
+  rdoc.rdoc_files.include('lib/**/*.rb')
+end
+
+
+

data/lib/sms_gateway/adapters/sms_global.rb

@@ -6,8 +6,11 @@ module SmsGateway
       require 'httparty'
       include HTTParty
       base_uri 'http://www.smsglobal.com'
+
       def initialize(config={})
-        @config = SmsGateway::Base.config
+        @config = {:user => SmsGateway::Base.user, :password => SmsGateway::Base.password,
+          :from => SmsGateway::Base.from}
+        @config.merge!(config)
       end
 
       def send_sms(sms)

data/lib/sms_gateway/adapters/sms_trade.rb

@@ -0,0 +1,26 @@
+module SmsGateway
+
+  module Adapters
+
+    class SmsTrade
+      require 'httparty'
+      include HTTParty
+      base_uri 'http://gateway.smstrade.de'
+
+      def initialize(config={})
+        @config = {:key => SmsGateway::Base.key, :from => SmsGateway::Base.from, :route => SmsGateway::Base.route}
+        @config.merge!(config)
+      end
+
+      def send_sms(sms)
+        options = @config.merge({:to => sms.to, :message => sms.text}) 
+        self.class.get('/', :query => options)
+      end
+
+    end
+
+  end
+
+end
+
+

data/lib/sms_gateway/base.rb

@@ -3,18 +3,34 @@ module SmsGateway
   class Base
 
     class << self
-      attr_accessor :connection
-      attr_reader :config
+      attr_accessor :from, :user, :password, :key, :route
+      attr_reader :adapter
+
+      def configure
+        yield(self)
+      end
+
+      def adapter=(underscore_name)
+         klassname = underscore_name.split("_").map(&:capitalize).join
+         klass = SmsGateway::Adapters.const_get(klassname)
+         @adapter = klass.new
+      end
+
+      def config
+        @config
+      end
 
       def config=(options)
         @config = options.symbolize_keys 
-        klassname = @config[:adapter].to_s.split("_").map(&:capitalize).join
-        klass = SmsGateway::Adapters.const_get(klassname)
-        self.connection = klass.new
+        adapter = @config.delete(:adapter)
+        @config.each do |k,v|
+          self.send "#{k}=", v
+        end
+        self.adapter = adapter 
       end
 
       def deliver(options)
-        self.connection.send_sms(SmsGateway::Sms.new(options.symbolize_keys))
+        self.adapter.send_sms(SmsGateway::Sms.new(options.symbolize_keys))
       end
 
       def self.deliver_later(text, to, from=Base.config[:from]) 

data/lib/sms_gateway/sms.rb

@@ -4,7 +4,8 @@ module SmsGateway
   class Sms < Struct.new(:from, :to, :text)
 
     def initialize(params)
-      self.from = params[:from]||SmsGateway::Base.config[:from]
+      #self.from = params[:from]||SmsGateway::Base.config[:from]
+      self.from = params[:from]||SmsGateway::Base.from
       self.to = params[:to]
       self.text = params[:text]
     end

data/lib/sms_gateway/version.rb

@@ -1,3 +1,4 @@
 module SmsGateway
-  VERSION = "0.0.2"
+  VERSION = "0.1.0"
 end
+

data/lib/sms_gateway.rb

@@ -4,6 +4,7 @@ require 'rails/generators'
 require 'sms_gateway/base'
 require 'sms_gateway/sms'
 require 'sms_gateway/adapters/sms_global'
+require 'sms_gateway/adapters/sms_trade'
 require 'sms_gateway/adapters/test'
 require 'sms_gateway/jobs/sms_job'
 require 'sms_gateway/generators/install/install_generator'

data/sms_gateway.gemspec

@@ -22,6 +22,8 @@ Gem::Specification.new do |s|
   s.add_dependency('httparty')
   s.add_dependency('resque')
 
+  s.add_development_dependency('webmock')
+
 end
 
 

data/test/configuration_test.rb

@@ -0,0 +1,50 @@
+
+require 'test_helper'
+
+class SmsGateway::ConfigurationTest < Test::Unit::TestCase
+
+  def setup
+     SmsGateway::Base.configure do |config|
+      config.from = '123456789'
+      config.user = 'some_user'
+      config.password = 'secret'
+      config.adapter = 'test' 
+    end
+  end
+
+  def test_parse_user
+    assert_equal 'some_user', SmsGateway::Base.user
+  end
+
+  def test_parse_password
+    assert_equal 'secret', SmsGateway::Base.password
+  end
+
+  def test_parse_from
+    sms = SmsGateway::Sms.new(:text => 'test')
+    assert_equal '123456789', sms.from
+  end
+
+#  def test_parse_adapter
+#    assert_equal SmsGateway::Adapters::Test, SmsGateway::Base.adapter
+#  end
+#
+#  def test_work_config_hash
+#    SmsGateway::Base.config = {
+#      :from => 'new_from',
+#      :user => 'new_user',
+#      :password => 'new_password', 
+#      :adapter => 'sms_global'}
+#    
+#    assert_equal 'new_from', SmsGateway::Base.from
+#    assert_equal 'new_user', SmsGateway::Base.user
+#    assert_equal 'new_password', SmsGateway::Base.password
+#    assert_equal SmsGateway::Adapters::SmsGlobal, SmsGateway::Base.adapter
+#  end
+
+end
+
+
+
+
+

data/test/sms_gateway_test.rb

@@ -0,0 +1,55 @@
+
+require 'test_helper'
+
+class SmsGateway::Adapters::SmsGatewayTest < Test::Unit::TestCase
+  include SmsGateway
+
+  def setup
+  end
+
+  def test_sms_gateway
+
+    SmsGateway::Base.config = { 
+      :from => '493011111111',
+      :user => 'userid',
+      :password => 'secret',
+      :adapter => 'sms_global'
+    }
+
+    stub_request(:post, "http://www.smsglobal.com/http-api.php?action=sendsms&from=493011111111&password=secret&text=hello&to=493088888888&user=userid").
+      to_return(:status => 200, :body => "OK: 0;", :headers => {})
+
+    sms = Sms.new(:to => '493088888888',
+                  :text => "hello")
+
+    sms.deliver
+
+    assert_requested(:post, "http://www.smsglobal.com/http-api.php?action=sendsms&from=493011111111&password=secret&text=hello&to=493088888888&user=userid")
+  end
+
+
+  def test_sms_trade
+
+    SmsGateway::Base.config = {
+      :adapter => 'sms_trade',
+      :route => 'direct',
+      :key => 'KEY',
+      :from => 'SMSTRADE'
+    }
+
+    stub_request(:get, "http://gateway.smstrade.de/?from=SMSTRADE&key=KEY&message=Hello%20World&route=direct&to=491701234567").
+        to_return(:status => 200, :body => "", :headers => {})
+
+    sms = Sms.new(:to => '491701234567', :text => "Hello World")
+
+    sms.deliver
+
+    assert_requested(:get, "http://gateway.smstrade.de/?key=KEY&to=491701234567&message=Hello+World&route=direct&from=SMSTRADE")
+  end
+
+
+end
+
+
+
+

data/test/test_helper.rb

@@ -0,0 +1,11 @@
+
+require 'rubygems'
+require 'test/unit'
+require 'webmock/test_unit'
+
+require 'sms_gateway'
+
+class Test::Unit::TestCase
+end
+
+

metadata

@@ -5,9 +5,9 @@ version: !ruby/object:Gem::Version
   prerelease: 
   segments: 
   - 0
+  - 1
   - 0
-  - 2
-  version: 0.0.2
+  version: 0.1.0
 platform: ruby
 authors: 
 - Kai Rubarth
@@ -15,8 +15,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2011-06-20 00:00:00 -04:00
-default_executable: 
+date: 2012-01-04 00:00:00 Z
 dependencies: 
 - !ruby/object:Gem::Dependency 
   name: httparty
@@ -46,6 +45,20 @@ dependencies:
         version: "0"
   type: :runtime
   version_requirements: *id002
+- !ruby/object:Gem::Dependency 
+  name: webmock
+  prerelease: false
+  requirement: &id003 !ruby/object:Gem::Requirement 
+    none: false
+    requirements: 
+    - - ">="
+      - !ruby/object:Gem::Version 
+        hash: 3
+        segments: 
+        - 0
+        version: "0"
+  type: :development
+  version_requirements: *id003
 description: Provides an interface to SMS Gateways. So far it supports smsglobal.com.
 email: 
 - kai@doxter.de
@@ -62,6 +75,7 @@ files:
 - Rakefile
 - lib/sms_gateway.rb
 - lib/sms_gateway/adapters/sms_global.rb
+- lib/sms_gateway/adapters/sms_trade.rb
 - lib/sms_gateway/adapters/test.rb
 - lib/sms_gateway/base.rb
 - lib/sms_gateway/generators/install/install_generator.rb
@@ -71,7 +85,9 @@ files:
 - lib/sms_gateway/sms.rb
 - lib/sms_gateway/version.rb
 - sms_gateway.gemspec
-has_rdoc: true
+- test/configuration_test.rb
+- test/sms_gateway_test.rb
+- test/test_helper.rb
 homepage: ""
 licenses: []
 
@@ -101,7 +117,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
 requirements: []
 
 rubyforge_project: sms_gateway
-rubygems_version: 1.5.2
+rubygems_version: 1.8.10
 signing_key: 
 specification_version: 3
 summary: Simple and flexible interface to SMS Gateways