sms_broker 1.0.4 → 1.0.5

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: ea414f2b1fa82dce9c8c0d1d3e4ecf6fe3ea992c
-  data.tar.gz: c32329c461796e15dbcc731b41d41663ae2cc144
+  metadata.gz: de0fd0c33b437013e02a4ade7f46121eba90e819
+  data.tar.gz: 12ae1bb6e541bebb950b316102ad90c226513291
 SHA512:
-  metadata.gz: 93756cbd914e72958c4f6b4956582582640627b248d645aab289854a0ea7f8f4aacc08e18779d447584291711ae0a24b7ff600d19ae3e38bb54f1abbd707dcaa
-  data.tar.gz: 99121ad5099a3505d825b2db0b33f184c3197fc97bacb4e793c509a9d06f7dc3d58269ce876e81f52a0fad50c4da87fd451e8b9c74903bcc6f0053f59770c40d
+  metadata.gz: 2b253d6f2cfaabf8d9eeb227bab1ac8038eabeede40091776fb317c1a7423879d4aa74d172e84a625148e89cf8c82bcad0e62ad440925cc05564d50b6e03e8f3
+  data.tar.gz: 75c9a6c6e463d2d98b1893a0b9677c536b3cea8869c1859bba3964cc3822a4639a7a2a34e80aa1dfc823e0453749193ac5b98af69f9ff1c60b07408dd24765de

data/lib/sms_broker/client/response/twilio_error.rb

@@ -2,7 +2,7 @@ module SmsBroker
   module Client
     module Response
       class TwilioError < Error
-        SENDER_ID_NOT_SUPPORTED = '21212'.freeze
+        SENDER_ID_NOT_SUPPORTED = %w(21212 21612).freeze
 
         def initialize(twilio_response)
           super :twilio, twilio_response, serialize(twilio_response)
@@ -23,7 +23,7 @@ module SmsBroker
             response.error_code.to_s => [response.error_message]
           }
 
-          if response.error_code.to_s == SENDER_ID_NOT_SUPPORTED
+          if SENDER_ID_NOT_SUPPORTED.include?(response.error_code.to_s)
             errors['sender_id'] = ['is invalid']
           end
 
@@ -35,7 +35,7 @@ module SmsBroker
             exception.code.to_s => [exception.message]
           }
 
-          if exception.code.to_s == SENDER_ID_NOT_SUPPORTED
+          if SENDER_ID_NOT_SUPPORTED.include?(exception.code.to_s)
             errors['sender_id'] = ['is invalid']
           end
 

data/lib/sms_broker/version.rb

@@ -1,3 +1,3 @@
 module SmsBroker
-  VERSION = '1.0.4'.freeze
+  VERSION = '1.0.5'.freeze
 end

data/spec/sms_broker/twilio_spec.rb

@@ -46,7 +46,7 @@ describe SmsBroker do
             end
           end
 
-          it 'should return error for invalid sender_id' do
+          it 'should return 21212 error for invalid sender_id' do
             VCR.use_cassette('twilio/create_invalid_phone_error') do
               response = send_message(text_message, '15005550006')
 
@@ -59,6 +59,20 @@ describe SmsBroker do
                 include("The 'From' number +15005550001 is not a valid")
             end
           end
+
+          it 'should return 21612 error for invalid sender_id' do
+            VCR.use_cassette('twilio/create_invalid_phone_error_21612') do
+              response = send_message(text_message, '15005550006')
+
+              expect(response.service).to eq(:twilio)
+              expect(response.success?).to eq(false)
+              expect(response.serialized[:errors].keys).to include('21612')
+              # if the code is 21612 and message includes the phone_number,
+              # it means that it tried with sender_id and failed
+              expect(response.serialized[:errors]['21612'][0]).to \
+                include("The 'From' number +15005550001 is not a valid")
+            end
+          end
         end
       end
 

data/spec/support/vcr_cassettes/twilio/create_invalid_phone_error_21612.yml

@@ -0,0 +1,61 @@
+---
+http_interactions:
+- request:
+    method: post
+    uri: https://api.twilio.com/2010-04-01/Accounts/account_sid/Messages.json
+    body:
+      encoding: US-ASCII
+      string: Body=Hello+World&From=%2B15005550001&To=%2B15005550006
+    headers:
+      Accept:
+      - application/json
+      Accept-Charset:
+      - utf-8
+      User-Agent:
+      - twilio-ruby/4.13.0 (ruby/x86_64-darwin16 2.3.0-p0)
+      Accept-Encoding:
+      - gzip;q=1.0,deflate;q=0.6,identity;q=0.3
+      Authorization:
+      - Basic YWNjb3VudF9zaWQ6YXV0aF90b2tlbg==
+      Content-Type:
+      - application/x-www-form-urlencoded
+  response:
+    status:
+      code: 400
+      message: BAD REQUEST
+    headers:
+      Access-Control-Allow-Credentials:
+      - 'true'
+      Access-Control-Allow-Headers:
+      - Accept, Authorization, Content-Type, If-Match, If-Modified-Since, If-None-Match,
+        If-Unmodified-Since
+      Access-Control-Allow-Methods:
+      - GET, POST, DELETE, OPTIONS
+      Access-Control-Allow-Origin:
+      - "*"
+      Access-Control-Expose-Headers:
+      - ETag
+      Content-Type:
+      - application/json; charset=utf-8
+      Date:
+      - Thu, 03 Aug 2017 16:25:30 GMT
+      Twilio-Request-Duration:
+      - '0.005'
+      Twilio-Request-Id:
+      - RQ88fc11c3581341748e3b3a7ec25dd449
+      X-Powered-By:
+      - AT-5000
+      X-Shenanigans:
+      - none
+      Content-Length:
+      - '185'
+      Connection:
+      - keep-alive
+    body:
+      encoding: UTF-8
+      string: '{"code": 21612, "message": "The ''From'' number +15005550001 is not
+        a valid phone number, shortcode, or alphanumeric sender ID.", "more_info":
+        "https://www.twilio.com/docs/errors/21212", "status": 400}'
+    http_version:
+  recorded_at: Thu, 03 Aug 2017 16:25:30 GMT
+recorded_with: VCR 3.0.3

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: sms_broker
 version: !ruby/object:Gem::Version
-  version: 1.0.4
+  version: 1.0.5
 platform: ruby
 authors:
 - Streetbees Dev Team
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-11-24 00:00:00.000000000 Z
+date: 2017-08-03 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: nexmo
@@ -154,6 +154,7 @@ files:
 - spec/spec_helper.rb
 - spec/support/nexmo_helpers.rb
 - spec/support/vcr_cassettes/twilio/create_invalid_phone_error.yml
+- spec/support/vcr_cassettes/twilio/create_invalid_phone_error_21612.yml
 - spec/support/vcr_cassettes/twilio/create_success.yml
 homepage: https://github.com/streetbees/sms_broker
 licenses: []
@@ -174,7 +175,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.4.6
+rubygems_version: 2.6.10
 signing_key: 
 specification_version: 4
 summary: Sms Broker
@@ -188,4 +189,5 @@ test_files:
 - spec/spec_helper.rb
 - spec/support/nexmo_helpers.rb
 - spec/support/vcr_cassettes/twilio/create_invalid_phone_error.yml
+- spec/support/vcr_cassettes/twilio/create_invalid_phone_error_21612.yml
 - spec/support/vcr_cassettes/twilio/create_success.yml