sms_aero 0.0.8 → 0.0.9

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 72e9e51445557fc494d84d9cfce4b5957dfa80fd
-  data.tar.gz: c1a3b3bf2bc3ff692611c22c0673db2af0c61df1
+  metadata.gz: 47495d4e60d1b2a8904d61a84e717e2dd07f45e6
+  data.tar.gz: d4f7bf8b15f966f5aa2995484caaa44a81e006f5
 SHA512:
-  metadata.gz: a9db2d930914402abcd8c62dc42856d85694ae103def4d274c7e58edca6820775b477b60c8edf0c064b398501d9a371fba044bbe955ab5e99aa958382253e2a7
-  data.tar.gz: a18d350f2706ef047a93efddb26c8ec37495184e0eb776328b615427ddb50855a925d5104d495e403070832e4935596dea8154f58f66713fcd8ea0ca4aaaa4ba
+  metadata.gz: 4072ece391ff1ad9f1ebd508b9a89d39c70e6c95f9aecb4a6d85ddf08de1b10da031f5e94ec3a65601cd906199e00e367587ef6a17a288326e86be35a2324704
+  data.tar.gz: 036f412146078b61ec6d1fee915d4a98686de50301938e9c7e7e7b57879e4972365510aff4a805fb7f0fb41e8b672b6c9ebb1a2711075a990de512aa8274f214

data/CHANGELOG.md

@@ -4,12 +4,18 @@ All notable changes to this project will be documented in this file.
 The format is based on [Keep a Changelog](http://keepachangelog.com/)
 and this project adheres to [Semantic Versioning](http://semver.org/).
 
+## [0.0.9] - [2017-06-23]
+
+### Fixed
+- Always add `#success` to answers to `#send_sms` (@nepalez)
+
 ## [0.0.8] - [2017-06-23]
 
 ### Added
 - Weakened dependency from [dry-types], allowing v0.0.9 (@nepalez)
+
   Between v0.9.0 and v0.9.1 an `optional` property has been broken.
-  Starting from sms_aero v1.0 [dry-types] will be removed from dependencies.
 
 [dry-types]: https://github.com/dry-rb/dry-types
-[0.0.8]: https://github.com/tram-rb/tram-policy/compare/v0.0.7...v0.0.8
+[0.0.8]: https://github.com/nepalez/sms_aero/compare/v0.0.7...v0.0.8
+[0.0.9]: https://github.com/nepalez/sms_aero/compare/v0.0.8...v0.0.9

data/lib/sms_aero/operations/send_sms.rb

@@ -12,7 +12,11 @@ class SmsAero
 
     response :success, 200, format: :json, model: Answer do
       attribute :id, proc(&:to_s)
-      attribute :success, default: proc { !id.empty? }
+      attribute :success, default: proc { id != "" }
+    end
+
+    response :failure, 200, format: :json, model: Answer do
+      attribute :success, default: proc { false }
     end
   end
 end

data/sms_aero.gemspec

@@ -1,6 +1,6 @@
 Gem::Specification.new do |gem|
   gem.name     = "sms_aero"
-  gem.version  = "0.0.8"
+  gem.version  = "0.0.9"
   gem.author   = "Andrew Kozin (nepalez)"
   gem.email    = "andrew.kozin@gmail.com"
   gem.homepage = "https://github.com/nepalez/sms_aero"

data/spec/sms_aero/operations/send_sms_spec.rb

@@ -3,6 +3,7 @@ RSpec.describe SmsAero, "#send_sms" do
   let(:client)   { described_class.new(settings) }
   let(:params)   { { text: "Hi", to: "+7 (909) 382-84-45", from: "Qux" } }
   let(:answer)   { { id: 3898, result: "accepted" } }
+  let(:failure)  { { reason: nil, result: "no credits" } }
 
   before  { stub_request(:any, //).to_return(body: answer.to_json) }
   subject { client.send_sms(params) }
@@ -24,11 +25,21 @@ RSpec.describe SmsAero, "#send_sms" do
       expect(a_request(:post, url)).to have_been_made
     end
 
-    it "returns success" do
+    it "returns successful answer" do
       expect(subject).to be_kind_of SmsAero::Answer
       expect(subject.result).to eq "accepted"
+      expect(subject.id).to eq "3898"
       expect(subject.success).to eq true
     end
+
+    context "with a failure:" do
+      before { stub_request(:any, //).to_return(body: failure.to_json) }
+
+      it "returns unsuccessful answer" do
+        expect(subject).to be_kind_of SmsAero::Answer
+        expect(subject.success).to eq false
+      end
+    end
   end
 
   context "via GET:" do

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: sms_aero
 version: !ruby/object:Gem::Version
-  version: 0.0.8
+  version: 0.0.9
 platform: ruby
 authors:
 - Andrew Kozin (nepalez)
@@ -194,7 +194,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.5.2
+rubygems_version: 2.6.4
 signing_key: 
 specification_version: 4
 summary: HTTP(s) client to SMS Aero API