sms_aero 0.0.1 → 0.0.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: fd3453fde3013efda34bdd4eef1de330c07933fc
-  data.tar.gz: 62bb50f526ccfd080df2b399fdefad5aedfbdc15
+  metadata.gz: a8c467f30e3d598212701a014bfd6b9bd0f41848
+  data.tar.gz: 8a4b14ffca904586bae8ebd89bdf306e52e7dc2f
 SHA512:
-  metadata.gz: 6ac5ea53d23db0b146cc6aea6cac0cf4ebad9f0f72715d8b9b085f3bf0d42c299a7d91530fdfd51483ceb35d97700f0df2d232d3b791a01c092ac0390502b044
-  data.tar.gz: a9a944438acf080749852be2fbcb5dedc3e23c79098269d89b8e21d546bfd3d09c20eb1e93b2d28f1c2e176c782f03927c053bd63a5c6691d902dfd442dab477
+  metadata.gz: 148f114d52e5aa557a884789db3359a727dc9514bb6934146464f905b511abce59c780666ae2ee1957a224dbff62487031208ab86b1ba0befc544d083806ec15
+  data.tar.gz: 8998b13c3a1309f3ef6aaaec87e57828f5a28af1c0a8bab79d3bd7aac2f0cecff08922d67dd610f1af04e8053620ff770d813840836062311c907babe338ee25

data/.codeclimate.yml

@@ -4,4 +4,15 @@ engines:
     enabled: true
     checks:
       Rubocop/Style/FrozenStringLiteralComment:
-        enabled: false
+        enabled: false
+      Rubocop/Style/Documentation:
+        enabled: false
+      Rubocop/Style/ClassAndModuleChildren:
+        enabled: false
+      Rubocop/Style/SpaceInLambdaLiteral:
+        enabled: false
+  reek:
+    enabled: true
+ratings:
+  paths:
+    - "lib/**.rb"

data/.gitignore

@@ -7,3 +7,4 @@
 /pkg/
 /spec/reports/
 /tmp/
+*.gem

data/.rubocop.yml

@@ -5,8 +5,27 @@ AllCops:
   StyleGuideCopsOnly: true
   TargetRubyVersion:  2.3
 
+Metrics/LineLength:
+  AllowHeredoc: true
+  AllowURI: true
+  URISchemes:
+    - http
+    - https
+  
 Style/Lambda:
   Enabled: false
 
 Style/StringLiterals:
   EnforcedStyle: double_quotes
+
+Style/FrozenStringLiteralComment:
+  Enabled: false
+
+Style/Documentation:
+  Enabled: false
+
+Style/ClassAndModuleChildren:
+  Enabled: false
+
+Style/SpaceInLambdaLiteral:
+  Enabled: false

data/Gemfile

@@ -8,5 +8,5 @@ group :development, :test do
   gem "pry-byebug", platform: :mri
 end
 
-gem "evil-client",     github: "evilmartians/evil-client", branch: "master"
-gem "dry-initializer", github: "dry-rb/dry-initializer",   branch: "master"
+gem "evil-client",     git: "https://github.com/evilmartians/evil-client"
+gem "dry-initializer", git: "https://github.com/dry-rb/dry-initializer"

data/lib/sms_aero/models/sms.rb

@@ -5,11 +5,11 @@ class SmsAero
     attribute :date,    Types::Future,  optional: true
     attribute :digital, Types::Digital, optional: true
     attribute :type,    Types::Channel, default: -> (*) do
-                                          case digital
-                                          when Dry::Initializer::UNDEFINED
-                                            2
-                                          else Dry::Initializer::UNDEFINED
-                                          end
-                                        end
+                                                   if digital == 1
+                                                     Dry::Initializer::UNDEFINED
+                                                   else
+                                                     2
+                                                   end
+                                                 end
   end
 end

data/lib/sms_aero/types/future.rb

@@ -8,7 +8,7 @@ module SmsAero::Types
       time ||= ::Time.parse(value.to_s) unless value.is_a? Numeric
       number = time.to_i
 
-      (number > ::Time.now.to_i) ? number : raise(error)
+      number > ::Time.now.to_i ? number : raise(error)
     rescue
       raise error
     end

data/lib/sms_aero/types/password.rb

@@ -0,0 +1,5 @@
+module SmsAero::Types
+  Password = Strict::String.constructor do |value|
+               OpenSSL::Digest::MD5.new.hexdigest(value)
+             end
+end

data/lib/sms_aero.rb

@@ -16,13 +16,13 @@ class SmsAero
 
   settings do
     option :user,     Types::FilledString
-    option :password, Types::FilledString
+    option :password, Types::Password
     option :use_ssl,  Types::Form::Bool, default: proc { true }
     option :use_post, Types::Form::Bool, default: proc { true }
   end
 
   base_url do |settings|
-    "http#{"s" if settings.use_ssl}://gate.smsaero.ru/"
+    "http#{'s' if settings.use_ssl}://gate.smsaero.ru/"
   end
 
   operation do |settings|
@@ -30,10 +30,10 @@ class SmsAero
 
     http_method(settings.use_post ? :post : :get)
 
-    security do |user: nil, password: nil, **|
-      key_auth :user,     user     || settings.user,     using: :query
-      key_auth :password, password || settings.password, using: :query
-      key_auth :answer,   "json",                        using: :query
+    security do
+      key_auth :user,     settings.user,     using: :query
+      key_auth :password, settings.password, using: :query
+      key_auth :answer,   "json",            using: :query
     end
 
     responses format: :json do

data/sms_aero.gemspec

@@ -1,6 +1,6 @@
 Gem::Specification.new do |gem|
   gem.name     = "sms_aero"
-  gem.version  = "0.0.1"
+  gem.version  = "0.0.2"
   gem.author   = "Andrew Kozin (nepalez)"
   gem.email    = "andrew.kozin@gmail.com"
   gem.homepage = "https://github.com/nepalez/sms_aero"

data/spec/sms_aero/operations/add_blacklist_spec.rb

@@ -8,12 +8,17 @@ RSpec.describe SmsAero, "#add_blacklist" do
   subject { client.add_blacklist(params) }
 
   context "using ssl via POST:" do
-    let(:host)  { "https://gate.smsaero.ru/addblacklist" }
-    let(:query) { "answer=json&password=PASSWORD&phone=70181324388&user=LOGIN" }
+    let(:url) do
+      "https://gate.smsaero.ru/addblacklist?" \
+      "answer=json&" \
+      "password=319f4d26e3c536b5dd871bb2c52e3178&" \
+      "phone=70181324388&" \
+      "user=LOGIN"
+    end
 
     it "sends a request" do
       subject
-      expect(a_request(:post, "#{host}?#{query}")).to have_been_made
+      expect(a_request(:post, url)).to have_been_made
     end
 
     it "returns success" do
@@ -23,50 +28,36 @@ RSpec.describe SmsAero, "#add_blacklist" do
   end
 
   context "via GET:" do
-    let(:host)  { "https://gate.smsaero.ru/addblacklist" }
-    let(:query) { "answer=json&password=PASSWORD&phone=70181324388&user=LOGIN" }
+    let(:url) do
+      "https://gate.smsaero.ru/addblacklist?" \
+      "answer=json&" \
+      "password=319f4d26e3c536b5dd871bb2c52e3178&" \
+      "phone=70181324388&" \
+      "user=LOGIN"
+    end
 
     before { settings[:use_post] = false }
 
     it "sends a request" do
       subject
-      expect(a_request(:get, "#{host}?#{query}")).to have_been_made
+      expect(a_request(:get, url)).to have_been_made
     end
   end
 
   context "not using ssl:" do
-    let(:host)  { "http://gate.smsaero.ru/addblacklist" }
-    let(:query) { "answer=json&password=PASSWORD&phone=70181324388&user=LOGIN" }
+    let(:url) do
+      "http://gate.smsaero.ru/addblacklist?" \
+      "answer=json&" \
+      "password=319f4d26e3c536b5dd871bb2c52e3178&" \
+      "phone=70181324388&" \
+      "user=LOGIN"
+    end
 
     before { settings[:use_ssl] = false }
 
     it "sends a request via http" do
       subject
-      expect(a_request(:post, "#{host}?#{query}")).to have_been_made
-    end
-  end
-
-  context "with custom user:" do
-    let(:host)  { "https://gate.smsaero.ru/addblacklist" }
-    let(:query) { "answer=json&password=PASSWORD&phone=70181324388&user=USER" }
-
-    before { params[:user] = "USER" }
-
-    it "sends a request" do
-      subject
-      expect(a_request(:post, "#{host}?#{query}")).to have_been_made
-    end
-  end
-
-  context "with custom password:" do
-    let(:host)  { "https://gate.smsaero.ru/addblacklist" }
-    let(:query) { "answer=json&password=PSWD&phone=70181324388&user=LOGIN" }
-
-    before { params[:password] = "PSWD" }
-
-    it "sends a request" do
-      subject
-      expect(a_request(:post, "#{host}?#{query}")).to have_been_made
+      expect(a_request(:post, url)).to have_been_made
     end
   end
 

data/spec/sms_aero/operations/add_group_spec.rb

@@ -8,12 +8,17 @@ RSpec.describe SmsAero, "#add_group" do
   subject { client.add_group(params) }
 
   context "using ssl via POST:" do
-    let(:host)  { "https://gate.smsaero.ru/addgroup" }
-    let(:query) { "answer=json&group=foobar&password=PASSWORD&user=LOGIN" }
+    let(:url) do
+      "https://gate.smsaero.ru/addgroup?" \
+      "answer=json&" \
+      "group=foobar&" \
+      "password=319f4d26e3c536b5dd871bb2c52e3178&" \
+      "user=LOGIN"
+    end
 
     it "sends a request" do
       subject
-      expect(a_request(:post, "#{host}?#{query}")).to have_been_made
+      expect(a_request(:post, url)).to have_been_made
     end
 
     it "returns success" do
@@ -23,50 +28,36 @@ RSpec.describe SmsAero, "#add_group" do
   end
 
   context "via GET:" do
-    let(:host)  { "https://gate.smsaero.ru/addgroup" }
-    let(:query) { "answer=json&group=foobar&password=PASSWORD&user=LOGIN" }
+    let(:url) do
+      "https://gate.smsaero.ru/addgroup?" \
+      "answer=json&" \
+      "group=foobar&" \
+      "password=319f4d26e3c536b5dd871bb2c52e3178&" \
+      "user=LOGIN"
+    end
 
     before { settings[:use_post] = false }
 
     it "sends a request" do
       subject
-      expect(a_request(:get, "#{host}?#{query}")).to have_been_made
+      expect(a_request(:get, url)).to have_been_made
     end
   end
 
   context "not using ssl:" do
-    let(:host)  { "http://gate.smsaero.ru/addgroup" }
-    let(:query) { "answer=json&group=foobar&password=PASSWORD&user=LOGIN" }
-
-    before { settings[:use_ssl] = false }
-
-    it "sends a request" do
-      subject
-      expect(a_request(:post, "#{host}?#{query}")).to have_been_made
-    end
-  end
-
-  context "with custom user:" do
-    let(:host)  { "https://gate.smsaero.ru/addgroup" }
-    let(:query) { "answer=json&group=foobar&password=PASSWORD&user=USER" }
-
-    before { params[:user] = "USER" }
-
-    it "sends a request" do
-      subject
-      expect(a_request(:post, "#{host}?#{query}")).to have_been_made
+    let(:url) do
+      "http://gate.smsaero.ru/addgroup?" \
+      "answer=json&" \
+      "group=foobar&" \
+      "password=319f4d26e3c536b5dd871bb2c52e3178&" \
+      "user=LOGIN"
     end
-  end
-
-  context "with custom password:" do
-    let(:host)  { "https://gate.smsaero.ru/addgroup" }
-    let(:query) { "answer=json&group=foobar&password=PSWD&user=LOGIN" }
 
-    before { params[:password] = "PSWD" }
+    before { settings[:use_ssl] = false }
 
-    it "sends a request" do
-      subject
-      expect(a_request(:post, "#{host}?#{query}")).to have_been_made
+    it "returns success" do
+      expect(subject).to be_kind_of SmsAero::Answer
+      expect(subject.result).to eq "accepted"
     end
   end
 

data/spec/sms_aero/operations/add_phone_spec.rb

@@ -8,12 +8,17 @@ RSpec.describe SmsAero, "#add_phone" do
   subject { client.add_phone(params) }
 
   context "using ssl via POST:" do
-    let(:host)  { "https://gate.smsaero.ru/addphone" }
-    let(:query) { "answer=json&password=PASSWORD&phone=79093828445&user=LOGIN" }
+    let(:url) do
+      "https://gate.smsaero.ru/addphone?" \
+      "answer=json&" \
+      "password=319f4d26e3c536b5dd871bb2c52e3178&" \
+      "phone=79093828445&" \
+      "user=LOGIN"
+    end
 
     it "sends a request" do
       subject
-      expect(a_request(:post, "#{host}?#{query}")).to have_been_made
+      expect(a_request(:post, url)).to have_been_made
     end
 
     it "returns success" do
@@ -23,50 +28,36 @@ RSpec.describe SmsAero, "#add_phone" do
   end
 
   context "via GET:" do
-    let(:host)  { "https://gate.smsaero.ru/addphone" }
-    let(:query) { "answer=json&password=PASSWORD&phone=79093828445&user=LOGIN" }
+    let(:url) do
+      "https://gate.smsaero.ru/addphone?" \
+      "answer=json&" \
+      "password=319f4d26e3c536b5dd871bb2c52e3178&" \
+      "phone=79093828445&" \
+      "user=LOGIN"
+    end
 
     before { settings[:use_post] = false }
 
     it "sends a request" do
       subject
-      expect(a_request(:get, "#{host}?#{query}")).to have_been_made
+      expect(a_request(:get, url)).to have_been_made
     end
   end
 
   context "not using ssl:" do
-    let(:host)  { "http://gate.smsaero.ru/addphone" }
-    let(:query) { "answer=json&password=PASSWORD&phone=79093828445&user=LOGIN" }
-
-    before { settings[:use_ssl] = false }
-
-    it "sends a request" do
-      subject
-      expect(a_request(:post, "#{host}?#{query}")).to have_been_made
+    let(:url) do
+      "http://gate.smsaero.ru/addphone?" \
+      "answer=json&" \
+      "password=319f4d26e3c536b5dd871bb2c52e3178&" \
+      "phone=79093828445&" \
+      "user=LOGIN"
     end
-  end
-
-  context "with custom user:" do
-    let(:host)  { "https://gate.smsaero.ru/addphone" }
-    let(:query) { "answer=json&password=PASSWORD&phone=79093828445&user=USER" }
 
-    before { params[:user] = "USER" }
-
-    it "sends a request" do
-      subject
-      expect(a_request(:post, "#{host}?#{query}")).to have_been_made
-    end
-  end
-
-  context "with custom password:" do
-    let(:host)  { "https://gate.smsaero.ru/addphone" }
-    let(:query) { "answer=json&password=PSWD&phone=79093828445&user=LOGIN" }
-
-    before { params[:password] = "PSWD" }
+    before { settings[:use_ssl] = false }
 
     it "sends a request" do
       subject
-      expect(a_request(:post, "#{host}?#{query}")).to have_been_made
+      expect(a_request(:post, url)).to have_been_made
     end
   end
 
@@ -87,16 +78,20 @@ RSpec.describe SmsAero, "#add_phone" do
   end
 
   context "with valid fname:" do
-    let(:host)  { "https://gate.smsaero.ru/addphone" }
-    let(:query) do
-      "answer=json&fname=joe&password=PASSWORD&phone=79093828445&user=LOGIN"
+    let(:url) do
+      "https://gate.smsaero.ru/addphone?" \
+      "answer=json&" \
+      "fname=joe&" \
+      "password=319f4d26e3c536b5dd871bb2c52e3178&" \
+      "phone=79093828445&" \
+      "user=LOGIN"
     end
 
     before { params[:fname] = "joe" }
 
     it "sends a request" do
       subject
-      expect(a_request(:post, "#{host}?#{query}")).to have_been_made
+      expect(a_request(:post, url)).to have_been_made
     end
   end
 
@@ -109,16 +104,20 @@ RSpec.describe SmsAero, "#add_phone" do
   end
 
   context "with valid sname:" do
-    let(:host)  { "https://gate.smsaero.ru/addphone" }
-    let(:query) do
-      "answer=json&password=PASSWORD&phone=79093828445&sname=joe&user=LOGIN"
+    let(:url) do
+      "https://gate.smsaero.ru/addphone?" \
+      "answer=json&" \
+      "password=319f4d26e3c536b5dd871bb2c52e3178&" \
+      "phone=79093828445&" \
+      "sname=joe&" \
+      "user=LOGIN"
     end
 
     before { params[:sname] = "joe" }
 
     it "sends a request" do
       subject
-      expect(a_request(:post, "#{host}?#{query}")).to have_been_made
+      expect(a_request(:post, url)).to have_been_made
     end
   end
 
@@ -131,16 +130,20 @@ RSpec.describe SmsAero, "#add_phone" do
   end
 
   context "with valid lname:" do
-    let(:host)  { "https://gate.smsaero.ru/addphone" }
-    let(:query) do
-      "answer=json&lname=smith&password=PASSWORD&phone=79093828445&user=LOGIN"
+    let(:url) do
+      "https://gate.smsaero.ru/addphone?" \
+      "answer=json&" \
+      "lname=smith&" \
+      "password=319f4d26e3c536b5dd871bb2c52e3178&" \
+      "phone=79093828445&" \
+      "user=LOGIN"
     end
 
     before { params[:lname] = "smith" }
 
     it "sends a request" do
       subject
-      expect(a_request(:post, "#{host}?#{query}")).to have_been_made
+      expect(a_request(:post, url)).to have_been_made
     end
   end
 
@@ -153,16 +156,20 @@ RSpec.describe SmsAero, "#add_phone" do
   end
 
   context "with valid group:" do
-    let(:host)  { "https://gate.smsaero.ru/addphone" }
-    let(:query) do
-      "answer=json&group=qux&password=PASSWORD&phone=79093828445&user=LOGIN"
+    let(:url) do
+      "https://gate.smsaero.ru/addphone?" \
+      "answer=json&" \
+      "group=qux&" \
+      "password=319f4d26e3c536b5dd871bb2c52e3178&" \
+      "phone=79093828445&" \
+      "user=LOGIN"
     end
 
     before { params[:group] = "qux" }
 
     it "sends a request" do
       subject
-      expect(a_request(:post, "#{host}?#{query}")).to have_been_made
+      expect(a_request(:post, url)).to have_been_made
     end
   end
 
@@ -175,16 +182,20 @@ RSpec.describe SmsAero, "#add_phone" do
   end
 
   context "with valid param:" do
-    let(:host)  { "https://gate.smsaero.ru/addphone" }
-    let(:query) do
-      "answer=json&param=qux&password=PASSWORD&phone=79093828445&user=LOGIN"
+    let(:url) do
+      "https://gate.smsaero.ru/addphone?" \
+      "answer=json&" \
+      "param=qux&" \
+      "password=319f4d26e3c536b5dd871bb2c52e3178&" \
+      "phone=79093828445&" \
+      "user=LOGIN"
     end
 
     before { params[:param] = "qux" }
 
     it "sends a request" do
       subject
-      expect(a_request(:post, "#{host}?#{query}")).to have_been_made
+      expect(a_request(:post, url)).to have_been_made
     end
   end
 
@@ -197,17 +208,20 @@ RSpec.describe SmsAero, "#add_phone" do
   end
 
   context "with valid bday:" do
-    let(:host)  { "https://gate.smsaero.ru/addphone" }
-    let(:query) do
-      "answer=json&bday=1901-08-17&password=PASSWORD&" \
-      "phone=79093828445&user=LOGIN"
+    let(:url) do
+      "https://gate.smsaero.ru/addphone?" \
+      "answer=json&" \
+      "bday=1901-08-17&" \
+      "password=319f4d26e3c536b5dd871bb2c52e3178&" \
+      "phone=79093828445&" \
+      "user=LOGIN"
     end
 
     before { params[:bday] = Date.parse("1901-08-17") }
 
     it "sends a request" do
       subject
-      expect(a_request(:post, "#{host}?#{query}")).to have_been_made
+      expect(a_request(:post, url)).to have_been_made
     end
   end
 

data/spec/sms_aero/operations/check_balance_spec.rb

@@ -8,12 +8,16 @@ RSpec.describe SmsAero, "#check_balance" do
   subject { client.check_balance(params) }
 
   context "using ssl via POST:" do
-    let(:host)  { "https://gate.smsaero.ru/balance" }
-    let(:query) { "answer=json&password=PASSWORD&user=LOGIN" }
+    let(:url) do
+      "https://gate.smsaero.ru/balance?" \
+      "answer=json&" \
+      "password=319f4d26e3c536b5dd871bb2c52e3178&" \
+      "user=LOGIN"
+    end
 
     it "sends a request" do
       subject
-      expect(a_request(:post, "#{host}?#{query}")).to have_been_made
+      expect(a_request(:post, url)).to have_been_made
     end
 
     it "returns success" do
@@ -25,50 +29,34 @@ RSpec.describe SmsAero, "#check_balance" do
   end
 
   context "via GET:" do
-    let(:host)  { "https://gate.smsaero.ru/balance" }
-    let(:query) { "answer=json&password=PASSWORD&user=LOGIN" }
+    let(:url) do
+      "https://gate.smsaero.ru/balance?" \
+      "answer=json&" \
+      "password=319f4d26e3c536b5dd871bb2c52e3178&" \
+      "user=LOGIN"
+    end
 
     before { settings[:use_post] = false }
 
     it "sends a request" do
       subject
-      expect(a_request(:get, "#{host}?#{query}")).to have_been_made
+      expect(a_request(:get, url)).to have_been_made
     end
   end
 
   context "not using ssl:" do
-    let(:host)  { "http://gate.smsaero.ru/balance" }
-    let(:query) { "answer=json&password=PASSWORD&user=LOGIN" }
-
-    before { settings[:use_ssl] = false }
-
-    it "sends a request" do
-      subject
-      expect(a_request(:post, "#{host}?#{query}")).to have_been_made
+    let(:url) do
+      "http://gate.smsaero.ru/balance?" \
+      "answer=json&" \
+      "password=319f4d26e3c536b5dd871bb2c52e3178&" \
+      "user=LOGIN"
     end
-  end
-
-  context "with custom user:" do
-    let(:host)  { "https://gate.smsaero.ru/balance" }
-    let(:query) { "answer=json&password=PASSWORD&user=USER" }
 
-    before { params[:user] = "USER" }
-
-    it "sends a request" do
-      subject
-      expect(a_request(:post, "#{host}?#{query}")).to have_been_made
-    end
-  end
-
-  context "with custom password:" do
-    let(:host)  { "https://gate.smsaero.ru/balance" }
-    let(:query) { "answer=json&password=PSWD&user=LOGIN" }
-
-    before { params[:password] = "PSWD" }
+    before { settings[:use_ssl] = false }
 
     it "sends a request" do
       subject
-      expect(a_request(:post, "#{host}?#{query}")).to have_been_made
+      expect(a_request(:post, url)).to have_been_made
     end
   end
 
@@ -78,7 +66,7 @@ RSpec.describe SmsAero, "#check_balance" do
     it "returns result" do
       expect(subject).to be_kind_of SmsAero::Answer
 
-      expect(subject.result).to  eq "rejected"
+      expect(subject.result).to eq "rejected"
       expect(subject).not_to respond_to :balance
     end
   end