sms-spec 0.1.10 → 0.2.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 2c34ed4c16eee1805f81392619bf8c1600044f83
-  data.tar.gz: 4881f53d715ae43c5133da25cabf156928fa515d
+  metadata.gz: f4449249ef13af22e774a0f860198cb53907ec4d
+  data.tar.gz: 07e35f6581c2d4aac45b6c3bbf557884156b2a0f
 SHA512:
-  metadata.gz: a3474a9046254133ab9bee3782217cf2ec8a7b47e1d34c2512009b72eaf2bf2af2d24373576af5bf38fa788e3bb06ca127775d2675a28f3c8949828ba6c4a6cd
-  data.tar.gz: 1f7792d5316d188d1a6a0c43edd286c238e4e365e68a6f53dc2a113d316e66b72a9df8def6bd7043ee1072d9dff474e657e5150dafaa1e6740308c6e345fabbe
+  metadata.gz: 32944714927b4ae97bee2603704caee2d3661244458f13d4a25053dd2d857ad4d4c0b5f083c3ef71c9de73fd6a8ac9b799a396fc06d411040415506856e64fee
+  data.tar.gz: 03bd0dc1dcabab78dfac20086dbc626ef6f893240a12620a41c929904b48d9272fde876719dec18de58cd388be1ca06e6ef409ee4537b1696508a339dfed5174

data/.gitignore

@@ -2,3 +2,4 @@
 .bundle
 Gemfile.lock
 pkg/*
+.rvmrc

data/.travis.yml

@@ -0,0 +1,14 @@
+language: ruby
+rvm:
+  - 2.2.0
+  - ruby-head
+  - jruby-head
+  - rbx-head
+
+matrix:
+  allow_failures:
+    - rvm: ruby-head
+    - rvm: jruby-head
+    - rvm: rbx-head
+
+script: rake

data/README.markdown

@@ -1,7 +1,7 @@
 # SMS Spec
 
-[![Build Status](https://travis-ci.org/manlycode/sms-spec.svg)](https://travis-ci.org/manlycode/sms-spec)
-[![Code Climate](https://codeclimate.com/github/manlycode/sms-spec/badges/gpa.svg)](https://codeclimate.com/github/manlycode/sms-spec)
+[![Build Status](https://travis-ci.org/rosskevin/sms-spec.svg)](https://travis-ci.org/rosskevin/sms-spec)
+[![Code Climate](https://codeclimate.com/github/rosskevin/sms-spec/badges/gpa.svg)](https://codeclimate.com/github/rosskevin/sms-spec)
 
 An RSpec DSL and Cucumber steps to test SMS interactions with your
 Ruby on Rails application.
@@ -11,17 +11,18 @@ Currently this gem only supports testing SMS messaging using the
 [lookout-clickatell](https://github.com/lookout/clickatell) gem.
 
 ##Setup
-Add the sms-spec gem to your Gemfile:
-<pre>
+Add the sms-spec gem to `Gemfile`:
+
+```ruby
 group :test do
   gem 'sms-spec'
 end
-</pre>
+```
 
 ## RSpec
-In your spec_helper.rb file configure a driver and include helper and matcher methods.
+Configure a driver and include helper and matcher methods in the `spec_helper.rb`:
 
-<pre>
+```ruby
 require 'sms_spec'
 
 Spec::Runner.configure do |config|
@@ -30,19 +31,19 @@ Spec::Runner.configure do |config|
 end
 
 SmsSpec.driver = :twilio-ruby #this can be any available sms-spec driver
-</pre>
+```
 
 ## Cucumber
-Add the folloing to you env.rb file:
+Add the following to `env.rb`:
 
-<pre>
+```ruby
 require 'sms_spec'
 require 'sms_spec/cucumber'
-</pre>
+```
 
 This loads the sms_spec RSpec helpers into your cucumber wold. Then,
 run the following to generate the text_messsage_steps.rb file:
 
-<pre>
+```ruby
 rails generate sms_spec:steps
-</pre>
+```

data/lib/sms_spec/drivers/twilio-ruby.rb

@@ -1,9 +1,37 @@
+require 'twilio-ruby/util/configuration'
+
 module Twilio
+  extend SingleForwardable
+
+  def_delegators :configuration, :account_sid, :auth_token
+
+  ##
+  # Pre-configure with account SID and auth token so that you don't need to
+  # pass them to various initializers each time.
+  def self.configure(&block)
+    yield configuration
+  end
+
+  ##
+  # Returns an existing or instantiates a new configuration object.
+  def self.configuration
+    @configuration ||= Util::Configuration.new
+  end
+  private_class_method :configuration
+
   module REST
     class Client
 
-      def initialize(account_sid, auth_token)
-        $account_sid = account_sid
+      def initialize(*args)
+        # mimic the primary class's #initialize.
+        options = args.last.is_a?(Hash) ? args.pop : {}
+        @config = options #DEFAULTS.merge! options
+
+        @account_sid = args[0] || Twilio.account_sid
+        @auth_token = args[1] || Twilio.auth_token
+        if @account_sid.nil? || @auth_token.nil?
+          raise ArgumentError, 'Account SID and auth token are required'
+        end
       end
 
       class Messages
@@ -29,8 +57,28 @@ module Twilio
 
       def account
         account = Account.new
-        account.class.send(:define_method, :sid, lambda { $account_sid })
-        account
+      end
+
+
+      ## Mirror method_missing approach
+      ##
+      # Delegate account methods from the client. This saves having to call
+      # <tt>client.account</tt> every time for resources on the default
+      # account.
+      def method_missing(method_name, *args, &block)
+        if account.respond_to?(method_name)
+          account.send(method_name, *args, &block)
+        else
+          super
+        end
+      end
+
+      def respond_to?(method_name, include_private=false)
+        if account.respond_to?(method_name, include_private)
+          true
+        else
+          super
+        end
       end
     end
   end

data/lib/sms_spec/version.rb

@@ -1,3 +1,3 @@
 module SmsSpec
-  VERSION = "0.1.10"
+  VERSION = '0.2.0'
 end

data/sms-spec.gemspec

@@ -18,7 +18,7 @@ Gem::Specification.new do |s|
   s.executables   = `git ls-files -- bin/*`.split("\n").map{ |f| File.basename(f) }
   s.require_paths = ["lib"]
 
-  s.add_dependency 'rspec', "~> 2.11"
+  s.add_dependency 'rspec', "~> 3.1"
   s.add_development_dependency "rake"
   s.add_development_dependency "twilio-ruby", "~> 3.0"
   s.add_development_dependency "lookout-clickatell", "~> 0.8"

data/spec/drivers/twilio_spec.rb

@@ -1,63 +1,100 @@
 require 'spec_helper'
 
-describe SmsSpec do
+describe 'twilio-ruby' do
   include SmsSpec::Helpers
+  SmsSpec.driver = :'twilio-ruby'
 
   before :each do
     SmsSpec::Data.clear_messages
   end
 
-  describe "the twilio-ruby driver" do
-    it "is assignable" do
-      SmsSpec.driver = :"twilio-ruby"
+  context 'instantiation options' do
+
+    before :each do
+      @account_sid = 'ACxxxxxxxxxxxxxxxxxxxxxxxxxxxxx'
+      @auth_token = 'yyyyyyyyyyyyyyyyyyyyyyyyyyyyyyy'
+      @client = nil
     end
 
-    it "intercepts calls to twilio's sms client" do
-      account_sid = 'ACxxxxxxxxxxxxxxxxxxxxxxxxxxxxx'
-      auth_token = 'yyyyyyyyyyyyyyyyyyyyyyyyyyyyyyy'
+    it 'with two args' do
+      @client = Twilio::REST::Client.new @account_sid, @auth_token
+      expect(@client).to_not be_nil
+    end
 
-      @client = Twilio::REST::Client.new account_sid, auth_token
-      @client.account.messages.create(
-        :from => '+14159341234',
-        :to => '+16105557069',
-        :body => 'Hey there!'
+    it 'with config' do
+      Twilio.configure do |config|
+        config.account_sid = @account_sid
+        config.auth_token = @auth_token
+      end
+      @client = Twilio::REST::Client.new
+      expect(@client).to_not be_nil
+    end
+  end
+
+
+  context 'using method_missing approach' do
+
+    before do
+      @account_sid = 'ACxxxxxxxxxxxxxxxxxxxxxxxxxxxxx'
+      @auth_token = 'yyyyyyyyyyyyyyyyyyyyyyyyyyyyyyy'
+      Twilio.configure do |config|
+        config.account_sid = @account_sid
+        config.auth_token = @auth_token
+      end
+      @client = Twilio::REST::Client.new
+    end
+
+    it 'intercepts calls to twilio sms client' do
+      @client.messages.create(
+          :from => '+14159341234',
+          :to => '+16105557069',
+          :body => 'Hey there!'
       )
 
-      open_last_text_message_for("+16105557069")
+      open_last_text_message_for('+16105557069')
       expect(current_text_message).to_not be_nil
     end
 
-    it "allows for sid method calls on the account object" do
-      account_sid = 'ACxxxxxxxxxxxxxxxxxxxxxxxxxxxxx'
-      auth_token = 'yyyyyyyyyyyyyyyyyyyyyyyyyyyyyyy'
+    it 'records the from number for a message' do
+      @client.messages.create(
+          :from => '+14159341234',
+          :to => '+16105557069',
+          :body => 'Hey there!'
+      )
+
+      open_last_text_message_for('+16105557069')
+      expect(current_text_message.from).to eq('+14159341234')
+    end
+  end
 
-      @client = Twilio::REST::Client.new account_sid, auth_token
+  context 'using .account.* methods' do
+
+    before do
+      @account_sid = 'ACxxxxxxxxxxxxxxxxxxxxxxxxxxxxx'
+      @auth_token = 'yyyyyyyyyyyyyyyyyyyyyyyyyyyyyyy'
+      @client = Twilio::REST::Client.new @account_sid, @auth_token
+    end
+
+    it 'intercepts calls to twilio sms client' do
       @client.account.messages.create(
-        :from => '+14159341234',
-        :to => '+16105557069',
-        :body => 'Hey there!'
+          :from => '+14159341234',
+          :to => '+16105557069',
+          :body => 'Hey there!'
       )
 
-      open_last_text_message_for("+16105557069")
+      open_last_text_message_for('+16105557069')
       expect(current_text_message).to_not be_nil
-      expect(@client.account).to respond_to(:sid)
-      expect(@client.account.sid).to be(account_sid)
     end
 
-    it "records the from number for a message" do
-      account_sid = 'ACxxxxxxxxxxxxxxxxxxxxxxxxxxxxx'
-      auth_token = 'yyyyyyyyyyyyyyyyyyyyyyyyyyyyyyy'
-
-      @client = Twilio::REST::Client.new account_sid, auth_token
+    it 'records the from number for a message' do
       @client.account.messages.create(
-        :from => '+14159341234',
-        :to => '+16105557069',
-        :body => 'Hey there!'
+          :from => '+14159341234',
+          :to => '+16105557069',
+          :body => 'Hey there!'
       )
 
-      open_last_text_message_for("+16105557069")
+      open_last_text_message_for('+16105557069')
       expect(current_text_message.from).to eq('+14159341234')
     end
-
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: sms-spec
 version: !ruby/object:Gem::Version
-  version: 0.1.10
+  version: 0.2.0
 platform: ruby
 authors:
 - Chris Rittersdorf
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-09-17 00:00:00.000000000 Z
+date: 2016-02-29 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rspec
@@ -16,14 +16,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '2.11'
+        version: '3.1'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '2.11'
+        version: '3.1'
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
@@ -88,7 +88,7 @@ extensions: []
 extra_rdoc_files: []
 files:
 - ".gitignore"
-- ".ruby-version"
+- ".travis.yml"
 - Gemfile
 - Guardfile
 - README.markdown
@@ -135,7 +135,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: sms-spec
-rubygems_version: 2.4.1
+rubygems_version: 2.5.1
 signing_key: 
 specification_version: 4
 summary: Test SMS interactions with RSpec and Cucumber

data/.ruby-version

@@ -1 +0,0 @@
-2.1.2