smooth_operator 1.10.11 → 1.10.13

checksums.yaml

@@ -1,15 +1,15 @@
 ---
 !binary "U0hBMQ==":
   metadata.gz: !binary |-
-    MjkwOGZiOWM3NGYzODQ5MzY0ZGI4OTEwZWNhNWI5MzgyZmE4Y2E4Zg==
+    ZmY5YjcxMjdiMTMzZGM1OTAwNGZhNmY4Mjc4MzRhZGQwNDk0OWY5Mw==
   data.tar.gz: !binary |-
-    NzFiOWZiZWY4N2QwZWFmNzU5ODRhYTcyMjk0NGMwNjg0ODgzNDgxOA==
+    ZGJlMTk3MTAxMWM5MmM1ZGIxNzliZjYxMTBjNjhmNjE3MjczYWRlMQ==
 SHA512:
   metadata.gz: !binary |-
-    YTNiMjUwODdkN2NhMDljMjUxNGZkZTlkMzExMzM1ZTg5NzUyN2ExMzZlYTBk
-    MzE5OGIyZGYyMWZmNWYwOWY4OTU5YjBiNjNjMTE4MzdmMmE1M2Y2MWI3ZTFh
-    Y2I1YmY2YTUxMTZmMmNlOTRlMGU1N2FlNzVjNWVmMmEzYjdiODQ=
+    NzVjN2JlOTI0OTllZDlmYTNlNzkxYjAzODU0NGEyNTQ5ZmY1YTQ1ZjRlYTMy
+    Yzg2YTEwYWM3ZTU1OTJhMDk1M2I0ODk2NWU2M2VlMzY2MDUxMDlkMDU2YTU5
+    MTZmMjgyNjhkZGY0NzdhOTgwYzExNzFhY2VlMTBkYTA1NmFhNWU=
   data.tar.gz: !binary |-
-    MmExYzVkNDQ0YmEyZGJjZGMxYzljOWMwMjJmMjBiMGI3MDE1ZDU5ZjVlOTI0
-    ZDQ4ODA5NWIwZjcxYTY4M2Y0OGI2MzU2OTk5OWUxYzI4NzQ4MDI1YTY4ODNm
-    N2IzMmMzMTU2ODgwNmRiOGYwMjNkNTI3MDlmNDZiY2VkYWM0ZDA=
+    MDUyMGNiMDllZDI5NjExNWEzMzMyYzY4YTQ1MGUzYjU3M2I2M2UwNzM2OTNm
+    YTYwMDAwOWEwMjM2YjViY2JhMDFkNzE4MGU4ODc5OWViMTFiZjFhMmVkZmY3
+    MWZkZjhhYmIzNzQ5N2Q2MjFkNGE5ZTE1NDk5YTM5ODYyOTA4MzE=

data/README.md

@@ -120,7 +120,7 @@ post.save("#{post.id}/save_and_add_to_list", { admin: true, post: { author: 'Age
 ### 2.4) Saving using HTTP Patch verb
 ```ruby
 class Page < MyBlogResource
-  self.save_http_verb = :patch
+  self.update_http_verb = :patch
 end
 
 page = Page.find(2)
@@ -142,23 +142,30 @@ remote_call = Page.find(:all) # Will make a GET call to 'http://myblog.com/api/v
 pages = remote_call.objects # 'pages = remote_call.data' also works
 
 # If the server response is positive (http code between 200 and 299):
-  remote_call.success? # true
-  remote_call.failure? # false
+  remote_call.ok? # true
+  remote_call.not_processed? # false
   remote_call.error? # false
   remote_call.status # true
   pages = remote_call.data # array of Page instances
   remote_call.http_status # server_response code
 
-# If the server response is negative (http code between 400 and 499):
-  remote_call.success? # false
-  remote_call.failure? # true
+# If the server response is unprocessed entity (http code 422):
+  remote_call.ok? # false
+  remote_call.not_processed? # true
   remote_call.error? # false
   remote_call.status # false
   remote_call.http_status # server_response code
 
-# If the server response is an error (http code between 500 and 599), or the connection broke:
-  remote_call.success? # false
-  remote_call.failure? # false
+# If the server response is client error (http code between 400..499, except 422):
+  remote_call.ok? # false
+  remote_call.not_processed? # false
+  remote_call.error? # true
+  remote_call.status # nil
+  remote_call.http_status # server_response code
+
+# If the server response is server error (http code between 500 and 599), or the connection broke:
+  remote_call.ok? # false
+  remote_call.not_processed? # false
   remote_call.error? # true
   remote_call.status # nil
   remote_call.http_status # server_response code or 0 if connection broke

data/lib/smooth_operator/finder_methods.rb

@@ -14,7 +14,7 @@ module SmoothOperator
       returning_object = {}
 
       get(relative_path, data, options).tap do |remote_call|
-        remote_call.object = build_object(remote_call.parsed_response, options) if remote_call.success?
+        remote_call.object = build_object(remote_call.parsed_response, options) if remote_call.ok?
 
         returning_object = remote_call
       end

data/lib/smooth_operator/persistence.rb

@@ -8,35 +8,27 @@ module SmoothOperator
 
     module ClassMethods
 
-      def methods_http_verbs
-        @methods_http_verbs ||= { create: :post, save: :put, destroy: :delete }
+      def methods_vs_http_verbs
+        @methods_vs_http_verbs ||= { reload: :get, create: :post, update: :put, destroy: :delete }
       end
 
-      [:create, :save, :destroy].each do |method|
-        define_method("#{method}_http_verb=") { |http_verb| methods_http_verbs[method] = http_verb }
+      [:reload, :create, :update, :destroy].each do |method|
+        define_method("#{method}_http_verb=") { |http_verb| methods_vs_http_verbs[method] = http_verb }
       end
 
       def create(attributes = nil, relative_path = nil, data = {}, options = {})
-        # if attributes.is_a?(Array)
-        #   attributes.map { |array_entry| create(array_entry, relative_path, data, options) }
-        # else
-          new(attributes).tap { |object| object.save(relative_path, data, options) }
-        # end
+        new(attributes).tap { |object| object.save(relative_path, data, options) }
       end
 
     end
 
 
-    attr_accessor :extra_params
-
     def reload(relative_path = nil, data = {}, options = {})
-      raise 'UnknownPath' if !respond_to?(:id) || Helpers.blank?(id)
-
-      relative_path, options = resource_path(relative_path, options)
+      raise 'UnknownPath' if Helpers.blank?(relative_path) && (!respond_to?(:id) || Helpers.blank?(id))
 
       success = {}
 
-      make_remote_call(:get, relative_path, data, options) do |remote_call|
+      make_the_call(*persistent_method_args(:reload, relative_path, data, options)) do |remote_call|
         success = remote_call.status
       end
 
@@ -70,11 +62,9 @@ module SmoothOperator
     def destroy(relative_path = nil, data = {}, options = {})
       return false unless persisted?
 
-      relative_path, options = resource_path(relative_path, options)
-
       success = {}
 
-      success = make_remote_call(self.class.methods_http_verbs[:destroy], relative_path, data, options) do |remote_call|
+      make_the_call(*persistent_method_args(:destroy, relative_path, data, options)) do |remote_call|
         success = remote_call.status
 
         @destroyed = true if success
@@ -87,13 +77,15 @@ module SmoothOperator
     protected ######################### PROTECTED ##################
 
     def create_or_update(relative_path, data, options)
+      data = data_with_object_attributes(data, options)
+
       new_record? ? create(relative_path, data, options) : update(relative_path, data, options)
     end
 
     def create(relative_path, data, options)
       success = {}
       
-      make_remote_call(self.class.methods_http_verbs[:create], relative_path, data, options) do |remote_call|
+      make_the_call(http_verb_for(:create, options), relative_path, data, options) do |remote_call|
         success = remote_call.status
 
         @new_record = false if success
@@ -103,60 +95,59 @@ module SmoothOperator
     end
 
     def update(relative_path, data, options)
-      relative_path, options = resource_path(relative_path, options)
-      
       success = {}
 
-      make_remote_call(self.class.methods_http_verbs[:save], relative_path, data, options) do |remote_call|
+      make_the_call(*persistent_method_args(:update, relative_path, data, options)) do |remote_call|
         success = remote_call.status
       end
 
       success
     end
 
+    def make_the_call(http_verb, relative_path, data, options)
+      self.class.make_the_call(http_verb, relative_path, data, options) do |remote_call|
+        @last_remote_call = remote_call
+
+        returning_data = @last_remote_call.parsed_response
+
+        if !@last_remote_call.error? && returning_data.is_a?(Hash)
+          assign_attributes returning_data, from_server: true
+        end
+
+        yield(remote_call)
+      end
+    end
+
 
     private ##################### PRIVATE ####################
 
-    def resource_path(relative_path, options)
+    def persistent_method_args(method, relative_path, data, options)
+      options ||= {}
+
       if Helpers.blank?(relative_path)
         if parent_object.nil? || options[:ignore_parent] == true
           relative_path = id.to_s
         else
-          options ||= {}
           options[:table_name] = ''
           relative_path = "#{parent_object.table_name}/#{parent_object.id}/#{table_name}/#{id}"
         end
       end
 
-      [relative_path, options]
+      [http_verb_for(method, options), relative_path, data, options]
     end
 
-    def make_remote_call(http_verb, relative_path, data, options)
-      data ||= {}
-      data.merge!(extra_params || {})
-
-      data, options = build_remote_call_args(http_verb, data, options)
-
-      self.class.make_the_call(http_verb, relative_path, data, options) do |remote_call|
-        @last_remote_call = remote_call
-
-        returning_data = @last_remote_call.parsed_response
-
-        if !@last_remote_call.error? && returning_data.is_a?(Hash)
-          assign_attributes returning_data, from_server: true
-        end
-
-        yield(remote_call)
-      end
+    def http_verb_for(method, options)
+      options[:http_verb] || self.class.methods_vs_http_verbs[method]
     end
 
-    def build_remote_call_args(http_verb, data, options)
-      return [data, options] if http_verb == :delete
+    def data_with_object_attributes(data, options)
+      data = Helpers.stringify_keys(data)
 
       hash = serializable_hash(options[:serializable_options]).dup
+
       hash.delete('id')
 
-      [{ model_name => hash }.merge(data), options]
+      { model_name => hash }.merge(data)
     end
 
   end

data/lib/smooth_operator/remote_call/base.rb

@@ -15,36 +15,31 @@ module SmoothOperator
       end
 
 
-      def success?
+      def ok?
         http_status.between?(200, 299) || http_status == 304
       end
 
-      alias :ok? :success?
-
-      def not_success?
-        !success?
+      def not_processed?
+        http_status == 422
       end
 
-      alias :not_ok? :not_success?
+      def error?
+        !ok? && !not_processed?
+      end
 
-      def failure?
+      def client_error?
         http_status.between?(400, 499)
       end
 
-      alias :failed? :failure?
-
-      def error?
+      def server_error?
         http_status.between?(500, 599) || http_status == 0
       end
 
+
       def not_found?
         http_status == 404
       end
 
-      def not_processed?
-        http_status == 422
-      end
-
       def timeout?
         false
       end
@@ -53,6 +48,7 @@ module SmoothOperator
         false
       end
 
+
       def parsed_response
         return nil if body.nil?
         
@@ -66,11 +62,7 @@ module SmoothOperator
       end
 
       def status
-        return nil if error?
-        
-        return true if success?
-
-        not_processed? ? false : nil
+        error? ? nil : ok?
       end
 
       def objects

data/lib/smooth_operator/version.rb

@@ -1,3 +1,3 @@
 module SmoothOperator
-  VERSION = "1.10.11"
+  VERSION = "1.10.13"
 end

data/spec/smooth_operator/finder_methods_spec.rb

@@ -19,8 +19,21 @@ describe SmoothOperator::FinderMethods do
   subject { UserWithAddressAndPosts::Son }
 
   describe ".all" do
-    xit "should can .find(:all) with the same arguments that it as received" do
-      
+    context "when NO arguments are passed" do
+      it "it should can .find(:all, {}, {})" do
+        expect(subject).to receive(:find).with(:all, {}, {})
+        subject.all
+      end
+    end
+
+    context "when arguments are passed" do
+      it "it should can .find(:all) with the same arguments that .alll has received" do
+        arguments = [{ id: 2 }, { http_verb: 'head' }]
+
+        expect(subject).to receive(:find).with(:all, *arguments)
+
+        subject.all(*arguments)
+      end
     end
   end
 

data/spec/smooth_operator/persistence_spec.rb

@@ -24,7 +24,7 @@ shared_examples_for "persistent remote call" do
 
     it "it should return true" do
       execute_method
-      expect(subject.last_remote_call.success?).to be true
+      expect(subject.last_remote_call.ok?).to be true
       expect(subject.last_remote_call.status).to be true
     end
 
@@ -36,12 +36,12 @@ shared_examples_for "persistent remote call" do
     it_behaves_like "successful persistent remote call"
   end
 
-  context "when the response is negative" do
+  context "when the response is unprocessed_entity" do
     let(:method_arguments) { ['', { status: 422 }] }
 
     it "it should return false" do
       execute_method
-      expect(subject.last_remote_call.failure?).to be true
+      expect(subject.last_remote_call.not_processed?).to be true
       expect(subject.last_remote_call.status).to be false
     end
 
@@ -53,11 +53,28 @@ shared_examples_for "persistent remote call" do
     it_behaves_like "successful persistent remote call"
   end
 
+  context "when the response is client side error" do
+    let(:method_arguments) { ['', { status: 404 }] }
+
+    it "it should return nil" do
+      execute_method
+      expect(subject.last_remote_call.client_error?).to be true
+      expect(subject.last_remote_call.error?).to be true
+      expect(subject.last_remote_call.status).to be nil
+    end
+
+    it "it should assert the subject's persistence" do
+      execute_method
+      expect(subject.persisted?).to be(persistence_state[500])
+    end
+  end
+
   context "when the there is a connection error ou http 500" do
     let(:method_arguments) { ['', { status: 500 }] }
 
     it "it should return nil" do
       execute_method
+      expect(subject.last_remote_call.server_error?).to be true
       expect(subject.last_remote_call.error?).to be true
       expect(subject.last_remote_call.status).to be_nil
     end
@@ -87,11 +104,28 @@ shared_examples_for "save method" do
   end
 end
 
+shared_examples_for "a method that calls the #make_the_call method" do
+  let(:method_arguments) { ['custom_path', { "user" => { "first_name" => "nhoJ" }, "extra_params" => 'extra_params' }, { option1: 'option1', option2: 'option2', http_verb: :get, serializable_options: { only: [:first_name] } }] }
+
+  it "it should pass all arguments to #make_the_call" do
+    expect(subject).to receive(:make_the_call).with(:get, *method_arguments)
+
+    execute_method
+  end
+
+  it "it should pass all arguments to .make_the_call" do
+    expect(subject.class).to receive(:make_the_call).with(:get, *method_arguments)
+
+    execute_method
+  end
+end
+
 
 describe SmoothOperator::Persistence, helpers: :persistence do
 
   describe "#reload", current: true do
     subject { new_user }
+    let(:method_to_execute) { :reload }
 
     context "before calling #reload" do
       it "#has_data_from_server and #from_server should return false" do
@@ -149,6 +183,8 @@ describe SmoothOperator::Persistence, helpers: :persistence do
       end
 
     end
+
+    it_behaves_like "a method that calls the #make_the_call method"
   end
 
   describe ".create" do
@@ -281,14 +317,16 @@ describe SmoothOperator::Persistence, helpers: :persistence do
       subject { new_user }
       let(:persistence_state) { { 200 => true, 422 => false, 500 => false } }
 
-      it_behaves_like "persistent remote call"
-
       it "it should make a post http call" do
         execute_method
         expect(subject.last_remote_call.parsed_response['http_verb']).to eq('post')
       end
 
       it_behaves_like "save method"
+
+      it_behaves_like "persistent remote call"
+
+      it_behaves_like "a method that calls the #make_the_call method"
     end
 
     context "when an instance IS persisted" do
@@ -296,31 +334,34 @@ describe SmoothOperator::Persistence, helpers: :persistence do
         subject { existing_user }
         let(:persistence_state) { { 200 => true, 422 => true, 500 => true } }
 
-        it_behaves_like "persistent remote call"
-
         it "it should make a put http call" do
           execute_method
           expect(subject.last_remote_call.parsed_response['http_verb']).to eq('put')
         end
 
         it_behaves_like "save method"
+
+        it_behaves_like "persistent remote call"
+
+        it_behaves_like "a method that calls the #make_the_call method"
       end
 
       context "and it uses 'patch' http verb to save" do
         subject { existing_user_with_patch }
         let(:persistence_state) { { 200 => true, 422 => true, 500 => true } }
 
-        it_behaves_like "persistent remote call"
-
         it "it should make a patch http call" do
           execute_method
           expect(subject.last_remote_call.parsed_response['http_verb']).to eq('patch')
         end
 
         it_behaves_like "save method"
+
+        it_behaves_like "persistent remote call"
+
+        it_behaves_like "a method that calls the #make_the_call method"
       end
     end
-
   end
 
   describe "#save!" do
@@ -362,12 +403,14 @@ describe SmoothOperator::Persistence, helpers: :persistence do
       subject { existing_user }
       let(:persistence_state) { { 200 => false, 422 => true, 500 => true } }
 
-      it_behaves_like "persistent remote call"
-
       it "it should make a delete http call" do
         execute_method
         expect(subject.last_remote_call.parsed_response['http_verb']).to eq('delete')
       end
+
+      it_behaves_like "persistent remote call"
+
+      it_behaves_like "a method that calls the #make_the_call method"
     end
 
   end

data/spec/smooth_operator/remote_call_spec.rb

@@ -1,17 +1,25 @@
 require "spec_helper"
 
-describe SmoothOperator::RemoteCall, current: true do
+describe SmoothOperator::RemoteCall do
   subject { UserWithAddressAndPosts::Son.new(attributes_for(:user_with_address_and_posts)) }
 
   context "when the server response has a http code in the 200 range" do
     before { subject.save(nil, { status: 200 }) }
 
-    it "#success? should return true" do
-      expect(subject.last_remote_call.success?).to be true
+    it "#ok? should return true" do
+      expect(subject.last_remote_call.ok?).to be true
     end
 
-    it "#failure? should return false" do
-      expect(subject.last_remote_call.failure?).to be false
+    it "#not_processed? should return false" do
+      expect(subject.last_remote_call.not_processed?).to be false
+    end
+
+    it "#client_error? should return false" do
+      expect(subject.last_remote_call.client_error?).to be false
+    end
+
+    it "#server_error? should return false" do
+      expect(subject.last_remote_call.server_error?).to be false
     end
 
     it "#error? should return false" do
@@ -22,10 +30,6 @@ describe SmoothOperator::RemoteCall, current: true do
       expect(subject.last_remote_call.not_found?).to be false
     end
 
-    it "#not_processed? should return false" do
-      expect(subject.last_remote_call.not_processed?).to be false
-    end
-
     it "#timeout? should return false" do
       expect(subject.last_remote_call.timeout?).to be false
     end
@@ -39,27 +43,31 @@ describe SmoothOperator::RemoteCall, current: true do
     end
   end
 
-  context "when the server response has a http code in the 400 range" do
+  context "when the server response has a http code in the 400 range (not 422, 404)" do
     before { subject.save(nil, { status: 400 }) }
 
-    it "#success? should return false" do
-      expect(subject.last_remote_call.success?).to be false
+    it "#ok? should return false" do
+      expect(subject.last_remote_call.ok?).to be false
     end
 
-    it "#failure? should return true" do
-      expect(subject.last_remote_call.failure?).to be true
+    it "#not_processed? should return false" do
+      expect(subject.last_remote_call.not_processed?).to be false
     end
 
-    it "#error? should return false" do
-      expect(subject.last_remote_call.error?).to be false
+    it "#client_error? should return true" do
+      expect(subject.last_remote_call.client_error?).to be true
     end
 
-    it "#not_found? should return false" do
-      expect(subject.last_remote_call.not_found?).to be false
+    it "#server_error? should return false" do
+      expect(subject.last_remote_call.server_error?).to be false
     end
 
-    it "#not_processed? should return false" do
-      expect(subject.last_remote_call.not_processed?).to be false
+    it "#error? should return true" do
+      expect(subject.last_remote_call.error?).to be true
+    end
+
+    it "#not_found? should return false" do
+      expect(subject.last_remote_call.not_found?).to be false
     end
 
     it "#timeout? should return false" do
@@ -78,24 +86,28 @@ describe SmoothOperator::RemoteCall, current: true do
   context "when the server response has a http is 404" do
     before { subject.save(nil, { status: 404 }) }
 
-    it "#success? should return false" do
-      expect(subject.last_remote_call.success?).to be false
+    it "#ok? should return false" do
+      expect(subject.last_remote_call.ok?).to be false
     end
 
-    it "#failure? should return true" do
-      expect(subject.last_remote_call.failure?).to be true
+    it "#not_processed? should return false" do
+      expect(subject.last_remote_call.not_processed?).to be false
     end
 
-    it "#error? should return false" do
-      expect(subject.last_remote_call.error?).to be false
+    it "#client_error? should return true" do
+      expect(subject.last_remote_call.client_error?).to be true
     end
 
-    it "#not_found? should return true" do
-      expect(subject.last_remote_call.not_found?).to be true
+    it "#server_error? should return false" do
+      expect(subject.last_remote_call.server_error?).to be false
     end
 
-    it "#not_processed? should return false" do
-      expect(subject.last_remote_call.not_processed?).to be false
+    it "#error? should return true" do
+      expect(subject.last_remote_call.error?).to be true
+    end
+
+    it "#not_found? should return true" do
+      expect(subject.last_remote_call.not_found?).to be true
     end
 
     it "#timeout? should return false" do
@@ -114,12 +126,20 @@ describe SmoothOperator::RemoteCall, current: true do
   context "when the server response has a http is 422" do
     before { subject.save(nil, { status: 422 }) }
 
-    it "#success? should return false" do
-      expect(subject.last_remote_call.success?).to be false
+    it "#ok? should return false" do
+      expect(subject.last_remote_call.ok?).to be false
+    end
+
+    it "#not_processed? should return true" do
+      expect(subject.last_remote_call.not_processed?).to be true
+    end
+
+    it "#client_error? should return true" do
+      expect(subject.last_remote_call.client_error?).to be true
     end
 
-    it "#failure? should return true" do
-      expect(subject.last_remote_call.failure?).to be true
+    it "#server_error? should return false" do
+      expect(subject.last_remote_call.server_error?).to be false
     end
 
     it "#error? should return false" do
@@ -130,10 +150,6 @@ describe SmoothOperator::RemoteCall, current: true do
       expect(subject.last_remote_call.not_found?).to be false
     end
 
-    it "#not_processed? should return true" do
-      expect(subject.last_remote_call.not_processed?).to be true
-    end
-
     it "#timeout? should return false" do
       expect(subject.last_remote_call.timeout?).to be false
     end
@@ -150,12 +166,20 @@ describe SmoothOperator::RemoteCall, current: true do
   context "when the server response has a http code in the 500 range" do
     before { subject.save(nil, { status: 500 }) }
 
-    it "#success? should return false" do
-      expect(subject.last_remote_call.success?).to be false
+    it "#ok? should return false" do
+      expect(subject.last_remote_call.ok?).to be false
+    end
+
+    it "#not_processed? should return false" do
+      expect(subject.last_remote_call.not_processed?).to be false
+    end
+
+    it "#client_error? should return false" do
+      expect(subject.last_remote_call.client_error?).to be false
     end
 
-    it "#failure? should return false" do
-      expect(subject.last_remote_call.failure?).to be false
+    it "#server_error? should return true" do
+      expect(subject.last_remote_call.server_error?).to be true
     end
 
     it "#error? should return true" do
@@ -166,10 +190,6 @@ describe SmoothOperator::RemoteCall, current: true do
       expect(subject.last_remote_call.not_found?).to be false
     end
 
-    it "#not_processed? should return false" do
-      expect(subject.last_remote_call.not_processed?).to be false
-    end
-
     it "#timeout? should return false" do
       expect(subject.last_remote_call.timeout?).to be false
     end
@@ -188,12 +208,20 @@ describe SmoothOperator::RemoteCall, current: true do
 
     before { subject.save }
 
-    it "#success? should return false" do
-      expect(subject.last_remote_call.success?).to be false
+    it "#ok? should return false" do
+      expect(subject.last_remote_call.ok?).to be false
     end
 
-    it "#failure? should return false" do
-      expect(subject.last_remote_call.failure?).to be false
+    it "#not_processed? should return false" do
+      expect(subject.last_remote_call.not_processed?).to be false
+    end
+
+    it "#client_error? should return false" do
+      expect(subject.last_remote_call.client_error?).to be false
+    end
+
+    it "#server_error? should return true" do
+      expect(subject.last_remote_call.server_error?).to be true
     end
 
     it "#error? should return true" do
@@ -204,10 +232,6 @@ describe SmoothOperator::RemoteCall, current: true do
       expect(subject.last_remote_call.not_found?).to be false
     end
 
-    it "#not_processed? should return false" do
-      expect(subject.last_remote_call.not_processed?).to be false
-    end
-
     it "#timeout? should return false" do
       expect(subject.last_remote_call.timeout?).to be false
     end
@@ -226,12 +250,20 @@ describe SmoothOperator::RemoteCall, current: true do
     
     before { subject.save('timeout') }
 
-    it "#success? should return false" do
-      expect(subject.last_remote_call.success?).to be false
+    it "#ok? should return false" do
+      expect(subject.last_remote_call.ok?).to be false
     end
 
-    it "#failure? should return false" do
-      expect(subject.last_remote_call.failure?).to be false
+    it "#not_processed? should return false" do
+      expect(subject.last_remote_call.not_processed?).to be false
+    end
+
+    it "#client_error? should return false" do
+      expect(subject.last_remote_call.client_error?).to be false
+    end
+
+    it "#server_error? should return true" do
+      expect(subject.last_remote_call.server_error?).to be true
     end
 
     it "#error? should return true" do
@@ -242,10 +274,6 @@ describe SmoothOperator::RemoteCall, current: true do
       expect(subject.last_remote_call.not_found?).to be false
     end
 
-    it "#not_processed? should return false" do
-      expect(subject.last_remote_call.not_processed?).to be false
-    end
-
     it "#timeout? should return true" do
       expect(subject.last_remote_call.timeout?).to be true
     end

data/spec/support/models/user_with_address_and_posts.rb

@@ -27,7 +27,7 @@ module UserWithAddressAndPosts
 
     self.table_name = 'users'
 
-    self.save_http_verb = :patch
+    self.update_http_verb = :patch
 
   end
   

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: smooth_operator
 version: !ruby/object:Gem::Version
-  version: 1.10.11
+  version: 1.10.13
 platform: ruby
 authors:
 - João Gonçalves
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-05-09 00:00:00.000000000 Z
+date: 2014-05-10 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler