smile-identity-core 1.0.0 → 1.0.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: a3b6be5ffaad64aa13c654eca628db1437da28d46a1e3d4b3564b373e4132508
-  data.tar.gz: 1042167bb8981ac85cf0a1dbf466f2b099ca5468b013e62119a322582a879c9c
+  metadata.gz: edcf68a6d2595ffaaace47ea75b7a7ef4829072f02ef7095564472261563649a
+  data.tar.gz: e6657acf87f95de20366f5a559118bfcea6a58757bfa77a88984b083d44c2fe1
 SHA512:
-  metadata.gz: f301a2f41634473bb47393dc5992f30f381a8088250aa2ebfc7739003384c52a37031182fc6e048b78227e990c465659f18fcc0d39bd4efc65ecc48d285325ce
-  data.tar.gz: ba2e07c8c8f68117f7343bf0949277999a3e48ec770a50bfdd51ab0f98690d4219d2f989bbe436a558a9ca9adc3092607ae427911f2fc68e1233e94c33267f47
+  metadata.gz: bc0a67955105b33ca0cd3a287772ec3666a6fc22f1f5ae3c1a0d47f1fc2b70838b830748d7f29d14dde39bc84ce230d4d45028cd40b9c06ae8d419a39ff29654
+  data.tar.gz: 7b4afa3dafab637388ffead740accaea4d1ba43327297ca7567a80ad180d60bbf39507e7865071275305b4e781bce1540ec484a4f5c576f3c73293283d175ef1

data/CHANGELOG.md

@@ -39,3 +39,8 @@ Amend the success response when job status is false to be a JSON String containi
 Add the ID API Class
 Add the ability to query ID Api from the Web API class
 Update the documentation
+
+## [1.0.1] - 2019-10-24
+## Updated
+Remove first_name and last_name validations from id information in Web Api
+Add country, id_number and id_type validations for id information in ID Api

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    smile-identity-core (1.0.0)
+    smile-identity-core (1.0.1)
       rubyzip (~> 1.2, >= 1.2.3)
       typhoeus (~> 1.0, >= 1.0.1)
 

data/lib/smile-identity-core/id_api.rb

@@ -57,7 +57,11 @@ module SmileIdentityCore
         raise ArgumentError.new("Please make sure that id_info not empty or nil")
       end
 
-      # maybe do some validation on consistent required fields like id_type and id_number
+      [:country, :id_type, :id_number].each do |key|
+        unless updated_id_info[key] && !updated_id_info[key].nil? && !updated_id_info[key].empty?
+          raise ArgumentError.new("Please make sure that #{key.to_s} is included in the id_info")
+        end
+      end
 
       @id_info = updated_id_info
     end

data/lib/smile-identity-core/version.rb

@@ -1,3 +1,3 @@
 module SmileIdentityCore
-  VERSION = "1.0.0"
+  VERSION = "1.0.1"
 end

data/lib/smile-identity-core/web_api.rb

@@ -97,6 +97,7 @@ module SmileIdentityCore
       end
 
       @images = images.map { |image| symbolize_keys image }
+
     end
 
     def id_info=(id_info)
@@ -118,17 +119,13 @@ module SmileIdentityCore
       end
 
       if updated_id_info[:entered] && updated_id_info[:entered] == 'true'
-        [:first_name, :last_name, :country, :id_type, :id_number].each do |key|
+        [:country, :id_type, :id_number].each do |key|
           unless id_info[key] && !id_info[key].nil? && !id_info[key].empty?
             raise ArgumentError.new("Please make sure that #{key.to_s} is included in the id_info")
           end
         end
       end
 
-      if updated_id_info[:country] && updated_id_info[:country].upcase == 'NG' && ['PASSPORT', 'VOTER_ID', 'DRIVERS_LICENSE', 'NATIONAL_ID', 'TIN', 'CAC'].include?(updated_id_info[:id_type].upcase) && (!updated_id_info[:dob] || updated_id_info[:dob].empty? || updated_id_info[:dob].nil?)
-        raise ArgumentError.new("The ID type #{updated_id_info[:id_type]} for #{updated_id_info[:country]} requires a valid dob paramater.")
-      end
-
       @id_info = updated_id_info
     end
 

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: smile-identity-core
 version: !ruby/object:Gem::Version
-  version: 1.0.0
+  version: 1.0.1
 platform: ruby
 authors:
 - Ridhwana
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2019-10-11 00:00:00.000000000 Z
+date: 2019-10-25 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler