smash_the_state 1.4.3 → 1.4.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 591b5f213e895130ff25cf2bc2638275d6f89a054abbe01c0fb55ff5c6f3cc84
-  data.tar.gz: 249752c9f3aa7a7efea1adf1dcc4af85bfe135235bf0d07b6961fb3a5eca2a80
+  metadata.gz: 9a4407b73af1d296ca49dc0e0d112e3fd4a497d37e66cc97026bcf75835e8d48
+  data.tar.gz: 19c36a89864c088ff0ff068768049dc68c798b57b3b074dd4cd4721f46386abb
 SHA512:
-  metadata.gz: c74f691d3f1d7d9e6fe008e67d97b7da9cf24cef2d444a57744c1a4ee41f559358d39d6e1e74f5222f93c5d41c1eb9a53f3a61f9635a0cd522798fc77e0d2395
-  data.tar.gz: fbf4c5c27f114281a9db33f2d76d64a50f8f42594f1e2a5a84dfce2414893e1728dae5702e0ea8a65ccd4a3c82790ace05cba760e4634f08ab157e8b115c2e91
+  metadata.gz: 3054575953e6e59b15a454609698b8346a6a2fab75ee578c94029b895e03568ed0af214db70cd283c7db0eb97954a41d752d8ed4b18898282940a01534969b49
+  data.tar.gz: b08cde0d76694574172be59467ffe790013aaa462664182345fb494d84976837102db57c60ba74e0753cda7c1b7925fa85adef77fae15e2eefecf5bb0903b41e

data/lib/smash_the_state/operation/sequence.rb

@@ -93,13 +93,20 @@ module SmashTheState
         step.error_handler = block
       end
 
-      # rubocop:disable Lint/ShadowedException
       def middleware_class(state, original_state = nil)
-        middleware_class_block.call(state, original_state).constantize
-      rescue NameError, NoMethodError
-        nil
+        klass = middleware_class_block.call(state, original_state)
+
+        case klass
+        when Module, Class
+          klass
+        else
+          begin
+            klass.constantize if klass.respond_to?(:constantize)
+          rescue NameError
+            nil
+          end
+        end
       end
-      # rubocop:enable Lint/ShadowedException
 
       def add_middleware_step(step_name, options = {})
         step = Operation::Step.new step_name, options do |state, original_state|
@@ -127,7 +134,9 @@ module SmashTheState
       def make_original_state(state)
         return dynamic_schema_step.implementation.call(state, state, run_options) if dynamic_schema?
 
-        state.dup
+        state.
+          dup.
+          freeze # don't allow any modifications to the original state
       end
 
       def run_steps(steps_to_run, state)

data/lib/smash_the_state/version.rb

@@ -1,3 +1,3 @@
 module SmashTheState
-  VERSION = "1.4.3".freeze
+  VERSION = "1.4.4".freeze
 end

data/spec/unit/operation/sequence_spec.rb

@@ -204,28 +204,40 @@ describe SmashTheState::Operation::Sequence do
     end
 
     context "with a middleware_class_block" do
-      it "runs the middleware_class_block, passes in the state, constantizes" do
-        expect(instance.middleware_class("String")).to eq(String)
+      context "that returns a string" do
+        it "runs the middleware_class_block, passes in the state, constantizes" do
+          expect(instance.middleware_class("String")).to eq(String)
+        end
       end
-    end
 
-    context "with a NameError" do
-      it "returns nil" do
-        expect(instance.middleware_class("Whazzat")).to eq(nil)
-      end
-    end
+      context "that returns a constant" do
+        before do
+          instance.middleware_class_block = proc do |state|
+            state
+          end
+        end
 
-    context "with a NoMethodError" do
-      let!(:state) { double }
+        context "that is a class" do
+          let!(:klass) { Class.new }
 
-      before do
-        allow(state).to receive(:to_s) do
-          raise NoMethodError
+          it "runs the middleware_class_block, passes in the state" do
+            expect(instance.middleware_class(klass)).to eq(klass)
+          end
+        end
+
+        context "that returns a module" do
+          let!(:modyule) { Module.new }
+
+          it "runs the middleware_class_block, passes in the state" do
+            expect(instance.middleware_class(modyule)).to eq(modyule)
+          end
         end
       end
+    end
 
+    context "with a NameError" do
       it "returns nil" do
-        expect(instance.middleware_class(state)).to eq(nil)
+        expect(instance.middleware_class("Whazzat")).to eq(nil)
       end
     end
   end
@@ -254,10 +266,11 @@ describe SmashTheState::Operation::Sequence do
         instance.add_middleware_step :extra_step
       end
 
-      it "block receives both the state and original state" do
+      it "block receives both the state and frozen original state" do
         instance.middleware_class_block = proc do |state, original_state|
           expect(state).to eq(baz: "bing")
           expect(original_state).to eq(foo: "bar")
+          expect(original_state.frozen?).to eq(true)
         end
 
         instance.call(foo: "bar")

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: smash_the_state
 version: !ruby/object:Gem::Version
-  version: 1.4.3
+  version: 1.4.4
 platform: ruby
 authors:
 - Dan Connor
-autorequire:
+autorequire: 
 bindir: bin
 cert_chain: []
-date: 2021-04-21 00:00:00.000000000 Z
+date: 2021-10-12 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: active_model_attributes
@@ -68,7 +68,7 @@ homepage: https://github.com/ibm-cloud/smash-the-state
 licenses:
 - Apache-2.0
 metadata: {}
-post_install_message:
+post_install_message: 
 rdoc_options: []
 require_paths:
 - lib
@@ -84,7 +84,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubygems_version: 3.1.4
-signing_key:
+signing_key: 
 specification_version: 4
 summary: A useful utility for transforming state that provides step sequencing, middleware,
   and validation.