smartname 0.5.0 → 0.5.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: db3a78f4a254d599ca83a93a19d14a61a37c8b05
-  data.tar.gz: 1889454b39276d368ea7ae05b53e255c9f559490
+  metadata.gz: f612c29dbef138ab916ebcf8645fc67dfa7c7c09
+  data.tar.gz: 0501b8a442d67f73cd80bfae48c8d70b1a1703db
 SHA512:
-  metadata.gz: aa470ffc741acea8d1d3b3e22c9a61d8b79de9f2f2650c5f08d669e7920bc1c237cdd4310f6cbfef8ab8ccde0243a64dfc07cfd4895bbdafe14b19aa5f9ff8cf
-  data.tar.gz: 50be6deee20d1b2c0554645786be70167ceaf8b41147fe982dc42fac5d59d84290ffc1952c39e5a05251bada945244534817bf532ba3e0a151d3963d86902cc7
+  metadata.gz: 5f7b99953fe2d1d8dd6953f5c277a96f1d2dc17ad2d736bbabc3f963a8e2ce697010859e606f8d86fd63e5b951910c7124b327ce5004d09048f9e8a072d42333
+  data.tar.gz: d1240995bc6ce9160f9363465395e81f7f51f5dadf93229596d6ba8b7cd28247463cefd575cb2f3b3e6f771bd21c4e9da32b57f82691231245ed2582c570e8ca

data/VERSION

@@ -1 +1 @@
-0.5.0
+0.5.1

data/lib/smart_name/contextual.rb

@@ -58,6 +58,7 @@ class SmartName
       context = context.to_name
 
       new_parts = replace_contextual_parts context
+      return "" if new_parts.empty?
 
       if new_parts.first.empty? && !new_parts.to_name.starts_with?(context)
         new_parts[0] = context.to_s

data/lib/smart_name/parts.rb

@@ -7,15 +7,6 @@ class SmartName
 
     alias simple? simple
     alias_method :to_a, :parts
-    alias_method :to_ary, :parts
-
-    def to_ary
-      if parts.empty?
-        [""]
-      else
-        parts
-      end
-    end
 
     def initialize_parts
       # -1 = don't suppress trailing null fields
@@ -108,17 +99,28 @@ class SmartName
         end
     end
 
-    # name parts can be accessed and manipulated like an array
-    def method_missing method, *args, &block
-      if parts.respond_to?(method)
-        self.class.new parts.send(method, *args, &block)
-      else
-        super
-      end
+    def + other
+      self.class.new(parts + other.to_name.parts)
     end
 
-    def respond_to? method, include_private=false
-      super || parts.respond_to?(method, include_private)
+    def [] *args
+      self.class.new parts[*args]
     end
+
+    # full support of array methods caused trouble with `flatten` calls
+    # It splits the parts of smartnames in arrays
+    # # name parts can be accessed and manipulated like an array
+    # def method_missing method, *args, &block
+    #   if ARRAY_METHODS.include? method # parts.respond_to?(method)
+    #     self.class.new parts.send(method, *args, &block)
+    #   else
+    #     super
+    #   end
+    # end
+    #
+    # def respond_to? method, include_private=false
+    #   return true if ARRAY_METHODS.include? method
+    #   super || parts.respond_to?(method, include_private)
+    # end
   end
 end

data/spec/lib/smart_name/contextual_spec.rb

@@ -44,6 +44,10 @@ RSpec.describe SmartName::Contextual do
       expect('_2+_3'.to_name.to_absolute('A+B+C')).to eq('B+C')
     end
 
+    it 'handles empty name' do
+      expect(''.to_name.to_absolute('A+B')).to eq('')
+    end
+
     it 'handles _LLR etc' do
       expect('_R'.to_name.to_absolute('A+B+C+D+E')).to    eq('E')
       expect('_L'.to_name.to_absolute('A+B+C+D+E')).to    eq('A+B+C+D')

data/spec/lib/smart_name/parts_spec.rb

@@ -61,5 +61,9 @@ RSpec.describe SmartName::Parts do
     it 'flatten preserves empty names' do
       expect(["".to_name, "A"].flatten.to_name.s).to eq "+A"
     end
+
+    it 'flatten preserves names' do
+      expect([["A+B".to_name], "C+D".to_name].flatten).to eq ["A+B".to_name, "C+D".to_name]
+    end
   end
 end

data/spec/lib/smart_name_spec.rb

@@ -2,63 +2,77 @@
 require File.expand_path('../spec_helper', File.dirname(__FILE__))
 
 describe SmartName do
-  describe '#key' do
-    it 'should remove spaces' do
-      expect('this    Name'.to_name.key).to eq('this_name')
+  describe "#key" do
+    it "lowercases and underscores" do
+      expect("This Name".to_name.key).to eq("this_name")
     end
 
-    it 'should have initial _ for initial cap' do
-      expect('This Name'.to_name.key).to eq('this_name')
+    it "removes spaces" do
+      expect("this    Name".to_name.key).to eq("this_name")
     end
 
-    it 'should have initial _ for initial cap' do
-      expect('_This Name'.to_name.key).to eq('this_name')
+    describe "underscores" do
+      it "is treated like spaces" do
+        expect("weird_ combo".to_name.key).to eq("weird  combo".to_name.key)
+      end
+
+      it "does not impede pluralization checks" do
+        expect("Mamas_and_Papas".to_name.key).to(
+          eq("Mamas and Papas".to_name.key)
+        )
+      end
+
+      it "is removed when before first word character" do
+        expect("_This Name".to_name.key).to eq("this_name")
+      end
     end
 
-    it 'should singularize' do
-      expect('ethans'.to_name.key).to eq('ethan')
+    it "singularizes" do
+      expect("ethans".to_name.key).to eq("ethan")
     end
 
-    it 'should underscore' do
-      expect('ThisThing'.to_name.key).to eq('this_thing')
+    it "changes CamelCase to snake case" do
+      expect("ThisThing".to_name.key).to eq("this_thing")
     end
 
-    it 'should handle plus cards' do
-      expect('ThisThing+Ethans'.to_name.key).to eq('this_thing+ethan')
+    it "handles plus cards" do
+      expect("ThisThing+Ethans".to_name.key).to eq("this_thing+ethan")
     end
 
-    it 'should retain * for star cards' do
-      expect('*right'.to_name.key).to eq('*right')
+    it "retains * for star cards" do
+      expect("*right".to_name.key).to eq("*right")
     end
 
-    it "should not singularize double s's" do
-      expect('grass'.to_name.key).to eq('grass')
+    it "does not singularize double s's" do
+      expect("grass".to_name.key).to eq("grass")
     end
 
-    it "should not singularize letter 'S'" do
-      expect('S'.to_name.key).to eq('s')
+    it "does not singularize letter 'S'" do
+      expect("S".to_name.key).to eq("s")
     end
 
-    it 'should handle unicode characters' do
-      expect('Mañana'.to_name.key).to eq('mañana')
+    it "handles unicode characters" do
+      expect("Mañana".to_name.key).to eq("mañana")
     end
 
-    it 'should handle weird initial characters' do
-      expect('__you motha @#$'.to_name.key).to eq('you_motha')
-      expect('?!_you motha @#$'.to_name.key).to eq('you_motha')
+    it "handles weird initial characters" do
+      expect("__you motha @\#$".to_name.key).to eq("you_motha")
+      expect("?!_you motha @\#$".to_name.key).to eq("you_motha")
     end
 
-    it 'should allow numbers' do
-      expect('3way'.to_name.key).to eq('3way')
+    it "allows numbers" do
+      expect("3way".to_name.key).to eq("3way")
     end
 
-    it 'internal plurals' do
-      expect('cards hooks label foos'.to_name.key).to eq('card_hook_label_foo')
+    it "internal plurals" do
+      expect("cards hooks label foos".to_name.key).to eq("card_hook_label_foo")
     end
 
-    it 'should handle html entities' do
+    it "handles html entities" do
       # This no longer takes off the s, is singularize broken now?
-      expect('Jean-françois Noubel'.to_name.key).to eq('jean_françoi_noubel')
+      expect("Jean-françois Noubel".to_name.key).to(
+        eq("jean_françoi_noubel")
+      )
     end
   end
 

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: smartname
 version: !ruby/object:Gem::Version
-  version: 0.5.0
+  version: 0.5.1
 platform: ruby
 authors:
 - Gerry Gleason