smart_todo 1.0.0 → 1.0.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: e194a50190cc4abe3340fa3cb500ea64e9d0ea6a5270044578d83fcdb996e11c
-  data.tar.gz: 7b03f430e450a5b56a8e0b976f9212b8301a5302fc4e4296695f355f06d109de
+  metadata.gz: 00c1fc521428aa50cef7d23ea71e79cd7ef19389c2ec9bf6a03f83a61613d43c
+  data.tar.gz: 793c12664a7e8c54e22d33f392eec319d6cfeed0954b3854c0b631a4bac7e585
 SHA512:
-  metadata.gz: 30a88b03050f254e56eac390202399a52077a27308f8b0ecec1c1a61ac3b10ee30bb8470885388055c30fcb3cdb769948395f11be0d60dfc246849953e6d97e5
-  data.tar.gz: 32ff62e57ace9b8b35620ba7f42e250d8718faae78846cda850bee080db6d7abb18908b0f45fdc51b1b480e811f7150d0b4cdb91bdee679a1032e1223e7ca560
+  metadata.gz: cc05790423e467a734c1e0ca0f8fe60a095da70ecfddc05ddb91f908f024ee47d198ab166dd2c658daf6ac604b7b9c18647354edf2e5f080498275b8fb379d35
+  data.tar.gz: ba0ec4630934f6d9688f7bcdfd7a1ab05cac527f939adf7c9b84baac8b8e58a8a9dba23e68043bd028f310751271ba21b53756ce11c4a1173aa117993b9f3c7a

data/.rubocop.yml

@@ -3,3 +3,5 @@ inherit_from:
 
 AllCops:
   TargetRubyVersion: 2.5
+  Exclude:
+    - vendor/**/*

data/.travis.yml

@@ -0,0 +1,15 @@
+sudo: false
+cache: bundler
+language: ruby
+before_install:
+  - gem update bundler
+rvm:
+  - 2.3
+  - 2.4
+  - 2.5
+  - 2.6
+script:
+  - bundle exec rubocop --config .rubocop.yml
+  - bundle exec rake test
+notifications:
+  email: false

data/CHANGELOG.md

@@ -0,0 +1,15 @@
+# Changelog
+All notable changes to this project will be documented in this file.
+
+The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
+and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
+
+## [Unreleased]
+
+## [1.0.1] - 2019-08-06
+### Fixed
+- Fixed `issue_close` event making a call to the `pulls/` GH endpoint instead of the `issues/` one
+
+## [1.0.0] - 2019-07-19
+### Added
+- Initial Release

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    smart_todo (1.0.0)
+    smart_todo (1.0.1)
 
 GEM
   remote: https://rubygems.org/

data/README.md

@@ -2,7 +2,7 @@
   <img src="https://user-images.githubusercontent.com/8122246/61341925-b936d180-a848-11e9-95c1-0d2f398c51b1.png?raw=true" width="200">
 </h3>
 
-[![Build status](https://badge.buildkite.com/dc3ed74a08ef4a3f6f13bc37bf6ac19a80c0deb3157dfa7937.svg)](https://buildkite.com/shopify/smart-todo?branch=master)
+[![Build Status](https://travis-ci.com/Shopify/smart_todo.svg?branch=master)](https://travis-ci.com/Shopify/smart_todo)
 
 _SmartTodo_  is a library designed to assign users on TODO comments written in your codebase and help assignees be reminded when it's time to commit to their TODO.
 

data/lib/smart_todo/events/{pull_request_close.rb → issue_close.rb}

@@ -5,20 +5,20 @@ require 'json'
 
 module SmartTodo
   module Events
-    # An event that check if a GitHun Pull Request or Issue is closed.
+    # An event that check if a GitHub Pull Request or Issue is closed.
     # This event will make an API call to the GitHub API.
     #
     # If the Pull Request or Issue is on a private repository, exporting a token
     # with the `repos` scope in the +SMART_TODO_GITHUB_TOKEN+ environment variable
     # is required.
-    class PullRequestClose
+    class IssueClose
       TOKEN_ENV = 'SMART_TODO_GITHUB_TOKEN'
 
       # @param organization [String]
       # @param repo [String]
       # @param pr_number [String, Integer]
-      def initialize(organization, repo, pr_number)
-        @url = "/repos/#{organization}/#{repo}/pulls/#{pr_number}"
+      def initialize(organization, repo, pr_number, type:)
+        @url = "/repos/#{organization}/#{repo}/#{type}/#{pr_number}"
         @organization = organization
         @repo = repo
         @pr_number = pr_number

data/lib/smart_todo/events.rb

@@ -38,15 +38,24 @@ module SmartTodo
       GemRelease.new(gem_name, requirements).met?
     end
 
-    # Check if the Pull Request or issue +pr_number+ is closed
+    # Check if the issue +issue_number+ is closed
+    #
+    # @param organization [String] the GitHub organization name
+    # @param repo [String] the GitHub repo name
+    # @param issue_number [String, Integer]
+    # @return [false, String]
+    def issue_close(organization, repo, issue_number)
+      IssueClose.new(organization, repo, issue_number, type: 'issues').met?
+    end
+
+    # Check if the pull request +pr_number+ is closed
     #
     # @param organization [String] the GitHub organization name
     # @param repo [String] the GitHub repo name
     # @param pr_number [String, Integer]
     # @return [false, String]
     def pull_request_close(organization, repo, pr_number)
-      PullRequestClose.new(organization, repo, pr_number).met?
+      IssueClose.new(organization, repo, pr_number, type: 'pulls').met?
     end
-    alias_method :issue_close, :pull_request_close
   end
 end

data/lib/smart_todo/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module SmartTodo
-  VERSION = "1.0.0"
+  VERSION = "1.0.1"
 end

data/lib/smart_todo.rb

@@ -17,6 +17,6 @@ module SmartTodo
   module Events
     autoload :Date,                   'smart_todo/events/date'
     autoload :GemRelease,             'smart_todo/events/gem_release'
-    autoload :PullRequestClose,       'smart_todo/events/pull_request_close'
+    autoload :IssueClose,             'smart_todo/events/issue_close'
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: smart_todo
 version: !ruby/object:Gem::Version
-  version: 1.0.0
+  version: 1.0.1
 platform: ruby
 authors:
 - Shopify
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2019-07-19 00:00:00.000000000 Z
+date: 2019-08-06 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -94,8 +94,8 @@ files:
 - ".gitignore"
 - ".rubocop-http---shopify-github-io-ruby-style-guide-rubocop-yml"
 - ".rubocop.yml"
-- ".shopify-build/VERSION"
-- ".shopify-build/smart-todo.yml"
+- ".travis.yml"
+- CHANGELOG.md
 - CODE_OF_CONDUCT.md
 - Gemfile
 - Gemfile.lock
@@ -113,7 +113,7 @@ files:
 - lib/smart_todo/events.rb
 - lib/smart_todo/events/date.rb
 - lib/smart_todo/events/gem_release.rb
-- lib/smart_todo/events/pull_request_close.rb
+- lib/smart_todo/events/issue_close.rb
 - lib/smart_todo/parser/comment_parser.rb
 - lib/smart_todo/parser/metadata_parser.rb
 - lib/smart_todo/parser/todo_node.rb

data/.shopify-build/VERSION

@@ -1 +0,0 @@
-v1

data/.shopify-build/smart-todo.yml

@@ -1,37 +0,0 @@
-containers:
-  ruby-2.3:
-    docker: circleci/ruby:2.3
-  ruby-2.4:
-    docker: circleci/ruby:2.4
-  ruby-2.5:
-    docker: circleci/ruby:2.5
-  ruby-2.6:
-    docker: circleci/ruby:2.6
-
-shared:
-  defaults: &defaults
-    timeout: 5m
-    dependencies:
-    - bundler
-    run:
-      - bundle exec rake test
-
-steps:
-- label: ":cop: Ruby style check"
-  timeout: 5m
-  container: ruby-2.5
-  dependencies:
-  - bundler
-  run: bin/rubocop
-- label: ":ruby: Ruby 2.3"
-  container: ruby-2.3
-  <<: *defaults
-- label: ":ruby: Ruby 2.4"
-  container: ruby-2.4
-  <<: *defaults
-- label: ":ruby: Ruby 2.5"
-  container: ruby-2.5
-  <<: *defaults
-- label: ":ruby: Ruby 2.6"
-  container: ruby-2.6
-  <<: *defaults