smart_settings 0.1.1 → 0.1.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
-SHA1:
-  metadata.gz: 13b9e02e948f0cd9036e96d8a3746eb2bdb3328c
-  data.tar.gz: f877f01cca18f28ba110b6e3ce4a6a7ffe970ff1
+SHA256:
+  metadata.gz: dd6604f5f2ae057b84ae65fe2aab6a9fb6311104ae6e7b32f0502196e350b6ad
+  data.tar.gz: eaa68492d6a18f875dc68bc9fcf2831a312cbd4fb8ee45468ff7dd40fc54b6a9
 SHA512:
-  metadata.gz: bd1215594e9814a60b5b139f1ccf47761935c866fed1aea7d8717bf91b074b3b56ba616e6fa1b970fc5632e73ceef62b3f445662a52a69517b39535f43bafed5
-  data.tar.gz: 6d64ba1b64cdfe11b73e7ec988a9beb2afc958e101cf4644d46c107ca4b8917e4d5c4db45b5c5495fc0bc3239c56bf22b0c3b14e7c55775397d7b7d7bf57a71a
+  metadata.gz: e36902d73b0e9671d07d9222eba95da95434b2c2c83a7e8f46a18cd3ca4783cb79546a1e3e0aed49bf192d190154e7fd1f400b29f3730ffe42a183a618c882a7
+  data.tar.gz: 41468b19beb844c27d677f3fe124f8cea5163bf4cbb7d85711f3f21667b637747e10c3807812bf02b42d79cbf8416cf043f72c717e0ac3fe289827131eabf2e0

data/README.md

@@ -125,12 +125,8 @@ After checking out the repo, run `bin/setup` to install dependencies. Then, run
 
 ## Contributing
 
-Bug reports and pull requests are welcome on GitHub at https://github.com/hardpixel/smart-settings. This project is intended to be a safe, welcoming space for collaboration, and contributors are expected to adhere to the [Contributor Covenant](http://contributor-covenant.org) code of conduct.
+Bug reports and pull requests are welcome on GitHub at https://github.com/hardpixel/smart-settings.
 
 ## License
 
 The gem is available as open source under the terms of the [MIT License](http://opensource.org/licenses/MIT).
-
-## Code of Conduct
-
-Everyone interacting in the SmartSettings project’s codebases, issue trackers, chat rooms and mailing lists is expected to follow the [code of conduct](https://github.com/hardpixel/smart-settings/blob/master/CODE_OF_CONDUCT.md).

data/lib/generators/smart_settings/setting_generator.rb

@@ -14,29 +14,29 @@ module SmartSettings
 
     private
 
-      def setting_class
-        name.camelize
-      end
+    def setting_class
+      name.camelize
+    end
 
-      def setting_file
-        "#{name.downcase.underscore}_settings"
-      end
+    def setting_file
+      "#{name.downcase.underscore}_settings"
+    end
 
-      def setting_fields
-        args.map do |arg|
-          field, cast_type, default, group = arg.split(':')
+    def setting_fields
+      args.map do |arg|
+        field, cast_type, default, group = arg.split(':')
 
-          items  = [":#{field.to_sym}", ":#{cast_type.to_sym}"]
-          items << ["default: #{value_type_cast(cast_type.to_sym, default)}"] if default.present?
-          items << ["group: :#{group.to_sym}"] if group.present?
+        items  = [":#{field.to_sym}", ":#{cast_type.to_sym}"]
+        items << ["default: #{value_type_cast(cast_type.to_sym, default)}"] if default.present?
+        items << ["group: :#{group.to_sym}"] if group.present?
 
-          items.join(', ')
-        end
+        items.join(', ')
       end
+    end
 
-      def value_type_cast(cast_type, value)
-        strings = [:string, :date, :datetime, :time]
-        cast_type.in?(strings) ? "'#{value}'" : value
-      end
+    def value_type_cast(cast_type, value)
+      strings = [:string, :date, :datetime, :time]
+      cast_type.in?(strings) ? "'#{value}'" : value
+    end
   end
 end

data/lib/smart_settings/attributes.rb

@@ -11,17 +11,17 @@ module SmartSettings
     end
 
     class_methods do
-      def setting(name, type_cast=:string, options={})
+      def setting(name, type_cast = :string, options = {})
         gname = options.delete(:group)
         sname = gname.nil? ? name : :"#{gname}_#{name}"
 
         attribute sname, type_cast, options
         self.setting_names += [sname]
 
-        unless gname.nil?
-          group = setting_groups.fetch(gname, []) + [sname]
-          self.setting_groups = setting_groups.merge(gname => group)
-        end
+        return if gname.nil?
+
+        group = setting_groups.fetch(gname, []) + [sname]
+        self.setting_groups = setting_groups.merge(gname => group)
       end
 
       def method_missing(method, *args, &block)
@@ -38,16 +38,16 @@ module SmartSettings
     end
 
     def group_exists?(name)
-      setting_groups.keys.include? name
+      setting_groups.key? name
     end
 
     def group(name)
-      if group_exists?(name)
-        keys = setting_groups[name]
-        data = attributes.symbolize_keys.select { |k, _v| k.in? keys }
+      return unless group_exists?(name)
 
-        Hash[data.map { |k, v| [k.to_s.sub("#{name}_", '').to_sym, v] }]
-      end
+      keys = setting_groups[name]
+      data = attributes.symbolize_keys.select { |k, _v| k.in? keys }
+
+      Hash[data.map { |k, v| [k.to_s.sub("#{name}_", '').to_sym, v] }]
     end
 
     def method_missing(method, *args, &block)

data/lib/smart_settings/naming.rb

@@ -17,11 +17,11 @@ module SmartSettings
     end
 
     def var
-      "#{self.class.name}".demodulize.sub('Settings', '')
+      self.class.name.to_s.demodulize.sub('Settings', '')
     end
 
     def to_param
-      "#{var}".parameterize
+      var.to_s.parameterize
     end
 
     def permitted_attributes

data/lib/smart_settings/persistence.rb

@@ -30,37 +30,37 @@ module SmartSettings
     end
 
     def settings
-      if settings_table_exists?
-        valid = self.attribute_names.reject { |i| i == 'var' }
-        Setting.where(settable_type: self.class.name, settable_id: id, var: valid)
-      end
+      return unless settings_table_exists?
+
+      valid = self.attribute_names.reject { |i| i == 'var' }
+      Setting.where(settable_type: self.class.name, settable_id: id, var: valid)
     end
 
     private
 
-      def cast_setting_value(var, value)
-        self.class.attribute_types[var].cast(value)
-      end
+    def cast_setting_value(var, value)
+      self.class.attribute_types[var].cast(value)
+    end
 
-      def create_setting(var, value)
-        parameters = { var: var, value: cast_setting_value(var, value) }
-        Setting.create(parameters.merge(settable_type: self.class.name, settable_id: id))
-      end
+    def create_setting(var, value)
+      parameters = { var: var, value: cast_setting_value(var, value) }
+      Setting.create(parameters.merge(settable_type: self.class.name, settable_id: id))
+    end
 
-      def update_setting(var, value)
-        settings.where(var: var).update(value: cast_setting_value(var, value))
-      end
+    def update_setting(var, value)
+      settings.where(var: var).update(value: cast_setting_value(var, value))
+    end
 
-      def create_or_update_setting(var, value)
-        if settings.where(var: var).exists?
-          update_setting(var, value)
-        else
-          create_setting(var, value)
-        end
+    def create_or_update_setting(var, value)
+      if settings.where(var: var).exists?
+        update_setting(var, value)
+      else
+        create_setting(var, value)
       end
+    end
 
-      def settings_table_exists?
-        ActiveRecord::Base.connection.table_exists? Setting.table_name
-      end
+    def settings_table_exists?
+      ActiveRecord::Base.connection.table_exists? Setting.table_name
+    end
   end
 end

data/lib/smart_settings/querying.rb

@@ -8,12 +8,10 @@ module SmartSettings
       end
 
       def find(*var)
-        if var.size > 1
-          results = where(var: var)
-          raise_record_not_found_exception!(var) if results.blank?
-        else
-          find_by_var!(var.first)
-        end
+        return find_by_var!(var.first) unless var.size > 1
+
+        results = where(var: var)
+        raise_record_not_found_exception!(var) if results.blank?
       end
 
       def find_by_var(var)
@@ -26,7 +24,7 @@ module SmartSettings
         setting.nil? ? raise_record_not_found_exception!(var) : setting
       end
 
-      def where(options={})
+      def where(options = {})
         vars = Hash[options][:var]
         return all if vars.nil?
 
@@ -35,14 +33,12 @@ module SmartSettings
       end
 
       def all
-        if setting_names.empty?
-          files = Dir.glob(Rails.root.join('app', 'settings', '*.rb'))
-          files = files.map { |file| file.to_s.split('/').last.sub('_settings.rb', '') }
+        return new.all if setting_names.any?
+
+        files = Dir.glob(Rails.root.join('app', 'settings', '*.rb'))
+        files = files.map { |file| file.to_s.split('/').last.sub('_settings.rb', '') }
 
-          where(var: files)
-        else
-          new.all
-        end
+        where(var: files)
       end
 
       def method_missing(method, *args, &block)
@@ -52,12 +48,12 @@ module SmartSettings
 
       private
 
-        def raise_record_not_found_exception!(ids)
-          vars  = ids.is_a?(Array) ? "(#{ids.join(', ')})" : ids
-          error = "Couldn't find Settings with var: #{vars}"
+      def raise_record_not_found_exception!(ids)
+        vars  = ids.is_a?(Array) ? "(#{ids.join(', ')})" : ids
+        error = "Couldn't find Settings with var: #{vars}"
 
-          raise ActiveRecord::RecordNotFound.new(error, 'Settings', 'var')
-        end
+        raise ActiveRecord::RecordNotFound.new(error, 'Settings', 'var')
+      end
     end
   end
 end

data/lib/smart_settings/version.rb

@@ -1,3 +1,3 @@
 module SmartSettings
-  VERSION = '0.1.1'
+  VERSION = '0.1.2'
 end

metadata

@@ -1,29 +1,35 @@
 --- !ruby/object:Gem::Specification
 name: smart_settings
 version: !ruby/object:Gem::Version
-  version: 0.1.1
+  version: 0.1.2
 platform: ruby
 authors:
 - Jonian Guveli
 autorequire: 
-bindir: exe
+bindir: bin
 cert_chain: []
-date: 2017-12-28 00:00:00.000000000 Z
+date: 2019-08-27 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activerecord
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
         version: '5.0'
+    - - "<"
+      - !ruby/object:Gem::Version
+        version: '7.0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
         version: '5.0'
+    - - "<"
+      - !ruby/object:Gem::Version
+        version: '7.0'
 - !ruby/object:Gem::Dependency
   name: tableless
   requirement: !ruby/object:Gem::Requirement
@@ -44,14 +50,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.14'
+        version: '2.0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.14'
+        version: '2.0'
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
@@ -88,7 +94,6 @@ executables: []
 extensions: []
 extra_rdoc_files: []
 files:
-- CODE_OF_CONDUCT.md
 - Gemfile
 - LICENSE.txt
 - README.md
@@ -125,8 +130,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubyforge_project: 
-rubygems_version: 2.6.14
+rubygems_version: 3.0.3
 signing_key: 
 specification_version: 4
 summary: Persist application or record settings on ActiveRecord

data/CODE_OF_CONDUCT.md

@@ -1,74 +0,0 @@
-# Contributor Covenant Code of Conduct
-
-## Our Pledge
-
-In the interest of fostering an open and welcoming environment, we as
-contributors and maintainers pledge to making participation in our project and
-our community a harassment-free experience for everyone, regardless of age, body
-size, disability, ethnicity, gender identity and expression, level of experience,
-nationality, personal appearance, race, religion, or sexual identity and
-orientation.
-
-## Our Standards
-
-Examples of behavior that contributes to creating a positive environment
-include:
-
-* Using welcoming and inclusive language
-* Being respectful of differing viewpoints and experiences
-* Gracefully accepting constructive criticism
-* Focusing on what is best for the community
-* Showing empathy towards other community members
-
-Examples of unacceptable behavior by participants include:
-
-* The use of sexualized language or imagery and unwelcome sexual attention or
-advances
-* Trolling, insulting/derogatory comments, and personal or political attacks
-* Public or private harassment
-* Publishing others' private information, such as a physical or electronic
-  address, without explicit permission
-* Other conduct which could reasonably be considered inappropriate in a
-  professional setting
-
-## Our Responsibilities
-
-Project maintainers are responsible for clarifying the standards of acceptable
-behavior and are expected to take appropriate and fair corrective action in
-response to any instances of unacceptable behavior.
-
-Project maintainers have the right and responsibility to remove, edit, or
-reject comments, commits, code, wiki edits, issues, and other contributions
-that are not aligned to this Code of Conduct, or to ban temporarily or
-permanently any contributor for other behaviors that they deem inappropriate,
-threatening, offensive, or harmful.
-
-## Scope
-
-This Code of Conduct applies both within project spaces and in public spaces
-when an individual is representing the project or its community. Examples of
-representing a project or community include using an official project e-mail
-address, posting via an official social media account, or acting as an appointed
-representative at an online or offline event. Representation of a project may be
-further defined and clarified by project maintainers.
-
-## Enforcement
-
-Instances of abusive, harassing, or otherwise unacceptable behavior may be
-reported by contacting the project team at info@hardpixel.eu. All
-complaints will be reviewed and investigated and will result in a response that
-is deemed necessary and appropriate to the circumstances. The project team is
-obligated to maintain confidentiality with regard to the reporter of an incident.
-Further details of specific enforcement policies may be posted separately.
-
-Project maintainers who do not follow or enforce the Code of Conduct in good
-faith may face temporary or permanent repercussions as determined by other
-members of the project's leadership.
-
-## Attribution
-
-This Code of Conduct is adapted from the [Contributor Covenant][homepage], version 1.4,
-available at [http://contributor-covenant.org/version/1/4][version]
-
-[homepage]: http://contributor-covenant.org
-[version]: http://contributor-covenant.org/version/1/4/