smart_proxy_dynflow 0.8.0 → 0.8.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 8852c64e45de97691310f1c9fd17bef228a9ea87db2085377cee1cd404546752
-  data.tar.gz: 54afa19849d245f44f8d5e03c69d82e30015ff95978b266cad0db3919eb82195
+  metadata.gz: 0c9cd93e1cf950c5f7977d700a2d8b307faa98182af93063c55ced580617d054
+  data.tar.gz: 2de7767e855c5914d6db7678ef2c2302c414a20b04cb6dd4df7294263ee00f95
 SHA512:
-  metadata.gz: 4a1799f87c74aa10807ea642d217686f208fe2de5444b4a87c540a8685e419d4c88b272e03faa83a9756fa7ef4e996f3cd8195f730ae43e97800e4666fecae59
-  data.tar.gz: ab1dd31d7555502d566803ba4e87965e2431bb6d32c67cc6e0e39f7ac1c6c5369e22b1b6c7f6e3abb8cfdcccf6b4432029ba10b277171931f6a5fa05ed792d8d
+  metadata.gz: b03995ac1c1bf44c900926371d3b42c56f05dc8b994fb07f3c87613e788a990e9ec597d67bb24a97279ae4bc0557fca01dabfbaace26299553467f8173ff8f73
+  data.tar.gz: 0d4737d0298d940988c51ba62e04c45740530660ae76c492e706459965446e984f2ddeb319651a416864636dca407d4f281029bb75da9ad747da7f6b6d71ee42

data/lib/smart_proxy_dynflow/process_manager.rb

@@ -76,12 +76,12 @@ module Proxy
         out_read, out_write = IO.pipe
         err_read, err_write = IO.pipe
 
-        @pid = spawn(*@command, :in => in_read, :out => out_write, :err => err_write)
-        [in_read, out_write, err_write].each(&:close)
-
         @stdin.io  = in_write
         @stdout.io = out_read
         @stderr.io = err_read
+
+        @pid = spawn(*@command, :in => in_read, :out => out_write, :err => err_write)
+        [in_read, out_write, err_write].each(&:close)
       rescue Errno::ENOENT => e
         [in_read, in_write, out_read, out_write, err_read, err_write].each(&:close)
         @pid = -1
@@ -158,8 +158,10 @@ module Proxy
       # @return [void]
       def finish
         close
-        _pid, status = Process.wait2(@pid)
-        @status = status.exitstatus
+        unless @pid == -1
+          _pid, status = Process.wait2(@pid)
+          @status = status.exitstatus
+        end
       end
     end
   end

data/lib/smart_proxy_dynflow/runner/command.rb

@@ -1,5 +1,18 @@
 module Proxy::Dynflow
   module Runner
+    # This module expects to be included into a Runner action, where it can be
+    # used to simplify handling of long-running processes. However it tracks the
+    # running process as a group of instance variables, which has served us
+    # reasonably well in the past, but can be rather error prone.
+    #
+    # A better alternative to this is
+    # {::Proxy::Dynflow::Runner::ProcessManagerCommand}. It tracks the whole
+    # execution of a process under a single instance variable and uses a more
+    # robust {::Proxy::Dynflow::ProcessManager} under the hood. It also
+    # maintains the same interface and can be used as a drop-in replacement.
+    #
+    # This module is now soft-deprecated and
+    # {::Proxy::Dynflow::Runner::ProcessManagerCommand} should be used instead.
     module Command
       def initialize_command(*command)
         @command_out, @command_in, @command_pid = PTY.spawn(*command)

data/lib/smart_proxy_dynflow/runner/command_runner.rb

@@ -4,6 +4,7 @@ require 'smart_proxy_dynflow/runner/command'
 
 module Proxy::Dynflow
   module Runner
+    # This class is now soft-deprecated, see {::Proxy::Dynflow::Runner::Command}
     class CommandRunner < Base
       include Command
     end

data/lib/smart_proxy_dynflow/runner/process_manager_command.rb

@@ -2,13 +2,21 @@ require 'smart_proxy_dynflow/process_manager'
 
 module Proxy::Dynflow
   module Runner
+    # A convenience module which should be included into a Runner action. It
+    # leverages {::Proxy::Dynflow::ProcessManager} to reliably keep track of
+    # an external process and collect its output.
+    #
+    # The only expectation from the Runner action is to call
+    # {#initialize_command} somewhere and pass the command to be run to it.
     module ProcessManagerCommand
       def initialize_command(*command)
         @process_manager = ProcessManager.new(command)
         set_process_manager_callbacks(@process_manager)
         @process_manager.start!
         if @process_manager.done? && @process_manager.status == 255
-          publish_exception("Error running command '#{command.join(' ')}'", @process_manager.stderr.to_s)
+          exception = RuntimeError.new(@process_manager.stderr.to_s)
+          exception.set_backtrace Thread.current.backtrace
+          publish_exception("Error running command '#{command.join(' ')}'", exception)
         end
       end
 
@@ -24,7 +32,7 @@ module Proxy::Dynflow
       end
 
       def refresh
-        @process_manager.process(timeout: 0.1)
+        @process_manager.process(timeout: 0.1) unless @process_manager.done?
         publish_exit_status(@process_manager.status) if @process_manager.done?
       end
 

data/lib/smart_proxy_dynflow/version.rb

@@ -1,5 +1,5 @@
 module Proxy
   module Dynflow
-    VERSION = '0.8.0'.freeze
+    VERSION = '0.8.1'.freeze
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: smart_proxy_dynflow
 version: !ruby/object:Gem::Version
-  version: 0.8.0
+  version: 0.8.1
 platform: ruby
 authors:
 - Ivan Nečas