smart_properties 1.2.0 → 1.2.1

data/.travis.yml

@@ -1,9 +1,10 @@
 rvm:
-  - 1.8.7
-  - 1.9.2
   - 1.9.3
-  - jruby
+  - jruby-19mode
   - rbx-19mode
+  - rbx-18mode
+
+bundler_args: --without documentation
 
 branches:
   only:

data/Gemfile

@@ -3,4 +3,12 @@ source 'https://rubygems.org'
 # Specify your gem's dependencies in smart_properties.gemspec
 gemspec
 
-gem "ruby_gntp"
+if RUBY_PLATFORM =~ /darwin/
+  gem "ruby_gntp"
+  gem "rb-fsevent"
+end
+
+group :documentation do
+  gem "yard"
+  gem "redcarpet"
+end

data/Rakefile

@@ -2,9 +2,12 @@
 require 'bundler/setup'
 require 'bundler/gem_tasks'
 
-require 'yard'
-YARD::Rake::YardocTask.new do |t|
-  t.files   = ['lib/**/*.rb', 'README.md']
+begin
+  require 'yard'
+  YARD::Rake::YardocTask.new do |t|
+    t.files   = ['lib/**/*.rb', 'README.md']
+  end
+rescue LoadError
 end
 
 require 'rspec/core/rake_task'

data/lib/smart_properties.rb

@@ -22,7 +22,7 @@
 #
 module SmartProperties
 
-  VERSION = "1.2.0"
+  VERSION = "1.2.1"
 
   class Property
 
@@ -40,7 +40,7 @@ module SmartProperties
       @required  = !!attrs.delete(:required)
 
       unless attrs.empty?
-        raise ArgumentError, "SmartProperties do not support the following configuration options: #{attrs.keys.join(', ')}."
+        raise ArgumentError, "SmartProperties do not support the following configuration options: #{attrs.keys.map { |m| m.to_s }.sort.join(', ')}."
       end
     end
 
@@ -165,7 +165,7 @@ module SmartProperties
         end
 
         def to_hash
-          Hash[members.zip(entries)]
+          Hash[each_pair.to_a]
         end
       end
     end

data/smart_properties.gemspec

@@ -18,10 +18,8 @@ Gem::Specification.new do |gem|
   gem.name          = "smart_properties"
   gem.require_paths = ["lib"]
   gem.version       = SmartProperties::VERSION
-  
+
   gem.add_development_dependency "rspec", "~> 2.0"
   gem.add_development_dependency "rake", "~> 0.8"
-  gem.add_development_dependency "yard", "~> 0.8"
-  gem.add_development_dependency "redcarpet", "~> 2.1"
   gem.add_development_dependency "guard-rspec", "~> 0.7"
 end

data/spec/smart_properties_spec.rb

@@ -472,4 +472,75 @@ describe SmartProperties do
 
   end
 
+  context 'when used to build a class that is then subclassed and later extended at runtime' do
+
+    let!(:klass) do
+      Class.new.tap do |c|
+        c.send(:include, described_class)
+        c.send(:property, :title)
+      end
+    end
+
+    let!(:subklass) do
+      Class.new(klass).tap do |c|
+        c.send(:property, :body)
+      end
+    end
+
+    before do
+      klass.tap do |c|
+        c.send(:property, :subject)
+      end
+    end
+
+    context "the class's properties" do
+
+      subject { klass.properties }
+
+      it { should have_key(:title) }
+      it { should have_key(:subject) }
+
+    end
+
+    context "the subclass's properties" do
+
+      subject { subklass.properties }
+
+      it { should have_key(:title) }
+      it { should have_key(:body) }
+
+      pending '(dynamically defined property is not inherited)' do
+        it { should have_key(:subject) }
+      end
+
+    end
+
+    context 'the subclass' do
+
+      subject { subklass }
+
+      it "should be initializable using a block", :pending => true do
+        configuration_instructions = lambda do |s|
+          s.title = "Lorem Ipsum"
+          s.priority = :low
+          s.body = "Lorem ipsum dolor sit amet."
+        end
+
+        expect { subject.new(&configuration_instructions) }.to_not raise_error
+      end
+
+      it "should be initializable using a hash of attributes" do
+        attributes = {
+          :title => "Lorem Ipsum",
+          :priority => :low,
+          :body => "Lorem ipsum dolor sit amet."
+        }
+
+        expect { subject.new(attributes) }.to_not raise_error
+      end
+
+    end
+
+  end
+
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: smart_properties
 version: !ruby/object:Gem::Version
-  version: 1.2.0
+  version: 1.2.1
   prerelease: 
 platform: ruby
 authors:
@@ -43,38 +43,6 @@ dependencies:
     - - ~>
       - !ruby/object:Gem::Version
         version: '0.8'
-- !ruby/object:Gem::Dependency
-  name: yard
-  requirement: !ruby/object:Gem::Requirement
-    none: false
-    requirements:
-    - - ~>
-      - !ruby/object:Gem::Version
-        version: '0.8'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    none: false
-    requirements:
-    - - ~>
-      - !ruby/object:Gem::Version
-        version: '0.8'
-- !ruby/object:Gem::Dependency
-  name: redcarpet
-  requirement: !ruby/object:Gem::Requirement
-    none: false
-    requirements:
-    - - ~>
-      - !ruby/object:Gem::Version
-        version: '2.1'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    none: false
-    requirements:
-    - - ~>
-      - !ruby/object:Gem::Version
-        version: '2.1'
 - !ruby/object:Gem::Dependency
   name: guard-rspec
   requirement: !ruby/object:Gem::Requirement
@@ -126,7 +94,7 @@ required_ruby_version: !ruby/object:Gem::Requirement
       version: '0'
       segments:
       - 0
-      hash: 2972832392315398871
+      hash: 183774927770524698
 required_rubygems_version: !ruby/object:Gem::Requirement
   none: false
   requirements:
@@ -135,7 +103,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
       segments:
       - 0
-      hash: 2972832392315398871
+      hash: 183774927770524698
 requirements: []
 rubyforge_project: 
 rubygems_version: 1.8.24