smart_properties 1.12.0 → 1.13.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 308f2acd5b26ff6c0d5f008835d1ed86ba18218c
-  data.tar.gz: d3744f7a5be843235043d5f04d290693016e0877
+  metadata.gz: fbf78f2b4f868f64a7e675336305c7f68579ec33
+  data.tar.gz: 12eeb1777b492bfb56f4d3fe68e0b2fbea222d88
 SHA512:
-  metadata.gz: 7f62e2aee8c528d1d6387e5e51594a998e6ef81c9afdc17935e51389c774f769eaeadc7cd3d55b0b7242c50730be371d2c843f26a4ccfe4e0d34c9f5fb72bb35
-  data.tar.gz: 34fc69a7afb5635f32201fb8e3c9ca132177fe628ffcd3b7b3f11462dd1901360041234542dc9998b8fd04ab8b62593ed07308b834d5f482152fd17955150435
+  metadata.gz: 67139c47fcc6da96c64d3d4489cfc16144f5cdb8772ece8b96e493a3aed6b127de5197003d7695f1d61365e7b2154a5983c2653c9b33e9529ac3d5f4702293b1
+  data.tar.gz: 926f1575ffe3723a502ae0f2d427df880d638fafc47ff5870a19df87e81103cf435bf4f2931d583a08e9f7095e1ac41e2d2d7fcab6c54b628b728522f6777b64

data/lib/smart_properties.rb

@@ -107,10 +107,15 @@ module SmartProperties
 
   ##
   # Implements a key-value enabled constructor that acts as default
-  # constructor for all {SmartProperties}-enabled classes.
+  # constructor for all {SmartProperties}-enabled classes. Positional arguments
+  # or keyword arguments that do not correspond to a property are forwarded to
+  # the super class constructor.
   #
   # @param [Hash] attrs the set of attributes that is used for initialization
   #
+  # @raise [SmartProperties::ConstructorArgumentForwardingError] when unknown arguments were supplied that could not be processed by the super class initializer either.
+  # @raise [SmartProperties::InitializationError] when incorrect values were supplied or required values weren't been supplied.
+  #
   def initialize(*args, &block)
     attrs = args.last.is_a?(Hash) ? args.pop.dup : {}
     properties = self.class.properties
@@ -130,7 +135,11 @@ module SmartProperties
     end
 
     # Call the super constructor and forward unprocessed arguments
-    attrs.empty? ? super(*args) : super(*args.push(attrs))
+    begin
+      attrs.empty? ? super(*args) : super(*args.dup.push(attrs))
+    rescue ArgumentError
+      raise SmartProperties::ConstructorArgumentForwardingError.new(args, attrs)
+    end
 
     # Execute configuration block
     block.call(self) if block

data/lib/smart_properties/errors.rb

@@ -13,6 +13,35 @@ module SmartProperties
     end
   end
 
+  class ConstructorArgumentForwardingError < Error
+    def initialize(positional_arguments, keyword_arguments)
+      argument_description = [
+        generate_description("positional", positional_arguments.count),
+        generate_description("keyword", keyword_arguments.count)
+      ].compact
+
+      arguments = positional_arguments + keyword_arguments.map { |name, value| "#{name}: #{value}" }
+
+      super "Forwarding the following %s failed: %s" % [
+        argument_description.join(" and "),
+        arguments.join(", ")
+      ]
+    end
+
+    private
+
+    def generate_description(argument_type, argument_number)
+      case argument_number
+      when 0
+        nil
+      when 1
+        "#{argument_type} argument"
+      else
+        "#{argument_number} #{argument_type} arguments"
+      end
+    end
+  end
+
   class MissingValueError < AssignmentError
     def initialize(sender, property)
       super(

data/lib/smart_properties/version.rb

@@ -1,3 +1,3 @@
 module SmartProperties
-  VERSION = "1.12.0"
+  VERSION = "1.13.0"
 end

data/spec/base_spec.rb

@@ -19,6 +19,21 @@ RSpec.describe SmartProperties do
         expect { instance = klass.new(title: BasicObject) }.to_not raise_error
       end
     end
+
+    context "the initializer" do
+      it "should raise an ConstructorArgumentForwardingError if provided with an additional positional argument" do
+        unexpected_argument = double("unexpected argument")
+        expect { klass.new(unexpected_argument) }
+          .to raise_error(SmartProperties::ConstructorArgumentForwardingError, /Forwarding the following positional argument failed:.*unexpected argument.*/)
+      end
+
+      it "should raise an ConstructorArgumentForwardingError if provided with unknown keyword arguments" do
+        unexpected_argument1 = double("unexpected argument")
+        unexpected_argument2 = double("unexpected argument")
+        expect { klass.new(first_arg: unexpected_argument1, second_arg: unexpected_argument2) }
+            .to raise_error(SmartProperties::ConstructorArgumentForwardingError, /Forwarding the following 2 keyword arguments failed: first_arg: .*unexpected argument.*, second_arg: .*unexpected argument.*/)
+      end
+    end
   end
 
   context "when used to build a class that has a property called title that utilizes the full feature set of SmartProperties" do

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: smart_properties
 version: !ruby/object:Gem::Version
-  version: 1.12.0
+  version: 1.13.0
 platform: ruby
 authors:
 - Konstantin Tennhard
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-10-11 00:00:00.000000000 Z
+date: 2016-10-13 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rspec