smart_properties 1.10.0 → 1.10.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: c5343469849e0419f91004d5beab3e1516f1d609
-  data.tar.gz: 90469264e820a223d9d77a896f5899b10c67e3ba
+  metadata.gz: 51973702fc038f8cc5e9ebd3f324096da3cd7a1f
+  data.tar.gz: 503b028e51034731838313d04197abbae91eecb2
 SHA512:
-  metadata.gz: dacd46d89ef227413d25bb3770dcd3bfad5b340f212a46cbd385fd9063d66fa7979fbb84a030600810acc95b1cefdd4a2c562bf7c2cbab47c6afb90fc5dabc77
-  data.tar.gz: 73e2cac3ff5075e1cb1bc61d28c85e8a54d6e14174ad0dfcaf55cd3c1b419d916b3dad78c1a0e481a1aa57582e59ca3fb6e68030e72206820beff2bc681b38a3
+  metadata.gz: 4107bbacae8c70445914acbacfa7b294fab58e81aecdf83fc3084aa57f5448bfcd0be73d5ad1a13e29da0a99498d188c8499bb740e05a7f501cb66bc21d37cfc
+  data.tar.gz: 1cb798b2e0c8a984f5a4779d16e2c0f20fb35228b5de80c4e0926bb9cb5700d5b08944447b77cd7ed47d77fdfd2d5317f630d42226743d18dfe3550ed6caf277

data/lib/smart_properties/errors.rb

@@ -35,13 +35,15 @@ module SmartProperties
 
     def initialize(sender, property, value)
       @value = value
+
       super(
         sender,
         property,
-        "%s does not accept %s as value for the property %s" % [
+        "%s does not accept %s as value for the property %s. Only accepts: %s" % [
           sender.class.name,
           value.inspect,
-          property.name
+          property.name,
+          acceptor_message(sender, property)
         ]
       )
     end
@@ -49,6 +51,16 @@ module SmartProperties
     def to_hash
       Hash[property.name, "does not accept %s as value" % value.inspect]
     end
+
+    private
+
+    def acceptor_message(sender, property)
+      acceptor = sender.class.properties[property.name].accepter
+      if acceptor.is_a?(Proc)
+        return "Values passing lambda defined in #{acceptor.source_location.join(' at line ')}"
+      end
+      acceptor
+    end
   end
 
   class InitializationError < Error

data/lib/smart_properties/version.rb

@@ -1,3 +1,3 @@
 module SmartProperties
-  VERSION = "1.10.0"
+  VERSION = "1.10.1"
 end

data/smart_properties.gemspec

@@ -1,5 +1,5 @@
 # -*- encoding: utf-8 -*-
-require_relative 'lib/smart_properties/version'
+require File.expand_path('../lib/smart_properties/version', __FILE__)
 
 Gem::Specification.new do |gem|
   gem.authors       = ["Konstantin Tennhard"]

data/spec/acceptance_checking_spec.rb

@@ -19,8 +19,10 @@ RSpec.describe SmartProperties, 'acceptance checking' do
 
       it "should not allow to set :maybe as value for visible" do
         exception = SmartProperties::InvalidValueError
-        message =  "Dummy does not accept :maybe as value for the property visible"
-        further_expectations = lambda { |error| expect(error.to_hash[:visible]).to eq('does not accept :maybe as value') }
+        message =  /Dummy does not accept \:maybe as value for the property visible/
+        further_expectations = lambda do |error|
+          expect(error.to_hash[:visible]).to eq('does not accept :maybe as value')
+        end
 
         expect { klass.new visible: :maybe }.to raise_error(exception, message, &further_expectations)
         expect { klass.new { |i| i.visible = :maybe } }.to raise_error(exception, message, &further_expectations)
@@ -28,6 +30,13 @@ RSpec.describe SmartProperties, 'acceptance checking' do
         expect { instance.visible = :maybe }.to raise_error(exception, message, &further_expectations)
         expect { instance[:visible] = :maybe }.to raise_error(exception, message, &further_expectations)
       end
+
+      it 'should give the user a list of what it accepts on InvalidValueError' do
+        exception = SmartProperties::InvalidValueError
+        message = /Only accepts\: \[true, false\]/
+
+        expect { klass.new visible: :maybe }.to raise_error(exception, message)
+      end
     end
   end
 
@@ -47,10 +56,12 @@ RSpec.describe SmartProperties, 'acceptance checking' do
         expect { subject[:title] = :test }.to_not raise_error
       end
 
-      it 'should not an instance of any other type' do
+      it 'should not accept an instance of any other type' do
         exception = SmartProperties::InvalidValueError
-        message = 'Dummy does not accept 13 as value for the property title'
-        further_expectations = lambda { |error| expect(error.to_hash[:title]).to eq('does not accept 13 as value') }
+        message = /Dummy does not accept 13 as value for the property title/
+        further_expectations = lambda do |error|
+          expect(error.to_hash[:title]).to match(/does not accept 13 as value/)
+        end
 
         expect { klass.new title: 13 }.to raise_error(exception, message, &further_expectations)
         expect { klass.new { |i| i.title = 13 } }.to raise_error(exception, message, &further_expectations)
@@ -58,10 +69,17 @@ RSpec.describe SmartProperties, 'acceptance checking' do
         expect { instance.title = 13 }.to raise_error(exception, message, &further_expectations)
         expect { instance[:title] = 13 }.to raise_error(exception, message, &further_expectations)
       end
+
+      it 'should give the user a list of what it accepts on InvalidValueError' do
+        exception = SmartProperties::InvalidValueError
+        message = /Only accepts\: \[String, Symbol\]/
+
+        expect { klass.new title: 13 }.to raise_error(exception, message)
+      end
     end
   end
 
-  context 'when used to build a class that has a property called :license_plate which uses a lambda statement for accpetance checking' do
+  context 'when used to build a class that has a property called :license_plate which uses a lambda statement for acceptance checking' do
     subject(:klass) do
       DummyClass.new do
         property :license_plate, accepts: lambda { |v| license_plate_pattern.match(v) }
@@ -77,8 +95,10 @@ RSpec.describe SmartProperties, 'acceptance checking' do
 
       it 'should not a accept "invalid" as value for license_plate' do
         exception = SmartProperties::InvalidValueError
-        message = 'Dummy does not accept "invalid" as value for the property license_plate'
-        further_expectations = lambda { |error| expect(error.to_hash[:license_plate]).to eq('does not accept "invalid" as value') }
+        message = /Dummy does not accept "invalid" as value for the property license_plate/
+        further_expectations = lambda do |error|
+          expect(error.to_hash[:license_plate]).to match(/does not accept "invalid" as value/)
+        end
 
         expect { klass.new license_plate: "invalid" }.to raise_error(exception, message, &further_expectations)
         expect { klass.new { |i| i.license_plate = "invalid" } }.to raise_error(exception, message, &further_expectations)
@@ -87,6 +107,13 @@ RSpec.describe SmartProperties, 'acceptance checking' do
         expect { instance[:license_plate] = "invalid" }.to raise_error(exception, message, &further_expectations)
       end
 
+      it 'should give the user the location of the proc determining what it accepts on InvalidValueError' do
+        exception = SmartProperties::InvalidValueError
+        message = /spec\/acceptance_checking_spec\.rb at line 85/
+
+        expect { klass.new license_plate: 'slurp' }.to raise_error(exception, message)
+      end
+
       it 'should accept "NE RD 1337" as license plate' do
         expect { klass.new.license_plate = "NE RD 1337" }.to_not raise_error
         expect { klass.new { |i| i.license_plate = "NE RD 1337" } }.to_not raise_error

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: smart_properties
 version: !ruby/object:Gem::Version
-  version: 1.10.0
+  version: 1.10.1
 platform: ruby
 authors:
 - Konstantin Tennhard
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-10-11 00:00:00.000000000 Z
+date: 2016-04-28 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rspec
@@ -63,7 +63,6 @@ extensions: []
 extra_rdoc_files: []
 files:
 - ".gitignore"
-- ".travis.yml"
 - ".yardopts"
 - Gemfile
 - LICENSE
@@ -105,7 +104,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.4.5
+rubygems_version: 2.5.1
 signing_key: 
 specification_version: 4
 summary: SmartProperties – Ruby accessors on steroids

data/.travis.yml

@@ -1,8 +0,0 @@
-rvm:
-  - 2.2.0
-  - 1.9.3
-  - rbx-2
-  - ruby-head
-  - jruby-head
-
-bundler_args: --without documentation