smart_init 4.2.1 → 5.0.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 87c97f355f94cafbe2dc57c0c4894ecc2dbc916795d6f9789841a94f88cccd08
-  data.tar.gz: 1fae85e561e47465fee2b2c34520987d6d4517c8466061adc4da85093baca94f
+  metadata.gz: e98d279fac333ac355c8d854d724c567151dd9798d11cf248f50e75edc1ebdc0
+  data.tar.gz: 517a005cd94b3841e6f212c4368034c220aff25c1e73410e884445397bc5da34
 SHA512:
-  metadata.gz: b35c0abc26085a6008d0d34d878dfc4c1da3285cae60c052428a243af0bb68fe3c0f17fd660cf5e4cadb20ea3cf3adfbfe26771fcf76d025ecb037f483bbfdfa
-  data.tar.gz: ee1805b175baacf1476a8ef6a2ced3313279eae99b56f82dbf8ffc2f090a822fcd6af7f9870e8f3c11074371e2f5e7ef81a4605ba875c40b0c94147be25740bf
+  metadata.gz: 98a3581a564a6ffc532c52540c4942d2b103b3d0bec9d5511e40e0fc57c6dd775bfb79ddcfa9d2e3acf0616ab8b4c724fc50ce173658cc63d14aff230667d3b0
+  data.tar.gz: f789ca9f6b424fc6b77f519ef90564d08ac85eb937ac11e77856cb2a41c1f41f12fc825f450d114ef8bf8d7c24f6dacd92ba9cbbad5e5c7944022a05ecc868c1

data/README.md

@@ -1,4 +1,4 @@
-# Smart Init [![Build Status](https://travis-ci.org/pawurb/smart_init.svg)](https://travis-ci.org/pawurb/smart_init) [![Gem Version](https://badge.fury.io/rb/smart_init.svg)](https://badge.fury.io/rb/smart_init)
+# Smart Init - Simple service objects in Ruby [![Build Status](https://travis-ci.org/pawurb/smart_init.svg)](https://travis-ci.org/pawurb/smart_init) [![Gem Version](https://badge.fury.io/rb/smart_init.svg)](https://badge.fury.io/rb/smart_init)
 
 Do you find yourself writing a lot of boilerplate code like this?
 
@@ -32,6 +32,8 @@ gem 'smart_init'
 You can use it either by extending a module:
 
 ```ruby
+require 'smart_init'
+
 class ApiClient
   extend SmartInit
 
@@ -214,21 +216,3 @@ client.api_token = 'new_token' => # NoMethodError (undefined method `api_token='
 client.timeout_length => 100
 client.timeout_length = 150 => # NoMethodError (undefined method `timeout_length=' called for #<SemiPublicReadersSemiPublicAccessorsApiClient:0x000...>)
 ```
-
-## Arguments API
-
-Alternatively you can use an API without hash arguments, default values, public readers, or public accessors support:
-
-```ruby
-class Calculator < SmartInit::Base
-  initialize_with_args :data
-  is_callable
-
-  def call
-    ...
-    result
-  end
-end
-
-Calculator.call(data) => result
-```

data/lib/smart_init/main.rb

@@ -8,13 +8,12 @@ module SmartInit
       :call
     end
 
-    define_singleton_method method_name do |*parameters|
-      new(*parameters).public_send(method_name)
+    define_singleton_method method_name do |**parameters|
+      new(**parameters).public_send(method_name)
     end
   end
 
   def initialize_with_hash(*required_attrs, **attributes_and_options)
-
     public_readers = attributes_and_options.delete(:public_readers) || []
     public_accessors = attributes_and_options.delete(:public_accessors) || []
     if  public_readers == true || public_accessors == true
@@ -52,28 +51,6 @@ module SmartInit
   end
 
   alias initialize_with initialize_with_hash
-
-  def initialize_with_args *attributes
-    define_method :initialize do |*parameters|
-      if attributes.count != parameters.count
-        raise ArgumentError, "wrong number of arguments (given #{parameters.count}, expected #{attributes.count})"
-      end
-
-      attributes.zip(parameters).each do |pair|
-        name = pair[0]
-        value = pair[1]
-        instance_variable_set("@#{name}", value)
-      end
-    end
-
-    instance_eval do
-      attr_reader(*attributes)
-
-      attributes.each do |method_name|
-        private method_name
-      end
-    end
-  end
 end
 
 class SmartInit::Base

data/lib/smart_init/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module SmartInit
-  VERSION = "4.2.1"
+  VERSION = "5.0.0"
 end

data/test/test_hash_public_accessors.rb

@@ -4,7 +4,7 @@ require "byebug"
 require "test/unit"
 require_relative '../lib/smart_init/main'
 
-class TestAllPublic
+class TestAllPublicAccessors
   extend SmartInit
   initialize_with :attribute_1, :attribute_2, public_accessors: true
   is_callable
@@ -14,7 +14,7 @@ class TestAllPublic
   end
 end
 
-class TestSomePublic
+class TestSomePublicAccessors
   extend SmartInit
   initialize_with :attribute_1, :attribute_2, public_accessors: [:attribute_1]
   is_callable
@@ -24,7 +24,7 @@ class TestSomePublic
   end
 end
 
-class TestDefaultPublic
+class TestDefaultPublicAccessors
   extend SmartInit
   initialize_with :attribute_1, attribute_2: 2, public_accessors: [:attribute_2]
 
@@ -33,9 +33,9 @@ class TestDefaultPublic
   end
 end
 
-class HashApiPublicTest < Test::Unit::TestCase
+class HashApiPublicTestAccessors < Test::Unit::TestCase
   def test_all_public
-    service = TestAllPublic.new(attribute_1: "a", attribute_2: "b")
+    service = TestAllPublicAccessors.new(attribute_1: "a", attribute_2: "b")
     assert_nothing_raised do
       service.attribute_1 = "c"
       service.attribute_2 = "d"
@@ -45,7 +45,7 @@ class HashApiPublicTest < Test::Unit::TestCase
   end
 
   def test_some_public
-    service = TestSomePublic.new(attribute_1: "a", attribute_2: "b")
+    service = TestSomePublicAccessors.new(attribute_1: "a", attribute_2: "b")
     assert_nothing_raised do
       service.attribute_1 = "c"
     end
@@ -59,7 +59,7 @@ class HashApiPublicTest < Test::Unit::TestCase
   end
 
   def test_default_public
-    service = TestDefaultPublic.new(attribute_1: "a")
+    service = TestDefaultPublicAccessors.new(attribute_1: "a")
     assert_nothing_raised do
       service.attribute_2 = 3
     end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: smart_init
 version: !ruby/object:Gem::Version
-  version: 4.2.1
+  version: 5.0.0
 platform: ruby
 authors:
 - pawurb
-autorequire: 
+autorequire:
 bindir: bin
 cert_chain: []
-date: 2020-06-08 00:00:00.000000000 Z
+date: 2020-08-10 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rake
@@ -69,7 +69,6 @@ files:
 - lib/smart_init/main.rb
 - lib/smart_init/version.rb
 - smart_init.gemspec
-- test/test_args_api.rb
 - test/test_hash_api.rb
 - test/test_hash_public_accessors.rb
 - test/test_hash_public_mixed.rb
@@ -78,7 +77,7 @@ homepage: http://github.com/pawurb/smart_init
 licenses:
 - MIT
 metadata: {}
-post_install_message: 
+post_install_message:
 rdoc_options: []
 require_paths:
 - lib
@@ -93,12 +92,11 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.0.6
-signing_key: 
+rubygems_version: 3.1.2
+signing_key:
 specification_version: 4
 summary: Remove Ruby initializer boilerplate code
 test_files:
-- test/test_args_api.rb
 - test/test_hash_api.rb
 - test/test_hash_public_accessors.rb
 - test/test_hash_public_mixed.rb

data/test/test_args_api.rb

@@ -1,79 +0,0 @@
-# frozen_string_literal: true
-
-require "test/unit"
-require_relative '../lib/smart_init/main'
-
-class TestClass
-  extend SmartInit
-  initialize_with_args :attribute_1, :attribute_2
-  is_callable
-
-  def call
-    [attribute_1, attribute_2]
-  end
-end
-
-class TestNoInit
-  extend SmartInit
-  is_callable
-
-  def call
-    'result'
-  end
-end
-
-class TestMethodName
-  extend SmartInit
-
-  is_callable method_name: :run!
-
-  def run!
-    true
-  end
-end
-
-def test_object
-  @_test_object ||= TestClass.new("attr_1_value", "attr_2_value")
-end
-
-class StandardApiTest < Test::Unit::TestCase
-  def test_number_of_attributes
-    assert_nothing_raised do
-      TestClass.new(
-        "attr_1_value",
-        "attr_2_value"
-      )
-    end
-
-    assert_raise ArgumentError do
-      TestClass.new(
-        "attr_1_value"
-      )
-    end
-  end
-
-  def test_instance_variables
-    assert_equal test_object.instance_variable_get("@attribute_1"), "attr_1_value"
-  end
-
-  def test_private_getters
-    error = assert_raise NoMethodError do
-      test_object.attribute_1
-    end
-    assert_match("private method", error.message)
-
-    assert_equal test_object.send(:attribute_1), "attr_1_value"
-  end
-
-  def test_is_callable
-    assert_equal TestClass.call("a", "b"), ["a", "b"]
-  end
-
-  def test_is_callable_no_initializers
-    assert_equal TestNoInit.call, 'result'
-  end
-
-  def test_is_callable_method_name
-    assert_equal TestMethodName.run!, true
-  end
-end