smart_field_constraints 0.0.2 → 0.1.0

data/{CHANGELOG → CHANGELOG.rdoc}

@@ -1,23 +1,21 @@
-*SVN*
+== master
 
-*0.0.2* (June 22nd, 2008)
+== 0.1.0 / 2008-12-14
 
-* Remove log files from gems
+* Remove the PluginAWeek namespace
+* Update tests to use ActionView::TestCase
 
-* Don't check length validation constraints if models were loaded prior to the plugin being loaded [grosser]
+== 0.0.2 / 2008-06-22
 
+* Remove log files from gems
+* Don't check length validation constraints if models were loaded prior to the plugin being loaded [grosser]
 * Refactor FormHelper extension to allow for others to easily extend the plugin for things like textarea lengths [grosser]
-
 * Add support for tracking validates_size_of validations
 
-*0.0.1* (May 5th, 2008)
+== 0.0.1 / 2008-05-05
 
 * Initial public release
-
 * Add documentation
-
 * Remove maxlength attribute for textare tags since it's not valid html
-
 * Don't set the size based on the smart maxlength
-
 * Don't expect columns to exist for every attribute

data/{README → README.rdoc}

@@ -5,21 +5,21 @@ fields based on column constraints and validations.
 
 == Resources
 
-Wiki
-
-* http://wiki.pluginaweek.org/Smart_field_constraints
-
 API
 
 * http://api.pluginaweek.org/smart_field_constraints
 
+Bugs
+
+* http://pluginaweek.lighthouseapp.com/projects/13287-smart_field_constraints
+
 Development
 
-* http://dev.pluginaweek.org/browser/trunk/smart_field_constraints
+* http://github.com/pluginaweek/smart_field_constraints
 
 Source
 
-* http://svn.pluginaweek.org/trunk/smart_field_constraints
+* git://github.com/pluginaweek/smart_field_constraints.git
 
 == Description
 
@@ -28,9 +28,9 @@ and improving the user experience. Normally, adding the +maxlength+ configuratio
 option for input fields is not DRY and duplicates data already available in the
 model or database. This plugin helps make this automatic.
 
-+smart_field_cosntraints+ looks in two places for determining the maxlength value
++smart_field_constraints+ looks in two places for determining the maxlength value
 for an input field:
-* Model validates_length_of validations
+* Model validates_length_of/validates_size_of validations
 * Database column definitions (limits specifically)
 
 Model validations will always take preference over database column definitions.
@@ -59,7 +59,7 @@ HTML:
 Since the +maxlength+ attribute is not W3C-compliant for textareas, it is not
 included in the types of fields that will be automatically assigned length
 constraints.  However, you can easily add this yourself by extending the plugin
-like done at http://dev.pluginaweek.org/ticket/2.
+yourself.
 
 == Caveats
 
@@ -81,7 +81,7 @@ config/environment.rb:
 == Testing
 
 Before you can run any tests, the following gem must be installed:
-* plugin_test_helper[http://wiki.pluginaweek.org/Plugin_test_helper]
+* plugin_test_helper[http://github.com/pluginaweek/plugin_test_helper]
 
 To run against a specific version of Rails:
 

data/Rakefile

@@ -3,46 +3,54 @@ require 'rake/rdoctask'
 require 'rake/gempackagetask'
 require 'rake/contrib/sshpublisher'
 
-PKG_NAME           = 'smart_field_constraints'
-PKG_VERSION        = '0.0.2'
-PKG_FILE_NAME      = "#{PKG_NAME}-#{PKG_VERSION}"
-RUBY_FORGE_PROJECT = 'pluginaweek'
-
-desc 'Default: run unit tests.'
+spec = Gem::Specification.new do |s|
+  s.name              = 'smart_field_constraints'
+  s.version           = '0.1.0'
+  s.platform          = Gem::Platform::RUBY
+  s.summary           = 'Intelligently applies a maxlength attribute for text fields based on column constraints and validations'
+  
+  s.files             = FileList['{lib,test}/**/*'] + %w(CHANGELOG.rdoc init.rb LICENSE Rakefile README.rdoc) - FileList['test/app_root/{log,log/*,script,script/*}']
+  s.require_path      = 'lib'
+  s.has_rdoc          = true
+  s.test_files        = Dir['test/**/*_test.rb']
+  
+  s.author            = 'Aaron Pfeifer'
+  s.email             = 'aaron@pluginaweek.org'
+  s.homepage          = 'http://www.pluginaweek.org'
+  s.rubyforge_project = 'pluginaweek'
+end
+  
+desc 'Default: run all tests.'
 task :default => :test
 
-desc 'Test the smart_field_constraints plugin.'
+desc "Test the #{spec.name} plugin."
 Rake::TestTask.new(:test) do |t|
   t.libs << 'lib'
-  t.pattern = 'test/**/*_test.rb'
+  t.test_files = spec.test_files
   t.verbose = true
 end
 
-desc 'Generate documentation for the smart_field_constraints plugin.'
+begin
+  require 'rcov/rcovtask'
+  namespace :test do
+    desc "Test the #{spec.name} plugin with Rcov."
+    Rcov::RcovTask.new(:rcov) do |t|
+      t.libs << 'lib'
+      t.test_files = spec.test_files
+      t.rcov_opts << '--exclude="^(?!lib/)"'
+      t.verbose = true
+    end
+  end
+rescue LoadError
+end
+
+desc "Generate documentation for the #{spec.name} plugin."
 Rake::RDocTask.new(:rdoc) do |rdoc|
   rdoc.rdoc_dir = 'rdoc'
-  rdoc.title    = 'SmartFieldConstraints'
+  rdoc.title    = spec.name
   rdoc.template = '../rdoc_template.rb'
   rdoc.options << '--line-numbers' << '--inline-source'
-  rdoc.rdoc_files.include('README')
-  rdoc.rdoc_files.include('lib/**/*.rb')
-end
-
-spec = Gem::Specification.new do |s|
-  s.name            = PKG_NAME
-  s.version         = PKG_VERSION
-  s.platform        = Gem::Platform::RUBY
-  s.summary         = 'Intelligently applies a maxlength attribute for text fields based on column constraints and validations'
-  
-  s.files           = FileList['{lib,test}/**/*'].to_a - FileList['test/app_root/log/*'].to_a + %w(CHANGELOG init.rb LICENSE Rakefile README)
-  s.require_path    = 'lib'
-  s.autorequire     = 'smart_field_constraints'
-  s.has_rdoc        = true
-  s.test_files      = Dir['test/**/*_test.rb']
-  
-  s.author          = 'Aaron Pfeifer'
-  s.email           = 'aaron@pluginaweek.org'
-  s.homepage        = 'http://www.pluginaweek.org'
+  rdoc.rdoc_files.include('README.rdoc', 'CHANGELOG.rdoc', 'LICENSE', 'lib/**/*.rb')
 end
   
 Rake::GemPackageTask.new(spec) do |p|
@@ -51,14 +59,14 @@ Rake::GemPackageTask.new(spec) do |p|
   p.need_zip = true
 end
 
-desc 'Publish the beta gem'
+desc 'Publish the beta gem.'
 task :pgem => [:package] do
-  Rake::SshFilePublisher.new('aaron@pluginaweek.org', '/home/aaron/gems.pluginaweek.org/public/gems', 'pkg', "#{PKG_FILE_NAME}.gem").upload
+  Rake::SshFilePublisher.new('aaron@pluginaweek.org', '/home/aaron/gems.pluginaweek.org/public/gems', 'pkg', "#{spec.name}-#{spec.version}.gem").upload
 end
 
-desc 'Publish the API documentation'
+desc 'Publish the API documentation.'
 task :pdoc => [:rdoc] do
-  Rake::SshDirPublisher.new('aaron@pluginaweek.org', "/home/aaron/api.pluginaweek.org/public/#{PKG_NAME}", 'rdoc').upload
+  Rake::SshDirPublisher.new('aaron@pluginaweek.org', "/home/aaron/api.pluginaweek.org/public/#{spec.name}", 'rdoc').upload
 end
 
 desc 'Publish the API docs and gem'
@@ -71,10 +79,10 @@ task :release => [:gem, :package] do
   ruby_forge = RubyForge.new.configure
   ruby_forge.login
   
-  %w( gem tgz zip ).each do |ext|
-    file = "pkg/#{PKG_FILE_NAME}.#{ext}"
+  %w(gem tgz zip).each do |ext|
+    file = "pkg/#{spec.name}-#{spec.version}.#{ext}"
     puts "Releasing #{File.basename(file)}..."
     
-    ruby_forge.add_release(RUBY_FORGE_PROJECT, PKG_NAME, PKG_VERSION, file)
+    ruby_forge.add_release(spec.rubyforge_project, spec.name, spec.version, file)
   end
 end

data/lib/smart_field_constraints/extensions/form_helper.rb

@@ -1,56 +1,55 @@
-module PluginAWeek #:nodoc:
-  module SmartFieldConstraints
-    module Extensions #:nodoc:
-      # Automatically applies maximum length for an input field if it can be determined
-      module InstanceTag
-        def self.included(base) #:nodoc:
-          base.class_eval do
-            alias_method_chain :to_input_field_tag, :smart_constraints
-          end
+module SmartFieldConstraints
+  module Extensions #:nodoc:
+    # Automatically applies the maximum length for an input field if it can be
+    # determined
+    module InstanceTag
+      def self.included(base) #:nodoc:
+        base.class_eval do
+          alias_method_chain :to_input_field_tag, :smart_constraints
         end
+      end
+      
+      # Apply constraints for the given field
+      def to_input_field_tag_with_smart_constraints(field_type, options = {})
+        # Only check password and text fields
+        add_max_length_constraints(options) if %w(password text).include?(field_type)
         
-        # Applies constraints for the given field
-        def to_input_field_tag_with_smart_constraints(field_type, options = {})
-          # Only check password and text fields
-          add_max_length_constraints(options) if %w(password text).include?(field_type)
+        to_input_field_tag_without_smart_constraints(field_type, options)
+      end
+      
+      private
+        def add_max_length_constraints(options)
+          options.stringify_keys!
+          return if options['maxlength'] || !object
           
-          to_input_field_tag_without_smart_constraints(field_type, options)
+          # Look for the attribute's maximum length from tracked validations or
+          # the column's definition
+          if max_length = validation_length || column_limit
+            # If the size isn't specified, use the caller's maxlength of the default value.
+            # This must be done here, otherwise it'll use the maxlength value that
+            # we apply here
+            options['size'] ||= options['maxlength'] || ActionView::Helpers::InstanceTag::DEFAULT_FIELD_OPTIONS['size']
+            options['maxlength'] = max_length
+          end
         end
         
-        private
-          def add_max_length_constraints(options)
-            options.stringify_keys!
-            return if options['maxlength'] || !object
-            
-            # Look for the attribute's maximum length from tracked validations or
-            # the column's definition
-            if max_length = validation_length || column_limit
-              # If the size isn't specified, use the caller's maxlength of the default value.
-              # This must be done here, otherwise it'll use the maxlength value that
-              # we apply here
-              options['size'] ||= options['maxlength'] || ActionView::Helpers::InstanceTag::DEFAULT_FIELD_OPTIONS['size']
-              options['maxlength'] = max_length
-            end
-          end
-          
-          # Finds the maximum length according to validations
-          def validation_length
-            if constraints = object.class.smart_length_constraints
-              constraints[method_name]
-            end
+        # Finds the maximum length according to validations
+        def validation_length
+          if constraints = object.class.smart_length_constraints
+            constraints[method_name]
           end
-          
-          # Finds the maximum length according to column limits
-          def column_limit
-            if column = object.class.columns_hash[method_name]
-              column.limit
-            end
+        end
+        
+        # Finds the maximum length according to column limits
+        def column_limit
+          if column = object.class.columns_hash[method_name]
+            column.limit
           end
-      end
+        end
     end
   end
 end
 
 ActionView::Helpers::InstanceTag.class_eval do
-  include PluginAWeek::SmartFieldConstraints::Extensions::InstanceTag
+  include SmartFieldConstraints::Extensions::InstanceTag
 end

data/lib/smart_field_constraints/extensions/validations.rb

@@ -1,76 +1,74 @@
-module PluginAWeek #:nodoc:
-  module SmartFieldConstraints
-    module Extensions #:nodoc:
-      # Tracks validations on the length of fields so that they can be used when
-      # generate form tags for those fields
-      module Validations
-        def self.included(base) #:nodoc:
-          base.class_eval do
-            extend PluginAWeek::SmartFieldConstraints::Extensions::Validations::ClassMethods
-          end
+module SmartFieldConstraints
+  module Extensions #:nodoc:
+    # Tracks validations on the length of fields so that they can be used when
+    # generating form tags for those fields
+    module Validations
+      def self.included(base) #:nodoc:
+        base.class_eval do
+          extend SmartFieldConstraints::Extensions::Validations::ClassMethods
         end
-        
-        module ClassMethods
-          def self.extended(base) #:nodoc:
-            base.class_eval do
-              class_inheritable_hash :smart_length_constraints
-              self.smart_length_constraints = {}
-            end
-            
-            class << base
-              alias_method_chain :validates_length_of, :smart_constraints
-              alias_method_chain :validates_size_of, :smart_constraints
-            end
-          end
-          
-          # Tracks what the maximum value that's allowed for all of the attributes
-          # being validated
-          def validates_length_of_with_smart_constraints(*attrs)
-            track_length_constraints(attrs)
-            validates_length_of_without_smart_constraints(*attrs)
+      end
+      
+      module ClassMethods
+        def self.extended(base) #:nodoc:
+          base.class_eval do
+            class_inheritable_hash :smart_length_constraints
+            self.smart_length_constraints = {}
           end
           
-          # Tracks what the maximum value that's allowed for all of the attributes
-          # being validated
-          def validates_size_of_with_smart_constraints(*attrs)
-            track_length_constraints(attrs)
-            validates_size_of_without_smart_constraints(*attrs)
+          class << base
+            alias_method_chain :validates_length_of, :smart_constraints
+            alias_method_chain :validates_size_of, :smart_constraints
           end
-          
-          private
-            def track_length_constraints(attrs)
-              options = attrs.last
-              if options.is_a?(Hash)
-                # Extract the option restricting the length
-                options = options.symbolize_keys
-                range_options = ActiveRecord::Validations::ClassMethods::ALL_RANGE_OPTIONS & options.keys
-                option = range_options.first
-                option_value = options[range_options.first]
-                
-                # Find the max value from ranges or specific maximums
-                max_length = nil
-                case option
-                when :within, :in
-                  max_length = option_value.end
-                when :maximum, :is
-                  max_length = option_value
-                end
-                
-                if max_length
-                  # Store the maximum value for each attribute so that it can be referenced later
-                  attrs.each do |attr|
-                    self.smart_length_constraints ||= {}
-                    self.smart_length_constraints[attr.to_s] = max_length
-                  end
+        end
+        
+        # Tracks what the maximum value is that's allowed for all of the
+        # attributes being validated
+        def validates_length_of_with_smart_constraints(*attrs)
+          track_length_constraints(attrs)
+          validates_length_of_without_smart_constraints(*attrs)
+        end
+        
+        # Tracks what the maximum value is that's allowed for all of the
+        # attributes being validated
+        def validates_size_of_with_smart_constraints(*attrs)
+          track_length_constraints(attrs)
+          validates_size_of_without_smart_constraints(*attrs)
+        end
+        
+        private
+          def track_length_constraints(attrs)
+            options = attrs.last
+            if options.is_a?(Hash)
+              # Extract the option restricting the length
+              options = options.symbolize_keys
+              range_options = ActiveRecord::Validations::ClassMethods::ALL_RANGE_OPTIONS & options.keys
+              option = range_options.first
+              option_value = options[range_options.first]
+              
+              # Find the max value from ranges or specific maximums
+              max_length = nil
+              case option
+              when :within, :in
+                max_length = option_value.end
+              when :maximum, :is
+                max_length = option_value
+              end
+              
+              if max_length
+                # Store the maximum value for each attribute so that it can be referenced later
+                attrs.each do |attr|
+                  self.smart_length_constraints ||= {}
+                  self.smart_length_constraints[attr.to_s] = max_length
                 end
               end
             end
-        end
+          end
       end
     end
   end
 end
 
 ActiveRecord::Base.class_eval do
-  include PluginAWeek::SmartFieldConstraints::Extensions::Validations
+  include SmartFieldConstraints::Extensions::Validations
 end

data/test/app_root/config/environment.rb

@@ -1,8 +1,7 @@
 require 'config/boot'
 
 Rails::Initializer.run do |config|
-  config.plugin_paths << '..'
-  config.plugins = %w(plugins_plus tags smart_field_constraints)
+  config.plugins = %w(tags smart_field_constraints)
   config.cache_classes = false
   config.whiny_nils = true
 end

data/test/{unit → helpers}/form_helper_test.rb

@@ -1,8 +1,7 @@
-require File.dirname(__FILE__) + '/../test_helper'
+require File.expand_path(File.dirname(__FILE__) + '/../test_helper')
 
-class FormHelperWithoutConstraintsTest < Test::Unit::TestCase
-  include ActionView::Helpers::TagHelper
-  include ActionView::Helpers::FormHelper
+class FormHelperWithoutConstraintsTest < ActionView::TestCase
+  tests ActionView::Helpers::FormHelper
   
   def setup
     @user = User.new
@@ -17,9 +16,8 @@ class FormHelperWithoutConstraintsTest < Test::Unit::TestCase
   end
 end
 
-class FormHelperWithValidationConstraintsTest < Test::Unit::TestCase
-  include ActionView::Helpers::TagHelper
-  include ActionView::Helpers::FormHelper
+class FormHelperWithValidationConstraintsTest < ActionView::TestCase
+  tests ActionView::Helpers::FormHelper
   
   def setup
     User.validates_length_of :biography, :maximum => 120
@@ -59,9 +57,8 @@ class FormHelperWithValidationConstraintsTest < Test::Unit::TestCase
   end
 end
 
-class FormHelperWithColumnConstraintsTest < Test::Unit::TestCase
-  include ActionView::Helpers::TagHelper
-  include ActionView::Helpers::FormHelper
+class FormHelperWithColumnConstraintsTest < ActionView::TestCase
+  tests ActionView::Helpers::FormHelper
   
   def setup
     @user = User.new
@@ -88,9 +85,8 @@ class FormHelperWithColumnConstraintsTest < Test::Unit::TestCase
   end
 end
 
-class FormHelperForModelNotTrackedTest < Test::Unit::TestCase
-  include ActionView::Helpers::TagHelper
-  include ActionView::Helpers::FormHelper
+class FormHelperForModelNotTrackedTest < ActionView::TestCase
+  tests ActionView::Helpers::FormHelper
   
   def setup
     @tag = Tag.new

data/test/unit/validations_test.rb

@@ -1,4 +1,4 @@
-require File.dirname(__FILE__) + '/../test_helper'
+require File.expand_path(File.dirname(__FILE__) + '/../test_helper')
 
 class ModelWithoutLengthValidationsTest < Test::Unit::TestCase
   def test_should_not_have_any_constraints

metadata

@@ -1,15 +1,15 @@
 --- !ruby/object:Gem::Specification 
 name: smart_field_constraints
 version: !ruby/object:Gem::Version 
-  version: 0.0.2
+  version: 0.1.0
 platform: ruby
 authors: 
 - Aaron Pfeifer
-autorequire: smart_field_constraints
+autorequire: 
 bindir: bin
 cert_chain: []
 
-date: 2008-06-22 00:00:00 -04:00
+date: 2008-12-14 00:00:00 -05:00
 default_executable: 
 dependencies: []
 
@@ -24,35 +24,35 @@ extra_rdoc_files: []
 files: 
 - lib/smart_field_constraints
 - lib/smart_field_constraints/extensions
-- lib/smart_field_constraints/extensions/validations.rb
 - lib/smart_field_constraints/extensions/form_helper.rb
+- lib/smart_field_constraints/extensions/validations.rb
 - lib/smart_field_constraints.rb
+- test/test_helper.rb
+- test/unit
+- test/unit/validations_test.rb
+- test/helpers
+- test/helpers/form_helper_test.rb
 - test/app_root
-- test/app_root/app
-- test/app_root/app/models
-- test/app_root/app/models/user.rb
+- test/app_root/db
+- test/app_root/db/migrate
+- test/app_root/db/migrate/001_create_users.rb
+- test/app_root/db/migrate/002_create_tags.rb
+- test/app_root/config
+- test/app_root/config/environment.rb
 - test/app_root/vendor
 - test/app_root/vendor/plugins
 - test/app_root/vendor/plugins/tags
-- test/app_root/vendor/plugins/tags/init.rb
 - test/app_root/vendor/plugins/tags/lib
 - test/app_root/vendor/plugins/tags/lib/tag.rb
-- test/app_root/config
-- test/app_root/config/environment.rb
-- test/app_root/db
-- test/app_root/db/migrate
-- test/app_root/db/migrate/001_create_users.rb
-- test/app_root/db/migrate/002_create_tags.rb
-- test/app_root/log
-- test/test_helper.rb
-- test/unit
-- test/unit/validations_test.rb
-- test/unit/form_helper_test.rb
-- CHANGELOG
+- test/app_root/vendor/plugins/tags/init.rb
+- test/app_root/app
+- test/app_root/app/models
+- test/app_root/app/models/user.rb
+- CHANGELOG.rdoc
 - init.rb
 - LICENSE
 - Rakefile
-- README
+- README.rdoc
 has_rdoc: true
 homepage: http://www.pluginaweek.org
 post_install_message: 
@@ -74,11 +74,11 @@ required_rubygems_version: !ruby/object:Gem::Requirement
   version: 
 requirements: []
 
-rubyforge_project: 
-rubygems_version: 1.1.1
+rubyforge_project: pluginaweek
+rubygems_version: 1.2.0
 signing_key: 
 specification_version: 2
 summary: Intelligently applies a maxlength attribute for text fields based on column constraints and validations
 test_files: 
 - test/unit/validations_test.rb
-- test/unit/form_helper_test.rb
+- test/helpers/form_helper_test.rb