smacks-savon 0.1.0 → 0.1.1

data/README.rdoc

@@ -23,8 +23,8 @@ Instantiate a new Savon::Service instance passing in the WSDL of your service.
 
   proxy = Savon::Service.new "http://example.com/ExampleService?wsdl"
 
-Call the SOAP service method you would like to choose on your Savon::Service
-instance passing in a Hash of options for the service method to receive.
+Call the SOAP service method of your choice on your Savon::Service instance
+passing in a Hash of options for the service method to receive.
 
   response = proxy.findExampleById(:id => 123)
 
@@ -41,12 +41,12 @@ instance to get a list of available SOAP service methods.
 Check if the SOAP request was successful.
 
   response.success?
-  response.fault?
+  response.error?
 
-Access the fault message and code.
+Access error message and code in case a request was not successful.
 
-  response.fault
-  response.fault_code
+  response.error_message
+  response.error_code
 
 === Different response formats
 

data/lib/savon/response.rb

@@ -7,11 +7,11 @@ module Savon
   # Savon::Response represents the HTTP response.
   class Response
 
-    # The HTTP or SOAP fault message.
-    attr_reader :fault
+    # The HTTP error or SOAP fault message.
+    attr_reader :error_message
 
-    # The HTTP or SOAP fault code.
-    attr_reader :fault_code
+    # The HTTP error or SOAP fault code.
+    attr_reader :error_code
 
     # Initializer expects the HTTP response and checks for HTTP or SOAP faults.
     #
@@ -25,12 +25,12 @@ module Savon
 
     # Returns true if the request was successful, false otherwise.
     def success?
-      @fault_code.nil?
+      @error_code.nil?
     end
 
     # Returns true if there was a HTTP or SOAP fault, false otherwise.
-    def fault?
-      !@fault_code.nil?
+    def error?
+      !@error_code.nil?
     end
 
     # Returns the SOAP response message as a Hash. Call with XPath expession
@@ -41,7 +41,7 @@ module Savon
     #
     # * +root_node+ - Optional. Custom root node to start parsing at.
     def to_hash(root_node = "//return")
-      return nil if fault?
+      return nil if error?
       ApricotEatsGorilla[@response.body, root_node]
     end
 
@@ -53,7 +53,7 @@ module Savon
     #
     # * +root_node+ - Optional. Custom root node to start parsing at.
     def to_mash(root_node = "//return")
-      return nil if fault?
+      return nil if error?
       hash = to_hash(root_node)
       Savon::Mash.new(hash)
     end
@@ -65,14 +65,14 @@ module Savon
 
   private
 
-    # Checks for HTTP and SOAP faults.
+    # Checks for HTTP errors and SOAP faults.
     def validate
       if @response.code.to_i >= 300
-        @fault, @fault_code = @response.message, @response.code
+        @error_message, @error_code = @response.message, @response.code
       else
-        fault = to_hash("//soap:Fault")
-        @fault = fault[:faultstring] unless fault.nil?
-        @fault_code = fault[:faultcode] unless fault.nil?
+        soap_fault = to_hash("//soap:Fault")
+        @error_message = soap_fault[:faultstring] unless soap_fault.nil?
+        @error_code = soap_fault[:faultcode] unless soap_fault.nil?
       end
     end
 

data/test/savon/response_test.rb

@@ -35,16 +35,16 @@ class SavonResponseTest < Test::Unit::TestCase
       assert_equal true, @response.success?
     end
 
-    should "return 'false' on fault?" do
-      assert_equal false, @response.fault?
+    should "return 'false' on error?" do
+      assert_equal false, @response.error?
     end
 
-    should "return 'nil' for fault" do
-      assert_equal nil, @response.fault
+    should "return 'nil' for error_message" do
+      assert_equal nil, @response.error_message
     end
 
-    should "return 'nil' for fault_code" do
-      assert_equal nil, @response.fault_code
+    should "return 'nil' for error_code" do
+      assert_equal nil, @response.error_code
     end
   end
 
@@ -70,16 +70,16 @@ class SavonResponseTest < Test::Unit::TestCase
       assert_equal false, @response.success?
     end
 
-    should "return 'true' on fault?" do
-      assert_equal true, @response.fault?
+    should "return 'true' on error?" do
+      assert_equal true, @response.error?
     end
 
-    should "return the fault on fault" do
-      assert_equal soap_fault, @response.fault
+    should "return the error message on error_message" do
+      assert_equal soap_fault, @response.error_message
     end
 
-    should "return the fault_code on fault_code" do
-      assert_equal soap_fault_code, @response.fault_code
+    should "return the error code on error_code" do
+      assert_equal soap_fault_code, @response.error_code
     end
   end
 
@@ -105,16 +105,16 @@ class SavonResponseTest < Test::Unit::TestCase
       assert_equal false, @response.success?
     end
 
-    should "return 'true' on fault?" do
-      assert_equal true, @response.fault?
+    should "return 'true' on error?" do
+      assert_equal true, @response.error?
     end
 
-    should "return the fault on fault" do
-      assert_equal "NotFound", @response.fault
+    should "return the error message on error_message" do
+      assert_equal "NotFound", @response.error_message
     end
 
-    should "return the fault_code on fault_code" do
-      assert_equal "404", @response.fault_code
+    should "return the error code on error_code" do
+      assert_equal "404", @response.error_code
     end
 
   end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification 
 name: smacks-savon
 version: !ruby/object:Gem::Version 
-  version: 0.1.0
+  version: 0.1.1
 platform: ruby
 authors: 
 - Daniel Harrington