slugifiable 0.1.1 → 0.2.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: e9f707db7b8e857da8289a7e17754261aa3dd4b06b517673b983936cc449e530
-  data.tar.gz: 36144ba06043096a3ead2aa5e3728a3c6c0f54bf9be15c27d085e944d47a1b76
+  metadata.gz: f376f3d8ed6b225b61c6bd96cf207d4fb90970a7e138bd0685571225fe750343
+  data.tar.gz: 8d77cb7631dd2e4b7eb7be4b15e1d2fd1d0b3bcb6ddfabfcf0c505d776d50ddd
 SHA512:
-  metadata.gz: 848886284f316ccb3086afcb268ddf09bf136c040a055c353fa4492021d578e439367ce137d471334a339fb43ff2997271267b2c0668d25f7654803cd4e73cad
-  data.tar.gz: 984f18e9268a0fff5b64f3e8d28e654c2586fa99c02f2199134bbac798cb311e68e5714b17c22ef6583eae75f51cce22b209ac08791d973dbe7f71a2e8830645
+  metadata.gz: ae99e80bff43688ca9402bb2b09074a0df88c685be8974d4120b5772f648b77d583c0cae3631dbbaee711a6477f51706499337c08fa3d46cfa0ba8888b05f4d5
+  data.tar.gz: ec724965c4aed46aa09207ef3a2cc0e761466c6097efc871ff0190d05b2833a207ee6afeb6150ca04da970036f727946c25252c574fbde4f9200779634c51d7d

data/.simplecov

@@ -0,0 +1,35 @@
+# frozen_string_literal: true
+
+# SimpleCov configuration file (auto-loaded before test suite)
+# This keeps test_helper.rb clean and follows best practices
+
+SimpleCov.start do
+  # Use SimpleFormatter for terminal-only output (no HTML generation)
+  formatter SimpleCov::Formatter::SimpleFormatter
+
+  # Track coverage for the lib directory (gem source code)
+  add_filter "/test/"
+
+  # Track the lib and app directories
+  track_files "{lib,app}/**/*.rb"
+
+  # Enable branch coverage for more detailed metrics
+  enable_coverage :branch
+
+  # Set minimum coverage threshold to prevent coverage regression
+  minimum_coverage line: 90, branch: 90
+
+  # Disambiguate parallel test runs
+  command_name "Job #{ENV['TEST_ENV_NUMBER']}" if ENV['TEST_ENV_NUMBER']
+end
+
+# Print coverage summary to terminal after tests complete
+SimpleCov.at_exit do
+  SimpleCov.result.format!
+  puts "\n" + "=" * 60
+  puts "COVERAGE SUMMARY"
+  puts "=" * 60
+  puts "Line Coverage:   #{SimpleCov.result.covered_percent.round(2)}%"
+  puts "Branch Coverage: #{SimpleCov.result.coverage_statistics[:branch]&.percent&.round(2) || 'N/A'}%"
+  puts "=" * 60
+end

data/AGENTS.md

@@ -0,0 +1,5 @@
+# AGENTS.md
+
+This file provides guidance to AI Agents (like OpenAI's Codex, Cursor Agent, Claude Code, etc) when working with code in this repository.
+
+Please go ahead and read the full context for this project at `.cursor/rules/0-overview.mdc` and `.cursor/rules/1-quality.mdc` now. Also read the README for a good overview of the project.

data/Appraisals

@@ -0,0 +1,20 @@
+# frozen_string_literal: true
+
+# Note: Rails < 7.2 is not compatible with Ruby 3.4
+# (Logger became a bundled gem in Ruby 3.4, and only Rails 7.2+ handles this)
+# See: https://stdgems.org/logger/
+
+# Test against Rails 7.2 (minimum version compatible with Ruby 3.4)
+appraise "rails-7.2" do
+  gem "rails", "~> 7.2.0"
+end
+
+# Test against Rails 8.0
+appraise "rails-8.0" do
+  gem "rails", "~> 8.0.0"
+end
+
+# Test against Rails 8.1 (latest)
+appraise "rails-8.1" do
+  gem "rails", "~> 8.1.2"
+end

data/CHANGELOG.md

@@ -1,4 +1,18 @@
+## [0.2.0] - 2026-01-16
+
+- Added a full Minitest test suite
+- Fixed `respond_to?(:slug)` returning false for models using method_missing by implementing `respond_to_missing?`
+- Fixed collision resolution generating identical suffixes by switching from id-based deterministic suffixes to SecureRandom-based random suffixes
+- Fixed length parameter edge cases (zero, negative, very large values) by adding length validation and clamping via `normalize_length` method
+- Fixed timestamp fallback to include random suffix for additional uniqueness guarantee
+- Added length validation constants (`MAX_HEX_STRING_LENGTH`, `MAX_NUMBER_LENGTH`) to prevent invalid length values
+
+## [0.1.1] - 2024-03-21
+
+- Slugs can be now generated based off methods that return a string, not just based off attributes
+- Enhanced collision resolution strategy so that it doesn't get stuck in infinite loops
+- Added comprehensive test suite
+
 ## [0.1.0] - 2024-10-30
 
 - Initial release
-

data/CLAUDE.md

@@ -0,0 +1,5 @@
+# CLAUDE.md
+
+This file provides guidance to Claude Code (claude.ai/code) when working with code in this repository.
+
+Please go ahead and read the full context for this project at `.cursor/rules/0-overview.mdc` and `.cursor/rules/1-quality.mdc` now. Also read the README for a good overview of the project.

data/README.md

@@ -1,8 +1,11 @@
-# 🐌 `slugifiable` - Rails gem to generate SEO-friendly slugs
+# 🐌 `slugifiable` - Generate SEO-optimized URL slugs
 
-[![Gem Version](https://badge.fury.io/rb/slugifiable.svg)](https://badge.fury.io/rb/slugifiable)
+[![Gem Version](https://badge.fury.io/rb/slugifiable.svg)](https://badge.fury.io/rb/slugifiable) [![Build Status](https://github.com/rameerez/slugifiable/workflows/Tests/badge.svg)](https://github.com/rameerez/slugifiable/actions)
 
-Automatically generates unique slugs for your Rails' model records, so you can expose SEO-friendly URLs.
+> [!TIP]
+> **🚀 Ship your next Rails app 10x faster!** I've built **[RailsFast](https://railsfast.com/?ref=slugifiable)**, a production-ready Rails boilerplate template that comes with everything you need to launch a software business in days, not weeks. Go [check it out](https://railsfast.com/?ref=slugifiable)!
+
+Ruby gem to automatically generate unique slugs for your Rails' model records, so you can expose SEO-friendly URLs.
 
 Example:
 ```
@@ -183,7 +186,7 @@ end
 This will generate slugs like:
 ```ruby
 Event.first.slug
-=> "my-awesome-event-new-york-new-york"  # Automatically parameterized
+=> "my-awesome-event-new-york"  # Automatically parameterized
 ```
 
 There may be collisions if two records share the same name – but slugs should be unique! To resolve this, when this happens, `slugifiable` will append a unique string at the end to make the slug unique:

data/gemfiles/rails_7.2.gemfile

@@ -0,0 +1,17 @@
+# This file was generated by Appraisal
+
+source "https://rubygems.org"
+
+gem "rake", "~> 13.0"
+gem "rails", "~> 7.2.0"
+
+group :development, :test do
+  gem "appraisal"
+  gem "minitest", "~> 6.0"
+  gem "minitest-mock"
+  gem "rack-test"
+  gem "simplecov", require: false
+  gem "sqlite3", ">= 2.1"
+end
+
+gemspec path: "../"

data/gemfiles/rails_8.0.gemfile

@@ -0,0 +1,17 @@
+# This file was generated by Appraisal
+
+source "https://rubygems.org"
+
+gem "rake", "~> 13.0"
+gem "rails", "~> 8.0.0"
+
+group :development, :test do
+  gem "appraisal"
+  gem "minitest", "~> 6.0"
+  gem "minitest-mock"
+  gem "rack-test"
+  gem "simplecov", require: false
+  gem "sqlite3", ">= 2.1"
+end
+
+gemspec path: "../"

data/gemfiles/rails_8.1.gemfile

@@ -0,0 +1,17 @@
+# This file was generated by Appraisal
+
+source "https://rubygems.org"
+
+gem "rake", "~> 13.0"
+gem "rails", "~> 8.1.2"
+
+group :development, :test do
+  gem "appraisal"
+  gem "minitest", "~> 6.0"
+  gem "minitest-mock"
+  gem "rack-test"
+  gem "simplecov", require: false
+  gem "sqlite3", ">= 2.1"
+end
+
+gemspec path: "../"

data/lib/slugifiable/model.rb

@@ -28,6 +28,11 @@ module Slugifiable
     DEFAULT_SLUG_STRING_LENGTH = 11
     DEFAULT_SLUG_NUMBER_LENGTH = 6
 
+    # SHA256 produces 64 hex characters
+    MAX_HEX_STRING_LENGTH = 64
+    # 10^18 fits safely in a 64-bit integer
+    MAX_NUMBER_LENGTH = 18
+
     # Maximum number of attempts to generate a unique slug
     # before falling back to timestamp-based suffix
     MAX_SLUG_GENERATION_ATTEMPTS = 10
@@ -51,13 +56,17 @@ module Slugifiable
     end
 
     def method_missing(missing_method, *args, &block)
-      if missing_method.to_s == "slug" && !self.methods.include?(:slug)
+      if missing_method.to_s == "slug" && !has_slug_method?
         compute_slug
       else
         super
       end
     end
 
+    def respond_to_missing?(method_name, include_private = false)
+      method_name.to_s == "slug" && !has_slug_method? || super
+    end
+
     def compute_slug
       strategy, options = determine_slug_generation_method
 
@@ -71,12 +80,12 @@ module Slugifiable
     end
 
     def compute_slug_as_string(length = DEFAULT_SLUG_STRING_LENGTH)
-      length ||= DEFAULT_SLUG_STRING_LENGTH
+      length = normalize_length(length, DEFAULT_SLUG_STRING_LENGTH, MAX_HEX_STRING_LENGTH)
       (Digest::SHA2.hexdigest self.id.to_s).first(length)
     end
 
     def compute_slug_as_number(length = DEFAULT_SLUG_NUMBER_LENGTH)
-      length ||= DEFAULT_SLUG_NUMBER_LENGTH
+      length = normalize_length(length, DEFAULT_SLUG_NUMBER_LENGTH, MAX_NUMBER_LENGTH)
       generate_random_number_based_on_id_hex(length)
     end
 
@@ -129,8 +138,14 @@ module Slugifiable
 
     private
 
+    def normalize_length(length, default, max)
+      length = length.to_i
+      return default if length <= 0
+      [length, max].min
+    end
+
     def generate_random_number_based_on_id_hex(length = DEFAULT_SLUG_NUMBER_LENGTH)
-      length ||= DEFAULT_SLUG_NUMBER_LENGTH
+      length = normalize_length(length, DEFAULT_SLUG_NUMBER_LENGTH, MAX_NUMBER_LENGTH)
       ((Digest::SHA2.hexdigest(id.to_s)).hex % (10 ** length))
     end
 
@@ -147,14 +162,16 @@ module Slugifiable
 
       while self.class.exists?(slug: slug_candidate) && attempts < MAX_SLUG_GENERATION_ATTEMPTS
         attempts += 1
-        random_suffix = compute_slug_as_number
+        # Use SecureRandom for truly random suffixes during collision resolution
+        # This ensures each attempt tries a different suffix
+        random_suffix = SecureRandom.random_number(10 ** DEFAULT_SLUG_NUMBER_LENGTH)
         slug_candidate = "#{base_slug}-#{random_suffix}"
       end
 
       # If we couldn't find a unique slug after MAX_SLUG_GENERATION_ATTEMPTS,
-      # append timestamp to ensure uniqueness
+      # append timestamp + random to ensure uniqueness
       if attempts == MAX_SLUG_GENERATION_ATTEMPTS
-        slug_candidate = "#{base_slug}-#{Time.current.to_i}"
+        slug_candidate = "#{base_slug}-#{Time.current.to_i}-#{SecureRandom.random_number(1000)}"
       end
 
       slug_candidate
@@ -185,7 +202,7 @@ module Slugifiable
             return [DEFAULT_SLUG_GENERATION_STRATEGY, options]
           end
         elsif strategy.key?(:attribute)
-          return [:compute_slug_based_on_attribute, strategy[:attribute], options]
+          return [:compute_slug_based_on_attribute, strategy[:attribute]]
         end
       end
 
@@ -193,7 +210,12 @@ module Slugifiable
     end
 
     def slug_persisted?
-      self.methods.include?(:slug) && self.attributes.include?("slug")
+      has_slug_method? && self.attributes.include?("slug")
+    end
+
+    def has_slug_method?
+      # Check if slug method exists from ActiveRecord (not from method_missing)
+      self.class.method_defined?(:slug) || self.class.private_method_defined?(:slug)
     end
 
     def set_slug

data/lib/slugifiable/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Slugifiable
-  VERSION = "0.1.1"
+  VERSION = "0.2.0"
 end

data/lib/slugifiable.rb

@@ -1,5 +1,7 @@
 # frozen_string_literal: true
 
+require "securerandom"
+
 require_relative "slugifiable/version"
 require_relative "slugifiable/model"
 

metadata

@@ -1,13 +1,13 @@
 --- !ruby/object:Gem::Specification
 name: slugifiable
 version: !ruby/object:Gem::Version
-  version: 0.1.1
+  version: 0.2.0
 platform: ruby
 authors:
 - rameerez
 bindir: exe
 cert_chain: []
-date: 2025-02-23 00:00:00.000000000 Z
+date: 2026-01-16 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails
@@ -32,10 +32,17 @@ executables: []
 extensions: []
 extra_rdoc_files: []
 files:
+- ".simplecov"
+- AGENTS.md
+- Appraisals
 - CHANGELOG.md
+- CLAUDE.md
 - LICENSE.txt
 - README.md
 - Rakefile
+- gemfiles/rails_7.2.gemfile
+- gemfiles/rails_8.0.gemfile
+- gemfiles/rails_8.1.gemfile
 - lib/slugifiable.rb
 - lib/slugifiable/model.rb
 - lib/slugifiable/version.rb