sluggable_finder 2.2.0 → 2.2.1

data/README.markdown

@@ -26,6 +26,9 @@ Then run the following to load the test schema:
 
 rake db:create
 
+Note: I'm using mysql for now due to an apparent bug in ActiveRecord's sqlite3 adapter.
+Look for configuration in spec/sluggable_finder_spec.rb
+
 ## SYNOPSIS:
 
 ### Models
@@ -102,17 +105,19 @@ ActiveRecord, ActiveSupport
 
 ## INSTALL:
 
-If you haven't yet, add github.com to your gem sources (you only need to do that once):
+You can install or clone the repo from Github, but the recommended way for normal usage is to install the latest stable version from Gemcutter.org:
+
+If you haven't yet, add gemcutter.org to your gem sources (you only need to do that once):
 
-    gem sources -a http://gems.github.com
+    gem sources -a http://gemcutter.org
 
 Now you can install the normal way:
 
-    sudo gem install ismasan-sluggable_finder
+    sudo gem install sluggable_finder
 
 Then, in your Rails app's environment:
 
-    config.gem "ismasan-sluggable_finder", :lib => 'sluggable_finder'
+    config.gem "sluggable_finder"
 
 If you wan to unpack the gem to you app's "vendor" directory:
 
@@ -120,7 +125,7 @@ If you wan to unpack the gem to you app's "vendor" directory:
 
 ## TODO:
 
-*Refactor. It works but I hate the code.
+*Refactor. It works but I hate the code. Find a way to override ActiveRecord.find more cleanly. Maybe Rails 3?
 
 ## LICENSE:
 

data/VERSION.yml

@@ -1,4 +1,4 @@
 --- 
 :major: 2
 :minor: 2
-:patch: 0
+:patch: 1

data/lib/sluggable_finder/finder.rb

@@ -4,7 +4,7 @@ module SluggableFinder
   module Finder
     def find_sluggable(opts,*args)
       key = args.first
-      if key.is_a?(Symbol) || (key.to_s =~ /\A\d+\Z/ && opts[:allow_integer_ids]) # normal INT find
+      if key.is_a?(Symbol) || key.kind_of?(Array) || (key.to_s =~ /\A\d+\Z/ && opts[:allow_integer_ids]) # normal INT find
         find_without_slug(*args)
       else # sluggable find
         options = {:conditions => ["#{ opts[:to]} = ?", key]}

data/sluggable_finder.gemspec

@@ -5,11 +5,11 @@
 
 Gem::Specification.new do |s|
   s.name = %q{sluggable_finder}
-  s.version = "2.2.0"
+  s.version = "2.2.1"
 
   s.required_rubygems_version = Gem::Requirement.new(">= 0") if s.respond_to? :required_rubygems_version=
   s.authors = ["Ismael Celis"]
-  s.date = %q{2009-11-09}
+  s.date = %q{2009-12-09}
   s.description = %q{This plugin allows models to generate a unique "slug" (url-enabled name) from any regular attribute. Add friendly URLs to your models with one line.}
   s.email = %q{ismaelct@gmail.com}
   s.extra_rdoc_files = [

data/spec/sluggable_finder_spec.rb

@@ -1,8 +1,13 @@
 require File.dirname(__FILE__) + '/spec_helper'
 
 ActiveRecord::Base.establish_connection(
-  :adapter=>'sqlite3',
-  :dbfile=> File.join(File.dirname(__FILE__),'db','test.db')
+  # :adapter =>'sqlite3',
+  #   :database => File.join(File.dirname(__FILE__),'db','test.db')
+  :adapter => 'mysql',
+  :host => 'localhost',
+  :database => 'sluggable_finder_test',
+  :user => 'root',
+  :password => ''
 )
 
 LOGGER = Logger.new(STDOUT)
@@ -51,6 +56,7 @@ end
 class Category < ActiveRecord::Base
   has_many :scoped_items
   has_many :simple_items
+  has_many :string_only_items
 end
 
 class ScopedItem < Item
@@ -144,6 +150,30 @@ describe "SluggableFinder" do
       StringOnlyItem.find('1234567890').should == @item2
       StringOnlyItem.find(1234567890).should == @item2
     end
+    
+    describe 'with nested models' do
+      
+      before do
+        @category = Category.create(:name => 'foo')
+        @item1 = @category.string_only_items.create(:title => 'scoped string only')
+        @item2 = @category.string_only_items.create(:title => '987654321')
+      end
+      
+      it 'should work by string permalink' do
+        @category.string_only_items.find('scoped-string-only').should == @item1
+      end
+      
+      it 'should NOT allow integer ID' do
+        lambda {
+          @category.string_only_items.find(@item1.id)
+        }.should raise_error(ActiveRecord::RecordNotFound)
+      end
+      
+      it 'should find by integer-like slugs' do
+        @category.string_only_items.find('987654321').should == @item2
+        @category.string_only_items.find(987654321).should == @item2
+      end
+    end
   end
 
   # Raising custom not found exceptions allows us to use this with merb's NotFound exception
@@ -287,4 +317,23 @@ describe "SluggableFinder" do
       NoFinder.find(@string_id).should == @item
     end
   end
+  
+  describe 'collection setters' do
+    before do
+      @item1 = SimpleItem.create(:title => 'item1')
+      @item2 = SimpleItem.create(:title => 'item12')
+      @category = Category.create(:name => 'Cat1')
+    end
+    
+    it 'should assign children ids' do
+      @category.simple_item_ids = [@item1.id, @item2.id]
+      @category.simple_items.should == [@item1, @item2]
+    end
+    
+    it 'should not break when assigning empty array' do
+      lambda {
+       @category.simple_item_ids = []
+      }.should_not raise_error
+    end
+  end
 end

data/spec/spec_helper.rb

@@ -7,4 +7,4 @@ rescue LoadError
 end
 
 $:.unshift(File.dirname(__FILE__) + '/../lib')
-require 'sluggable_finder'
+require 'sluggable_finder'

data/tasks/db.rake

@@ -1,7 +1,12 @@
 require 'active_record'
 db = {
-  :adapter=>'sqlite3',
-  :dbfile=> File.join(File.dirname(__FILE__),'..','spec','db','test.db')
+  # :adapter=>'sqlite3',
+  #   :dbfile=> File.join(File.dirname(__FILE__),'..','spec','db','test.db')
+  :adapter => 'mysql',
+  :host => 'localhost',
+  :database => 'sluggable_finder_test',
+  :user => 'root',
+  :password => ''
 }
 ActiveRecord::Base.establish_connection( db )
 # define a migration
@@ -31,7 +36,7 @@ namespace :db do
   desc "Create test schema"
   task :create do
     # run the migration
-    File.unlink(db[:dbfile]) if File.exists?(db[:dbfile])
+    File.unlink(db[:dbfile]) if db[:adapter] == 'sqlite3' && File.exists?(db[:dbfile])
     ActiveRecord::Base.connection
     TestSchema.migrate(:up)
   end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification 
 name: sluggable_finder
 version: !ruby/object:Gem::Version 
-  version: 2.2.0
+  version: 2.2.1
 platform: ruby
 authors: 
 - Ismael Celis
@@ -9,7 +9,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2009-11-09 00:00:00 +00:00
+date: 2009-12-09 00:00:00 +00:00
 default_executable: 
 dependencies: 
 - !ruby/object:Gem::Dependency