slop 4.4.0 → 4.4.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 496c3e58ee49a489dc45b3885c49b32367ad0fe5
-  data.tar.gz: 7efe7c13f5992f1533486adf452c904f1f4b1981
+  metadata.gz: de2091f9afde594e40aac061706815b7136bbf2c
+  data.tar.gz: 9ba238ffb27744cbf3293cb532824f18a10f5e7e
 SHA512:
-  metadata.gz: 4b1905b9eefaee4c30dd96eb94a6e1740700c2b370e37230869d1d8ccd4679ae6ea5924ae3f72e0f9be97d21c020003ce875c7eb5a4c75f958ddd1da07110ea6
-  data.tar.gz: ab9fcf28c51edeece517285cdeb33a82fdf4e1a51e853bf94ae2594ea60d1a405cd665b1161871e5ed43717f5b57f157d30814396d8a53c09d82177f0fa0bc87
+  metadata.gz: a9701396bf3f9e1def3dbf17d38446f96ea560b7a046a3cab55783d053212a019a8f75102550dc67baf0df8b793dae0466ff1332fb0e42d0387cda143bdf20c2
+  data.tar.gz: dbb443da3652723951432d1603bbf2fe614335ea0c7605d5e9bdffb04f06c5f4042bed5fe2880f64d3fec978bd14aef006fdb2946359e6db0368557bae12dda5

data/CHANGELOG.md

@@ -1,6 +1,13 @@
 Changelog
 =========
 
+v4.4.1 (2016-08-21)
+-------------------
+
+Bug fixes:
+  * Handle bad constant names in `Slop.option_defined?`. #198
+    (Ellen Marie Dash)
+
 v4.4.0 (2016-08-15)
 -------------------
 

data/lib/slop.rb

@@ -6,7 +6,7 @@ require 'slop/types'
 require 'slop/error'
 
 module Slop
-  VERSION = '4.4.0'
+  VERSION = '4.4.1'
 
   # Parse an array of options (defaults to ARGV). Accepts an
   # optional hash of configuration options and block.
@@ -31,6 +31,10 @@ module Slop
   # Returns true if an option is defined.
   def self.option_defined?(name)
     const_defined?(string_to_option(name.to_s))
+  rescue NameError
+    # If a NameError is raised, it wasn't a valid constant name,
+    # and thus couldn't have been defined.
+    false
   end
 
   # Example:

data/test/slop_test.rb

@@ -0,0 +1,17 @@
+require "test_helper"
+
+describe Slop do
+  describe ".option_defined?" do
+    it "handles bad constant names" do
+      assert_equal false, Slop.option_defined?("Foo?Bar")
+    end
+
+    it "returns false if the option is not defined" do
+      assert_equal false, Slop.option_defined?("Foo")
+    end
+
+    it "returns true if the option is defined" do
+      assert_equal true, Slop.option_defined?("String")
+    end
+  end
+end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: slop
 version: !ruby/object:Gem::Version
-  version: 4.4.0
+  version: 4.4.1
 platform: ruby
 authors:
 - Lee Jarvis
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-08-15 00:00:00.000000000 Z
+date: 2016-08-21 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rake
@@ -64,6 +64,7 @@ files:
 - test/options_test.rb
 - test/parser_test.rb
 - test/result_test.rb
+- test/slop_test.rb
 - test/test_helper.rb
 - test/types_test.rb
 homepage: http://github.com/leejarvis/slop
@@ -96,6 +97,7 @@ test_files:
 - test/options_test.rb
 - test/parser_test.rb
 - test/result_test.rb
+- test/slop_test.rb
 - test/test_helper.rb
 - test/types_test.rb
 has_rdoc: