slimmer 3.28.0 → 3.28.1

data/CHANGELOG.md

@@ -1,3 +1,7 @@
+# 3.28.1
+
+* Added nil check for multivalue custom vars in google analytics configurator
+
 # 3.28.0
 
 * Report multiple need ids to Google analytics and Performance tracking

data/lib/slimmer/processors/google_analytics_configurator.rb

@@ -33,7 +33,7 @@ module Slimmer::Processors
     end
 
     def set_multivalue_custom_var(slot, name, values)
-      return nil if values.empty?
+      return nil if !values.is_a?(Array) || values.empty?
       set_custom_var(slot, name, values.join(',').downcase)
     end
 

data/lib/slimmer/version.rb

@@ -1,3 +1,3 @@
 module Slimmer
-  VERSION = '3.28.0'
+  VERSION = '3.28.1'
 end

data/test/processors/google_analytics_test.rb

@@ -119,6 +119,28 @@ module GoogleAnalyticsTest
     end
   end
 
+  class WithInvalidAttributes < SlimmerIntegrationTest
+    include JavaScriptAssertions
+
+    def setup
+      super
+    end
+
+    def test_should_skip_passing_need_ids_if_they_are_nil
+      artefact = artefact_for_slug_in_a_subsection("something", "rhubarb/in-puddings")
+      headers = {
+        Slimmer::Headers::ARTEFACT_HEADER => artefact.to_json,
+        Slimmer::Headers::FORMAT_HEADER => "custard"
+      }
+      given_response 200, GENERIC_DOCUMENT, headers
+
+      refute_custom_var "NeedID"
+      # the presence of these attributes tests that the nil check worked
+      assert_custom_var 1, "Section", "rhubarb", PAGE_LEVEL_EVENT
+      assert_custom_var 2, "Format", "custard", PAGE_LEVEL_EVENT
+    end
+  end
+
   class WithoutHeadersTest < SlimmerIntegrationTest
     include JavaScriptAssertions
 

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: slimmer
 version: !ruby/object:Gem::Version
-  version: 3.28.0
+  version: 3.28.1
   prerelease: 
 platform: ruby
 authors:
@@ -10,7 +10,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-03-31 00:00:00.000000000 Z
+date: 2014-04-23 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: nokogiri
@@ -341,7 +341,7 @@ required_ruby_version: !ruby/object:Gem::Requirement
       version: '0'
       segments:
       - 0
-      hash: -4353529555828351700
+      hash: -2679624557716830951
 required_rubygems_version: !ruby/object:Gem::Requirement
   none: false
   requirements:
@@ -350,7 +350,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
       segments:
       - 0
-      hash: -4353529555828351700
+      hash: -2679624557716830951
 requirements: []
 rubyforge_project: slimmer
 rubygems_version: 1.8.23