slimmer 18.5.2 → 18.6.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: f4d01a71c91dcc05c81dbfe0b72a94505a46ef1ceca890db26144d48aac077ca
-  data.tar.gz: e54b3f1e976748c8e522ac96b3d5bf51d00db5625a5da3633d6b3a14cc99ac10
+  metadata.gz: 929c5fc128e697424a5a97dde4a4fa38028936ae3d2243cce7bd6f9c06472437
+  data.tar.gz: 5a0edbbc1bbb1bf5a53409d1fa215a7f2d6fbc224e6c496e7d0e110c092f4b99
 SHA512:
-  metadata.gz: 2d4eb9f3f23b60a6e55bdc2060e9f7775987b8c0da333baeeedea541a92185201612c3c05b6c5eb8e9f2819db316216c39b012f6666021229c0a8894cbdc78d8
-  data.tar.gz: ad166d4c8c8d0e361be75f40bbb716f9f841efbfe8306a4d03d06a5fdcba187cd6119d7d6043772f65bd81049159f3898b952a7f0589210f9bfbef71897ee1c5
+  metadata.gz: 5ff2f81108c967b67edd10428c266e21843cb16a1e4ce68b2068e7328537e9ba023e3934f0a7cade8d18fb5abb7f6884557f8d2e70ecb603fdb18b808d06268c
+  data.tar.gz: a6869381c29230dea482014b2a7e7efcf155ed9d9f069ad9a193e6a0b1050585b1a4f313adceb261b3feccb7a6b473323192781b473b0f3edadb9a50281fab1c

data/CHANGELOG.md

@@ -1,3 +1,8 @@
+# 18.6.0
+
+* Remove the part of the body from the error message for SourceWrapperNotFoundError and do some cleanup
+  Use more explanatory error message. Apply this globally to all apps.
+
 # 18.5.2
 
 * Fix a mistake in 18.5.1

data/lib/slimmer/processors/body_inserter.rb

@@ -10,7 +10,14 @@ module Slimmer::Processors
       source_markup = src.at_css(@source_selector)
       destination_markup = dest.at_css(@destination_selector)
 
-      raise(Slimmer::SourceWrapperNotFoundError, "Source wrapper div not found", caller) if source_markup.nil? && wrapper_check?
+      if source_markup.nil?
+        raise(Slimmer::SourceWrapperNotFoundError, <<~ERROR_MESSAGE, caller)
+          Slimmer did not find a div with ID "wrapper" in the source HTML.
+          This could be because a request was made to your Rails application
+          for a format that it does not support. For example a JavaScript request,
+          when the application only has HTML templates.
+        ERROR_MESSAGE
+      end
 
       css_classes = []
       css_classes << source_markup.attributes["class"].to_s.split(/ +/) if source_markup.has_attribute?("class")
@@ -26,9 +33,5 @@ module Slimmer::Processors
     def is_gem_layout?
       @headers[Slimmer::Headers::TEMPLATE_HEADER]&.start_with?("gem_layout")
     end
-
-    def wrapper_check?
-      ENV["SLIMMER_WRAPPER_CHECK"] == "true"
-    end
   end
 end

data/lib/slimmer/skin.rb

@@ -100,7 +100,6 @@ module Slimmer
     end
 
     def success(source_request, response, body)
-      original_body = body.dup
       wrapper_id = options[:wrapper_id] || "wrapper"
       template_wrapper_id = "wrapper" # All templates in Static use `#wrapper`
 
@@ -123,12 +122,6 @@ module Slimmer
 
       template_name = response.headers[Headers::TEMPLATE_HEADER] || "gem_layout"
       process(processors, body, template(template_name), source_request.env)
-    rescue SourceWrapperNotFoundError => e
-      message = "#{e.message} "\
-                "at: #{source_request.base_url}#{source_request.path} "\
-                "length: #{original_body.to_s.length} "\
-                "body: #{original_body.to_s[0..2000]}"
-      raise SourceWrapperNotFoundError, message, caller
     end
   end
 end

data/lib/slimmer/version.rb

@@ -1,3 +1,3 @@
 module Slimmer
-  VERSION = "18.5.2".freeze
+  VERSION = "18.6.0".freeze
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: slimmer
 version: !ruby/object:Gem::Version
-  version: 18.5.2
+  version: 18.6.0
 platform: ruby
 authors:
 - GOV.UK Dev
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2024-06-13 00:00:00.000000000 Z
+date: 2024-06-28 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: json
@@ -170,14 +170,14 @@ dependencies:
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 4.18.0
+        version: 5.0.1
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 4.18.0
+        version: 5.0.1
 - !ruby/object:Gem::Dependency
   name: webmock
   requirement: !ruby/object:Gem::Requirement
@@ -251,7 +251,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.5.11
+rubygems_version: 3.5.14
 signing_key: 
 specification_version: 4
 summary: Thinner than the skinner