slim-embedded-minify 0.2.5 → 0.2.6

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 14375e81992194bca2bc3c42733011ccb783db89cf89a3dffbb62ec3245f2184
-  data.tar.gz: 824370e31b97a05335c8d4c4a64c1bed55ea02ea9a678faa8609a4308c1657b6
+  metadata.gz: a0acd763c9c3c2869fee898e2da36f1a26aa1aa2430d9cfe9c3008db35ecd442
+  data.tar.gz: b3d30f07bbf45aa062deac825d4e849958f495fc4cae6cb819362ebb32f8c53b
 SHA512:
-  metadata.gz: 947549a68e10777ab21e2779ac67491a7be49cdb54e800f08e8b0fa891138ee72dc249f3216bbe9ac8f2b9f1e3574f1592a156c2ef90fa3c751771b1237e317b
-  data.tar.gz: df9d4962e7ba6e74492306c5367ff7c44bb6c5a9527b77dd19514bd2104da0a0de0020cd0bac68e58ccdbe33de7cfe48bb3819eef2cb4c4fb2391a38540e69e4
+  metadata.gz: f7e085fd30ce3b514709e55e8999c919e2ab4f25fbdcc7c3b62617a8ee09e890d732af7d6c03064eda833b002fbc5b2cec9cccf3ef5afe7ab93a7c843b708ad5
+  data.tar.gz: 26466135a7c571e04eb572f49906f8f17d3ccc21ae1be8ca44e9a00c1da1ae591cb7583d16cbada24d34e0f324a7bf1dd32afc7b4248ac82afed387527fffd58

data/CHANGELOG.md

@@ -1,8 +1,12 @@
 ## Unreleased
 
+## 0.2.6 - 2023-08-01
+
+- Fix incorrect removing when using escaped quotation.
+
 ## 0.2.5 - 2023-07-27
 
-Fix to not delete anything other than comments.
+- Fix to not delete anything other than comments.
 
 ## 0.2.4 - 2023-07-27
 

data/lib/slim/embedded/minify/javascript.rb

@@ -14,6 +14,8 @@ module Slim
         def remove_comments!(line)
           need_deletion = false
           need_deletion_all = false
+          escaped = false
+          escaped_backslash = false
           inside_char = nil
           line[-1] = line.last.chars.each_with_index.map do |char, index|
             next if need_deletion_all
@@ -29,22 +31,25 @@ module Slim
             elsif char == "/" && next_char(line, index) == "/" && inside_char.nil? && !need_deletion
               need_deletion_all = true
               next
-            elsif char == '"' && !need_deletion
-              if inside_char == '"'
-                inside_char = nil
-                next char
+            elsif char == "\\" && next_char(line, index) == "\\" && inside_char
+              escaped_backslash = true
+              next char
+            elsif char == "\\"
+              if ["'", '"'].include?(next_char(line, index)) && inside_char == next_char(line, index) && !escaped_backslash
+                escaped = true
               end
-
-              inside_char = '"' if inside_char.nil?
-            elsif char == "'" && !need_deletion
-              if inside_char == "'"
-                inside_char = nil
+              escaped_backslash = false
+              next char
+            elsif ["'", '"'].include?(char) && !need_deletion
+              if inside_char == char
+                inside_char = nil unless escaped
+                escaped = false
                 next char
               end
 
-              inside_char = "'" if inside_char.nil?
+              inside_char = char if inside_char.nil?
             end
-            char unless need_deletion
+            char if !need_deletion || inside_char
           end&.compact&.join
         end
       end

data/lib/slim/embedded/minify/tag.rb

@@ -75,7 +75,7 @@ module Slim
         end
 
         def prev_char(line, index)
-          line.last[index - 1]
+          line.last[index - 1] if index.positive?
         end
 
         def next_char(line, index)
@@ -89,7 +89,33 @@ module Slim
         end
 
         def stripped_quotes(line)
-          line.last.gsub(/(['"]).*?\1/, "")
+          inside_char = nil
+          escaped = false
+          escaped_backslash = false
+          line.last.chars.each_with_index.filter_map do |char, index|
+            if ["'", '"'].include?(char) && inside_char.nil?
+              inside_char = char
+              next
+            elsif char == "\\" && next_char(line, index) == "\\" && inside_char
+              escaped_backslash = true
+              next
+            elsif char == "\\"
+              if ["'",
+                  '"'].include?(next_char(line, index)) && inside_char == next_char(line, index) && !escaped_backslash
+                escaped = true
+              end
+              escaped_backslash = false
+              next
+            elsif char == inside_char && !inside_char.nil?
+              inside_char = nil unless escaped
+              escaped = false
+              next
+            elsif inside_char
+              next
+            else
+              char
+            end
+          end.join
         end
 
         def empty_line?(line)

data/lib/slim/embedded/minify/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module SlimEmbeddedMinify
-  VERSION = "0.2.5"
+  VERSION = "0.2.6"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: slim-embedded-minify
 version: !ruby/object:Gem::Version
-  version: 0.2.5
+  version: 0.2.6
 platform: ruby
 authors:
 - Yudai Takada
 autorequire:
 bindir: exe
 cert_chain: []
-date: 2023-07-27 00:00:00.000000000 Z
+date: 2023-08-01 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: slim