slideshare_api 0.0.5 → 0.0.6

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 12b16a7b8fd697bcf195e1f8d5909b3a46b41dc8
-  data.tar.gz: 6005c7902fa67bd5bc58920f44c849f8ea34e912
+  metadata.gz: b51beff1edd1f7d82c4f023e91cd22714089ea4f
+  data.tar.gz: 5ffdd7a0aeb502c4b4ac764bafa77493c1455711
 SHA512:
-  metadata.gz: d59ca225e637d18aeeaeb1f5bda7ff39cb6881731f6efd657d9b86c28d1033d99f29c5862d9ecde3fb28c602ef331e707cab603c705328cadddebb9b31345df4
-  data.tar.gz: 546739411465c909ba600afd6cc17905ea57f571629cca33948b58cf0a8e913c18c9a5a95ca0c5b53c5320ae46200680194fbd0334a71d573cefdd4d13f1fc88
+  metadata.gz: 2871d54d5b029544b65f345325ce70be8cce55d0ab9bfc3559a4b9b7a4f690aaebac64f0fd0186b72a0536f0bd66e5480cf379a4c2940ee5c39fa5172b7543d4
+  data.tar.gz: 94d549cc830f334a7f32a5e6f76658cc0b49a9fc55574ff22dd9df4c9db1a8dda0646c93fd0293cdec35763a9b92ef1bb000fb031b223879e8e69c3737fdab2b

data/lib/slideshare_api/client.rb

@@ -20,7 +20,9 @@ module SlideshareApi
       params.merge!({slideshow_url: cleaned_url(options[:slideshow_url])}) if options[:slideshow_url]
       params.merge!({slideshow_id: options[:slideshow_id]}) if options[:slideshow_id]
       params.merge!({detailed: 1}) if options[:detailed]
-      SlideshareApi::Model::Slideshow.new Nokogiri::XML(@connection.get('get_slideshow', api_validation_params.merge(params)).body)
+      xml_response = Nokogiri::XML(@connection.get('get_slideshow', api_validation_params.merge(params)).body)
+      check_error xml_response
+      SlideshareApi::Model::Slideshow.new xml_response
     end
 
     private
@@ -29,6 +31,11 @@ module SlideshareApi
       url.split('?')[0]
     end
 
+    def check_error(xml_response)
+      error = xml_response.search('SlideShareServiceError')
+      raise SlideshareApi::Error, xml_response.search('Message').text unless error.empty?
+    end
+
     def build_connection
       @connection = Faraday.new(url: SLIDESHARE_API_URL) do |faraday|
         faraday.request :json

data/lib/slideshare_api/error.rb

@@ -0,0 +1,4 @@
+module SlideshareApi
+  class Error < Exception
+  end
+end

data/lib/slideshare_api/version.rb

@@ -1,3 +1,3 @@
 module SlideshareApi
-  VERSION = '0.0.5'
+  VERSION = '0.0.6'
 end

data/spec/client_spec.rb

@@ -18,41 +18,51 @@ describe SlideshareApi::Client do
   end
 
   describe '.slideshow' do
-    let(:slideshow_raw_xml) { open('spec/fixtures/slideshow.xml').read }
+    context 'there is an error' do
+      let(:error_xml) { open('spec/fixtures/error.xml').read }
 
-    before { expect(connection).to receive(:body).and_return(slideshow_raw_xml) }
+      before { expect(connection).to receive(:get).and_return(connection) }
+      before { expect(connection).to receive(:body).and_return(error_xml) }
 
-    context 'get from slideshow url' do
-      context 'url has params' do
-        let(:slideshow_url_with_params) { 'http://fr.slideshare.net/jeremyvenezia/prerequis-pour-appliquer-le-lean-startup-en-entreprise?ref=http://fr.slideshare.net/?ss' }
-        let(:slideshow_url) { 'http://fr.slideshare.net/jeremyvenezia/prerequis-pour-appliquer-le-lean-startup-en-entreprise' }
+      it { expect(-> { slideshare_client.slideshow }).to raise_error(SlideshareApi::Error) }
+    end
 
-        before { expect(connection).to receive(:get).with('get_slideshow', api_validation_params.merge({slideshow_url: slideshow_url})).and_return(connection) }
+    context 'there is no error' do
+      let(:slideshow_raw_xml) { open('spec/fixtures/slideshow.xml').read }
+      before { expect(connection).to receive(:body).and_return(slideshow_raw_xml) }
 
-        subject { slideshare_client.slideshow slideshow_url: slideshow_url_with_params }
+      context 'get from slideshow url' do
+        context 'url has params' do
+          let(:slideshow_url_with_params) { 'http://fr.slideshare.net/jeremyvenezia/prerequis-pour-appliquer-le-lean-startup-en-entreprise?ref=http://fr.slideshare.net/?ss' }
+          let(:slideshow_url) { 'http://fr.slideshare.net/jeremyvenezia/prerequis-pour-appliquer-le-lean-startup-en-entreprise' }
 
-        it { should eql? SlideshareApi::Model::Slideshow.new(Nokogiri::XML(slideshow_raw_xml)) }
-      end
+          before { expect(connection).to receive(:get).with('get_slideshow', api_validation_params.merge({slideshow_url: slideshow_url})).and_return(connection) }
 
-      context 'url has no params' do
-        let(:slideshow_url) { 'http://fr.slideshare.net/jeremyvenezia/prerequis-pour-appliquer-le-lean-startup-en-entreprise' }
+          subject { slideshare_client.slideshow slideshow_url: slideshow_url_with_params }
 
-        before { expect(connection).to receive(:get).with('get_slideshow', api_validation_params.merge({slideshow_url: slideshow_url})).and_return(connection) }
+          it { should eql? SlideshareApi::Model::Slideshow.new(Nokogiri::XML(slideshow_raw_xml)) }
+        end
 
-        subject { slideshare_client.slideshow slideshow_url: slideshow_url }
+        context 'url has no params' do
+          let(:slideshow_url) { 'http://fr.slideshare.net/jeremyvenezia/prerequis-pour-appliquer-le-lean-startup-en-entreprise' }
 
-        it { should eql? SlideshareApi::Model::Slideshow.new(Nokogiri::XML(slideshow_raw_xml)) }
+          before { expect(connection).to receive(:get).with('get_slideshow', api_validation_params.merge({slideshow_url: slideshow_url})).and_return(connection) }
+
+          subject { slideshare_client.slideshow slideshow_url: slideshow_url }
+
+          it { should eql? SlideshareApi::Model::Slideshow.new(Nokogiri::XML(slideshow_raw_xml)) }
+        end
       end
-    end
 
-    context 'get from slideshow id' do
-      let(:slideshow_id) { '1234' }
+      context 'get from slideshow id' do
+        let(:slideshow_id) { '1234' }
 
-      before { expect(connection).to receive(:get).with('get_slideshow', api_validation_params.merge({slideshow_id: slideshow_id})).and_return(connection) }
+        before { expect(connection).to receive(:get).with('get_slideshow', api_validation_params.merge({slideshow_id: slideshow_id})).and_return(connection) }
 
-      subject { slideshare_client.slideshow slideshow_id: slideshow_id }
+        subject { slideshare_client.slideshow slideshow_id: slideshow_id }
 
-      it { should eql? SlideshareApi::Model::Slideshow.new(Nokogiri::XML(slideshow_raw_xml)) }
+        it { should eql? SlideshareApi::Model::Slideshow.new(Nokogiri::XML(slideshow_raw_xml)) }
+      end
     end
   end
 end

data/spec/fixtures/error.xml

@@ -0,0 +1,5 @@
+<SlideShareServiceError>
+  <Message id="0">
+    No API Key Provided
+  </Message>
+</SlideShareServiceError>

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: slideshare_api
 version: !ruby/object:Gem::Version
-  version: 0.0.5
+  version: 0.0.6
 platform: ruby
 authors:
 - Jeremy Venezia
@@ -123,10 +123,12 @@ files:
 - Rakefile
 - lib/slideshare_api.rb
 - lib/slideshare_api/client.rb
+- lib/slideshare_api/error.rb
 - lib/slideshare_api/model/slideshow.rb
 - lib/slideshare_api/version.rb
 - slideshare_api.gemspec
 - spec/client_spec.rb
+- spec/fixtures/error.xml
 - spec/fixtures/slideshow.xml
 - spec/fixtures/slideshow_detailed.xml
 - spec/model/slideshow_spec.rb
@@ -157,6 +159,7 @@ specification_version: 4
 summary: Ruby wrapper for the Slideshare API.
 test_files:
 - spec/client_spec.rb
+- spec/fixtures/error.xml
 - spec/fixtures/slideshow.xml
 - spec/fixtures/slideshow_detailed.xml
 - spec/model/slideshow_spec.rb