slideshare_api 0.0.4 → 0.0.5

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 63dba4aeab650366a2a5d89c7a150bf294841f0c
-  data.tar.gz: 5abdd7c7222d6e350040a39b2440d6a2664d8b5a
+  metadata.gz: 12b16a7b8fd697bcf195e1f8d5909b3a46b41dc8
+  data.tar.gz: 6005c7902fa67bd5bc58920f44c849f8ea34e912
 SHA512:
-  metadata.gz: 5031fd4b932932dd96ec8a81a06b98de66624a3dcdd8bfb8c205fbd9d11d76fcb80754c29cf6da8816e032a4e210a9783284523daec2002806ca45788e08146d
-  data.tar.gz: 8845fc91dc22218c6c494d368163f7bea082aaf65ab7a737b05ded7bcc30351daeb611ce2f935193b84bf006602438db46f23cdee0588a7fdf92d70e76e30329
+  metadata.gz: d59ca225e637d18aeeaeb1f5bda7ff39cb6881731f6efd657d9b86c28d1033d99f29c5862d9ecde3fb28c602ef331e707cab603c705328cadddebb9b31345df4
+  data.tar.gz: 546739411465c909ba600afd6cc17905ea57f571629cca33948b58cf0a8e913c18c9a5a95ca0c5b53c5320ae46200680194fbd0334a71d573cefdd4d13f1fc88

data/lib/slideshare_api/client.rb

@@ -17,7 +17,7 @@ module SlideshareApi
 
     def slideshow(options = {})
       params = {}
-      params.merge!({slideshow_url: options[:slideshow_url]}) if options[:slideshow_url]
+      params.merge!({slideshow_url: cleaned_url(options[:slideshow_url])}) if options[:slideshow_url]
       params.merge!({slideshow_id: options[:slideshow_id]}) if options[:slideshow_id]
       params.merge!({detailed: 1}) if options[:detailed]
       SlideshareApi::Model::Slideshow.new Nokogiri::XML(@connection.get('get_slideshow', api_validation_params.merge(params)).body)
@@ -25,6 +25,10 @@ module SlideshareApi
 
     private
 
+    def cleaned_url(url)
+      url.split('?')[0]
+    end
+
     def build_connection
       @connection = Faraday.new(url: SLIDESHARE_API_URL) do |faraday|
         faraday.request :json

data/lib/slideshare_api/version.rb

@@ -1,3 +1,3 @@
 module SlideshareApi
-  VERSION = '0.0.4'
+  VERSION = '0.0.5'
 end

data/spec/client_spec.rb

@@ -23,13 +23,26 @@ describe SlideshareApi::Client do
     before { expect(connection).to receive(:body).and_return(slideshow_raw_xml) }
 
     context 'get from slideshow url' do
-      let(:slideshow_url) { 'http://fr.slideshare.net/jeremyvenezia/prerequis-pour-appliquer-le-lean-startup-en-entreprise' }
+      context 'url has params' do
+        let(:slideshow_url_with_params) { 'http://fr.slideshare.net/jeremyvenezia/prerequis-pour-appliquer-le-lean-startup-en-entreprise?ref=http://fr.slideshare.net/?ss' }
+        let(:slideshow_url) { 'http://fr.slideshare.net/jeremyvenezia/prerequis-pour-appliquer-le-lean-startup-en-entreprise' }
 
-      before { expect(connection).to receive(:get).with('get_slideshow', api_validation_params.merge({slideshow_url: slideshow_url})).and_return(connection) }
+        before { expect(connection).to receive(:get).with('get_slideshow', api_validation_params.merge({slideshow_url: slideshow_url})).and_return(connection) }
 
-      subject { slideshare_client.slideshow slideshow_url: slideshow_url }
+        subject { slideshare_client.slideshow slideshow_url: slideshow_url_with_params }
 
-      it { should eql? SlideshareApi::Model::Slideshow.new(Nokogiri::XML(slideshow_raw_xml)) }
+        it { should eql? SlideshareApi::Model::Slideshow.new(Nokogiri::XML(slideshow_raw_xml)) }
+      end
+
+      context 'url has no params' do
+        let(:slideshow_url) { 'http://fr.slideshare.net/jeremyvenezia/prerequis-pour-appliquer-le-lean-startup-en-entreprise' }
+
+        before { expect(connection).to receive(:get).with('get_slideshow', api_validation_params.merge({slideshow_url: slideshow_url})).and_return(connection) }
+
+        subject { slideshare_client.slideshow slideshow_url: slideshow_url }
+
+        it { should eql? SlideshareApi::Model::Slideshow.new(Nokogiri::XML(slideshow_raw_xml)) }
+      end
     end
 
     context 'get from slideshow id' do

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: slideshare_api
 version: !ruby/object:Gem::Version
-  version: 0.0.4
+  version: 0.0.5
 platform: ruby
 authors:
 - Jeremy Venezia