slanger 0.4.2 → 0.4.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 5fea601e824e671ed0d87a8a5e44584d3e6a4c18
-  data.tar.gz: 64df554d024eef643d7b311afd8630e13c9a4784
+  metadata.gz: fa3af74396ad01a665097cd94f9520c3f9e93e35
+  data.tar.gz: beac501fa1ec42ba40096fe2854654200c7436ce
 SHA512:
-  metadata.gz: a4688a9c1191d2eb27bcedb34dbe6e492d0b01df3fb154d50bd7d20254f1495741cab833afc2f1c69538c513d7266f1d7fea298c952397c82327e518da92257d
-  data.tar.gz: 4c197dd2e23beef01734d01f7df2e9d5d21fe75908c2b61802691939de0941b6c3fc7a61dfa240bfaa373c3e95f5d4aaa495cc402c486886befe746fa07514a3
+  metadata.gz: dcf153eb18832d068ada988ca15d9c11cd21c06d712c0a38b1cdef1502becc64a19d106f6834819582b82b083e7e872578d6b8bd7290314c4827da17995036f8
+  data.tar.gz: 9c72e7738e139b245d474d4d007ca1897f9bfa585c642d369274cc6d877b2f74f75190a6cbaadba3ede607c0d1b708a7281f1e2bdf953c4e6d82337616f0ade7

data/lib/slanger/api/request_validation.rb

@@ -53,7 +53,7 @@ module Slanger
       end
 
       def validate_channel_id!(channel_id)
-        validate_with_regex!(/\A[\w@\-;]+\z/, channel_id, "channel_id")
+        validate_with_regex!(/\A[\w@\-;_.=,]{1,164}\z/, channel_id, "channel_id")
       end
 
       def validate_with_regex!(regex, value, name)

data/lib/slanger/version.rb

@@ -1,3 +1,3 @@
 module Slanger
-  VERSION = '0.4.2'
+  VERSION = '0.4.3'
 end

data/spec/unit/request_validation_spec.rb

@@ -28,22 +28,30 @@ describe Slanger::Api::RequestValidation do
     let(:body) { {socket_id: "1234.5678", channels: channels}.to_json }
 
     context "with valid channels" do
-      let(:channels) { ["MY_CHANNEL", "presence-abcd"] }
+      let(:channels) { ["MY_CHANNEL", "presence-abcd", "foo-bar_1234@=,.;", "a"*164] }
 
       it "returns an array of valid channel_id values" do
         rv = Slanger::Api::RequestValidation.new(body, {}, "")
 
-        expect(rv.channels).to eq ["MY_CHANNEL", "presence-abcd"]
+        expect(rv.channels).to eq ["MY_CHANNEL", "presence-abcd", "foo-bar_1234@=,.;", "a"*164]
       end
     end
 
-    context "with invalid channels" do
+    context "with invalid characters" do
       let(:channels) { ["MY_CHANNEL:presence-abcd", "presence-abcd"] }
 
       it "rejects invalid channels" do
         expect{ Slanger::Api::RequestValidation.new(body, {}, "")}.to raise_error Slanger::Api::InvalidRequest
       end
     end
+
+    context "with invalid channel length" do
+      let(:channels) { ["a"*165] }
+
+      it "rejects names longer than 164 characters" do
+        expect{ Slanger::Api::RequestValidation.new(body, {}, "")}.to raise_error Slanger::Api::InvalidRequest
+      end
+    end
   end
 
   describe "#socket_id" do

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: slanger
 version: !ruby/object:Gem::Version
-  version: 0.4.2
+  version: 0.4.3
 platform: ruby
 authors:
 - Stevie Graham
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-05-16 00:00:00.000000000 Z
+date: 2015-06-30 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: eventmachine
@@ -356,7 +356,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.4.5
+rubygems_version: 2.2.0
 signing_key: 
 specification_version: 4
 summary: A websocket service compatible with Pusher libraries
@@ -375,3 +375,4 @@ test_files:
 - spec/unit/channel_spec.rb
 - spec/unit/request_validation_spec.rb
 - spec/unit/webhook_spec.rb
+has_rdoc: